194374 2019-02-06 20:58:12 -0800 [JSC] Use BufferInternal single character StringImpl for SmallStrings 2019-02-06 21:52:28 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist ggaren keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1503613 0 ysuzuki 2019-02-06 20:58:12 -0800 [JSC] Use BufferInternal single character StringImpl for SmallStrings 1503614 1 361375 ysuzuki 2019-02-06 20:59:30 -0800 Created attachment 361375 Patch 1503615 2 361375 ggaren 2019-02-06 21:00:32 -0800 Comment on attachment 361375 Patch r=me 1503616 3 ysuzuki 2019-02-06 21:01:57 -0800 Thank you! 1503628 4 ysuzuki 2019-02-06 21:51:51 -0800 Committed r241117: <https://trac.webkit.org/changeset/241117> 1503629 5 webkit-bug-importer 2019-02-06 21:52:28 -0800 <rdar://problem/47875526> 361375 2019-02-06 20:59:30 -0800 2019-02-06 21:00:32 -0800 Patch bug-194374-20190206205930.patch text/plain 4095 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 Y2E1MjVlN2Y3YjFmMDJkNzIzY2YwOTVhZTcxYzU5MzNlMDExMjI3Li45N2Q1YmRkOWQ4NmM2MzRk ZGMyZjc2YmViZTJkZjI2ZWY1ZmY4NmM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxOS0wMi0wNiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFVzZSBCdWZmZXJJbnRlcm5hbCBzaW5nbGUgY2hhcmFjdGVyIFN0 cmluZ0ltcGwgZm9yIFNtYWxsU3RyaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTk0Mzc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQ3VycmVudGx5LCB3ZSBmaXJzdCBjcmVhdGUgYSBsYXJnZSBTdHJp bmdJbXBsLCBhbmQgY3JlYXRlIGJ1bmNoIG9mIHN1YnN0cmluZ3Mgd2l0aCBsZW5ndGggPSAxLgor ICAgICAgICBCdXQgcG9pbnRlciBpcyBsYXJnZXIgdGhhbiBzaW5nbGUgY2hhcmFjdGVyLiBCdWZm ZXJJbnRlcm5hbCBTdHJpbmdJbXBsIHdpdGggc2luZ2xlIGNoYXJhY3RlcgorICAgICAgICBpcyBt b3JlIG1lbW9yeSBlZmZpY2llbnQuCisKKyAgICAgICAgKiBydW50aW1lL1NtYWxsU3RyaW5ncy5j cHA6CisgICAgICAgIChKU0M6OlNtYWxsU3RyaW5nc1N0b3JhZ2U6OlNtYWxsU3RyaW5nc1N0b3Jh Z2UpOgorICAgICAgICAoSlNDOjpTbWFsbFN0cmluZ3M6OlNtYWxsU3RyaW5ncyk6CisgICAgICAg ICogcnVudGltZS9TbWFsbFN0cmluZ3MuaDoKKwogMjAxOS0wMi0wNiAgWXVzdWtlIFN1enVraSAg PHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIEluaXRpYWxpemVFbnRyeXBvaW50 QXJndW1lbnRzIHNob3VsZCBwcm9kdWNlIFNwZWNDZWxsQ2hlY2sgaWYgRmx1c2hGb3JtYXQgaXMg Rmx1c2hlZENlbGwKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1Nt YWxsU3RyaW5ncy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TbWFsbFN0cmlu Z3MuY3BwCmluZGV4IDYwZTIxYjZjZjQ2ZTEzZTQ2MjM1ODQ0OGZmMjhiN2RhOTE0MjJmY2UuLjhm MjZiM2UxZTJhMTY0ZTdmM2MzMzQ3Mjg3YzBmNGUzMzczNDc0N2YgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1NtYWxsU3RyaW5ncy5jcHAKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvU21hbGxTdHJpbmdzLmNwcApAQCAtNTIsMjggKzUyLDE4IEBA IGNsYXNzIFNtYWxsU3RyaW5nc1N0b3JhZ2UgewogCiBTbWFsbFN0cmluZ3NTdG9yYWdlOjpTbWFs bFN0cmluZ3NTdG9yYWdlKCkKIHsKLSAgICBMQ2hhciogY2hhcmFjdGVyQnVmZmVyID0gMDsKLSAg ICBhdXRvIGJhc2VTdHJpbmcgPSBTdHJpbmdJbXBsOjpjcmVhdGVVbmluaXRpYWxpemVkKHNpbmds ZUNoYXJhY3RlclN0cmluZ0NvdW50LCBjaGFyYWN0ZXJCdWZmZXIpOwogICAgIGZvciAodW5zaWdu ZWQgaSA9IDA7IGkgPCBzaW5nbGVDaGFyYWN0ZXJTdHJpbmdDb3VudDsgKytpKSB7Ci0gICAgICAg IGNoYXJhY3RlckJ1ZmZlcltpXSA9IGk7Ci0gICAgICAgIG1fcmVwc1tpXSA9IEF0b21pY1N0cmlu Z0ltcGw6OmFkZChTdHJpbmdJbXBsOjpjcmVhdGVTdWJzdHJpbmdTaGFyaW5nSW1wbChiYXNlU3Ry aW5nLmdldCgpLCBpLCAxKS5wdHIoKSk7CisgICAgICAgIGNvbnN0IExDaGFyIHN0cmluZ1tdID0g eyBzdGF0aWNfY2FzdDxMQ2hhcj4oaSkgfTsKKyAgICAgICAgbV9yZXBzW2ldID0gQXRvbWljU3Ry aW5nSW1wbDo6YWRkKFN0cmluZ0ltcGw6OmNyZWF0ZShzdHJpbmcsIDEpLnB0cigpKTsKICAgICB9 CiB9CiAKIFNtYWxsU3RyaW5nczo6U21hbGxTdHJpbmdzKCkKLSAgICA6IG1fZW1wdHlTdHJpbmco MCkKLSNkZWZpbmUgSlNDX0NPTU1PTl9TVFJJTkdTX0FUVFJJQlVURV9JTklUSUFMSVpFKG5hbWUp ICwgbV8jI25hbWUoMCkKLSAgICBKU0NfQ09NTU9OX1NUUklOR1NfRUFDSF9OQU1FKEpTQ19DT01N T05fU1RSSU5HU19BVFRSSUJVVEVfSU5JVElBTElaRSkKLSN1bmRlZiBKU0NfQ09NTU9OX1NUUklO R1NfQVRUUklCVVRFX0lOSVRJQUxJWkUKLSAgICAsIG1fb2JqZWN0U3RyaW5nU3RhcnQobnVsbHB0 cikKLSAgICAsIG1fbnVsbE9iamVjdFN0cmluZyhudWxscHRyKQotICAgICwgbV91bmRlZmluZWRP YmplY3RTdHJpbmcobnVsbHB0cikKLSAgICAsIG1fbmVlZHNUb0JlVmlzaXRlZCh0cnVlKQogewog ICAgIENPTVBJTEVfQVNTRVJUKHNpbmdsZUNoYXJhY3RlclN0cmluZ0NvdW50ID09IHNpemVvZiht X3NpbmdsZUNoYXJhY3RlclN0cmluZ3MpIC8gc2l6ZW9mKG1fc2luZ2xlQ2hhcmFjdGVyU3RyaW5n c1swXSksIElzTnVtQ2hhcmFjdGVyc0NvbnN0SW5TeW5jV2l0aENsYXNzVXNhZ2UpOwogCiAgICAg Zm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IHNpbmdsZUNoYXJhY3RlclN0cmluZ0NvdW50OyArK2kp Ci0gICAgICAgIG1fc2luZ2xlQ2hhcmFjdGVyU3RyaW5nc1tpXSA9IDA7CisgICAgICAgIG1fc2lu Z2xlQ2hhcmFjdGVyU3RyaW5nc1tpXSA9IG51bGxwdHI7CiB9CiAKIHZvaWQgU21hbGxTdHJpbmdz Ojppbml0aWFsaXplQ29tbW9uU3RyaW5ncyhWTSYgdm0pCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9TbWFsbFN0cmluZ3MuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL1NtYWxsU3RyaW5ncy5oCmluZGV4IDg4NTBjNGE5YTM0Mzk0ZjE4Zjc1YTM1ZDY3 YmEzYTQ1YTE5ZmU0N2UuLjc2OWQ0OTRmMzIwYzQwM2VmZjZmMTUzOWUyMjM5NmYwOWNmODM0ODYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1NtYWxsU3RyaW5ncy5o CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1NtYWxsU3RyaW5ncy5oCkBAIC0x MzEsMTYgKzEzMSwxNiBAQCBjbGFzcyBTbWFsbFN0cmluZ3MgewogCiAgICAgdm9pZCBpbml0aWFs aXplKFZNKiwgSlNTdHJpbmcqJiwgY29uc3QgY2hhciogdmFsdWUpOwogCi0gICAgSlNTdHJpbmcq IG1fZW1wdHlTdHJpbmc7Ci0jZGVmaW5lIEpTQ19DT01NT05fU1RSSU5HU19BVFRSSUJVVEVfREVD TEFSQVRJT04obmFtZSkgSlNTdHJpbmcqIG1fIyNuYW1lOworICAgIEpTU3RyaW5nKiBtX2VtcHR5 U3RyaW5nIHsgbnVsbHB0ciB9OworI2RlZmluZSBKU0NfQ09NTU9OX1NUUklOR1NfQVRUUklCVVRF X0RFQ0xBUkFUSU9OKG5hbWUpIEpTU3RyaW5nKiBtXyMjbmFtZSB7IG51bGxwdHIgfTsKICAgICBK U0NfQ09NTU9OX1NUUklOR1NfRUFDSF9OQU1FKEpTQ19DT01NT05fU1RSSU5HU19BVFRSSUJVVEVf REVDTEFSQVRJT04pCiAjdW5kZWYgSlNDX0NPTU1PTl9TVFJJTkdTX0FUVFJJQlVURV9ERUNMQVJB VElPTgotICAgIEpTU3RyaW5nKiBtX29iamVjdFN0cmluZ1N0YXJ0OwotICAgIEpTU3RyaW5nKiBt X251bGxPYmplY3RTdHJpbmc7Ci0gICAgSlNTdHJpbmcqIG1fdW5kZWZpbmVkT2JqZWN0U3RyaW5n OwotICAgIEpTU3RyaW5nKiBtX3NpbmdsZUNoYXJhY3RlclN0cmluZ3Nbc2luZ2xlQ2hhcmFjdGVy U3RyaW5nQ291bnRdOworICAgIEpTU3RyaW5nKiBtX29iamVjdFN0cmluZ1N0YXJ0IHsgbnVsbHB0 ciB9OworICAgIEpTU3RyaW5nKiBtX251bGxPYmplY3RTdHJpbmcgeyBudWxscHRyIH07CisgICAg SlNTdHJpbmcqIG1fdW5kZWZpbmVkT2JqZWN0U3RyaW5nIHsgbnVsbHB0ciB9OworICAgIEpTU3Ry aW5nKiBtX3NpbmdsZUNoYXJhY3RlclN0cmluZ3Nbc2luZ2xlQ2hhcmFjdGVyU3RyaW5nQ291bnRd IHsgbnVsbHB0ciB9OwogICAgIHN0ZDo6dW5pcXVlX3B0cjxTbWFsbFN0cmluZ3NTdG9yYWdlPiBt X3N0b3JhZ2U7Ci0gICAgYm9vbCBtX25lZWRzVG9CZVZpc2l0ZWQ7CisgICAgYm9vbCBtX25lZWRz VG9CZVZpc2l0ZWQgeyB0cnVlIH07CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBKU0MK