194364 2019-02-06 15:34:51 -0800 Print backgrounds preference should be honored instead of WKWebViewConfiguration value 2019-02-07 11:02:59 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen thorton webkit-bug-importer oldest_to_newest 1503508 0 achristensen 2019-02-06 15:34:51 -0800 Print backgrounds preference should be honored instead of WKWebViewConfiguration value 1503771 1 361408 achristensen 2019-02-07 10:07:02 -0800 Created attachment 361408 Patch 1503802 2 361408 thorton 2019-02-07 10:46:42 -0800 Comment on attachment 361408 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361408&action=review > Source/WebKit/ChangeLog:15 > + * UIProcess/API/Cocoa/WKWebView.mm: You need to explain the long-term cleanup plan either here or in the bug, and there should be a new bug tracking it. 1503819 3 361419 achristensen 2019-02-07 10:59:02 -0800 Created attachment 361419 Patch 1503822 4 achristensen 2019-02-07 11:01:39 -0800 https://trac.webkit.org/changeset/241131/webkit 1503824 5 webkit-bug-importer 2019-02-07 11:02:59 -0800 <rdar://problem/47889813> 361408 2019-02-07 10:07:02 -0800 2019-02-07 10:59:01 -0800 Patch bug-194364-20190207100701.patch text/plain 2803 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDExMDUpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE5LTAyLTA2ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUHJpbnQgYmFja2dy b3VuZHMgcHJlZmVyZW5jZSBzaG91bGQgYmUgaG9ub3JlZCBpbnN0ZWFkIG9mIFdLV2ViVmlld0Nv bmZpZ3VyYXRpb24gdmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5NDM2NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDc2Mjc1OTk+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2l0aG91dCB0aGlz IHBhdGNoLCBjaGFuZ2luZyB0aGUgcHJlZmVyZW5jZSBmb3IgcHJpbnRpbmcgdGhlIGJhY2tncm91 bmQgaGFzIG5vIGVmZmVjdC4KKyAgICAgICAgVGhpcyBwYXRjaCBmaXhlcyB0aGF0LCBhbmQgSSB2 ZXJpZmllZCBpdCBtYW51YWxseSBieSBjaGVja2luZyAiUHJpbnQgYmFja2dyb3VuZHMiIGluIFNh ZmFyaSdzIHByaW50IG1lbnUuCisgICAgICAgIFVuZm9ydHVuYXRlbHksIHRoZSBvbmx5IHdheSB0 byB0ZXN0IHRoaXMgaXMgYWN0dWFsbHkgcHJpbnRpbmcgYmVjYXVzZSBvbmx5IHZhbHVlcyBmcm9t IFdlYlBhZ2VQcm94eTo6cHJlZmVyZW5jZXMKKyAgICAgICAgb3IgV2ViUGFnZVByb3h5Ojpjb25m aWd1cmF0aW9uJ3MgcHJlZmVyZW5jZXMgYXJlIGV4cG9zZWQgdG8gdGhlIEFQSSwgYnV0IHZhbHVl cyBmcm9tIFdlYlBhZ2VQcm94eTo6cHJlZmVyZW5jZXNTdG9yZQorICAgICAgICBhcmUgdXNlZCB3 aGVuIHByaW50aW5nLiAgQWN0dWFsbHkgcHJpbnRpbmcgdmVyaWZpZXMgdGhpcyBjaGFuZ2UgZml4 ZXMgdGhlIGJ1Zy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1t OgorICAgICAgICAoLVtXS1dlYlZpZXcgX2luaXRpYWxpemVXaXRoQ29uZmlndXJhdGlvbjpdKToK KwogMjAxOS0wMi0wNiAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAg W1BheW1lbnQgUmVxdWVzdF0gSXQgc2hvdWxkIGJlIHBvc3NpYmxlIHRvIHJlcXVpcmUgYSBwaG9u ZXRpYyBuYW1lIGZvciBzaGlwcGluZyBjb250YWN0cwpJbmRleDogU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCShyZXZpc2lvbiAyNDEwMjgpCisrKyBT b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCSh3b3JraW5nIGNv cHkpCkBAIC01ODgsNyArNTg4LDkgQEAgLSAodm9pZClfaW5pdGlhbGl6ZVdpdGhDb25maWd1cmF0 aW9uOihXSwogICAgIHBhZ2VDb25maWd1cmF0aW9uLT5wcmVmZXJlbmNlVmFsdWVzKCkuc2V0KFdl YktpdDo6V2ViUHJlZmVyZW5jZXNLZXk6OnN1cHByZXNzZXNJbmNyZW1lbnRhbFJlbmRlcmluZ0tl eSgpLCBXZWJLaXQ6OldlYlByZWZlcmVuY2VzU3RvcmU6OlZhbHVlKCEhW19jb25maWd1cmF0aW9u IHN1cHByZXNzZXNJbmNyZW1lbnRhbFJlbmRlcmluZ10pKTsKIAogICAgIHBhZ2VDb25maWd1cmF0 aW9uLT5wcmVmZXJlbmNlVmFsdWVzKCkuc2V0KFdlYktpdDo6V2ViUHJlZmVyZW5jZXNLZXk6OnNo b3VsZFJlc3BlY3RJbWFnZU9yaWVudGF0aW9uS2V5KCksIFdlYktpdDo6V2ViUHJlZmVyZW5jZXNT dG9yZTo6VmFsdWUoISFbX2NvbmZpZ3VyYXRpb24gX3Jlc3BlY3RzSW1hZ2VPcmllbnRhdGlvbl0p KTsKKyNpZiAhUExBVEZPUk0oTUFDKQogICAgIHBhZ2VDb25maWd1cmF0aW9uLT5wcmVmZXJlbmNl VmFsdWVzKCkuc2V0KFdlYktpdDo6V2ViUHJlZmVyZW5jZXNLZXk6OnNob3VsZFByaW50QmFja2dy b3VuZHNLZXkoKSwgV2ViS2l0OjpXZWJQcmVmZXJlbmNlc1N0b3JlOjpWYWx1ZSghIVtfY29uZmln dXJhdGlvbiBfcHJpbnRzQmFja2dyb3VuZHNdKSk7CisjZW5kaWYKICAgICBwYWdlQ29uZmlndXJh dGlvbi0+cHJlZmVyZW5jZVZhbHVlcygpLnNldChXZWJLaXQ6OldlYlByZWZlcmVuY2VzS2V5Ojpp bmNyZW1lbnRhbFJlbmRlcmluZ1N1cHByZXNzaW9uVGltZW91dEtleSgpLCBXZWJLaXQ6OldlYlBy ZWZlcmVuY2VzU3RvcmU6OlZhbHVlKFtfY29uZmlndXJhdGlvbiBfaW5jcmVtZW50YWxSZW5kZXJp bmdTdXBwcmVzc2lvblRpbWVvdXRdKSk7CiAgICAgcGFnZUNvbmZpZ3VyYXRpb24tPnByZWZlcmVu Y2VWYWx1ZXMoKS5zZXQoV2ViS2l0OjpXZWJQcmVmZXJlbmNlc0tleTo6amF2YVNjcmlwdE1hcmt1 cEVuYWJsZWRLZXkoKSwgV2ViS2l0OjpXZWJQcmVmZXJlbmNlc1N0b3JlOjpWYWx1ZSghIVtfY29u ZmlndXJhdGlvbiBfYWxsb3dzSmF2YVNjcmlwdE1hcmt1cF0pKTsKICAgICBwYWdlQ29uZmlndXJh dGlvbi0+cHJlZmVyZW5jZVZhbHVlcygpLnNldChXZWJLaXQ6OldlYlByZWZlcmVuY2VzS2V5Ojpz aG91bGRDb252ZXJ0UG9zaXRpb25TdHlsZU9uQ29weUtleSgpLCBXZWJLaXQ6OldlYlByZWZlcmVu Y2VzU3RvcmU6OlZhbHVlKCEhW19jb25maWd1cmF0aW9uIF9jb252ZXJ0c1Bvc2l0aW9uU3R5bGVP bkNvcHldKSk7Cg== 361419 2019-02-07 10:59:02 -0800 2019-02-07 11:00:35 -0800 Patch bug-194364-20190207105902.patch text/plain 2925 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDExMjcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE5LTAyLTA3ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUHJpbnQgYmFja2dy b3VuZHMgcHJlZmVyZW5jZSBzaG91bGQgYmUgaG9ub3JlZCBpbnN0ZWFkIG9mIFdLV2ViVmlld0Nv bmZpZ3VyYXRpb24gdmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5NDM2NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDc2Mjc1OTk+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgVGltIEhvcnRvbi4KKworICAgICAgICBXaXRob3V0IHRoaXMgcGF0 Y2gsIGNoYW5naW5nIHRoZSBwcmVmZXJlbmNlIGZvciBwcmludGluZyB0aGUgYmFja2dyb3VuZCBo YXMgbm8gZWZmZWN0LgorICAgICAgICBUaGlzIHBhdGNoIGZpeGVzIHRoYXQsIGFuZCBJIHZlcmlm aWVkIGl0IG1hbnVhbGx5IGJ5IGNoZWNraW5nICJQcmludCBiYWNrZ3JvdW5kcyIgaW4gU2FmYXJp J3MgcHJpbnQgbWVudS4KKyAgICAgICAgVW5mb3J0dW5hdGVseSwgdGhlIG9ubHkgd2F5IHRvIHRl c3QgdGhpcyBpcyBhY3R1YWxseSBwcmludGluZyBiZWNhdXNlIG9ubHkgdmFsdWVzIGZyb20gV2Vi UGFnZVByb3h5OjpwcmVmZXJlbmNlcworICAgICAgICBvciBXZWJQYWdlUHJveHk6OmNvbmZpZ3Vy YXRpb24ncyBwcmVmZXJlbmNlcyBhcmUgZXhwb3NlZCB0byB0aGUgQVBJLCBidXQgdmFsdWVzIGZy b20gV2ViUGFnZVByb3h5OjpwcmVmZXJlbmNlc1N0b3JlCisgICAgICAgIGFyZSB1c2VkIHdoZW4g cHJpbnRpbmcuICBBY3R1YWxseSBwcmludGluZyB2ZXJpZmllcyB0aGlzIGNoYW5nZSBmaXhlcyB0 aGUgYnVnLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW06Cisg ICAgICAgICgtW1dLV2ViVmlldyBfaW5pdGlhbGl6ZVdpdGhDb25maWd1cmF0aW9uOl0pOgorCiAy MDE5LTAyLTA3ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgRGVwcmVjYXRlIFdLQnVuZGxlUGFnZVNldERlZmVyc0xvYWRpbmcKSW5kZXg6IFNv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQkocmV2aXNp b24gMjQxMDI4KQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmll dy5tbQkod29ya2luZyBjb3B5KQpAQCAtNTg4LDcgKzU4OCwxMCBAQCAtICh2b2lkKV9pbml0aWFs aXplV2l0aENvbmZpZ3VyYXRpb246KFdLCiAgICAgcGFnZUNvbmZpZ3VyYXRpb24tPnByZWZlcmVu Y2VWYWx1ZXMoKS5zZXQoV2ViS2l0OjpXZWJQcmVmZXJlbmNlc0tleTo6c3VwcHJlc3Nlc0luY3Jl bWVudGFsUmVuZGVyaW5nS2V5KCksIFdlYktpdDo6V2ViUHJlZmVyZW5jZXNTdG9yZTo6VmFsdWUo ISFbX2NvbmZpZ3VyYXRpb24gc3VwcHJlc3Nlc0luY3JlbWVudGFsUmVuZGVyaW5nXSkpOwogCiAg ICAgcGFnZUNvbmZpZ3VyYXRpb24tPnByZWZlcmVuY2VWYWx1ZXMoKS5zZXQoV2ViS2l0OjpXZWJQ cmVmZXJlbmNlc0tleTo6c2hvdWxkUmVzcGVjdEltYWdlT3JpZW50YXRpb25LZXkoKSwgV2ViS2l0 OjpXZWJQcmVmZXJlbmNlc1N0b3JlOjpWYWx1ZSghIVtfY29uZmlndXJhdGlvbiBfcmVzcGVjdHNJ bWFnZU9yaWVudGF0aW9uXSkpOworI2lmICFQTEFURk9STShNQUMpCisgICAgLy8gRklYTUU6IEV4 cG9zZSBXS1ByZWZlcmVuY2VzLl9zaG91bGRQcmludEJhY2tncm91bmRzIG9uIGlPUywgYWRvcHQg aXQgaW4gYWxsIGlPUyBjbGllbnRzLCBhbmQgcmVtb3ZlIHRoaXMgYW5kIFdLV2ViVmlld0NvbmZp Z3VyYXRpb24uX3ByaW50c0JhY2tncm91bmRzEwMuCiAgICAgcGFnZUNvbmZpZ3VyYXRpb24tPnBy ZWZlcmVuY2VWYWx1ZXMoKS5zZXQoV2ViS2l0OjpXZWJQcmVmZXJlbmNlc0tleTo6c2hvdWxkUHJp bnRCYWNrZ3JvdW5kc0tleSgpLCBXZWJLaXQ6OldlYlByZWZlcmVuY2VzU3RvcmU6OlZhbHVlKCEh W19jb25maWd1cmF0aW9uIF9wcmludHNCYWNrZ3JvdW5kc10pKTsKKyNlbmRpZgogICAgIHBhZ2VD b25maWd1cmF0aW9uLT5wcmVmZXJlbmNlVmFsdWVzKCkuc2V0KFdlYktpdDo6V2ViUHJlZmVyZW5j ZXNLZXk6OmluY3JlbWVudGFsUmVuZGVyaW5nU3VwcHJlc3Npb25UaW1lb3V0S2V5KCksIFdlYktp dDo6V2ViUHJlZmVyZW5jZXNTdG9yZTo6VmFsdWUoW19jb25maWd1cmF0aW9uIF9pbmNyZW1lbnRh bFJlbmRlcmluZ1N1cHByZXNzaW9uVGltZW91dF0pKTsKICAgICBwYWdlQ29uZmlndXJhdGlvbi0+ cHJlZmVyZW5jZVZhbHVlcygpLnNldChXZWJLaXQ6OldlYlByZWZlcmVuY2VzS2V5OjpqYXZhU2Ny aXB0TWFya3VwRW5hYmxlZEtleSgpLCBXZWJLaXQ6OldlYlByZWZlcmVuY2VzU3RvcmU6OlZhbHVl KCEhW19jb25maWd1cmF0aW9uIF9hbGxvd3NKYXZhU2NyaXB0TWFya3VwXSkpOwogICAgIHBhZ2VD b25maWd1cmF0aW9uLT5wcmVmZXJlbmNlVmFsdWVzKCkuc2V0KFdlYktpdDo6V2ViUHJlZmVyZW5j ZXNLZXk6OnNob3VsZENvbnZlcnRQb3NpdGlvblN0eWxlT25Db3B5S2V5KCksIFdlYktpdDo6V2Vi UHJlZmVyZW5jZXNTdG9yZTo6VmFsdWUoISFbX2NvbmZpZ3VyYXRpb24gX2NvbnZlcnRzUG9zaXRp b25TdHlsZU9uQ29weV0pKTsK