194363 2019-02-06 15:12:23 -0800 Digital crown should scroll safe browsing warning on watchOS 2019-02-07 10:24:58 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen webkit-bug-importer wenson_hsieh oldest_to_newest 1503499 0 achristensen 2019-02-06 15:12:23 -0800 Digital crown should scroll safe browsing warning on watchOS 1503500 1 361336 achristensen 2019-02-06 15:12:55 -0800 Created attachment 361336 Patch 1503501 2 achristensen 2019-02-06 15:12:57 -0800 <rdar://problem/47348124> 1503544 3 361336 wenson_hsieh 2019-02-06 17:51:31 -0800 Comment on attachment 361336 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361336&action=review > Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm:38 > +#import <UIKit/UIResponder_Private.h> Nit - I think you can just import "UIKitSPI.h" instead. > Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm:296 > + self.crownInputScrollDirection = PUICCrownInputScrollDirectionVertical; Nice, you took out the scrollIndicator = NO :) I was about to tell you that we actually want to show scroll indicators in native UI here, but it looks like you beat me to it. 1503785 4 achristensen 2019-02-07 10:24:58 -0800 https://trac.webkit.org/changeset/241125/webkit 361336 2019-02-06 15:12:55 -0800 2019-02-06 17:51:31 -0800 Patch bug-194363-20190206151255.patch text/plain 3369 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDExMDQpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTAyLTA2ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRGlnaXRhbCBjcm93 biBzaG91bGQgc2Nyb2xsIHNhZmUgYnJvd3Npbmcgd2FybmluZyBvbiB3YXRjaE9TCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQzNjMKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzQ3MzQ4MTI0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL1dLU2FmZUJyb3dzaW5nV2Fybmlu Zy5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9XS1NhZmVCcm93c2luZ1dhcm5pbmcubW06 CisgICAgICAgICgtW1dLU2FmZUJyb3dzaW5nV2FybmluZyBpbml0V2l0aEZyYW1lOnNhZmVCcm93 c2luZ1dhcm5pbmc6Y29tcGxldGlvbkhhbmRsZXI6XSk6CisgICAgICAgICgtW1dLU2FmZUJyb3dz aW5nV2FybmluZyBhZGRDb250ZW50XSk6CisKIDIwMTktMDItMDYgIEtlaXRoIFJvbGxpbiAgPGty b2xsaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlYWxseSBlbmFibGUgdGhlIGF1dG9tYXRpYyBj aGVja2luZyBhbmQgcmVnZW5lcmF0aW9ucyBvZiAueGNmaWxlbGlzdHMgZHVyaW5nIGJ1aWxkcwpJ bmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV0tTYWZlQnJvd3NpbmdXYXJuaW5n LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV0tTYWZlQnJv d3NpbmdXYXJuaW5nLmgJKHJldmlzaW9uIDI0MTAyOCkKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0NvY29hL1dLU2FmZUJyb3dzaW5nV2FybmluZy5oCSh3b3JraW5nIGNvcHkpCkBAIC01Nyw2 ICs1Nyw5IEBAIHVzaW5nIFJlY3RUeXBlID0gQ0dSZWN0OwogICAgIFJlZlB0cjxjb25zdCBXZWJL aXQ6OlNhZmVCcm93c2luZ1dhcm5pbmc+IF93YXJuaW5nOwogICAgIFdlYWtPYmpDUHRyPFdLU2Fm ZUJyb3dzaW5nVGV4dFZpZXc+IF9kZXRhaWxzOwogICAgIFdlYWtPYmpDUHRyPFZpZXdUeXBlPiBf Ym94OworI2lmIFBMQVRGT1JNKFdBVENIT1MpCisgICAgV2Vha09iakNQdHI8VUlSZXNwb25kZXI+ IF9wcmV2aW91c0ZpcnN0UmVzcG9uZGVyOworI2VuZGlmCiB9CiAKIC0gKGluc3RhbmNldHlwZSlp bml0V2l0aEZyYW1lOihSZWN0VHlwZSlmcmFtZSBzYWZlQnJvd3NpbmdXYXJuaW5nOihjb25zdCBX ZWJLaXQ6OlNhZmVCcm93c2luZ1dhcm5pbmcmKXdhcm5pbmcgY29tcGxldGlvbkhhbmRsZXI6KENv bXBsZXRpb25IYW5kbGVyPHZvaWQoVmFyaWFudDxXZWJLaXQ6OkNvbnRpbnVlVW5zYWZlTG9hZCwg VVJMPiYmKT4mJiljb21wbGV0aW9uSGFuZGxlcjsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0NvY29hL1dLU2FmZUJyb3dzaW5nV2FybmluZy5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XS1NhZmVCcm93c2luZ1dhcm5pbmcubW0JKHJldmlzaW9u IDI0MTAyOCkKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dLU2FmZUJyb3dzaW5n V2FybmluZy5tbQkod29ya2luZyBjb3B5KQpAQCAtMzMsNiArMzMsMTEgQEAKICNpbXBvcnQgPHd0 Zi9CbG9ja1B0ci5oPgogI2ltcG9ydCA8d3RmL0xhbmd1YWdlLmg+CiAKKyNpZiBQTEFURk9STShX QVRDSE9TKQorI2ltcG9ydCA8UGVwcGVyVUlDb3JlL1VJU2Nyb2xsVmlldytQVUlDQWRkaXRpb25z UHJpdmF0ZS5oPgorI2ltcG9ydCA8VUlLaXQvVUlSZXNwb25kZXJfUHJpdmF0ZS5oPgorI2VuZGlm CisKIGNvbnN0ZXhwciBDR0Zsb2F0IGV4Y2xhbWF0aW9uUG9pbnRTaXplID0gMzA7CiBjb25zdGV4 cHIgQ0dGbG9hdCBib3hDb3JuZXJSYWRpdXMgPSA2OwogI2lmIEhBVkUoU0FGRV9CUk9XU0lORykK QEAgLTI3NCwxMiArMjc5LDIyIEBAIC0gKGluc3RhbmNldHlwZSlpbml0V2l0aEZyYW1lOihSZWN0 VHlwZSkKICAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoV2ViS2l0OjpDb250aW51ZVVuc2FmZUxv YWQ6Olllcyk7CiAgICAgICAgIHJldHVybiBuaWw7CiAgICAgfQotICAgIF9jb21wbGV0aW9uSGFu ZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpOworICAgIF9jb21wbGV0aW9uSGFuZGxl ciA9IFt3ZWFrU2VsZiA9IFdlYWtPYmpDUHRyPFdLU2FmZUJyb3dzaW5nV2FybmluZz4oc2VsZiks IGNvbXBsZXRpb25IYW5kbGVyID0gV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcildIChWYXJpYW50 PFdlYktpdDo6Q29udGludWVVbnNhZmVMb2FkLCBVUkw+JiYgcmVzdWx0KSBtdXRhYmxlIHsKKyNp ZiBQTEFURk9STShXQVRDSE9TKQorICAgICAgICBpZiAoYXV0byBzdHJvbmdTZWxmID0gd2Vha1Nl bGYuZ2V0KCkpCisgICAgICAgICAgICBbc3Ryb25nU2VsZi5nZXQoKS0+X3ByZXZpb3VzRmlyc3RS ZXNwb25kZXIgYmVjb21lRmlyc3RSZXNwb25kZXJdOworI2VuZGlmCisgICAgICAgIGNvbXBsZXRp b25IYW5kbGVyKFdURk1vdmUocmVzdWx0KSk7CisgICAgfTsKICAgICBfd2FybmluZyA9IG1ha2VS ZWYod2FybmluZyk7CiAgICAgc2V0QmFja2dyb3VuZChzZWxmLCBjb2xvckZvckl0ZW0oV2Fybmlu Z0l0ZW06OkJhY2tncm91bmQsIHNlbGYpKTsKICNpZiBQTEFURk9STShNQUMpCiAgICAgW3NlbGYg YWRkQ29udGVudF07CiAjZW5kaWYKKworI2lmIFBMQVRGT1JNKFdBVENIT1MpCisgICAgc2VsZi5j cm93bklucHV0U2Nyb2xsRGlyZWN0aW9uID0gUFVJQ0Nyb3duSW5wdXRTY3JvbGxEaXJlY3Rpb25W ZXJ0aWNhbDsKKyNlbmRpZgogICAgIHJldHVybiBzZWxmOwogfQogCkBAIC0zNjIsNiArMzc3LDEx IEBAIC0gKHZvaWQpYWRkQ29udGVudAogICAgIFtzZWxmIHVwZGF0ZUNvbnRlbnRTaXplXTsKICNl bmRpZgogI2VuZGlmCisgICAgCisjaWYgUExBVEZPUk0oV0FUQ0hPUykKKyAgICBzZWxmLT5fcHJl dmlvdXNGaXJzdFJlc3BvbmRlciA9IFtzZWxmIGZpcnN0UmVzcG9uZGVyXTsKKyAgICBbc2VsZiBi ZWNvbWVGaXJzdFJlc3BvbmRlcl07CisjZW5kaWYKIH0KIAogLSAodm9pZClzaG93RGV0YWlsc0Ns aWNrZWQK