194359 2019-02-06 13:40:23 -0800 Fix potential build error in GPUDevice 2019-02-06 13:49:29 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino ews-watchlist graouts joepeck kondapallykalyan webkit-bug-importer oldest_to_newest 1503454 0 dino 2019-02-06 13:40:23 -0800 Fix potential build error in GPUDevice 1503455 1 361323 dino 2019-02-06 13:42:07 -0800 Created attachment 361323 Patch 1503456 2 361323 joepeck 2019-02-06 13:43:28 -0800 Comment on attachment 361323 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361323&action=review r=me > Source/WebCore/platform/graphics/gpu/cocoa/GPUDeviceMetal.mm:57 > if (!devicePtr) Can this just go outside of the #if/#else? 1503460 3 dino 2019-02-06 13:48:34 -0800 Committed r241047: <https://trac.webkit.org/changeset/241047> 1503461 4 webkit-bug-importer 2019-02-06 13:49:29 -0800 <rdar://problem/47862662> 361323 2019-02-06 13:42:07 -0800 2019-02-06 13:43:28 -0800 Patch bug-194359-20190207084206.patch text/plain 1441 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwOTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmViZDM2YzYxODFmNGQy YTFjZDk3ZGI1OGRjNWQ4NTFmZDVjNzgxZC4uMTM5ZWUxMTg2MTVkNjYxYzRjOWUwZjRhY2NhMGJk NWRlYThjMmNlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAyLTA2ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggcG90ZW50aWFsIGJ1aWxk IGVycm9yIGluIEdQVURldmljZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTk0MzU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkIGFuIFVOVVNFRF9QQVJBTSBmb3Igbm9uLW1hY09TIHBsYXRmb3Jtcy4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dwdS9jb2NvYS9HUFVEZXZpY2VNZXRhbC5t bToKKyAgICAgICAgKFdlYkNvcmU6OkdQVURldmljZTo6Y3JlYXRlKToKKwogMjAxOS0wMi0wNSAg QWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFN0 b3AgdXNpbmcgYmxvYlJlZ2lzdHJ5IGluIE5ldHdvcmtQcm9jZXNzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvY29jb2EvR1BVRGV2aWNlTWV0YWwubW0g Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvY29jb2EvR1BVRGV2aWNlTWV0 YWwubW0KaW5kZXggYzc2ZWM4YjFiYjNiMmQ0Yzg4OTUwM2JhYjMzMTFjYWM2ZTdkMGRiOS4uY2Rl MWZhYmMxMzBiZTQ4MjA3M2Y4ZmQ4N2Q4NmZiNjk0NTJhYTIyOCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L2NvY29hL0dQVURldmljZU1ldGFsLm1tCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9jb2NvYS9HUFVEZXZpY2VN ZXRhbC5tbQpAQCAtNTUsOCArNTUsMTAgQEAgUmVmUHRyPEdQVURldmljZT4gR1BVRGV2aWNlOjpj cmVhdGUoT3B0aW9uYWw8R1BVUmVxdWVzdEFkYXB0ZXJPcHRpb25zPiYmIG9wdGlvbnMKICAgICB9 CiAgICAgCiAgICAgaWYgKCFkZXZpY2VQdHIpCisjZWxzZQorICAgIFVOVVNFRF9QQVJBTShvcHRp b25zKTsKICNlbmRpZiAvLyBQTEFURk9STShNQUMpCi0gICAgICAgIGRldmljZVB0ciA9IGFkb3B0 TlMoTVRMQ3JlYXRlU3lzdGVtRGVmYXVsdERldmljZSgpKTsKKyAgICBkZXZpY2VQdHIgPSBhZG9w dE5TKE1UTENyZWF0ZVN5c3RlbURlZmF1bHREZXZpY2UoKSk7CiAKICAgICBFTkRfQkxPQ0tfT0JK Q19FWENFUFRJT05TOwogCg==