194355 2019-02-06 12:21:28 -0800 [ews-app] Fetch builder id to name mapping 2019-02-13 16:19:19 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue kocsen_chung lforschler webkit-bug-importer oldest_to_newest 1503426 0 aakash_jain 2019-02-06 12:21:28 -0800 ews-app should fetch builder id to name mapping from Buildbot so that it can display the builer name appropriately on EWS status bubbles. 1503434 1 361319 aakash_jain 2019-02-06 12:52:53 -0800 Created attachment 361319 Proposed patch 1505432 2 361319 lforschler 2019-02-12 15:17:24 -0800 Comment on attachment 361319 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=361319&action=review > Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py:63 > + builder_id = builder['builderid'] do you want to use a .get here as well? 1505917 3 361319 commit-queue 2019-02-13 16:16:22 -0800 Comment on attachment 361319 Proposed patch Clearing flags on attachment: 361319 Committed r241485: <https://trac.webkit.org/changeset/241485> 1505918 4 commit-queue 2019-02-13 16:16:23 -0800 All reviewed patches have been landed. Closing bug. 1505920 5 webkit-bug-importer 2019-02-13 16:19:19 -0800 <rdar://problem/48056974> 361319 2019-02-06 12:52:53 -0800 2019-02-13 16:16:22 -0800 Proposed patch ews-app-fetch-mapping.patch text/plain 2339 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MTA0MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTAyLTA2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWFwcF0gRmV0Y2ggYnVpbGRlciBpZCB0byBuYW1lIG1hcHBpbmcK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDM1NQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRT bGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvY29tbW9uL2J1aWxkYm90LnB5OgorICAgICAgICAoQnVp bGRib3QuZ2V0X2J1aWxkZXJfaWRfdG9fbmFtZV9tYXBwaW5nKToKKyAgICAgICAgKEJ1aWxkYm90 Ll9nZXRfZGlzcGxheV9uYW1lX2Zyb21fYnVpbGRlcl9uYW1lKToKKwogMjAxOS0wMi0wNiAgRGF2 aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdUUjo6SW5qZWN0ZWRC dW5kbGVQYWdlOjp3aWxsU2VuZFJlcXVlc3RGb3JGcmFtZSgpIGxlYWtzIGEgV0tEYXRhUmVmCklu ZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9jb21tb24vYnVpbGRib3Qu cHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvY29t bW9uL2J1aWxkYm90LnB5CShyZXZpc2lvbiAyNDEwNDIpCisrKyBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYXBwL2V3cy9jb21tb24vYnVpbGRib3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTIy LDggKzIyLDEwIEBACiAKIGltcG9ydCBsb2dnaW5nCiBpbXBvcnQgb3MKK2ltcG9ydCByZQogaW1w b3J0IHN1YnByb2Nlc3MKIAoraW1wb3J0IGV3cy5jb21tb24udXRpbCBhcyB1dGlsCiBpbXBvcnQg ZXdzLmNvbmZpZyBhcyBjb25maWcKIAogX2xvZyA9IGxvZ2dpbmcuZ2V0TG9nZ2VyKF9fbmFtZV9f KQpAQCAtNDksMyArNTEsMjYgQEAgY2xhc3MgQnVpbGRib3QoKToKICAgICAgICAgICAgIF9sb2cu d2FybignRXJyb3IgZXhlY3V0aW5nOiB7fSwgcmV0dXJuIGNvZGU9e30nLmZvcm1hdChjb21tYW5k LCByZXR1cm5fY29kZSkpCiAKICAgICAgICAgcmV0dXJuIHJldHVybl9jb2RlCisKKyAgICBAY2xh c3NtZXRob2QKKyAgICBkZWYgZ2V0X2J1aWxkZXJfaWRfdG9fbmFtZV9tYXBwaW5nKGNscyk6Cisg ICAgICAgIGJ1aWxkZXJfaWRfdG9fbmFtZV9tYXBwaW5nID0ge30KKyAgICAgICAgYnVpbGRlcl91 cmwgPSAnaHR0cDovL3t9L2FwaS92Mi9idWlsZGVycycuZm9ybWF0KGNvbmZpZy5CVUlMREJPVF9T RVJWRVJfSE9TVCkKKyAgICAgICAgYnVpbGRlcnNfZGF0YSA9IHV0aWwuZmV0Y2hfZGF0YV9mcm9t X3VybChidWlsZGVyX3VybCkKKyAgICAgICAgaWYgbm90IGJ1aWxkZXJzX2RhdGE6CisgICAgICAg ICAgICByZXR1cm4ge30KKyAgICAgICAgZm9yIGJ1aWxkZXIgaW4gYnVpbGRlcnNfZGF0YS5qc29u KCkuZ2V0KCdidWlsZGVycycsIFtdKToKKyAgICAgICAgICAgIGJ1aWxkZXJfaWQgPSBidWlsZGVy WydidWlsZGVyaWQnXQorICAgICAgICAgICAgYnVpbGRlcl9uYW1lID0gYnVpbGRlci5nZXQoJ25h bWUnKQorICAgICAgICAgICAgZGlzcGxheV9uYW1lID0gYnVpbGRlci5nZXQoJ2Rlc2NyaXB0aW9u JykKKyAgICAgICAgICAgIGlmIG5vdCBkaXNwbGF5X25hbWU6CisgICAgICAgICAgICAgICAgZGlz cGxheV9uYW1lID0gQnVpbGRib3QuX2dldF9kaXNwbGF5X25hbWVfZnJvbV9idWlsZGVyX25hbWUo YnVpbGRlcl9uYW1lKQorICAgICAgICAgICAgYnVpbGRlcl9pZF90b19uYW1lX21hcHBpbmdbYnVp bGRlcl9pZF0gPSB7J2J1aWxkZXJfbmFtZSc6IGJ1aWxkZXJfbmFtZSwgJ2Rpc3BsYXlfbmFtZSc6 IGRpc3BsYXlfbmFtZX0KKyAgICAgICAgcmV0dXJuIGJ1aWxkZXJfaWRfdG9fbmFtZV9tYXBwaW5n CisKKyAgICBAY2xhc3NtZXRob2QKKyAgICBkZWYgX2dldF9kaXNwbGF5X25hbWVfZnJvbV9idWls ZGVyX25hbWUoY2xzLCBidWlsZGVyX25hbWUpOgorICAgICAgICB3b3JkcyA9IHJlLnNwbGl0KCdb LCBcLV86KCldKycsIGJ1aWxkZXJfbmFtZSkKKyAgICAgICAgaWYgbm90IHdvcmRzOgorICAgICAg ICAgICAgcmV0dXJuIGJ1aWxkZXJfbmFtZQorICAgICAgICByZXR1cm4gd29yZHNbMF0ubG93ZXIo KQo=