194352 2019-02-06 11:46:08 -0800 WebKit searches for plugins even if plugins are disabled 2019-02-21 23:02:11 -0800 1 1 1 Unclassified WebKit Plug-ins Other PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 hschoepel webkit-unassigned achristensen bugs-noreply cdumez cgarcia commit-queue darin ews-watchlist mcatanzaro tsavell webkit-bug-importer youennf oldest_to_newest 1503405 0 hschoepel 2019-02-06 11:46:08 -0800 Dear ladies & gentlemen, I filled already a related bug here: https://bugs.webkit.org/show_bug.cgi?id=194351 The problem in this bug report is that Epiphany is scanning for plugins even the dconf value says it's "disabled". Terminal output: henrik@debian:~$ epiphany Error scanning plugin /usr/lib/jvm/oracle-java8-jre-amd64/lib/amd64/libnpjp2.so, /usr/lib/x86_64-linux-gnu/webkit2gtk-4.0/WebKitPluginProcess returned 11 exit status ** (WebKitWebProcess:28441): WARNING **: 19:08:44.386: WebKit wasn't able to find the GStreamer opengl plugin. Hardware-accelerated zero-copy video rendering can't be enabled without this plugin. ** (WebKitWebProcess:28441): WARNING **: 19:08:44.621: WebKit wasn't able to find the GStreamer opengl plugin. Hardware-accelerated zero-copy video rendering can't be enabled without this plugin. ** (WebKitWebProcess:28441): WARNING **: 19:08:45.105: WebKit wasn't able to find the GStreamer opengl plugin. Hardware-accelerated zero-copy video rendering can't be enabled without this plugin. ** (WebKitWebProcess:28441): WARNING **: 19:08:45.315: WebKit wasn't able to find the GStreamer opengl plugin. Hardware-accelerated zero-copy video rendering can't be enabled without this plugin. ^C Plugin dconf check: gsettings get org.gnome.Epiphany.web:/org/gnome/epiphany/web/ enable-plugins false Best regards, Henrik 1503447 1 mcatanzaro 2019-02-06 13:28:13 -0800 To be clear: the bug is that WebKit shouldn't be scanning plugins when the enable-plugins setting is disabled. 1505685 2 361906 cgarcia 2019-02-13 03:10:19 -0800 Created attachment 361906 Patch 1505686 3 ews-watchlist 2019-02-13 03:12:27 -0800 Attachment 361906 did not pass style-queue: ERROR: Source/WebKit/WebProcess/Plugins/WebPluginInfoProvider.cpp:152: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1505728 4 361906 mcatanzaro 2019-02-13 08:51:02 -0800 Comment on attachment 361906 Patch Style checker is correct! (It's easier to read with the braces, even though they're not necessary.) 1505735 5 cgarcia 2019-02-13 09:00:44 -0800 Thanks for the review, now we need WebKit2 owner approval. 1505738 6 cdumez 2019-02-13 09:03:28 -0800 Youenn, I think you looked into this code last. Could you please take a look? 1508051 7 cgarcia 2019-02-20 04:44:09 -0800 Ping Youenn, please. 1508076 8 361906 cdumez 2019-02-20 08:45:59 -0800 Comment on attachment 361906 Patch Sorry about the delay. I think Youenn is out of office. WK2 Owner LGTM. 1508086 9 361906 commit-queue 2019-02-20 09:11:38 -0800 Comment on attachment 361906 Patch Clearing flags on attachment: 361906 Committed r241817: <https://trac.webkit.org/changeset/241817> 1508087 10 commit-queue 2019-02-20 09:11:40 -0800 All reviewed patches have been landed. Closing bug. 1508088 11 webkit-bug-importer 2019-02-20 09:18:37 -0800 <rdar://problem/48239508> 1508158 12 tsavell 2019-02-20 11:23:48 -0800 Looks like this change https://trac.webkit.org/changeset/241817/webkit has caused 4 API failures: Failed TestWebKitAPI.WebKit.WKNavigationResponsePDFType Received data during response processing, queuing it. /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:45 Expected equality of these values: navigationResponse.canShowMIMEType Which is: '\0' self.expectation Which is: '\x1' (1) Timeout TestWebKitAPI.WebKit.GetPDFResourceDataInUnparentedWebView TestWebKitAPI.WebKit.WKPDFViewResizeCrash TestWebKitAPI.WebKit.GetPDFResourceData build: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20%28Tests%29/builds/11341 1508300 13 tsavell 2019-02-20 15:26:59 -0800 Reverted r241817 for reason: Caused 4 API failures Committed r241844: <https://trac.webkit.org/changeset/241844> 1508439 14 darin 2019-02-20 21:24:43 -0800 It looks like there are some special considerations on the macOS platform. Might need to scan for the PDF plug-in even if plug-ins are disabled or something like that. 1508490 15 cgarcia 2019-02-21 03:12:18 -0800 EWS doesn't run api tests? 1508492 16 cgarcia 2019-02-21 03:27:40 -0800 (In reply to Darin Adler from comment #14) > It looks like there are some special considerations on the macOS platform. > Might need to scan for the PDF plug-in even if plug-ins are disabled or > something like that. Right, the setting doesn't affect application plugins (pdf is the only application plugin, I guess). 1508493 17 362602 cgarcia 2019-02-21 03:37:27 -0800 Created attachment 362602 Patch for landing Made this only for non-cocoa ports. 1508494 18 ews-watchlist 2019-02-21 03:39:44 -0800 Attachment 362602 did not pass style-queue: ERROR: Source/WebKit/WebProcess/Plugins/WebPluginInfoProvider.cpp:158: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1508531 19 darin 2019-02-21 08:55:10 -0800 A correct version would tie this to ports that have "application plug-ins", rather than specifically to "Cocoa ports", but perhaps there is no obvious way to do that. 1508548 20 cgarcia 2019-02-21 09:53:33 -0800 (In reply to Darin Adler from comment #19) > A correct version would tie this to ports that have "application plug-ins", > rather than specifically to "Cocoa ports", but perhaps there is no obvious > way to do that. I assumed cocoa because PDF plugin is apparently the only application plugin and WebPage::pdfPluginEnabled() is in a cocoa platform ifdef. 1508902 21 cgarcia 2019-02-21 23:02:11 -0800 Committed r241933: <https://trac.webkit.org/changeset/241933> 361906 2019-02-13 03:10:19 -0800 2019-02-21 03:37:27 -0800 Patch wk-plugins-disabled.diff text/plain 2347 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMGI1M2YyMjlhZmYuLmNiYzA0MWVmZjlkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDE5LTAyLTEzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXSBFcGlwaGFueSBzZWFyY2hpbmcgZm9yIHBsdWdpbnMgZXZl biBpZiBwbHVnaW5zIGFyZSBkaXNhYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MzUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQ2hlY2sgcGx1Z2luc0VuYWJsZWQgc2V0dGluZyBiZWZvcmUgdHJ5 aW5nIHRvIGdldCBwbHVnaW5zIGZyb20gVUkgcHJvY2Vzcy4KKworICAgICAgICAqIFdlYlByb2Nl c3MvUGx1Z2lucy9XZWJQbHVnaW5JbmZvUHJvdmlkZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJQbHVnaW5JbmZvUHJvdmlkZXI6OnBvcHVsYXRlUGx1Z2luQ2FjaGUpOgorCiAyMDE5LTAyLTEz ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIENyYXNoIGluIFBh Z2U6OnNldEFjdGl2aXR5U3RhdGUgYmVjYXVzZSBtX3BhZ2UgaXMgbnVsbApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1BsdWdpbnMvV2ViUGx1Z2luSW5mb1Byb3ZpZGVyLmNw cCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9QbHVnaW5zL1dlYlBsdWdpbkluZm9Qcm92aWRl ci5jcHAKaW5kZXggNTQ1NWIzMGY0MGUuLmExN2E4NDc3NTUwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1dlYlByb2Nlc3MvUGx1Z2lucy9XZWJQbHVnaW5JbmZvUHJvdmlkZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9QbHVnaW5zL1dlYlBsdWdpbkluZm9Qcm92aWRlci5j cHAKQEAgLTM2LDYgKzM2LDcgQEAKICNpbmNsdWRlIDxXZWJDb3JlL0ZyYW1lTG9hZGVyLmg+CiAj aW5jbHVkZSA8V2ViQ29yZS9QYWdlLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9TY2hlbWVSZWdpc3Ry eS5oPgorI2luY2x1ZGUgPFdlYkNvcmUvU2V0dGluZ3MuaD4KICNpbmNsdWRlIDxXZWJDb3JlL1N1 YmZyYW1lTG9hZGVyLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5nSGFzaC5oPgogCkBAIC0x NDYsMTEgKzE0NywxMiBAQCBWZWN0b3I8V2ViQ29yZTo6UGx1Z2luSW5mbz4gV2ViUGx1Z2luSW5m b1Byb3ZpZGVyOjp3ZWJWaXNpYmxlUGx1Z2luSW5mbyhQYWdlJiBwYQogdm9pZCBXZWJQbHVnaW5J bmZvUHJvdmlkZXI6OnBvcHVsYXRlUGx1Z2luQ2FjaGUoY29uc3QgV2ViQ29yZTo6UGFnZSYgcGFn ZSkKIHsKICAgICBpZiAoIW1fcGx1Z2luQ2FjaGVJc1BvcHVsYXRlZCkgewotICAgICAgICBIYW5n RGV0ZWN0aW9uRGlzYWJsZXIgaGFuZ0RldGVjdGlvbkRpc2FibGVyOwotCi0gICAgICAgIGlmICgh V2ViUHJvY2Vzczo6c2luZ2xldG9uKCkucGFyZW50UHJvY2Vzc0Nvbm5lY3Rpb24oKS0+c2VuZFN5 bmMoTWVzc2FnZXM6OldlYlByb2Nlc3NQcm94eTo6R2V0UGx1Z2lucyhtX3Nob3VsZFJlZnJlc2hQ bHVnaW5zKSwKLSAgICAgICAgICAgIE1lc3NhZ2VzOjpXZWJQcm9jZXNzUHJveHk6OkdldFBsdWdp bnM6OlJlcGx5KG1fY2FjaGVkUGx1Z2lucywgbV9jYWNoZWRBcHBsaWNhdGlvblBsdWdpbnMsIG1f Y2FjaGVkU3VwcG9ydGVkUGx1Z2luSWRlbnRpZmllcnMpLCAwKSkKLSAgICAgICAgICAgIHJldHVy bjsKKyAgICAgICAgaWYgKHBhZ2Uuc2V0dGluZ3MoKS5hcmVQbHVnaW5zRW5hYmxlZCgpKSB7Cisg ICAgICAgICAgICBIYW5nRGV0ZWN0aW9uRGlzYWJsZXIgaGFuZ0RldGVjdGlvbkRpc2FibGVyOwor ICAgICAgICAgICAgaWYgKCFXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS5wYXJlbnRQcm9jZXNzQ29u bmVjdGlvbigpLT5zZW5kU3luYyhNZXNzYWdlczo6V2ViUHJvY2Vzc1Byb3h5OjpHZXRQbHVnaW5z KG1fc2hvdWxkUmVmcmVzaFBsdWdpbnMpLAorICAgICAgICAgICAgICAgIE1lc3NhZ2VzOjpXZWJQ cm9jZXNzUHJveHk6OkdldFBsdWdpbnM6OlJlcGx5KG1fY2FjaGVkUGx1Z2lucywgbV9jYWNoZWRB cHBsaWNhdGlvblBsdWdpbnMsIG1fY2FjaGVkU3VwcG9ydGVkUGx1Z2luSWRlbnRpZmllcnMpLCAw KSkKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KIAogICAgICAgICBtX3Nob3Vs ZFJlZnJlc2hQbHVnaW5zID0gZmFsc2U7CiAgICAgICAgIG1fcGx1Z2luQ2FjaGVJc1BvcHVsYXRl ZCA9IHRydWU7Cg== 362602 2019-02-21 03:37:27 -0800 2019-02-21 03:37:27 -0800 Patch for landing wk2-plugins-disabled.diff text/plain 2615 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggOTJjNjZkNGRjZmEuLmQ4MGVhZDY2NjVjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDE5LTAyLTIxICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXSBFcGlwaGFueSBzZWFyY2hpbmcgZm9yIHBsdWdpbnMgZXZl biBpZiBwbHVnaW5zIGFyZSBkaXNhYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MzUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTWljaGFlbCBD YXRhbnphcm8uCisKKyAgICAgICAgQ2hlY2sgcGx1Z2luc0VuYWJsZWQgc2V0dGluZyBiZWZvcmUg dHJ5aW5nIHRvIGdldCBwbHVnaW5zIGZyb20gVUkgcHJvY2Vzcy4KKworICAgICAgICAqIFdlYlBy b2Nlc3MvUGx1Z2lucy9XZWJQbHVnaW5JbmZvUHJvdmlkZXIuY3BwOgorICAgICAgICAoV2ViS2l0 OjpXZWJQbHVnaW5JbmZvUHJvdmlkZXI6OnBvcHVsYXRlUGx1Z2luQ2FjaGUpOgorCiAyMDE5LTAy LTIwICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIHBy b2dyYW1tYXRpYyBmcmFtZSBzY3JvbGxpbmcgd29yayBvbiBpT1MKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9QbHVnaW5zL1dlYlBsdWdpbkluZm9Qcm92aWRlci5jcHAgYi9T b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvUGx1Z2lucy9XZWJQbHVnaW5JbmZvUHJvdmlkZXIuY3Bw CmluZGV4IDU0NTViMzBmNDBlLi43Njg0MDY0MmVlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9XZWJQcm9jZXNzL1BsdWdpbnMvV2ViUGx1Z2luSW5mb1Byb3ZpZGVyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvUGx1Z2lucy9XZWJQbHVnaW5JbmZvUHJvdmlkZXIuY3BwCkBA IC0zNiw2ICszNiw3IEBACiAjaW5jbHVkZSA8V2ViQ29yZS9GcmFtZUxvYWRlci5oPgogI2luY2x1 ZGUgPFdlYkNvcmUvUGFnZS5oPgogI2luY2x1ZGUgPFdlYkNvcmUvU2NoZW1lUmVnaXN0cnkuaD4K KyNpbmNsdWRlIDxXZWJDb3JlL1NldHRpbmdzLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9TdWJmcmFt ZUxvYWRlci5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1N0cmluZ0hhc2guaD4KIApAQCAtMTQ2LDEx ICsxNDcsMTggQEAgVmVjdG9yPFdlYkNvcmU6OlBsdWdpbkluZm8+IFdlYlBsdWdpbkluZm9Qcm92 aWRlcjo6d2ViVmlzaWJsZVBsdWdpbkluZm8oUGFnZSYgcGEKIHZvaWQgV2ViUGx1Z2luSW5mb1By b3ZpZGVyOjpwb3B1bGF0ZVBsdWdpbkNhY2hlKGNvbnN0IFdlYkNvcmU6OlBhZ2UmIHBhZ2UpCiB7 CiAgICAgaWYgKCFtX3BsdWdpbkNhY2hlSXNQb3B1bGF0ZWQpIHsKLSAgICAgICAgSGFuZ0RldGVj dGlvbkRpc2FibGVyIGhhbmdEZXRlY3Rpb25EaXNhYmxlcjsKLQotICAgICAgICBpZiAoIVdlYlBy b2Nlc3M6OnNpbmdsZXRvbigpLnBhcmVudFByb2Nlc3NDb25uZWN0aW9uKCktPnNlbmRTeW5jKE1l c3NhZ2VzOjpXZWJQcm9jZXNzUHJveHk6OkdldFBsdWdpbnMobV9zaG91bGRSZWZyZXNoUGx1Z2lu cyksCi0gICAgICAgICAgICBNZXNzYWdlczo6V2ViUHJvY2Vzc1Byb3h5OjpHZXRQbHVnaW5zOjpS ZXBseShtX2NhY2hlZFBsdWdpbnMsIG1fY2FjaGVkQXBwbGljYXRpb25QbHVnaW5zLCBtX2NhY2hl ZFN1cHBvcnRlZFBsdWdpbklkZW50aWZpZXJzKSwgMCkpCi0gICAgICAgICAgICByZXR1cm47Cisj aWYgUExBVEZPUk0oQ09DT0EpCisgICAgICAgIC8vIEFwcGxpY2F0aW9uIHBsdWdpbnMgYXJlIG5v dCBhZmZlY3RlZCBieSBlbmFibGVQbHVnaW5zIHNldHRpbmcsIHNvIHdlIGFsd2F5cyBuZWVkIHRv IHNjYW4gcGx1Z2lucyB0byBnZXQgdGhlbS4KKyAgICAgICAgYm9vbCBzaG91bGRTY2FuUGx1Z2lu cyA9IHRydWU7CisjZWxzZQorICAgICAgICBib29sIHNob3VsZFNjYW5QbHVnaW5zID0gcGFnZS5t YWluRnJhbWUoKS5sb2FkZXIoKS5zdWJmcmFtZUxvYWRlcigpLmFsbG93UGx1Z2lucygpOworI2Vu ZGlmCisgICAgICAgIGlmIChzaG91bGRTY2FuUGx1Z2lucykgeworICAgICAgICAgICAgSGFuZ0Rl dGVjdGlvbkRpc2FibGVyIGhhbmdEZXRlY3Rpb25EaXNhYmxlcjsKKyAgICAgICAgICAgIGlmICgh V2ViUHJvY2Vzczo6c2luZ2xldG9uKCkucGFyZW50UHJvY2Vzc0Nvbm5lY3Rpb24oKS0+c2VuZFN5 bmMoTWVzc2FnZXM6OldlYlByb2Nlc3NQcm94eTo6R2V0UGx1Z2lucyhtX3Nob3VsZFJlZnJlc2hQ bHVnaW5zKSwKKyAgICAgICAgICAgICAgICBNZXNzYWdlczo6V2ViUHJvY2Vzc1Byb3h5OjpHZXRQ bHVnaW5zOjpSZXBseShtX2NhY2hlZFBsdWdpbnMsIG1fY2FjaGVkQXBwbGljYXRpb25QbHVnaW5z LCBtX2NhY2hlZFN1cHBvcnRlZFBsdWdpbklkZW50aWZpZXJzKSwgMCkpCisgICAgICAgICAgICAg ICAgcmV0dXJuOworICAgICAgICB9CiAKICAgICAgICAgbV9zaG91bGRSZWZyZXNoUGx1Z2lucyA9 IGZhbHNlOwogICAgICAgICBtX3BsdWdpbkNhY2hlSXNQb3B1bGF0ZWQgPSB0cnVlOwo=