194341 2019-02-06 05:23:51 -0800 Build failure after r240315 2019-02-06 07:41:28 -0800 1 1 1 Unclassified WebKit WebCore JavaScript WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 psaavedra psaavedra commit-queue rniwa webkit-bug-importer wenson_hsieh oldest_to_newest 1502754 0 psaavedra 2019-02-06 05:23:51 -0800 Description: Failure happens building WPE with no VIDEO enabled (proably happens as well in other ports): -DENABLE_VIDEO=OFF -DPORT=WPE Diagnosis: JSC namespace not added to the Webcore namespace when video disabled Build errors: In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-68aea4ac-14.cpp:6: /home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+3646d86f28-r0/git/Source/WebCore/bindings/js/JSUndoItemCustom.cpp: At global scope: /home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+3646d86f28-r0/git/Source/WebCore/bindings/js/JSUndoItemCustom.cpp:41:91: error: 'SlotVisitor' has not been declared bool JSUndoItemOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown> handle, void*, SlotVisitor& visitor, const char** reason) In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-68aea4ac-14.cpp:6: /home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+3646d86f28-r0/git/Source/WebCore/bindings/js/JSUndoItemCustom.cpp: In member function 'virtual bool WebCore::JSUndoItemOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown>, void*, JSC::SlotVisitor&, const char**)': /home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+3646d86f28-r0/git/Source/WebCore/bindings/js/JSUndoItemCustom.cpp:46:33: error: 'jsCast' was not declared in this scope auto* documentForUndoItem = jsCast<JSUndoItem*>(handle.slot()->asCell())->wrapped().document(); ^~~~~~ Related to: https://bugs.webkit.org/show_bug.cgi?id=193111 1502755 1 361292 psaavedra 2019-02-06 05:26:10 -0800 Created attachment 361292 patch 1502762 2 361292 commit-queue 2019-02-06 07:40:36 -0800 Comment on attachment 361292 patch Clearing flags on attachment: 361292 Committed r241017: <https://trac.webkit.org/changeset/241017> 1502763 3 commit-queue 2019-02-06 07:40:37 -0800 All reviewed patches have been landed. Closing bug. 1502764 4 webkit-bug-importer 2019-02-06 07:41:28 -0800 <rdar://problem/47849690> 361292 2019-02-06 05:26:10 -0800 2019-02-06 07:40:36 -0800 patch bug-194341-20190206142609.patch text/plain 1848 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzZkYTc1Y2I5YWRlOTI5 NGMyNjYyYjA1ZDZiNDMzYjNjZTUzMDdjMi4uZjEwYWUxMmRiNzc3ZDUxYmI5ZjAyODExZDRhYTg5 MjdhZjIwYjU3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTAyLTA2ICBQYWJs byBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIEJ1aWxkIGZhaWx1 cmUgYWZ0ZXIgcjI0MDMxNQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk0MzQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU1VuZG9JdGVtQ3VzdG9tLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkpTVW5kb0l0ZW1Pd25lcjo6aXNSZWFjaGFibGVGcm9tT3BhcXVlUm9vdHMpOgorCiAy MDE5LTAyLTA1ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJF R1JFU1NJT04gKHIyNDA5MDkpOiBSZWxlYXNlIGFzc2VydCBpbiBGcmFtZUxvYWRlcjo6bG9hZFVS TCB3aGVuIG5hdmlnYXRpbmcgd2l0aCBhIG5vbi1leGlzdGVudCB0YXJnZXQgbmFtZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNVbmRvSXRlbUN1c3RvbS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1VuZG9JdGVtQ3VzdG9tLmNwcAppbmRleCBjZmFh MDI4YmJmZjVmZDViNGEzZjRhMGQ2MTAxMGZjYmU2NTNmYzc1Li4zZjZkZDlmZDAwZDg0NDIxMDVm YTQxMWFjNjU4MzhjMTVjMWMxNGQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9KU1VuZG9JdGVtQ3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9q cy9KU1VuZG9JdGVtQ3VzdG9tLmNwcApAQCAtMzQsMTIgKzM0LDEyIEBAIHZvaWQgSlNVbmRvSXRl bTo6dmlzaXRBZGRpdGlvbmFsQ2hpbGRyZW4oSlNDOjpTbG90VmlzaXRvciYgdmlzaXRvcikKICAg ICB3cmFwcGVkKCkucmVkb0hhbmRsZXIoKS52aXNpdEpTRnVuY3Rpb24odmlzaXRvcik7CiB9CiAK LWJvb2wgSlNVbmRvSXRlbU93bmVyOjppc1JlYWNoYWJsZUZyb21PcGFxdWVSb290cyhKU0M6Okhh bmRsZTxKU0M6OlVua25vd24+IGhhbmRsZSwgdm9pZCosIFNsb3RWaXNpdG9yJiB2aXNpdG9yLCBj b25zdCBjaGFyKiogcmVhc29uKQorYm9vbCBKU1VuZG9JdGVtT3duZXI6OmlzUmVhY2hhYmxlRnJv bU9wYXF1ZVJvb3RzKEpTQzo6SGFuZGxlPEpTQzo6VW5rbm93bj4gaGFuZGxlLCB2b2lkKiwgSlND OjpTbG90VmlzaXRvciYgdmlzaXRvciwgY29uc3QgY2hhcioqIHJlYXNvbikKIHsKICAgICBpZiAo VU5MSUtFTFkocmVhc29uKSkKICAgICAgICAgKnJlYXNvbiA9ICJEb2N1bWVudCBpcyBhbiBvcGFx dWUgcm9vdC4iOwogCi0gICAgYXV0byogZG9jdW1lbnRGb3JVbmRvSXRlbSA9IGpzQ2FzdDxKU1Vu ZG9JdGVtKj4oaGFuZGxlLnNsb3QoKS0+YXNDZWxsKCkpLT53cmFwcGVkKCkuZG9jdW1lbnQoKTsK KyAgICBhdXRvKiBkb2N1bWVudEZvclVuZG9JdGVtID0gSlNDOjpqc0Nhc3Q8SlNVbmRvSXRlbSo+ KGhhbmRsZS5zbG90KCktPmFzQ2VsbCgpKS0+d3JhcHBlZCgpLmRvY3VtZW50KCk7CiAgICAgcmV0 dXJuIGRvY3VtZW50Rm9yVW5kb0l0ZW0gJiYgdmlzaXRvci5jb250YWluc09wYXF1ZVJvb3QoZG9j dW1lbnRGb3JVbmRvSXRlbSk7CiB9CiAK