194339 2019-02-06 03:23:28 -0800 [JSC] Unify indirectEvalExecutableSpace and directEvalExecutableSpace 2019-02-06 11:51:34 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1502743 0 ysuzuki 2019-02-06 03:23:28 -0800 [JSC] Unify indirectEvalExecutableSpace and directEvalExecutableSpace 1502744 1 361286 ysuzuki 2019-02-06 03:26:42 -0800 Created attachment 361286 Patch 1503395 2 361286 msaboff 2019-02-06 11:23:52 -0800 Comment on attachment 361286 Patch r=me 1503396 3 361286 ysuzuki 2019-02-06 11:24:06 -0800 Comment on attachment 361286 Patch Thanks! 1503408 4 361286 commit-queue 2019-02-06 11:50:18 -0800 Comment on attachment 361286 Patch Clearing flags on attachment: 361286 Committed r241038: <https://trac.webkit.org/changeset/241038> 1503409 5 commit-queue 2019-02-06 11:50:19 -0800 All reviewed patches have been landed. Closing bug. 1503411 6 webkit-bug-importer 2019-02-06 11:51:34 -0800 <rdar://problem/47858327> 361286 2019-02-06 03:26:42 -0800 2019-02-06 11:50:18 -0800 Patch bug-194339-20190206032641.patch text/plain 6603 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm NDQ0OWRjNDI1NTE1Y2NmMzIwZjc5YjFlNDk4YjYxNjZlNDg5ZDY2Li41ZmY1NWJjN2ExODY1MTM5 ZGQ3NWMyNjIyZGE0Y2QyMWVlZTAxZmNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxOS0wMi0wNiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFVuaWZ5IGluZGlyZWN0RXZhbEV4ZWN1dGFibGVTcGFjZSBhbmQg ZGlyZWN0RXZhbEV4ZWN1dGFibGVTcGFjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MzM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRGlyZWN0RXZhbEV4ZWN1dGFibGUgYW5kIEluZGlyZWN0RXZhbEV4 ZWN1dGFibGUgaGF2ZSBjb21wbGV0ZWx5IHNhbWUgbWVtb3J5IGxheW91dC4KKyAgICAgICAgVGhl eSBoYXZlIGV2ZW4gdGhlIHNhbWUgc3RydWN0dXJlLiBUaGlzIHBhdGNoIHVuaWZpZXMgdGhlIHN1 YnNwYWNlcyBmb3IgdGhlbS4KKworICAgICAgICAqIHJ1bnRpbWUvRGlyZWN0RXZhbEV4ZWN1dGFi bGUuaDoKKyAgICAgICAgKiBydW50aW1lL0V2YWxFeGVjdXRhYmxlLmg6CisgICAgICAgIChKU0M6 OkV2YWxFeGVjdXRhYmxlOjpzdWJzcGFjZUZvcik6CisgICAgICAgICogcnVudGltZS9JbmRpcmVj dEV2YWxFeGVjdXRhYmxlLmg6CisgICAgICAgICogcnVudGltZS9WTS5jcHA6CisgICAgICAgICog cnVudGltZS9WTS5oOgorICAgICAgICAoSlNDOjpWTTo6Zm9yRWFjaFNjcmlwdEV4ZWN1dGFibGVT cGFjZSk6CisKIDIwMTktMDItMDYgIFBhYmxvIFNhYXZlZHJhICA8cHNhYXZlZHJhQGlnYWxpYS5j b20+CiAKICAgICAgICAgQnVpbGQgZmFpbHVyZSBhZnRlciByMjQwNDMxCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9EaXJlY3RFdmFsRXhlY3V0YWJsZS5oIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRGlyZWN0RXZhbEV4ZWN1dGFibGUuaAppbmRleCA2 M2UwMGY0NDZjNmJiOTJhNDk5OTVlNjRlYzFmYmM0MjBhMWI2ODcyLi44OTQ4ZDQ1YjU4MmVjNjVj NjhkY2RjM2ViNGZkY2UxOGY5N2U1OGJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9EaXJlY3RFdmFsRXhlY3V0YWJsZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0RpcmVjdEV2YWxFeGVjdXRhYmxlLmgKQEAgLTMxLDE1ICszMSwxMSBAQCBu YW1lc3BhY2UgSlNDIHsKIAogY2xhc3MgRGlyZWN0RXZhbEV4ZWN1dGFibGUgZmluYWwgOiBwdWJs aWMgRXZhbEV4ZWN1dGFibGUgewogcHVibGljOgotICAgIHRlbXBsYXRlPHR5cGVuYW1lIENlbGxU eXBlLCBTdWJzcGFjZUFjY2VzcyBtb2RlPgotICAgIHN0YXRpYyBJc29TdWJzcGFjZSogc3Vic3Bh Y2VGb3IoVk0mIHZtKQotICAgIHsKLSAgICAgICAgcmV0dXJuIHZtLmRpcmVjdEV2YWxFeGVjdXRh YmxlU3BhY2U8bW9kZT4oKTsKLSAgICB9Ci0KICAgICBzdGF0aWMgRGlyZWN0RXZhbEV4ZWN1dGFi bGUqIGNyZWF0ZShFeGVjU3RhdGUqLCBjb25zdCBTb3VyY2VDb2RlJiwgYm9vbCBpc0luU3RyaWN0 Q29udGV4dCwgRGVyaXZlZENvbnRleHRUeXBlLCBib29sIGlzQXJyb3dGdW5jdGlvbkNvbnRleHQs IEV2YWxDb250ZXh0VHlwZSwgY29uc3QgVmFyaWFibGVFbnZpcm9ubWVudCopOwogcHJpdmF0ZToK ICAgICBEaXJlY3RFdmFsRXhlY3V0YWJsZShFeGVjU3RhdGUqLCBjb25zdCBTb3VyY2VDb2RlJiwg Ym9vbCBpblN0cmljdENvbnRleHQsIERlcml2ZWRDb250ZXh0VHlwZSwgYm9vbCBpc0Fycm93RnVu Y3Rpb25Db250ZXh0LCBFdmFsQ29udGV4dFR5cGUpOwogfTsKIAorc3RhdGljX2Fzc2VydChzaXpl b2YoRGlyZWN0RXZhbEV4ZWN1dGFibGUpID09IHNpemVvZihFdmFsRXhlY3V0YWJsZSksICIiKTsK KwogfSAvLyBuYW1lc3BhY2UgSlNDCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9FdmFsRXhlY3V0YWJsZS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv RXZhbEV4ZWN1dGFibGUuaAppbmRleCBiODM0YTdjOTgxZWZlNzk4YzY5YzlmYmFkYzQ3NGQzODRm NzUyMTY3Li5mOThiNjQ0YTdhMTI5ZGYxZDljOTUxY2M1ZjdlMzJiMTBjMTU3N2RiIDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FdmFsRXhlY3V0YWJsZS5oCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V2YWxFeGVjdXRhYmxlLmgKQEAgLTU0LDYg KzU0LDEyIEBAIGNsYXNzIEV2YWxFeGVjdXRhYmxlIDogcHVibGljIFNjcmlwdEV4ZWN1dGFibGUg ewogICAgICAgICByZXR1cm4gU3RydWN0dXJlOjpjcmVhdGUodm0sIGdsb2JhbE9iamVjdCwgcHJv dG8sIFR5cGVJbmZvKEV2YWxFeGVjdXRhYmxlVHlwZSwgU3RydWN0dXJlRmxhZ3MpLCBpbmZvKCkp OwogICAgIH0KIAorICAgIHRlbXBsYXRlPHR5cGVuYW1lIENlbGxUeXBlLCBTdWJzcGFjZUFjY2Vz cyBtb2RlPgorICAgIHN0YXRpYyBJc29TdWJzcGFjZSogc3Vic3BhY2VGb3IoVk0mIHZtKQorICAg IHsKKyAgICAgICAgcmV0dXJuIHZtLmV2YWxFeGVjdXRhYmxlU3BhY2U8bW9kZT4oKTsKKyAgICB9 CisKICAgICBERUNMQVJFX0lORk87CiAKICAgICBFeGVjdXRhYmxlSW5mbyBleGVjdXRhYmxlSW5m bygpIGNvbnN0IHsgcmV0dXJuIEV4ZWN1dGFibGVJbmZvKHVzZXNFdmFsKCksIGlzU3RyaWN0TW9k ZSgpLCBmYWxzZSwgZmFsc2UsIENvbnN0cnVjdG9yS2luZDo6Tm9uZSwgSlNQYXJzZXJTY3JpcHRN b2RlOjpDbGFzc2ljLCBTdXBlckJpbmRpbmc6Ok5vdE5lZWRlZCwgU291cmNlUGFyc2VNb2RlOjpQ cm9ncmFtTW9kZSwgZGVyaXZlZENvbnRleHRUeXBlKCksIGlzQXJyb3dGdW5jdGlvbkNvbnRleHQo KSwgZmFsc2UsIGV2YWxDb250ZXh0VHlwZSgpKTsgfQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSW5kaXJlY3RFdmFsRXhlY3V0YWJsZS5oIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSW5kaXJlY3RFdmFsRXhlY3V0YWJsZS5oCmluZGV4IDUxMWI0NDdl YzliOTgyZjIwMmJlY2EzYmJjNTA5MjI4OGY2NmFlNjYuLjFlZGUxYThjZGU5OWUxZmM3NWJlYzFm NTgwMzVjYTFjZDVhNWYzZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0luZGlyZWN0RXZhbEV4ZWN1dGFibGUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9JbmRpcmVjdEV2YWxFeGVjdXRhYmxlLmgKQEAgLTMxLDE1ICszMSwxMSBAQCBuYW1l c3BhY2UgSlNDIHsKIAogY2xhc3MgSW5kaXJlY3RFdmFsRXhlY3V0YWJsZSBmaW5hbCA6IHB1Ymxp YyBFdmFsRXhlY3V0YWJsZSB7CiBwdWJsaWM6Ci0gICAgdGVtcGxhdGU8dHlwZW5hbWUgQ2VsbFR5 cGUsIFN1YnNwYWNlQWNjZXNzIG1vZGU+Ci0gICAgc3RhdGljIElzb1N1YnNwYWNlKiBzdWJzcGFj ZUZvcihWTSYgdm0pCi0gICAgewotICAgICAgICByZXR1cm4gdm0uaW5kaXJlY3RFdmFsRXhlY3V0 YWJsZVNwYWNlPG1vZGU+KCk7Ci0gICAgfQotCiAgICAgc3RhdGljIEluZGlyZWN0RXZhbEV4ZWN1 dGFibGUqIGNyZWF0ZShFeGVjU3RhdGUqLCBjb25zdCBTb3VyY2VDb2RlJiwgYm9vbCBpc0luU3Ry aWN0Q29udGV4dCwgRGVyaXZlZENvbnRleHRUeXBlLCBib29sIGlzQXJyb3dGdW5jdGlvbkNvbnRl eHQsIEV2YWxDb250ZXh0VHlwZSk7CiBwcml2YXRlOgogICAgIEluZGlyZWN0RXZhbEV4ZWN1dGFi bGUoRXhlY1N0YXRlKiwgY29uc3QgU291cmNlQ29kZSYsIGJvb2wgaW5TdHJpY3RDb250ZXh0LCBE ZXJpdmVkQ29udGV4dFR5cGUsIGJvb2wgaXNBcnJvd0Z1bmN0aW9uQ29udGV4dCwgRXZhbENvbnRl eHRUeXBlKTsKIH07CiAKK3N0YXRpY19hc3NlcnQoc2l6ZW9mKEluZGlyZWN0RXZhbEV4ZWN1dGFi bGUpID09IHNpemVvZihFdmFsRXhlY3V0YWJsZSksICIiKTsKKwogfSAvLyBuYW1lc3BhY2UgSlND CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5jcHAgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5jcHAKaW5kZXggNGVmN2JhYWI1YzUxYzg4NTRi YTk1YTA4NjI3ZGRiZjk2NGJiZjI1Yy4uYjllZGVjYzJmYWFhMDFjMGJhMTYwNTdiZWUwMzk4ZDNj YzE3ZmE4NCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uY3Bw CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcApAQCAtMTI1OSw4ICsx MjU5LDcgQEAgRFlOQU1JQ19JU09fU1VCU1BBQ0VfREVGSU5FX01FTUJFUl9TTE9XKHdlYkFzc2Vt Ymx5V3JhcHBlckZ1bmN0aW9uU3BhY2UsIGNlbGxIZWEKICAgICB9CiAKIERZTkFNSUNfU1BBQ0Vf QU5EX1NFVF9ERUZJTkVfTUVNQkVSX1NMT1coaW5mZXJyZWRWYWx1ZVNwYWNlLCBkZXN0cnVjdGli bGVDZWxsSGVhcENlbGxUeXBlLmdldCgpLCBJbmZlcnJlZFZhbHVlKQotRFlOQU1JQ19TUEFDRV9B TkRfU0VUX0RFRklORV9NRU1CRVJfU0xPVyhkaXJlY3RFdmFsRXhlY3V0YWJsZVNwYWNlLCBkZXN0 cnVjdGlibGVDZWxsSGVhcENlbGxUeXBlLmdldCgpLCBEaXJlY3RFdmFsRXhlY3V0YWJsZSkKLURZ TkFNSUNfU1BBQ0VfQU5EX1NFVF9ERUZJTkVfTUVNQkVSX1NMT1coaW5kaXJlY3RFdmFsRXhlY3V0 YWJsZVNwYWNlLCBkZXN0cnVjdGlibGVDZWxsSGVhcENlbGxUeXBlLmdldCgpLCBJbmRpcmVjdEV2 YWxFeGVjdXRhYmxlKQorRFlOQU1JQ19TUEFDRV9BTkRfU0VUX0RFRklORV9NRU1CRVJfU0xPVyhl dmFsRXhlY3V0YWJsZVNwYWNlLCBkZXN0cnVjdGlibGVDZWxsSGVhcENlbGxUeXBlLmdldCgpLCBF dmFsRXhlY3V0YWJsZSkKIERZTkFNSUNfU1BBQ0VfQU5EX1NFVF9ERUZJTkVfTUVNQkVSX1NMT1co bW9kdWxlUHJvZ3JhbUV4ZWN1dGFibGVTcGFjZSwgZGVzdHJ1Y3RpYmxlQ2VsbEhlYXBDZWxsVHlw ZS5nZXQoKSwgTW9kdWxlUHJvZ3JhbUV4ZWN1dGFibGUpCiAKICN1bmRlZiBEWU5BTUlDX1NQQUNF X0FORF9TRVRfREVGSU5FX01FTUJFUl9TTE9XCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9WTS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uaApp bmRleCAyZWE4MjA3OGEwMWY2ZDRmZmRmMzZjYjg3NGE3MWUzZmMwNTcxZmFhLi5hZTg4ZWM4Y2Uz NDBiYjY5ZWZiMjkwYjI5ZDEyZWY3MjBiMjdhZWE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9WTS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L1ZNLmgKQEAgLTQ1NSw4ICs0NTUsNyBAQCBjbGFzcyBWTSA6IHB1YmxpYyBUaHJlYWRTYWZlUmVm Q291bnRlZDxWTT4sIHB1YmxpYyBEb3VibHlMaW5rZWRMaXN0Tm9kZTxWTT4gewogICAgICAgICBm dW5jKGNvZGVCbG9ja1NwYWNlKTsKICAgICB9CiAKLSAgICBEWU5BTUlDX1NQQUNFX0FORF9TRVRf REVGSU5FX01FTUJFUihkaXJlY3RFdmFsRXhlY3V0YWJsZVNwYWNlKQotICAgIERZTkFNSUNfU1BB Q0VfQU5EX1NFVF9ERUZJTkVfTUVNQkVSKGluZGlyZWN0RXZhbEV4ZWN1dGFibGVTcGFjZSkKKyAg ICBEWU5BTUlDX1NQQUNFX0FORF9TRVRfREVGSU5FX01FTUJFUihldmFsRXhlY3V0YWJsZVNwYWNl KQogICAgIERZTkFNSUNfU1BBQ0VfQU5EX1NFVF9ERUZJTkVfTUVNQkVSKG1vZHVsZVByb2dyYW1F eGVjdXRhYmxlU3BhY2UpCiAgICAgU3BhY2VBbmRTZXQgZnVuY3Rpb25FeGVjdXRhYmxlU3BhY2U7 CiAgICAgU3BhY2VBbmRTZXQgcHJvZ3JhbUV4ZWN1dGFibGVTcGFjZTsKQEAgLTQ2NCwxMSArNDYz LDkgQEAgY2xhc3MgVk0gOiBwdWJsaWMgVGhyZWFkU2FmZVJlZkNvdW50ZWQ8Vk0+LCBwdWJsaWMg RG91Ymx5TGlua2VkTGlzdE5vZGU8Vk0+IHsKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBGdW5jPgog ICAgIHZvaWQgZm9yRWFjaFNjcmlwdEV4ZWN1dGFibGVTcGFjZShjb25zdCBGdW5jJiBmdW5jKQog ICAgIHsKLSAgICAgICAgaWYgKG1fZGlyZWN0RXZhbEV4ZWN1dGFibGVTcGFjZSkKLSAgICAgICAg ICAgIGZ1bmMoKm1fZGlyZWN0RXZhbEV4ZWN1dGFibGVTcGFjZSk7CisgICAgICAgIGlmIChtX2V2 YWxFeGVjdXRhYmxlU3BhY2UpCisgICAgICAgICAgICBmdW5jKCptX2V2YWxFeGVjdXRhYmxlU3Bh Y2UpOwogICAgICAgICBmdW5jKGZ1bmN0aW9uRXhlY3V0YWJsZVNwYWNlKTsKLSAgICAgICAgaWYg KG1faW5kaXJlY3RFdmFsRXhlY3V0YWJsZVNwYWNlKQotICAgICAgICAgICAgZnVuYygqbV9pbmRp cmVjdEV2YWxFeGVjdXRhYmxlU3BhY2UpOwogICAgICAgICBpZiAobV9tb2R1bGVQcm9ncmFtRXhl Y3V0YWJsZVNwYWNlKQogICAgICAgICAgICAgZnVuYygqbV9tb2R1bGVQcm9ncmFtRXhlY3V0YWJs ZVNwYWNlKTsKICAgICAgICAgZnVuYyhwcm9ncmFtRXhlY3V0YWJsZVNwYWNlKTsK