194324 2019-02-05 18:51:08 -0800 Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting 2019-02-05 20:27:01 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh aestes bdakin commit-queue lforschler thorton webkit-bug-importer oldest_to_newest 1502653 0 wenson_hsieh 2019-02-05 18:51:08 -0800 The fact that it's a member of TestOptions makes the -ForTesting suffix unnecessary. 1502656 1 361265 wenson_hsieh 2019-02-05 18:53:49 -0800 Created attachment 361265 Patch 1502671 2 361265 wenson_hsieh 2019-02-05 20:02:18 -0800 Comment on attachment 361265 Patch Thanks for the review! 1502672 3 361265 commit-queue 2019-02-05 20:26:59 -0800 Comment on attachment 361265 Patch Clearing flags on attachment: 361265 Committed r241009: <https://trac.webkit.org/changeset/241009> 1502673 4 commit-queue 2019-02-05 20:27:01 -0800 All reviewed patches have been landed. Closing bug. 361265 2019-02-05 18:53:49 -0800 2019-02-05 20:26:59 -0800 Patch bug-194324-20190205185349.patch text/plain 5378 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMDA1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWU3MmJlNWI1OTViNGEyZjY2M2ViNGM3YWNiMzQ4NWMy NDkyMTM4YS4uNTk4MTRiYTI4ODRhMDg2ZTU4MWQ3NGUwNTEwYjFmNzQ0NTlkMTQxZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE5LTAyLTA1ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor CisgICAgICAgIFJlbmFtZSBUZXN0T3B0aW9ucy5pZ25vcmVTeW5jaHJvbm91c01lc3NhZ2luZ1Rp bWVvdXRzRm9yVGVzdGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk0MzI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUmVuYW1lIGlnbm9yZVN5bmNocm9ub3VzTWVzc2FnaW5nVGltZW91dHNGb3JUZXN0 aW5nIHRvIGp1c3QgaWdub3JlU3luY2hyb25vdXNNZXNzYWdpbmdUaW1lb3V0cy4gVGhlIC1Gb3JU ZXN0aW5nCisgICAgICAgIHBhcnQgb2YgdGhlIG5hbWUgaXMgYWxyZWFkeSBpbXBsaWNpdCwgc2lu Y2UgdGhpcyBpcyBpbiB0ZXN0aW5nIGNvZGUgaW4gVGVzdE9wdGlvbnMuCisKKyAgICAgICAgKiBX ZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdUUjo6VGVzdENv bnRyb2xsZXI6OmdlbmVyYXRlQ29udGV4dENvbmZpZ3VyYXRpb24gY29uc3QpOgorICAgICAgICAo V1RSOjp1cGRhdGVUZXN0T3B0aW9uc0Zyb21UZXN0SGVhZGVyKToKKyAgICAgICAgKiBXZWJLaXRU ZXN0UnVubmVyL1Rlc3RPcHRpb25zLmg6CisgICAgICAgIChXVFI6OlRlc3RPcHRpb25zOjpoYXNT YW1lSW5pdGlhbGl6YXRpb25PcHRpb25zIGNvbnN0KToKKwogMjAxOS0wMi0wNSAgQWFrYXNoIEph aW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2V3cy1idWlsZF0gQWxsb3cg KiBhcyBwbGF0Zm9ybSBmb3IgYnVpbGRlcnMgYW5kIHdvcmtlcnMKZGlmZiAtLWdpdCBhL1Rvb2xz L1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1 bm5lci9UZXN0Q29udHJvbGxlci5jcHAKaW5kZXggMTcyZTgwOWM0MjIyZGY4OGNhMjFiNzcwZWU5 YjJhYmZhNmYzN2JjZC4uNGNjNGNjY2MwZjAyMzg3NmRlNGEwMGRhYjM2N2VjOGM2ODFhYzI5YiAx MDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKKysr IGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKQEAgLTQ1OCw3ICs0 NTgsNyBAQCBXS1JldGFpblB0cjxXS0NvbnRleHRDb25maWd1cmF0aW9uUmVmPiBUZXN0Q29udHJv bGxlcjo6Z2VuZXJhdGVDb250ZXh0Q29uZmlndXJhdAogICAgIGF1dG8gY29uZmlndXJhdGlvbiA9 IGFkb3B0V0soV0tDb250ZXh0Q29uZmlndXJhdGlvbkNyZWF0ZSgpKTsKICAgICBXS0NvbnRleHRD b25maWd1cmF0aW9uU2V0SW5qZWN0ZWRCdW5kbGVQYXRoKGNvbmZpZ3VyYXRpb24uZ2V0KCksIGlu amVjdGVkQnVuZGxlUGF0aCgpKTsKICAgICBXS0NvbnRleHRDb25maWd1cmF0aW9uU2V0RnVsbHlT eW5jaHJvbm91c01vZGVJc0FsbG93ZWRGb3JUZXN0aW5nKGNvbmZpZ3VyYXRpb24uZ2V0KCksIHRy dWUpOwotICAgIFdLQ29udGV4dENvbmZpZ3VyYXRpb25TZXRJZ25vcmVTeW5jaHJvbm91c01lc3Nh Z2luZ1RpbWVvdXRzRm9yVGVzdGluZyhjb25maWd1cmF0aW9uLmdldCgpLCBvcHRpb25zLmlnbm9y ZVN5bmNocm9ub3VzTWVzc2FnaW5nVGltZW91dHNGb3JUZXN0aW5nKTsKKyAgICBXS0NvbnRleHRD b25maWd1cmF0aW9uU2V0SWdub3JlU3luY2hyb25vdXNNZXNzYWdpbmdUaW1lb3V0c0ZvclRlc3Rp bmcoY29uZmlndXJhdGlvbi5nZXQoKSwgb3B0aW9ucy5pZ25vcmVTeW5jaHJvbm91c01lc3NhZ2lu Z1RpbWVvdXRzKTsKIAogICAgIGlmIChjb25zdCBjaGFyKiBkdW1wUmVuZGVyVHJlZVRlbXAgPSBs aWJyYXJ5UGF0aEZvclRlc3RpbmcoKSkgewogICAgICAgICBTdHJpbmcgdGVtcG9yYXJ5Rm9sZGVy ID0gU3RyaW5nOjpmcm9tVVRGOChkdW1wUmVuZGVyVHJlZVRlbXApOwpAQCAtMTI4Niw4ICsxMjg2 LDggQEAgc3RhdGljIHZvaWQgdXBkYXRlVGVzdE9wdGlvbnNGcm9tVGVzdEhlYWRlcihUZXN0T3B0 aW9ucyYgdGVzdE9wdGlvbnMsIGNvbnN0IHN0ZDoKICAgICAgICAgICAgIHRlc3RPcHRpb25zLmVu YWJsZVVuZG9NYW5hZ2VyQVBJID0gcGFyc2VCb29sZWFuVGVzdEhlYWRlclZhbHVlKHZhbHVlKTsK ICAgICAgICAgZWxzZSBpZiAoa2V5ID09ICJjb250ZW50SW5zZXQudG9wIikKICAgICAgICAgICAg IHRlc3RPcHRpb25zLmNvbnRlbnRJbnNldFRvcCA9IHN0ZDo6c3RvZCh2YWx1ZSk7Ci0gICAgICAg IGVsc2UgaWYgKGtleSA9PSAiaWdub3JlU3luY2hyb25vdXNNZXNzYWdpbmdUaW1lb3V0c0ZvclRl c3RpbmciKQotICAgICAgICAgICAgdGVzdE9wdGlvbnMuaWdub3JlU3luY2hyb25vdXNNZXNzYWdp bmdUaW1lb3V0c0ZvclRlc3RpbmcgPSBwYXJzZUJvb2xlYW5UZXN0SGVhZGVyVmFsdWUodmFsdWUp OworICAgICAgICBlbHNlIGlmIChrZXkgPT0gImlnbm9yZVN5bmNocm9ub3VzTWVzc2FnaW5nVGlt ZW91dHMiKQorICAgICAgICAgICAgdGVzdE9wdGlvbnMuaWdub3JlU3luY2hyb25vdXNNZXNzYWdp bmdUaW1lb3V0cyA9IHBhcnNlQm9vbGVhblRlc3RIZWFkZXJWYWx1ZSh2YWx1ZSk7CiAgICAgICAg IHBhaXJTdGFydCA9IHBhaXJFbmQgKyAxOwogICAgIH0KIH0KZGlmZiAtLWdpdCBhL1Rvb2xzL1dl YktpdFRlc3RSdW5uZXIvVGVzdE9wdGlvbnMuaCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVz dE9wdGlvbnMuaAppbmRleCBmOTFkZDUwYzlkMjA2YjAzZDNmMzgwYjc1YTgxZDA5NTIzZWVmY2Jj Li4wYWM1ODZlYjFlYWJlNWUxOTAxY2FkNjM4YjY0ODMyOGE3NGVhODgyIDEwMDY0NAotLS0gYS9U b29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RPcHRpb25zLmgKKysrIGIvVG9vbHMvV2ViS2l0VGVz dFJ1bm5lci9UZXN0T3B0aW9ucy5oCkBAIC02OCw3ICs2OCw3IEBAIHN0cnVjdCBUZXN0T3B0aW9u cyB7CiAgICAgYm9vbCBlbmFibGVFZGl0YWJsZUltYWdlcyB7IGZhbHNlIH07CiAgICAgYm9vbCBl ZGl0YWJsZSB7IGZhbHNlIH07CiAgICAgYm9vbCBlbmFibGVVbmRvTWFuYWdlckFQSSB7IGZhbHNl IH07Ci0gICAgYm9vbCBpZ25vcmVTeW5jaHJvbm91c01lc3NhZ2luZ1RpbWVvdXRzRm9yVGVzdGlu ZyB7IGZhbHNlIH07CisgICAgYm9vbCBpZ25vcmVTeW5jaHJvbm91c01lc3NhZ2luZ1RpbWVvdXRz IHsgZmFsc2UgfTsKIAogICAgIGRvdWJsZSBjb250ZW50SW5zZXRUb3AgeyAwIH07CiAKQEAgLTEx OCw3ICsxMTgsNyBAQCBzdHJ1Y3QgVGVzdE9wdGlvbnMgewogICAgICAgICAgICAgfHwgZWRpdGFi bGUgIT0gb3B0aW9ucy5lZGl0YWJsZQogICAgICAgICAgICAgfHwgZW5hYmxlVW5kb01hbmFnZXJB UEkgIT0gb3B0aW9ucy5lbmFibGVVbmRvTWFuYWdlckFQSQogICAgICAgICAgICAgfHwgY29udGVu dEluc2V0VG9wICE9IG9wdGlvbnMuY29udGVudEluc2V0VG9wCi0gICAgICAgICAgICB8fCBpZ25v cmVTeW5jaHJvbm91c01lc3NhZ2luZ1RpbWVvdXRzRm9yVGVzdGluZyAhPSBvcHRpb25zLmlnbm9y ZVN5bmNocm9ub3VzTWVzc2FnaW5nVGltZW91dHNGb3JUZXN0aW5nKQorICAgICAgICAgICAgfHwg aWdub3JlU3luY2hyb25vdXNNZXNzYWdpbmdUaW1lb3V0cyAhPSBvcHRpb25zLmlnbm9yZVN5bmNo cm9ub3VzTWVzc2FnaW5nVGltZW91dHMpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAg ICAgICAgaWYgKGV4cGVyaW1lbnRhbEZlYXR1cmVzICE9IG9wdGlvbnMuZXhwZXJpbWVudGFsRmVh dHVyZXMpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKaW5kZXggNzQ5MDhhN2ZhMDY1NjdiNWJkOGU1ZGMyYzYyZTJhY2E4MDE0NTViNC4u ZmNlYjJhZmVlOTdmMTlhOWEzMDJmN2QxOTkwNzg3NThkY2U5MGZlZiAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEyIEBACisyMDE5LTAyLTA1ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29t PgorCisgICAgICAgIFJlbmFtZSBUZXN0T3B0aW9ucy5pZ25vcmVTeW5jaHJvbm91c01lc3NhZ2lu Z1RpbWVvdXRzRm9yVGVzdGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTk0MzI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBmYXN0L2V2ZW50cy90b3VjaC9pb3Mvc2hvdy1tb2RhbC1hbGVydC1kdXJp bmctdG91Y2gtc3RhcnQuaHRtbDoKKwogMjAxOS0wMi0wNSAgTmlraXRhIFZhc2lseWV2ICA8bnZh c2lseWV2QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBGaXggbW9kaWZ5LWNz cy1wcm9wZXJ0eS1yYWNlLmh0bWwgdGVzdCBmYWlsdXJlcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmFzdC9ldmVudHMvdG91Y2gvaW9zL3Nob3ctbW9kYWwtYWxlcnQtZHVyaW5nLXRvdWNoLXN0 YXJ0Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90b3VjaC9pb3Mvc2hvdy1tb2RhbC1h bGVydC1kdXJpbmctdG91Y2gtc3RhcnQuaHRtbAppbmRleCA5YjNhYmMwNGI1MjUwZDQyYmM2NDli Nzg3ZDljYTFlMjNlMmZhZGZkLi4wMDMyODE3NGRlMmY4NWYzZWZkNjQxMTQxNWRiOGYyYThmOGZi YWFiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90b3VjaC9pb3Mvc2hvdy1t b2RhbC1hbGVydC1kdXJpbmctdG91Y2gtc3RhcnQuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0 L2V2ZW50cy90b3VjaC9pb3Mvc2hvdy1tb2RhbC1hbGVydC1kdXJpbmctdG91Y2gtc3RhcnQuaHRt bApAQCAtMSw0ICsxLDQgQEAKLTwhRE9DVFlQRSBodG1sPiA8IS0tIHdlYmtpdC10ZXN0LXJ1bm5l ciBbIHVzZUZsZXhpYmxlVmlld3BvcnQ9dHJ1ZSwgaWdub3JlU3luY2hyb25vdXNNZXNzYWdpbmdU aW1lb3V0c0ZvclRlc3Rpbmc9dHJ1ZSBdIC0tPgorPCFET0NUWVBFIGh0bWw+IDwhLS0gd2Via2l0 LXRlc3QtcnVubmVyIFsgdXNlRmxleGlibGVWaWV3cG9ydD10cnVlLCBpZ25vcmVTeW5jaHJvbm91 c01lc3NhZ2luZ1RpbWVvdXRzPXRydWUgXSAtLT4KIDxodG1sPgogPGhlYWQ+CiA8bWV0YSBuYW1l PSJ2aWV3cG9ydCIgY29udGVudD0id2lkdGg9ZGV2aWNlLXdpZHRoLCBpbml0aWFsLXNjYWxlPTEs IHVzZXItc2NhbGFibGU9bm8iPgo=