194307 2019-02-05 15:02:03 -0800 Fix DFG's doesGC() for a few more nodes. 2019-04-03 16:11:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam bfulgham fpizlo keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1502529 0 mark.lam 2019-02-05 15:02:03 -0800 Specifically, NumberToStringWithValidRadixConstant, RegExpExecNonGlobalOrSticky, RegExpMatchFast, RegExpMatchFastGlobal, and StringFromCharCode. 1502533 1 webkit-bug-importer 2019-02-05 15:06:35 -0800 <rdar://problem/47832956> 1502535 2 361225 mark.lam 2019-02-05 15:14:13 -0800 Created attachment 361225 proposed patch. 1502540 3 361225 ysuzuki 2019-02-05 15:20:17 -0800 Comment on attachment 361225 proposed patch. r=me 1502554 4 mark.lam 2019-02-05 15:34:38 -0800 Thanks for the review. Landed in r240998: <http://trac.webkit.org/r240998>. 1524016 5 bfulgham 2019-04-03 16:11:14 -0700 This was also <rdar://problem/49085119> 361225 2019-02-05 15:14:13 -0800 2019-02-05 15:20:17 -0800 proposed patch. bug-194307.patch text/plain 6027 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQwOTk1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQ1IEBA CisyMDE5LTAyLTA1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBG aXggREZHJ3MgZG9lc0dDKCkgZm9yIGEgZmV3IG1vcmUgbm9kZXMuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQzMDcKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzQ3ODMyOTU2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEZpeCBkb2VzR0MoKSBmb3IgdGhlIGZvbGxvd2luZyBub2RlczoKKworICAgICAg ICAgICAgTnVtYmVyVG9TdHJpbmdXaXRoVmFsaWRSYWRpeENvbnN0YW50OgorICAgICAgICAgICAg ICAgIENhbGxzIG9wZXJhdGlvbkludDMyVG9TdHJpbmdXaXRoVmFsaWRSYWRpeCgpLCB3aGljaCBj YWxscyBpbnQzMlRvU3RyaW5nKCksCisgICAgICAgICAgICAgICAgd2hpY2ggY2FuIGFsbG9jYXRl IGEgc3RyaW5nLgorICAgICAgICAgICAgICAgIENhbGxzIG9wZXJhdGlvbkludDUyVG9TdHJpbmdX aXRoVmFsaWRSYWRpeCgpLCB3aGljaCBjYWxscyBpbnQ1MlRvU3RyaW5nKCksCisgICAgICAgICAg ICAgICAgd2hpY2ggY2FuIGFsbG9jYXRlIGEgc3RyaW5nLgorICAgICAgICAgICAgICAgIENhbGxz IG9wZXJhdGlvbkRvdWJsZVRvU3RyaW5nV2l0aFZhbGlkUmFkaXgoKSwgd2hpY2ggY2FsbHMgbnVt YmVyVG9TdHJpbmcoKSwKKyAgICAgICAgICAgICAgICB3aGljaCBjYW4gYWxsb2NhdGUgYSBzdHJp bmcuCisKKyAgICAgICAgICAgIFJlZ0V4cEV4ZWNOb25HbG9iYWxPclN0aWNreTogY2FsbHMgY3Jl YXRlUmVnRXhwTWF0Y2hlc0FycmF5KCkgd2hpY2ggYWxsb2NhdGVzCisgICAgICAgICAgICAgICAg bWVtb3J5IGZvciBhbGwga2luZHMgb2Ygb2JqZWN0cy4KKyAgICAgICAgICAgIFJlZ0V4cE1hdGNo RmFzdDogY2FsbHMgb3BlcmF0aW9uUmVnRXhwTWF0Y2hGYXN0U3RyaW5nKCksIHdoaWNoIGNhbGxz CisgICAgICAgICAgICAgICAgUmVnRXhwT2JqZWN0OjpleGVjSW5saW5lKCkgYW5kIFJlZ0V4cE9i amVjdDo6bWF0Y2hHbG9iYWwoKS4gIEJvdGggb2YKKyAgICAgICAgICAgICAgICB0aGVzZSBhbGxv Y2F0ZXMgbWVtb3J5IGZvciB0aGUgbWF0Y2ggcmVzdWx0LgorICAgICAgICAgICAgUmVnRXhwTWF0 Y2hGYXN0R2xvYmFsOiBjYWxscyBvcGVyYXRpb25SZWdFeHBNYXRjaEZhc3RHbG9iYWxTdHJpbmco KSwgd2hpY2gKKyAgICAgICAgICAgICAgICBjYWxscyBSZWdFeHBPYmplY3QncyBjb2xsZWN0TWF0 Y2hlcygpLCB3aGljaCBhbGxvY2F0ZXMgYW4gYXJyYXkgYW1vbmdzdAorICAgICAgICAgICAgICAg IG90aGVyIG9iamVjdHMuCisKKyAgICAgICAgICAgIFN0cmluZ0Zyb21DaGFyQ29kZToKKyAgICAg ICAgICAgICAgICBJZiB0aGUgdWludDMyIGNvZGUgdG8gY29udmVydCBpcyBncmVhdGVyIHRoYW4g bWF4U2luZ2xlQ2hhcmFjdGVyU3RyaW5nLAorICAgICAgICAgICAgICAgIHdlJ2xsIGNhbGwgb3Bl cmF0aW9uU3RyaW5nRnJvbUNoYXJDb2RlKCksIHdoaWNoIGNhbGxzIGpzU2luZ2xlQ2hhcmFjdGVy U3RyaW5nKCksCisgICAgICAgICAgICAgICAgd2hpY2ggYWxsb2NhdGVzIGEgbmV3IHN0cmluZyBp ZiB0aGUgY29kZSBpcyBncmVhdGVyIHRoYW4gbWF4U2luZ2xlQ2hhcmFjdGVyU3RyaW5nLgorCisg ICAgICAgIEFsc28gZml4IFNwZWN1bGF0aXZlSklUOjpjb21waWxlRnJvbUNoYXJDb2RlKCkgYW5k IEZUTCdzIGNvbXBpbGVTdHJpbmdGcm9tQ2hhckNvZGUoKQorICAgICAgICB0byB1c2UgbWF4U2lu Z2xlQ2hhcmFjdGVyU3RyaW5nIGluc3RlYWQgb2YgYSBsaXRlcmFsIGNvbnN0YW50LgorCisgICAg ICAgICogZGZnL0RGR0RvZXNHQy5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6ZG9lc0dDKToKKyAg ICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlNw ZWN1bGF0aXZlSklUOjpjb21waWxlRnJvbUNoYXJDb2RlKToKKyAgICAgICAgKiBmdGwvRlRMTG93 ZXJERkdUb0IzLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpERkc6Okxvd2VyREZHVG9CMzo6Y29t cGlsZVN0cmluZ0Zyb21DaGFyQ29kZSk6CisKIDIwMTktMDItMDUgIEtlaXRoIFJvbGxpbiAgPGty b2xsaW5AYXBwbGUuY29tPgogCiAgICAgICAgIEVuYWJsZSB0aGUgYXV0b21hdGljIGNoZWNraW5n IGFuZCByZWdlbmVyYXRpb25zIG9mIC54Y2ZpbGVsaXN0cyBkdXJpbmcgYnVpbGRzCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0RvZXNHQy5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdEb2VzR0MuY3BwCShyZXZpc2lvbiAyNDA5OTEpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0RvZXNHQy5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTEyMSw5ICsxMjEsNiBAQCBib29sIGRvZXNHQyhHcmFwaCYgZ3JhcGgsIE5vZGUqIG5vZGUp CiAgICAgY2FzZSBDaGVja05vdEVtcHR5OgogICAgIGNhc2UgQXNzZXJ0Tm90RW1wdHk6CiAgICAg Y2FzZSBDaGVja1N0cmluZ0lkZW50OgotICAgIGNhc2UgUmVnRXhwRXhlY05vbkdsb2JhbE9yU3Rp Y2t5OgotICAgIGNhc2UgUmVnRXhwTWF0Y2hGYXN0OgotICAgIGNhc2UgUmVnRXhwTWF0Y2hGYXN0 R2xvYmFsOgogICAgIGNhc2UgQ29tcGFyZUxlc3M6CiAgICAgY2FzZSBDb21wYXJlTGVzc0VxOgog ICAgIGNhc2UgQ29tcGFyZUdyZWF0ZXI6CkBAIC0xNTAsNyArMTQ3LDYgQEAgYm9vbCBkb2VzR0Mo R3JhcGgmIGdyYXBoLCBOb2RlKiBub2RlKQogICAgIGNhc2UgSXNUeXBlZEFycmF5VmlldzoKICAg ICBjYXNlIFR5cGVPZjoKICAgICBjYXNlIExvZ2ljYWxOb3Q6Ci0gICAgY2FzZSBOdW1iZXJUb1N0 cmluZ1dpdGhWYWxpZFJhZGl4Q29uc3RhbnQ6CiAgICAgY2FzZSBKdW1wOgogICAgIGNhc2UgQnJh bmNoOgogICAgIGNhc2UgU3dpdGNoOgpAQCAtMTY1LDcgKzE2MSw2IEBAIGJvb2wgZG9lc0dDKEdy YXBoJiBncmFwaCwgTm9kZSogbm9kZSkKICAgICBjYXNlIEZvcmNlT1NSRXhpdDoKICAgICBjYXNl IENQVUludHJpbnNpYzoKICAgICBjYXNlIENoZWNrVHJhcHM6Ci0gICAgY2FzZSBTdHJpbmdGcm9t Q2hhckNvZGU6CiAgICAgY2FzZSBOb3JtYWxpemVNYXBLZXk6CiAgICAgY2FzZSBHZXRNYXBCdWNr ZXQ6CiAgICAgY2FzZSBHZXRNYXBCdWNrZXRIZWFkOgpAQCAtMzAxLDYgKzI5Niw3IEBAIGJvb2wg ZG9lc0dDKEdyYXBoJiBncmFwaCwgTm9kZSogbm9kZSkKICAgICBjYXNlIEluc3RhbmNlT2ZDdXN0 b206CiAgICAgY2FzZSBMb2FkVmFyYXJnczoKICAgICBjYXNlIE51bWJlclRvU3RyaW5nV2l0aFJh ZGl4OgorICAgIGNhc2UgTnVtYmVyVG9TdHJpbmdXaXRoVmFsaWRSYWRpeENvbnN0YW50OgogICAg IGNhc2UgUHV0QnlJZDoKICAgICBjYXNlIFB1dEJ5SWREaXJlY3Q6CiAgICAgY2FzZSBQdXRCeUlk Rmx1c2g6CkBAIC0zMTYsNiArMzEyLDkgQEAgYm9vbCBkb2VzR0MoR3JhcGgmIGdyYXBoLCBOb2Rl KiBub2RlKQogICAgIGNhc2UgUHV0U3RhY2s6CiAgICAgY2FzZSBQdXRUb0FyZ3VtZW50czoKICAg ICBjYXNlIFJlZ0V4cEV4ZWM6CisgICAgY2FzZSBSZWdFeHBFeGVjTm9uR2xvYmFsT3JTdGlja3k6 CisgICAgY2FzZSBSZWdFeHBNYXRjaEZhc3Q6CisgICAgY2FzZSBSZWdFeHBNYXRjaEZhc3RHbG9i YWw6CiAgICAgY2FzZSBSZWdFeHBUZXN0OgogICAgIGNhc2UgUmVzb2x2ZVNjb3BlOgogICAgIGNh c2UgUmVzb2x2ZVNjb3BlRm9ySG9pc3RpbmdGdW5jRGVjbEluRXZhbDoKQEAgLTQxNyw2ICs0MTYs MTMgQEAgYm9vbCBkb2VzR0MoR3JhcGgmIGdyYXBoLCBOb2RlKiBub2RlKQogICAgICAgICAgICAg cmV0dXJuIGZhbHNlOwogICAgICAgICByZXR1cm4gdHJ1ZTsKIAorICAgIGNhc2UgU3RyaW5nRnJv bUNoYXJDb2RlOgorICAgICAgICAvLyBGSVhNRTogU2hvdWxkIHdlIGNvbnN0YW50IGZvbGQgdGhp cyBjYXNlPworICAgICAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk0MzA4CisgICAgICAgIGlmIChub2RlLT5jaGlsZDEoKS0+aXNJbnQzMkNvbnN0YW50KCkg JiYgKG5vZGUtPmNoaWxkMSgpLT5hc1VJbnQzMigpIDw9IG1heFNpbmdsZUNoYXJhY3RlclN0cmlu ZykpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIHJldHVybiB0cnVlOworCiAg ICAgY2FzZSBMYXN0Tm9kZVR5cGU6CiAgICAgICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVE KCk7CiAgICAgICAgIHJldHVybiB0cnVlOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAJKHJldmlzaW9uIDI0MDk5MSkKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yMjgyLDcgKzIyODIsNyBAQCB2b2lkIFNwZWN1bGF0aXZlSklUOjpjb21waWxlRnJvbUNo YXJDb2RlCiAgICAgR1BSUmVnIHNtYWxsU3RyaW5nc1JlZyA9IHNtYWxsU3RyaW5ncy5ncHIoKTsK IAogICAgIEpJVENvbXBpbGVyOjpKdW1wTGlzdCBzbG93Q2FzZXM7Ci0gICAgc2xvd0Nhc2VzLmFw cGVuZChtX2ppdC5icmFuY2gzMihNYWNyb0Fzc2VtYmxlcjo6QWJvdmVPckVxdWFsLCBwcm9wZXJ0 eVJlZywgVHJ1c3RlZEltbTMyKDB4ZmYpKSk7CisgICAgc2xvd0Nhc2VzLmFwcGVuZChtX2ppdC5i cmFuY2gzMihNYWNyb0Fzc2VtYmxlcjo6QWJvdmVPckVxdWFsLCBwcm9wZXJ0eVJlZywgVHJ1c3Rl ZEltbTMyKG1heFNpbmdsZUNoYXJhY3RlclN0cmluZykpKTsKICAgICBtX2ppdC5tb3ZlKFRydXN0 ZWRJbW1QdHIobV9qaXQudm0oKS0+c21hbGxTdHJpbmdzLnNpbmdsZUNoYXJhY3RlclN0cmluZ3Mo KSksIHNtYWxsU3RyaW5nc1JlZyk7CiAgICAgbV9qaXQubG9hZFB0cihNYWNyb0Fzc2VtYmxlcjo6 QmFzZUluZGV4KHNtYWxsU3RyaW5nc1JlZywgcHJvcGVydHlSZWcsIE1hY3JvQXNzZW1ibGVyOjpT Y2FsZVB0ciwgMCksIHNjcmF0Y2hSZWcpOwogCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZnRsL0ZUTExvd2VyREZHVG9CMy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2Z0bC9GVExMb3dlckRGR1RvQjMuY3BwCShyZXZpc2lvbiAyNDA5OTEpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9CMy5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTY3MDgsNyArNjcwOCw3IEBAIHByaXZhdGU6CiAgICAgICAgIExCYXNpY0Jsb2NrIGNvbnRpbnVh dGlvbiA9IG1fb3V0Lm5ld0Jsb2NrKCk7CiAKICAgICAgICAgbV9vdXQuYnJhbmNoKAotICAgICAg ICAgICAgbV9vdXQuYWJvdmVPckVxdWFsKHZhbHVlLCBtX291dC5jb25zdEludDMyKDB4ZmYpKSwK KyAgICAgICAgICAgIG1fb3V0LmFib3ZlT3JFcXVhbCh2YWx1ZSwgbV9vdXQuY29uc3RJbnQzMiht YXhTaW5nbGVDaGFyYWN0ZXJTdHJpbmcpKSwKICAgICAgICAgICAgIHJhcmVseShzbG93Q2FzZSks IHVzdWFsbHkoc21hbGxJbnRDYXNlKSk7CiAKICAgICAgICAgTEJhc2ljQmxvY2sgbGFzdE5leHQg PSBtX291dC5hcHBlbmRUbyhzbWFsbEludENhc2UsIHNsb3dDYXNlKTsK