194288 2019-02-05 08:45:09 -0800 [GTK][WPE] force libpsl build to use ICU in jhbuild 2019-02-06 05:47:58 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 olivier.blin webkit-unassigned agomez aperez bugs-noreply cgarcia clopez commit-queue ews-watchlist ltilve mcatanzaro pnormand webkit-bug-importer zan oldest_to_newest 1502371 0 olivier.blin 2019-02-05 08:45:09 -0800 In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU. This can cause build failures if libidn is detected but libunistring is not available. Make sure that ICU is used for runtime and builtin PSL data. 1502372 1 361193 olivier.blin 2019-02-05 08:47:44 -0800 Created attachment 361193 Patch 1502465 2 361193 commit-queue 2019-02-05 12:28:53 -0800 Comment on attachment 361193 Patch Clearing flags on attachment: 361193 Committed r240987: <https://trac.webkit.org/changeset/240987> 1502466 3 commit-queue 2019-02-05 12:28:55 -0800 All reviewed patches have been landed. Closing bug. 1502704 4 361193 cgarcia 2019-02-05 23:42:21 -0800 Comment on attachment 361193 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361193&action=review > Tools/gtk/jhbuild.modules:234 > <branch module="rockdaboot/libpsl/releases/download/libpsl-${version}/libpsl-${version}.tar.gz" We should add icu as a dependency here like we do in WPE to ensure it's built before. Could you do it in a follow up patch, please? rs=me 1502750 5 olivier.blin 2019-02-06 05:09:24 -0800 Reopening to attach new patch. 1502751 6 361290 olivier.blin 2019-02-06 05:09:26 -0800 Created attachment 361290 Patch 1502756 7 361290 commit-queue 2019-02-06 05:47:56 -0800 Comment on attachment 361290 Patch Clearing flags on attachment: 361290 Committed r241016: <https://trac.webkit.org/changeset/241016> 1502757 8 commit-queue 2019-02-06 05:47:58 -0800 All reviewed patches have been landed. Closing bug. 361193 2019-02-05 08:47:44 -0800 2019-02-05 12:28:53 -0800 Patch bug-194288-20190205174743.patch text/plain 2126 olivier.blin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwOTY4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWFjZWNhYWVlY2UyY2ZkNTE4OTFlOTBiNzliMTAyYTVl NTU0YmM0Ni4uY2Y4NWNjY2Y4OWI0MTBkODNjMTVlOGMxZjJlZWE1MTdjMmM0ZTM2ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE5LTAyLTA1ICBPbGl2aWVyIEJsaW4gIDxvbGl2aWVyLmJsaW5Ac29mdGF0aG9tZS5j b20+CisKKyAgICAgICAgW0dUS11bV1BFXSBmb3JjZSBsaWJwc2wgYnVpbGQgdG8gdXNlIElDVSBp biBqaGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTQyODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJbiBqaGJ1aWxkLCBsaWJwc2wgZGVwZW5kcyBvbiBJQ1UsIGJ1dCBpdHMgY29uZmlndXJlIHNj cmlwdCBtYXkgZGVjaWRlIHRvIHVzZSBsaWJpZG4gaW5zdGVhZCBvZiBJQ1UuCisgICAgICAgIFRo aXMgY2FuIGNhdXNlIGJ1aWxkIGZhaWx1cmVzIGlmIGxpYmlkbiBpcyBkZXRlY3RlZCBidXQgbGli dW5pc3RyaW5nIGlzIG5vdCBhdmFpbGFibGUuCisKKyAgICAgICAgTWFrZSBzdXJlIHRoYXQgSUNV IGlzIHVzZWQgZm9yIHJ1bnRpbWUgYW5kIGJ1aWx0aW4gUFNMIGRhdGEuCisKKyAgICAgICAgKiBn dGsvamhidWlsZC5tb2R1bGVzOgorICAgICAgICAqIHdwZS9qaGJ1aWxkLm1vZHVsZXM6CisKIDIw MTktMDItMDUgIE9saXZpZXIgQmxpbiAgPG9saXZpZXIuYmxpbkBzb2Z0YXRob21lLmNvbT4KIAog ICAgICAgICBbV1BFXSByZXF1aXJlIHB5dGhvbjMtc2V0dXB0b29scyBmb3IgbWVzb24gYnVpbGQg aW4gamhidWlsZApkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcyBiL1Rvb2xz L2d0ay9qaGJ1aWxkLm1vZHVsZXMKaW5kZXggYTQwZDc1ZmI1MjQxYWNjNDUyZjVmYTRlODIxNDI5 NDAyZTE3ZDlkMi4uOTQ4Y2JmOTFmMjVmMDAzNzkyNjg2NzAxYjZiNzQwM2I4OTRhNDI3MyAxMDA2 NDQKLS0tIGEvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcworKysgYi9Ub29scy9ndGsvamhidWls ZC5tb2R1bGVzCkBAIC0yMjksNyArMjI5LDggQEAKICAgICAgICAgICAgIGhhc2g9InNoYTI1Njpi ZGZhMDI1NWUwMzFiOGVlMDAzY2MyODMwMDI1MzZiNzdlZTc2NDUwMTA1ZjFkYzZhYjA2NmI5YmY0 MzMwMDY4Ii8+CiAgIDwvbWVzb24+CiAKLSAgPGF1dG90b29scyBpZD0ibGlicHNsIj4KKyAgPGF1 dG90b29scyBpZD0ibGlicHNsIgorICAgICAgICAgICAgIGF1dG9nZW5hcmdzPSItLWVuYWJsZS1y dW50aW1lPWxpYmljdSAtLWVuYWJsZS1idWlsdGluPWxpYmljdSI+CiAgICAgPGJyYW5jaCBtb2R1 bGU9InJvY2tkYWJvb3QvbGlicHNsL3JlbGVhc2VzL2Rvd25sb2FkL2xpYnBzbC0ke3ZlcnNpb259 L2xpYnBzbC0ke3ZlcnNpb259LnRhci5neiIKICAgICAgICAgICAgIHZlcnNpb249IjAuMjAuMiIK ICAgICAgICAgICAgIHJlcG89ImdpdGh1Yi10YXJiYWxsIgpkaWZmIC0tZ2l0IGEvVG9vbHMvd3Bl L2poYnVpbGQubW9kdWxlcyBiL1Rvb2xzL3dwZS9qaGJ1aWxkLm1vZHVsZXMKaW5kZXggODIwZGNm YmI1OGVjMzBlN2VmNmJlNjZjNmQwODMxY2E2YzQyYWU1OS4uYTZlNmFkOTBlMjg5NzMxYjViMDZj ODMzNzMzNGIxMmJhZTU2ZjhiYyAxMDA2NDQKLS0tIGEvVG9vbHMvd3BlL2poYnVpbGQubW9kdWxl cworKysgYi9Ub29scy93cGUvamhidWlsZC5tb2R1bGVzCkBAIC05MCw3ICs5MCw4IEBACiAgICAg ICAgICAgICBoYXNoPSJzaGEyNTY6YmRmYTAyNTVlMDMxYjhlZTAwM2NjMjgzMDAyNTM2Yjc3ZWU3 NjQ1MDEwNWYxZGM2YWIwNjZiOWJmNDMzMDA2OCIvPgogICA8L21lc29uPgogCi0gIDxhdXRvdG9v bHMgaWQ9ImxpYnBzbCI+CisgIDxhdXRvdG9vbHMgaWQ9ImxpYnBzbCIKKyAgICAgICAgICAgICBh dXRvZ2VuYXJncz0iLS1lbmFibGUtcnVudGltZT1saWJpY3UgLS1lbmFibGUtYnVpbHRpbj1saWJp Y3UiPgogICAgIDxkZXBlbmRlbmNpZXM+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImljdSIvPgogICAg IDwvZGVwZW5kZW5jaWVzPgo= 361290 2019-02-06 05:09:26 -0800 2019-02-06 05:47:56 -0800 Patch bug-194288-20190206140925.patch text/plain 1258 olivier.blin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwOTY4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2Y4NWNjY2Y4OWI0MTBkODNjMTVlOGMxZjJlZWE1MTdj MmM0ZTM2ZC4uNmNiN2UyZjBhZDk3NTVlOGM2ZWVjNzZhNDRjNTFlZDUzNDllMmZjNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE5LTAyLTA2ICBPbGl2aWVyIEJsaW4gIDxvbGl2aWVyLmJsaW5Ac29mdGF0aG9tZS5j b20+CisKKyAgICAgICAgW0dUS11bV1BFXSBmb3JjZSBsaWJwc2wgYnVpbGQgdG8gdXNlIElDVSBp biBqaGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTQyODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGd0ay9qaGJ1aWxkLm1vZHVsZXM6CisgICAgICAgIFJlcXVpcmUgSUNVIGZvciBsaWJwc2wg YnVpbGQgaW4gamhidWlsZCwgbGlrZSBkb25lIGluIFdQRS4KKwogMjAxOS0wMi0wNSAgT2xpdmll ciBCbGluICA8b2xpdmllci5ibGluQHNvZnRhdGhvbWUuY29tPgogCiAgICAgICAgIFtHVEtdW1dQ RV0gZm9yY2UgbGlicHNsIGJ1aWxkIHRvIHVzZSBJQ1UgaW4gamhidWlsZApkaWZmIC0tZ2l0IGEv VG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcyBiL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKaW5k ZXggOTQ4Y2JmOTFmMjVmMDAzNzkyNjg2NzAxYjZiNzQwM2I4OTRhNDI3My4uMWVjZWJjMzFmMjM3 N2RkODJhMmJiY2ZmNTI2N2FlMWQyYmU4MTQyOSAxMDA2NDQKLS0tIGEvVG9vbHMvZ3RrL2poYnVp bGQubW9kdWxlcworKysgYi9Ub29scy9ndGsvamhidWlsZC5tb2R1bGVzCkBAIC0yMzEsNiArMjMx LDkgQEAKIAogICA8YXV0b3Rvb2xzIGlkPSJsaWJwc2wiCiAgICAgICAgICAgICAgYXV0b2dlbmFy Z3M9Ii0tZW5hYmxlLXJ1bnRpbWU9bGliaWN1IC0tZW5hYmxlLWJ1aWx0aW49bGliaWN1Ij4KKyAg ICA8ZGVwZW5kZW5jaWVzPgorICAgICAgPGRlcCBwYWNrYWdlPSJpY3UiLz4KKyAgICA8L2RlcGVu ZGVuY2llcz4KICAgICA8YnJhbmNoIG1vZHVsZT0icm9ja2RhYm9vdC9saWJwc2wvcmVsZWFzZXMv ZG93bmxvYWQvbGlicHNsLSR7dmVyc2lvbn0vbGlicHNsLSR7dmVyc2lvbn0udGFyLmd6IgogICAg ICAgICAgICAgdmVyc2lvbj0iMC4yMC4yIgogICAgICAgICAgICAgcmVwbz0iZ2l0aHViLXRhcmJh bGwiCg==