194280 2019-02-04 23:11:19 -0800 Web Inspector: Uncaught Exception: undefined is not an object (evaluating 'classes.includes') 2019-02-04 23:48:17 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED file:///Volumes/DATA/Build/Release/WebInspectorUI.framework/Resources/Main.html InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1502275 0 hi 2019-02-04 23:11:19 -0800 ------- Inspected URL: file:///Volumes/DATA/Build/Release/WebInspectorUI.framework/Resources/Main.html Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_4) AppleWebKit/605.1.15 (KHTML, like Gecko) Dispatch Source: Protocol Event Protocol Event: {"method":"DOM.attributeRemoved","params":{"nodeId":342,"name":"class"}} Uncaught Exceptions: - undefined is not an object (evaluating 'classes.includes') (at GeneralStyleDetailsSidebarPanel.js:373:37) _populateClassToggles @ GeneralStyleDetailsSidebarPanel.js:373:37 _handleNodeAttributeRemoved @ GeneralStyleDetailsSidebarPanel.js:309:39 dispatch @ Object.js:165:30 dispatchEventToListeners @ Object.js:172:17 _attributeRemoved @ DOMManager.js:225:38 attributeRemoved @ DOMObserver.js:52:40 dispatchEvent @ InspectorBackend.js:340:42 _dispatchEvent @ Connection.js:195:32 dispatch @ Connection.js:72:32 dispatchMessageFromTarget @ TargetManager.js:101:35 dispatchMessageFromTarget @ TargetObserver.js:42:51 dispatchEvent @ InspectorBackend.js:340:42 _dispatchEvent @ Connection.js:195:32 dispatch @ Connection.js:72:32 dispatch @ InspectorBackend.js:178:52 dispatchNextQueuedMessageFromBackend @ MessageDispatcher.js:42:34 Additional Details: cause --> An uncaught exception was thrown while handling event: DOM.attributeRemoved ------- * STEPS TO REPRODUCE 1. open inspector2 2. right click on the "class" attribute of <body> in the DOM tree 3. select Delete > Attribute 1502276 1 webkit-bug-importer 2019-02-04 23:11:57 -0800 <rdar://problem/47811159> 1502277 2 361162 hi 2019-02-04 23:13:57 -0800 Created attachment 361162 Patch 1502279 3 361162 mattbaker 2019-02-04 23:23:25 -0800 Comment on attachment 361162 Patch rs=me 1502283 4 361162 commit-queue 2019-02-04 23:48:16 -0800 Comment on attachment 361162 Patch Clearing flags on attachment: 361162 Committed r240967: <https://trac.webkit.org/changeset/240967> 1502284 5 commit-queue 2019-02-04 23:48:17 -0800 All reviewed patches have been landed. Closing bug. 361162 2019-02-04 23:13:57 -0800 2019-02-04 23:48:16 -0800 Patch bug-194280-20190204231356.patch text/plain 1953 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDYzMGJlYzRkZmI2YzFlYmE1OTA5YmZmYjUwOWMx MzNlNmJhNWI3MDEuLmVhZDAwYWM2MDhiNTY5MjI3ZTFhZDcxYWEwZmNiNGViMGMwMjMwZDYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAyLTA0ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBV bmNhdWdodCBFeGNlcHRpb246IHVuZGVmaW5lZCBpcyBub3QgYW4gb2JqZWN0IChldmFsdWF0aW5n ICdjbGFzc2VzLmluY2x1ZGVzJykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5NDI4MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDc4MTExNTk+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL1ZpZXdzL0dlbmVyYWxTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwuanM6CisgICAgICAg IChXSS5HZW5lcmFsU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsLnByb3RvdHlwZS5fcG9wdWxhdGVD bGFzc1RvZ2dsZXMpOgorICAgICAgICBBZGQgYSBmYWxsYmFjayB2YWx1ZSBpbiBjYXNlIHRoZSBg Y2xhc3NgIGF0dHJpYnV0ZSBpc24ndCBzcGVjaWZpZWQgZm9yIHRoZSBzZWxlY3RlZCBub2RlLgor CiAyMDE5LTAyLTA0ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBSZXNvdXJjZXM6IG1pc3NpbmcgcmVzb3VyY2UgZGF0YSBmb3IgZG9j dW1lbnQgb24gcmVsb2FkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9HZW5lcmFsU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsLmpzIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvR2VuZXJhbFN0eWxlRGV0YWlsc1Np ZGViYXJQYW5lbC5qcwppbmRleCBjNzNiMGI5MzQwNjMzN2UwYTcxNjIyYmJhYTBjMTM1OTYxZjM1 NDM0Li5kOWIxNjVlMjI0MjlmMmE2YWJjNzBiNDc1NzI4YWE0ZDdjNTc3Y2Q5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9HZW5lcmFsU3R5bGVE ZXRhaWxzU2lkZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL0dlbmVyYWxTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwuanMKQEAgLTM1OSw3 ICszNTksNyBAQCBXSS5HZW5lcmFsU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsID0gY2xhc3MgR2Vu ZXJhbFN0eWxlRGV0YWlsc1NpZGViYXJQYW5lbCBleHRlbgogICAgICAgICB3aGlsZSAodGhpcy5f Y2xhc3NMaXN0Q29udGFpbmVyLmNoaWxkcmVuLmxlbmd0aCA+IDEpCiAgICAgICAgICAgICB0aGlz Ll9jbGFzc0xpc3RDb250YWluZXIuY2hpbGRyZW5bMV0ucmVtb3ZlKCk7CiAKLSAgICAgICAgbGV0 IGNsYXNzZXMgPSB0aGlzLmRvbU5vZGUuZ2V0QXR0cmlidXRlKCJjbGFzcyIpOworICAgICAgICBs ZXQgY2xhc3NlcyA9IHRoaXMuZG9tTm9kZS5nZXRBdHRyaWJ1dGUoImNsYXNzIikgfHwgW107CiAg ICAgICAgIGxldCBjbGFzc1RvZ2dsZWRNYXAgPSB0aGlzLmRvbU5vZGVbV0kuR2VuZXJhbFN0eWxl RGV0YWlsc1NpZGViYXJQYW5lbC5Ub2dnbGVkQ2xhc3Nlc1N5bWJvbF07CiAgICAgICAgIGlmICgh Y2xhc3NUb2dnbGVkTWFwKQogICAgICAgICAgICAgY2xhc3NUb2dnbGVkTWFwID0gdGhpcy5kb21O b2RlW1dJLkdlbmVyYWxTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwuVG9nZ2xlZENsYXNzZXNTeW1i b2xdID0gbmV3IE1hcDsK