194270 2019-02-04 19:26:10 -0800 JITExecutable should not try to mmap executable memory without entitlement 2019-06-16 20:54:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 keith_miller keith_miller ews-watchlist mark.lam msaboff saam oldest_to_newest 1502215 0 keith_miller 2019-02-04 19:26:10 -0800 JITExecutable should not try to mmap executable memory without entitlement 1502216 1 361152 keith_miller 2019-02-04 19:28:56 -0800 Created attachment 361152 Patch 1502223 2 361153 keith_miller 2019-02-04 19:41:21 -0800 Created attachment 361153 Patch 1502224 3 361153 saam 2019-02-04 19:44:34 -0800 Comment on attachment 361153 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361153&action=review r=me > Source/JavaScriptCore/ChangeLog:10 > + We try to use our one time token to map JIT memory if we are not > + going to use the JIT in a process. If we never had the This sentence makes it seem like we only do this if we don't have the entitlement. I think you can make it clearer. 361152 2019-02-04 19:28:56 -0800 2019-02-04 19:41:18 -0800 Patch bug-194270-20190204192854.patch text/plain 2352 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwOTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 ZDcwMjI2YWM1YjNkYjEwODRkZmY1MTk5MGQ2NGZhZTlkOWIyMWI5Li5mZTMxNDgwMjlkMTczNjNi OTI3ODU0NDkwMWU0NzM5NzRhN2YyYmMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOS0wMi0wNCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBKSVRFeGVjdXRhYmxlIHNob3VsZCBub3QgdHJ5IHRvIG1tYXAgZXhl Y3V0YWJsZSBtZW1vcnkgd2l0aG91dCBlbnRpdGxlbWVudAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MjcwCisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS80NzcxNzE1MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBXZSB0cnkgdG8gdXNlIG91ciBvbmUgdGltZSB0b2tlbiB0byBtYXAgSklUIG1lbW9yeSBp ZiB3ZSBhcmUgbm90CisgICAgICAgIGdvaW5nIHRvIHVzZSB0aGUgSklUIGluIGEgcHJvY2Vzcy4g SWYgd2UgbmV2ZXIgaGFkIHRoZQorICAgICAgICBlbnRpdGxlbWVudCwgaG93ZXZlciwgdGhpcyB3 b3VsZCBjYXVzZSB0aGUgcHJvY2VzcyB0byBjcmFzaC4gIFRoaXMKKyAgICAgICAgcGF0Y2ggZml4 ZXMgdGhhdC4KKworICAgICAgICAqIGppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmNwcDoKKyAgICAg ICAgKEpTQzo6aXNKSVRFbmFibGVkKToKKyAgICAgICAgKEpTQzo6RXhlY3V0YWJsZUFsbG9jYXRv cjo6c2V0SklURW5hYmxlZCk6CisKIDIwMTktMDItMDQgIFJvYmluIE1vcmlzc2V0ICA8cm1vcmlz c2V0QGFwcGxlLmNvbT4KIAogICAgICAgICB3aGVuIGxvd2VyaW5nIEFzc2VydE5vdEVtcHR5LCBj cmVhdGUgdGhlIHZhbHVlIGJlZm9yZSBjcmVhdGluZyB0aGUgcGF0Y2hwb2ludApkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5jcHAKaW5kZXggNDYw Njc1NmU4MGM0YjhmNmYwOGM0OGFhNWM3NjlkNWM4OTgyNjI4Yy4uNzdjZmZjNDg5YmU3MzM2ZTAw MWQxOTZmMWZiMjM5MzU1MDc2NmRlMyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuY3BwCkBAIC0xMTcsMTEgKzExNywxMiBAQCBjbGFzcyBG aXhlZFZNUG9vbEV4ZWN1dGFibGVBbGxvY2F0b3I7CiBzdGF0aWMgRml4ZWRWTVBvb2xFeGVjdXRh YmxlQWxsb2NhdG9yKiBhbGxvY2F0b3IgPSBudWxscHRyOwogc3RhdGljIEV4ZWN1dGFibGVBbGxv Y2F0b3IqIGV4ZWN1dGFibGVBbGxvY2F0b3IgPSBudWxscHRyOwogCitzdGF0aWMgY29uc3RleHBy IGNoYXIqIGppdEVudGl0bGVtZW50ID0gImR5bmFtaWMtY29kZXNpZ25pbmciOwogc3RhdGljIGJv b2wgc19pc0pJVEVuYWJsZWQgPSB0cnVlOwogc3RhdGljIGJvb2wgaXNKSVRFbmFibGVkKCkKIHsK ICNpZiBQTEFURk9STShJT1NfRkFNSUxZKSAmJiAoQ1BVKEFSTTY0KSB8fCBDUFUoQVJNKSkKLSAg ICByZXR1cm4gcHJvY2Vzc0hhc0VudGl0bGVtZW50KCJkeW5hbWljLWNvZGVzaWduaW5nIikgJiYg c19pc0pJVEVuYWJsZWQ7CisgICAgcmV0dXJuIHByb2Nlc3NIYXNFbnRpdGxlbWVudChqaXRFbnRp dGxlbWVudCkgJiYgc19pc0pJVEVuYWJsZWQ7CiAjZWxzZQogICAgIHJldHVybiBzX2lzSklURW5h YmxlZDsKICNlbmRpZgpAQCAtMTM3LDYgKzEzOCw5IEBAIHZvaWQgRXhlY3V0YWJsZUFsbG9jYXRv cjo6c2V0SklURW5hYmxlZChib29sIGVuYWJsZWQpCiAKICNpZiBQTEFURk9STShJT1NfRkFNSUxZ KSAmJiAoQ1BVKEFSTTY0KSB8fCBDUFUoQVJNKSkKICAgICBpZiAoIWVuYWJsZWQpIHsKKyAgICAg ICAgaWYgKCFwcm9jZXNzSGFzRW50aXRsZW1lbnQoaml0RW50aXRsZW1lbnQpKQorICAgICAgICAg ICAgcmV0dXJuOworCiAgICAgICAgIGNvbnN0ZXhwciBzaXplX3Qgc2l6ZSA9IDE7CiAgICAgICAg IGNvbnN0ZXhwciBpbnQgcHJvdGVjdGlvbiA9IFBST1RfUkVBRCB8IFBST1RfV1JJVEUgfCBQUk9U X0VYRUM7CiAgICAgICAgIGNvbnN0ZXhwciBpbnQgZmxhZ3MgPSBNQVBfUFJJVkFURSB8IE1BUF9B Tk9OIHwgTUFQX0pJVDsK 361153 2019-02-04 19:41:21 -0800 2019-02-04 19:44:34 -0800 Patch bug-194270-20190204194119.patch text/plain 2348 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwOTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 ZDcwMjI2YWM1YjNkYjEwODRkZmY1MTk5MGQ2NGZhZTlkOWIyMWI5Li5mZTMxNDgwMjlkMTczNjNi OTI3ODU0NDkwMWU0NzM5NzRhN2YyYmMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOS0wMi0wNCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBKSVRFeGVjdXRhYmxlIHNob3VsZCBub3QgdHJ5IHRvIG1tYXAgZXhl Y3V0YWJsZSBtZW1vcnkgd2l0aG91dCBlbnRpdGxlbWVudAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MjcwCisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS80NzcxNzE1MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBXZSB0cnkgdG8gdXNlIG91ciBvbmUgdGltZSB0b2tlbiB0byBtYXAgSklUIG1lbW9yeSBp ZiB3ZSBhcmUgbm90CisgICAgICAgIGdvaW5nIHRvIHVzZSB0aGUgSklUIGluIGEgcHJvY2Vzcy4g SWYgd2UgbmV2ZXIgaGFkIHRoZQorICAgICAgICBlbnRpdGxlbWVudCwgaG93ZXZlciwgdGhpcyB3 b3VsZCBjYXVzZSB0aGUgcHJvY2VzcyB0byBjcmFzaC4gIFRoaXMKKyAgICAgICAgcGF0Y2ggZml4 ZXMgdGhhdC4KKworICAgICAgICAqIGppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmNwcDoKKyAgICAg ICAgKEpTQzo6aXNKSVRFbmFibGVkKToKKyAgICAgICAgKEpTQzo6RXhlY3V0YWJsZUFsbG9jYXRv cjo6c2V0SklURW5hYmxlZCk6CisKIDIwMTktMDItMDQgIFJvYmluIE1vcmlzc2V0ICA8cm1vcmlz c2V0QGFwcGxlLmNvbT4KIAogICAgICAgICB3aGVuIGxvd2VyaW5nIEFzc2VydE5vdEVtcHR5LCBj cmVhdGUgdGhlIHZhbHVlIGJlZm9yZSBjcmVhdGluZyB0aGUgcGF0Y2hwb2ludApkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5jcHAKaW5kZXggNDYw Njc1NmU4MGM0YjhmNmYwOGM0OGFhNWM3NjlkNWM4OTgyNjI4Yy4uNDk4MTI0MmFkNzM4ZGNkYWE4 ODdkOWUwMzBkNjQ1OTMzYTI4ZDc3ZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuY3BwCkBAIC0xMTcsMTEgKzExNywxMiBAQCBjbGFzcyBG aXhlZFZNUG9vbEV4ZWN1dGFibGVBbGxvY2F0b3I7CiBzdGF0aWMgRml4ZWRWTVBvb2xFeGVjdXRh YmxlQWxsb2NhdG9yKiBhbGxvY2F0b3IgPSBudWxscHRyOwogc3RhdGljIEV4ZWN1dGFibGVBbGxv Y2F0b3IqIGV4ZWN1dGFibGVBbGxvY2F0b3IgPSBudWxscHRyOwogCitzdGF0aWMgY29uc3QgY2hh ciogaml0RW50aXRsZW1lbnQgPSAiZHluYW1pYy1jb2Rlc2lnbmluZyI7CiBzdGF0aWMgYm9vbCBz X2lzSklURW5hYmxlZCA9IHRydWU7CiBzdGF0aWMgYm9vbCBpc0pJVEVuYWJsZWQoKQogewogI2lm IFBMQVRGT1JNKElPU19GQU1JTFkpICYmIChDUFUoQVJNNjQpIHx8IENQVShBUk0pKQotICAgIHJl dHVybiBwcm9jZXNzSGFzRW50aXRsZW1lbnQoImR5bmFtaWMtY29kZXNpZ25pbmciKSAmJiBzX2lz SklURW5hYmxlZDsKKyAgICByZXR1cm4gcHJvY2Vzc0hhc0VudGl0bGVtZW50KGppdEVudGl0bGVt ZW50KSAmJiBzX2lzSklURW5hYmxlZDsKICNlbHNlCiAgICAgcmV0dXJuIHNfaXNKSVRFbmFibGVk OwogI2VuZGlmCkBAIC0xMzcsNiArMTM4LDkgQEAgdm9pZCBFeGVjdXRhYmxlQWxsb2NhdG9yOjpz ZXRKSVRFbmFibGVkKGJvb2wgZW5hYmxlZCkKIAogI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpICYm IChDUFUoQVJNNjQpIHx8IENQVShBUk0pKQogICAgIGlmICghZW5hYmxlZCkgeworICAgICAgICBp ZiAoIXByb2Nlc3NIYXNFbnRpdGxlbWVudChqaXRFbnRpdGxlbWVudCkpCisgICAgICAgICAgICBy ZXR1cm47CisKICAgICAgICAgY29uc3RleHByIHNpemVfdCBzaXplID0gMTsKICAgICAgICAgY29u c3RleHByIGludCBwcm90ZWN0aW9uID0gUFJPVF9SRUFEIHwgUFJPVF9XUklURSB8IFBST1RfRVhF QzsKICAgICAgICAgY29uc3RleHByIGludCBmbGFncyA9IE1BUF9QUklWQVRFIHwgTUFQX0FOT04g fCBNQVBfSklUOwo=