194265 2019-02-04 18:16:27 -0800 vp8e_mr_alloc_mem() leaks LOWER_RES_FRAME_INFO if second memory allocation fails 2019-02-05 09:32:29 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.chromium.org/p/webrtc/issues/detail?id=10289 https://bugs.chromium.org/p/webm/issues/detail?id=1596 InRadar P2 Normal --- 1 ddkilzer ddkilzer commit-queue eric.carlson webkit-bug-importer youennf oldest_to_newest 1502188 0 ddkilzer 2019-02-04 18:16:27 -0800 vp8e_mr_alloc_mem() leaks LOWER_RES_FRAME_INFO if second memory allocation fails via clang static analyzer: Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp8/vp8_cx_iface.c:589:5: warning: Value stored to 'res' is never read res = VPX_CODEC_MEM_ERROR; ^ ~~~~~~~~~~~~~~~~~~~ Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp8/vp8_cx_iface.c:592:27: warning: Access to field 'mb_info' results in a dereference of a null pointer (loaded from variable 'shared_mem_loc') shared_mem_loc->mb_info = ~~~~~~~~~~~~~~ ^ Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp8/vp8_cx_iface.c:595:11: warning: Potential leak of memory pointed to by 'shared_mem_loc' res = VPX_CODEC_MEM_ERROR; ^~~~~~~~~~~~~~~~~~~ 3 warnings generated. 1502194 1 361148 ddkilzer 2019-02-04 18:25:25 -0800 Created attachment 361148 Patch v1 1502201 2 webkit-bug-importer 2019-02-04 18:41:27 -0800 <rdar://problem/47808154> 1502213 3 361148 commit-queue 2019-02-04 19:25:00 -0800 Comment on attachment 361148 Patch v1 Clearing flags on attachment: 361148 Committed r240961: <https://trac.webkit.org/changeset/240961> 1502214 4 commit-queue 2019-02-04 19:25:01 -0800 All reviewed patches have been landed. Closing bug. 361148 2019-02-04 18:25:25 -0800 2019-02-04 19:25:00 -0800 Patch v1 bug-194265-20190204182524.patch text/plain 4224 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwOTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCAzZjRmMWM4OGNmYTU5OTFhNTk5YmE2MjMwMDljYTE0NDA2MmI2MDM0Li5jMjQ0 NzNmOWRkYmQ2MWIxYzk4NTE1NzI5ZTBmNTk3ODc5OWJlYmY1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxOS0wMi0wNCAgRGF2aWQgS2ls emVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgorCisgICAgICAgIHZwOGVfbXJfYWxsb2NfbWVtKCkg bGVha3MgTE9XRVJfUkVTX0ZSQU1FX0lORk8gaWYgc2Vjb25kIG1lbW9yeSBhbGxvY2F0aW9uIGZh aWxzCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xOTQyNjU+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvdGhpcmRfcGFydHkv bGlidnB4L3NvdXJjZS9saWJ2cHgvdnA4L3ZwOF9jeF9pZmFjZS5jOgorICAgICAgICAodnA4ZV9t cl9hbGxvY19tZW0pOgorICAgICAgICAtIEluaXRpYWxpemUgYHJlc2AgdG8gVlBYX0NPREVDX09L IGluc3RlYWQgb2YgMC4KKyAgICAgICAgLSBSZXR1cm4gZWFybHkgaWYgZmlyc3QgY2FsbG9jKCkg ZmFpbHMgaW5zdGVhZCBvZiB0cnlpbmcgdGhlCisgICAgICAgICAgc2Vjb25kIGNhbGxvYygpLiAg VGhlIGZ1bmN0aW9uIHdvdWxkIGNyYXNoIGRlcmVmZXJlbmNpbmcKKyAgICAgICAgICBudWxscHRy IGluIGBzaGFyZWRfbWVtX2xvYy0+bWJfaW5mb2Agb3RoZXJ3aXNlLgorICAgICAgICAtIENhbGwg ZnJlZShzaGFyZWRfbWVtX2xvYykgaWYgdGhlIHNlY29uZCBjYWxsIHRvIGNhbGxvYygpCisgICAg ICAgICAgZmFpbHMuICBUaGlzIGZpeGVzIHRoZSBsZWFrLgorICAgICAgICAqIFdlYktpdC8wMDAz LWxpYndlYnJ0Yy1maXgtdnA4ZV9tcl9hbGxvY19tZW0tbGVhay5kaWZmOiBBZGQuCisKIDIwMTkt MDEtMzAgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyNDA2NjUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhp cmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3RoaXJkX3BhcnR5L2xpYnZweC9zb3VyY2UvbGlidnB4 L3ZwOC92cDhfY3hfaWZhY2UuYyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uv dGhpcmRfcGFydHkvbGlidnB4L3NvdXJjZS9saWJ2cHgvdnA4L3ZwOF9jeF9pZmFjZS5jCmluZGV4 IGQzZTIwMDU5NDEwMDE4NmQ3OTA1NzU1YzkyNDNjMGI1NzkxOGZkZTcuLmI2N2JhYWIyNGQxMGMw N2I0NGI4NjM5MTdjNzFlOWViMTlhNzIyM2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5 L2xpYndlYnJ0Yy9Tb3VyY2UvdGhpcmRfcGFydHkvbGlidnB4L3NvdXJjZS9saWJ2cHgvdnA4L3Zw OF9jeF9pZmFjZS5jCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2UvdGhp cmRfcGFydHkvbGlidnB4L3NvdXJjZS9saWJ2cHgvdnA4L3ZwOF9jeF9pZmFjZS5jCkBAIC01Nzcs NyArNTc3LDcgQEAgc3RhdGljIHZweF9jb2RlY19lcnJfdCBzZXRfc2NyZWVuX2NvbnRlbnRfbW9k ZSh2cHhfY29kZWNfYWxnX3ByaXZfdCAqY3R4LAogCiBzdGF0aWMgdnB4X2NvZGVjX2Vycl90IHZw OGVfbXJfYWxsb2NfbWVtKGNvbnN0IHZweF9jb2RlY19lbmNfY2ZnX3QgKmNmZywKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdm9pZCAqKm1lbV9sb2MpIHsKLSAgdnB4 X2NvZGVjX2Vycl90IHJlcyA9IDA7CisgIHZweF9jb2RlY19lcnJfdCByZXMgPSBWUFhfQ09ERUNf T0s7CiAKICNpZiBDT05GSUdfTVVMVElfUkVTX0VOQ09ESU5HCiAgIExPV0VSX1JFU19GUkFNRV9J TkZPICpzaGFyZWRfbWVtX2xvYzsKQEAgLTU4NiwxMiArNTg2LDEzIEBAIHN0YXRpYyB2cHhfY29k ZWNfZXJyX3QgdnA4ZV9tcl9hbGxvY19tZW0oY29uc3QgdnB4X2NvZGVjX2VuY19jZmdfdCAqY2Zn LAogCiAgIHNoYXJlZF9tZW1fbG9jID0gY2FsbG9jKDEsIHNpemVvZihMT1dFUl9SRVNfRlJBTUVf SU5GTykpOwogICBpZiAoIXNoYXJlZF9tZW1fbG9jKSB7Ci0gICAgcmVzID0gVlBYX0NPREVDX01F TV9FUlJPUjsKKyAgICByZXR1cm4gVlBYX0NPREVDX01FTV9FUlJPUjsKICAgfQogCiAgIHNoYXJl ZF9tZW1fbG9jLT5tYl9pbmZvID0KICAgICAgIGNhbGxvYyhtYl9yb3dzICogbWJfY29scywgc2l6 ZW9mKExPV0VSX1JFU19NQl9JTkZPKSk7CiAgIGlmICghKHNoYXJlZF9tZW1fbG9jLT5tYl9pbmZv KSkgeworICAgIGZyZWUoc2hhcmVkX21lbV9sb2MpOwogICAgIHJlcyA9IFZQWF9DT0RFQ19NRU1f RVJST1I7CiAgIH0gZWxzZSB7CiAgICAgKm1lbV9sb2MgPSAodm9pZCAqKXNoYXJlZF9tZW1fbG9j OwpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1dlYktpdC8wMDAzLWxp YndlYnJ0Yy1maXgtdnA4ZV9tcl9hbGxvY19tZW0tbGVhay5kaWZmIGIvU291cmNlL1RoaXJkUGFy dHkvbGlid2VicnRjL1dlYktpdC8wMDAzLWxpYndlYnJ0Yy1maXgtdnA4ZV9tcl9hbGxvY19tZW0t bGVhay5kaWZmCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjZjNTkxZTA0ZDg5ZDM5ZjljNjc3YWZmZjEzNTc5NDA1Mzll MzkxZjIKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvV2Vi S2l0LzAwMDMtbGlid2VicnRjLWZpeC12cDhlX21yX2FsbG9jX21lbS1sZWFrLmRpZmYKQEAgLTAs MCArMSwyOCBAQAorZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3Vy Y2UvdGhpcmRfcGFydHkvbGlidnB4L3NvdXJjZS9saWJ2cHgvdnA4L3ZwOF9jeF9pZmFjZS5jIGIv U291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS90aGlyZF9wYXJ0eS9saWJ2cHgvc291 cmNlL2xpYnZweC92cDgvdnA4X2N4X2lmYWNlLmMKK2luZGV4IGQzZTIwMDU5NDEwLi5iNjdiYWFi MjRkMSAxMDA2NDQKKy0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2UvdGhp cmRfcGFydHkvbGlidnB4L3NvdXJjZS9saWJ2cHgvdnA4L3ZwOF9jeF9pZmFjZS5jCisrKysgYi9T b3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3RoaXJkX3BhcnR5L2xpYnZweC9zb3Vy Y2UvbGlidnB4L3ZwOC92cDhfY3hfaWZhY2UuYworQEAgLTU3Nyw3ICs1NzcsNyBAQCBzdGF0aWMg dnB4X2NvZGVjX2Vycl90IHNldF9zY3JlZW5fY29udGVudF9tb2RlKHZweF9jb2RlY19hbGdfcHJp dl90ICpjdHgsCisgCisgc3RhdGljIHZweF9jb2RlY19lcnJfdCB2cDhlX21yX2FsbG9jX21lbShj b25zdCB2cHhfY29kZWNfZW5jX2NmZ190ICpjZmcsCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB2b2lkICoqbWVtX2xvYykgeworLSAgdnB4X2NvZGVjX2Vycl90IHJl cyA9IDA7CisrICB2cHhfY29kZWNfZXJyX3QgcmVzID0gVlBYX0NPREVDX09LOworIAorICNpZiBD T05GSUdfTVVMVElfUkVTX0VOQ09ESU5HCisgICBMT1dFUl9SRVNfRlJBTUVfSU5GTyAqc2hhcmVk X21lbV9sb2M7CitAQCAtNTg2LDEyICs1ODYsMTMgQEAgc3RhdGljIHZweF9jb2RlY19lcnJfdCB2 cDhlX21yX2FsbG9jX21lbShjb25zdCB2cHhfY29kZWNfZW5jX2NmZ190ICpjZmcsCisgCisgICBz aGFyZWRfbWVtX2xvYyA9IGNhbGxvYygxLCBzaXplb2YoTE9XRVJfUkVTX0ZSQU1FX0lORk8pKTsK KyAgIGlmICghc2hhcmVkX21lbV9sb2MpIHsKKy0gICAgcmVzID0gVlBYX0NPREVDX01FTV9FUlJP UjsKKysgICAgcmV0dXJuIFZQWF9DT0RFQ19NRU1fRVJST1I7CisgICB9CisgCisgICBzaGFyZWRf bWVtX2xvYy0+bWJfaW5mbyA9CisgICAgICAgY2FsbG9jKG1iX3Jvd3MgKiBtYl9jb2xzLCBzaXpl b2YoTE9XRVJfUkVTX01CX0lORk8pKTsKKyAgIGlmICghKHNoYXJlZF9tZW1fbG9jLT5tYl9pbmZv KSkgeworKyAgICBmcmVlKHNoYXJlZF9tZW1fbG9jKTsKKyAgICAgcmVzID0gVlBYX0NPREVDX01F TV9FUlJPUjsKKyAgIH0gZWxzZSB7CisgICAgICptZW1fbG9jID0gKHZvaWQgKilzaGFyZWRfbWVt X2xvYzsK