194264 2019-02-04 18:15:02 -0800 [ews-app] Add method to save BuilderMapping to database 2019-02-05 09:25:55 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap ews-watchlist jbedard kocsen_chung lforschler webkit-bug-importer oldest_to_newest 1502186 0 aakash_jain 2019-02-04 18:15:02 -0800 We should add method to save Builder Mapping to database for ews-app. 1502189 1 361145 aakash_jain 2019-02-04 18:19:29 -0800 Created attachment 361145 Proposed patch 1502191 2 ews-watchlist 2019-02-04 18:21:09 -0800 Attachment 361145 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py:52: [BuilderMapping.save_mapping] Instance of 'BuilderMapping' has no 'save' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py:75: [BuilderMapping.get_existing_mapping] Class 'BuilderMapping' has no 'objects' member [pylint/E1101] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1502381 3 361145 lforschler 2019-02-05 09:07:58 -0800 Comment on attachment 361145 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=361145&action=review > Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py:59 > + _log.error('builder_id {} does not match with builer_id {}. Ignoring new data.'.format(mapping.builder_id, builder_id)) nit: typo: builer 1502384 4 361145 jbedard 2019-02-05 09:15:55 -0800 Comment on attachment 361145 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=361145&action=review > Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py:80 > + def is_valid_mapping(cls, builder_id, builder_name, display_name): Why are we accepting builder_name and display_name if we don't do anything with them? 1502387 5 aakash_jain 2019-02-05 09:23:10 -0800 Committed r240977: <https://trac.webkit.org/changeset/240977> 1502389 6 webkit-bug-importer 2019-02-05 09:24:35 -0800 <rdar://problem/47820191> 1502391 7 aakash_jain 2019-02-05 09:25:55 -0800 > Why are we accepting builder_name and display_name if we don't do anything with them? It's not required, but I added it for future, we might want to add more validation later on (e.g.: ensuring that display_name is string). 361145 2019-02-04 18:19:29 -0800 2019-02-05 09:22:23 -0800 Proposed patch ews-app-save-buildermapping.patch text/plain 3582 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MDk1OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE5LTAyLTA0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWFwcF0gQWRkIG1ldGhvZCB0byBzYXZlIEJ1aWxkZXJNYXBwaW5n IHRvIGRhdGFiYXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTQyNjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9idWlsZGVybWFwcGlu Zy5weToKKyAgICAgICAgKEJ1aWxkZXJNYXBwaW5nLl9fc3RyX18pOgorICAgICAgICAoQnVpbGRl ck1hcHBpbmcpOgorICAgICAgICAoQnVpbGRlck1hcHBpbmcuc2F2ZV9tYXBwaW5nKToKKyAgICAg ICAgKEJ1aWxkZXJNYXBwaW5nLnVwZGF0ZV9tYXBwaW5nKToKKyAgICAgICAgKEJ1aWxkZXJNYXBw aW5nLmdldF9leGlzdGluZ19tYXBwaW5nKToKKyAgICAgICAgKEJ1aWxkZXJNYXBwaW5nLmlzX3Zh bGlkX21hcHBpbmcpOgorCiAyMDE5LTAyLTA0ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFw cGxlLmNvbT4KIAogICAgICAgICB3ZWJraXRweTogUHJlY2VkZW5jZSBvZiBib290ZWQgZGV2aWNl cyBzaG91bGQgbWF0Y2ggcHJlY2VkZW5jZSBpbiBERUZBVUxUX0RFVklDRV9UWVBFUwpJbmRleDog VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL2J1aWxkZXJtYXBwaW5n LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21v ZGVscy9idWlsZGVybWFwcGluZy5weQkocmV2aXNpb24gMjQwOTU5KQorKysgVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL2J1aWxkZXJtYXBwaW5nLnB5CSh3b3JraW5n IGNvcHkpCkBAIC0yMiw3ICsyMiwxMyBAQAogCiBmcm9tIF9fZnV0dXJlX18gaW1wb3J0IHVuaWNv ZGVfbGl0ZXJhbHMKIAoraW1wb3J0IGxvZ2dpbmcKKwogZnJvbSBkamFuZ28uZGIgaW1wb3J0IG1v ZGVscworZnJvbSBld3MuY29uZmlnIGltcG9ydCBFUlJfVU5FWFBFQ1RFRCwgU1VDQ0VTUworaW1w b3J0IGV3cy5jb21tb24udXRpbCBhcyB1dGlsCisKK19sb2cgPSBsb2dnaW5nLmdldExvZ2dlcihf X25hbWVfXykKIAogCiBjbGFzcyBCdWlsZGVyTWFwcGluZyhtb2RlbHMuTW9kZWwpOgpAQCAtMzEs NCArMzcsNDcgQEAgY2xhc3MgQnVpbGRlck1hcHBpbmcobW9kZWxzLk1vZGVsKToKICAgICBkaXNw bGF5X25hbWUgPSBtb2RlbHMuVGV4dEZpZWxkKCkKIAogICAgIGRlZiBfX3N0cl9fKHNlbGYpOgot ICAgICAgICByZXR1cm4gInt9OiB7fSIuZm9ybWF0KHNlbGYuYnVpbGRlcl9pZCwgc2VsZi5uYW1l KQorICAgICAgICByZXR1cm4gInt9OiB7fSIuZm9ybWF0KHNlbGYuYnVpbGRlcl9pZCwgc2VsZi5k aXNwbGF5X25hbWUpCisKKyAgICBAY2xhc3NtZXRob2QKKyAgICBkZWYgc2F2ZV9tYXBwaW5nKGNs cywgYnVpbGRlcl9pZCwgYnVpbGRlcl9uYW1lLCBkaXNwbGF5X25hbWUpOgorICAgICAgICBpZiBu b3QgQnVpbGRlck1hcHBpbmcuaXNfdmFsaWRfbWFwcGluZyhidWlsZGVyX2lkLCBidWlsZGVyX25h bWUsIGRpc3BsYXlfbmFtZSk6CisgICAgICAgICAgICByZXR1cm4gRVJSX1VORVhQRUNURUQKKwor ICAgICAgICBtYXBwaW5nID0gQnVpbGRlck1hcHBpbmcuZ2V0X2V4aXN0aW5nX21hcHBpbmcoYnVp bGRlcl9pZCkKKyAgICAgICAgaWYgbWFwcGluZzoKKyAgICAgICAgICAgICMgSWYgdGhlIG1hcHBp bmcgaXMgdXBkYXRlZCwgZS5nLjogZGlzcGxheSBuYW1lIGNoYW5nZWQuCisgICAgICAgICAgICBy ZXR1cm4gQnVpbGRlck1hcHBpbmcudXBkYXRlX21hcHBpbmcobWFwcGluZywgYnVpbGRlcl9pZCwg YnVpbGRlcl9uYW1lLCBkaXNwbGF5X25hbWUpCisKKyAgICAgICAgQnVpbGRlck1hcHBpbmcoYnVp bGRlcl9pZCwgYnVpbGRlcl9uYW1lLCBkaXNwbGF5X25hbWUpLnNhdmUoKQorICAgICAgICBfbG9n LmluZm8oJ1NhdmVkIG1hcHBpbmcgZm9yIGJ1aWxkZXJfaWQ6IHt9LCBuYW1lOiB7fSwgZGlzcGxh eV9uYW1lOiB7fScuZm9ybWF0KGJ1aWxkZXJfaWQsIGJ1aWxkZXJfbmFtZSwgZGlzcGxheV9uYW1l KSkKKyAgICAgICAgcmV0dXJuIFNVQ0NFU1MKKworICAgIEBjbGFzc21ldGhvZAorICAgIGRlZiB1 cGRhdGVfbWFwcGluZyhjbHMsIG1hcHBpbmcsIGJ1aWxkZXJfaWQsIGJ1aWxkZXJfbmFtZSwgZGlz cGxheV9uYW1lKToKKyAgICAgICAgaWYgbWFwcGluZy5idWlsZGVyX2lkICE9IGJ1aWxkZXJfaWQ6 CisgICAgICAgICAgICBfbG9nLmVycm9yKCdidWlsZGVyX2lkIHt9IGRvZXMgbm90IG1hdGNoIHdp dGggYnVpbGVyX2lkIHt9LiBJZ25vcmluZyBuZXcgZGF0YS4nLmZvcm1hdChtYXBwaW5nLmJ1aWxk ZXJfaWQsIGJ1aWxkZXJfaWQpKQorICAgICAgICAgICAgcmV0dXJuIEVSUl9VTkVYUEVDVEVECisK KyAgICAgICAgaWYgbWFwcGluZy5idWlsZGVyX25hbWUgPT0gYnVpbGRlcl9uYW1lIGFuZCBtYXBw aW5nLmRpc3BsYXlfbmFtZSA9PSBkaXNwbGF5X25hbWU6CisgICAgICAgICAgICBfbG9nLmRlYnVn KCdNYXBwaW5nIGFscmVhZHkgZXhpc3QgZm9yIGJ1aWxkZXJfaWQ6IHt9Jy5mb3JtYXQoYnVpbGRl cl9pZCkpCisgICAgICAgICAgICByZXR1cm4gU1VDQ0VTUworCisgICAgICAgIG1hcHBpbmcuYnVp bGRlcl9uYW1lID0gYnVpbGRlcl9uYW1lCisgICAgICAgIG1hcHBpbmcuZGlzcGxheV9uYW1lID0g ZGlzcGxheV9uYW1lCisgICAgICAgIG1hcHBpbmcuc2F2ZSh1cGRhdGVfZmllbGRzPVsnYnVpbGRl cl9uYW1lJywgJ2Rpc3BsYXlfbmFtZSddKQorICAgICAgICBfbG9nLmluZm8oJ1VwZGF0ZWQgbWFw cGluZyBmb3IgYnVpbGRlcl9pZDoge30sIG5hbWU6IHt9LCBkaXNwbGF5X25hbWU6IHt9Jy5mb3Jt YXQoYnVpbGRlcl9pZCwgYnVpbGRlcl9uYW1lLCBkaXNwbGF5X25hbWUpKQorICAgICAgICByZXR1 cm4gU1VDQ0VTUworCisgICAgQGNsYXNzbWV0aG9kCisgICAgZGVmIGdldF9leGlzdGluZ19tYXBw aW5nKGNscywgYnVpbGRlcl9pZCk6CisgICAgICAgIHRyeToKKyAgICAgICAgICAgIHJldHVybiBC dWlsZGVyTWFwcGluZy5vYmplY3RzLmdldChidWlsZGVyX2lkPWJ1aWxkZXJfaWQpCisgICAgICAg IGV4Y2VwdDoKKyAgICAgICAgICAgIHJldHVybiBOb25lCisKKyAgICBAY2xhc3NtZXRob2QKKyAg ICBkZWYgaXNfdmFsaWRfbWFwcGluZyhjbHMsIGJ1aWxkZXJfaWQsIGJ1aWxkZXJfbmFtZSwgZGlz cGxheV9uYW1lKToKKyAgICAgICAgaWYgbm90IHV0aWwuaXNfdmFsaWRfaWQoYnVpbGRlcl9pZCk6 CisgICAgICAgICAgICByZXR1cm4gRmFsc2UKKyAgICAgICAgcmV0dXJuIFRydWUK