194262 2019-02-04 17:31:19 -0800 Web Inspector: Styles: remove harmless "property was unlocked" asserts 2019-02-05 03:21:35 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1502166 0 nvasilyev 2019-02-04 17:31:19 -0800 Race conditions are now prevented even when the style declaration is unlocked: Bug 192739: Web Inspector: Styles: fix race conditions when editing We can safely remove "property was unlocked" asserts. 1502171 1 361140 nvasilyev 2019-02-04 17:33:38 -0800 Created attachment 361140 Patch 1502206 2 361140 mattbaker 2019-02-04 19:09:12 -0800 Comment on attachment 361140 Patch rs=me 1502324 3 361140 commit-queue 2019-02-05 03:18:08 -0800 Comment on attachment 361140 Patch Clearing flags on attachment: 361140 Committed r240970: <https://trac.webkit.org/changeset/240970> 1502325 4 commit-queue 2019-02-05 03:18:10 -0800 All reviewed patches have been landed. Closing bug. 1502326 5 webkit-bug-importer 2019-02-05 03:21:35 -0800 <rdar://problem/47814025> 361140 2019-02-04 17:33:38 -0800 2019-02-05 03:18:08 -0800 Patch patch.txt text/plain 2691 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDYzMGJlYzRkZmI2Li4wODgxMjZlOWRkNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDItMDQgIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogU3R5bGVzOiByZW1vdmUgaGFybWxlc3MgInByb3BlcnR5IHdhcyB1bmxvY2tlZCIgYXNzZXJ0 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MjYy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2Vy SW50ZXJmYWNlL1ZpZXdzL1NwcmVhZHNoZWV0U3R5bGVQcm9wZXJ0eS5qczoKKyAgICAgICAgKFdJ LlNwcmVhZHNoZWV0U3R5bGVQcm9wZXJ0eS5wcm90b3R5cGUucmVtb3ZlKToKKyAgICAgICAgKFdJ LlNwcmVhZHNoZWV0U3R5bGVQcm9wZXJ0eS5wcm90b3R5cGUudXBkYXRlKToKKyAgICAgICAgKFdJ LlNwcmVhZHNoZWV0U3R5bGVQcm9wZXJ0eS5wcm90b3R5cGUuX2hhbmRsZU5hbWVDaGFuZ2UpOgor ICAgICAgICAoV0kuU3ByZWFkc2hlZXRTdHlsZVByb3BlcnR5LnByb3RvdHlwZS5faGFuZGxlVmFs dWVDaGFuZ2UpOgorCiAyMDE5LTAyLTA0ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZXNvdXJjZXM6IG1pc3NpbmcgcmVzb3VyY2Ug ZGF0YSBmb3IgZG9jdW1lbnQgb24gcmVsb2FkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TcHJlYWRzaGVldFN0eWxlUHJvcGVydHkuanMgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TcHJlYWRzaGVldFN0eWxl UHJvcGVydHkuanMKaW5kZXggYjVlYjhkMTQxZjYuLmFmNmMwNjk5ZDAwIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TcHJlYWRzaGVldFN0eWxl UHJvcGVydHkuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvU3ByZWFkc2hlZXRTdHlsZVByb3BlcnR5LmpzCkBAIC0xMzEsNyArMTMxLDYgQEAgV0kuU3By ZWFkc2hlZXRTdHlsZVByb3BlcnR5ID0gY2xhc3MgU3ByZWFkc2hlZXRTdHlsZVByb3BlcnR5IGV4 dGVuZHMgV0kuT2JqZWN0CiAKICAgICByZW1vdmUocmVwbGFjZW1lbnQgPSBudWxsKQogICAgIHsK LSAgICAgICAgY29uc29sZS5hc3NlcnQodGhpcy5fcHJvcGVydHkub3duZXJTdHlsZS5sb2NrZWQs IGBSZW1vdmVkIHByb3BlcnR5IHdhcyB1bmxvY2tlZCAoJHt0aGlzLl9wcm9wZXJ0eS5uYW1lfSlg KTsKICAgICAgICAgdGhpcy5lbGVtZW50LnJlbW92ZSgpOwogCiAgICAgICAgIGlmIChyZXBsYWNl bWVudCkKQEAgLTE1Niw3ICsxNTUsNiBAQCBXSS5TcHJlYWRzaGVldFN0eWxlUHJvcGVydHkgPSBj bGFzcyBTcHJlYWRzaGVldFN0eWxlUHJvcGVydHkgZXh0ZW5kcyBXSS5PYmplY3QKICAgICAgICAg ICAgIHRoaXMuX2NoZWNrYm94RWxlbWVudC5jaGVja2VkID0gdGhpcy5fcHJvcGVydHkuZW5hYmxl ZDsKICAgICAgICAgICAgIHRoaXMuX2NoZWNrYm94RWxlbWVudC50YWJJbmRleCA9IC0xOwogICAg ICAgICAgICAgdGhpcy5fY2hlY2tib3hFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwg KGV2ZW50KSA9PiB7Ci0gICAgICAgICAgICAgICAgY29uc29sZS5hc3NlcnQodGhpcy5fcHJvcGVy dHkub3duZXJTdHlsZS5sb2NrZWQsIGBUb2dnbGVkIHByb3BlcnR5IHdhcyB1bmxvY2tlZCAoJHt0 aGlzLl9wcm9wZXJ0eS5uYW1lfSlgKTsKICAgICAgICAgICAgICAgICBldmVudC5zdG9wUHJvcGFn YXRpb24oKTsKICAgICAgICAgICAgICAgICBsZXQgZGlzYWJsZWQgPSAhdGhpcy5fY2hlY2tib3hF bGVtZW50LmNoZWNrZWQ7CiAgICAgICAgICAgICAgICAgdGhpcy5fcHJvcGVydHkuY29tbWVudE91 dChkaXNhYmxlZCk7CkBAIC02NzYsMTUgKzY3NCwxMSBAQCBXSS5TcHJlYWRzaGVldFN0eWxlUHJv cGVydHkgPSBjbGFzcyBTcHJlYWRzaGVldFN0eWxlUHJvcGVydHkgZXh0ZW5kcyBXSS5PYmplY3QK IAogICAgIF9oYW5kbGVOYW1lQ2hhbmdlKCkKICAgICB7Ci0gICAgICAgIGNvbnNvbGUuYXNzZXJ0 KHRoaXMuX3Byb3BlcnR5Lm93bmVyU3R5bGUubG9ja2VkLCBgTW9kaWZpZWQgcHJvcGVydHkgd2Fz IHVubG9ja2VkICgke3RoaXMuX3Byb3BlcnR5Lm5hbWV9KWApOwotCiAgICAgICAgIHRoaXMuX3By b3BlcnR5Lm5hbWUgPSB0aGlzLl9uYW1lRWxlbWVudC50ZXh0Q29udGVudC50cmltKCk7CiAgICAg fQogCiAgICAgX2hhbmRsZVZhbHVlQ2hhbmdlKCkKICAgICB7Ci0gICAgICAgIGNvbnNvbGUuYXNz ZXJ0KHRoaXMuX3Byb3BlcnR5Lm93bmVyU3R5bGUubG9ja2VkLCBgTW9kaWZpZWQgcHJvcGVydHkg d2FzIHVubG9ja2VkICgke3RoaXMuX3Byb3BlcnR5Lm5hbWV9KWApOwotCiAgICAgICAgIHRoaXMu X3Byb3BlcnR5LnJhd1ZhbHVlID0gdGhpcy5fdmFsdWVFbGVtZW50LnRleHRDb250ZW50LnRyaW0o KTsKICAgICB9CiAK