194242 2019-02-04 15:15:17 -0800 Web Inspector: REGRESSION: Resources: WI.TreeOutline assertions when refreshing the page 2019-02-04 17:08:47 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi mattbaker commit-queue hi inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1502050 0 hi 2019-02-04 15:15:17 -0800 # Steps to reproduce: 1. inspect <https://apple.com> 2. select the <https://apple.com> frame tree element in the Resources tab 3. refresh the page => many assertions fire - Assertion Failed: Unable to get index for tree element. - Assertion Failed: Index must be a non-negative integer. 1502051 1 webkit-bug-importer 2019-02-04 15:15:57 -0800 <rdar://problem/47802027> 1502054 2 hi 2019-02-04 15:17:31 -0800 It looks like `WI.TreeOutline`'s `_cachedNumberOfDescendents` is a negative value. 1502094 3 mattbaker 2019-02-04 16:26:26 -0800 Did some digging. When the frame navigates, FrameTreeElement calls TreeElement.prototype.removeChildren, which the immediate base class, FolderizedTreeElement overrides: removeChildren() { super.removeChildren(); this._clearNewChildQueue(); for (var folder of this._folderTypeMap.values()) folder.removeChildren(); this._folderExpandedSettingMap.clear(); this._folderTypeMap.clear(); this._groupedIntoFolders = false; } Calling `removeChildren` for each FolderTreeElement leads to the assertions when trying to calculate the indexes of TreeElements which are no longer attached the tree. I think the fix is to simply remove this step. I don't think it is necessary. We clear the map below, and I don't believe we hold on to any references to the FolderTreeElements after this function returns. 1502095 4 361124 mattbaker 2019-02-04 16:26:47 -0800 Created attachment 361124 Patch 1502107 5 361124 joepeck 2019-02-04 16:37:28 -0800 Comment on attachment 361124 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361124&action=review > Source/WebInspectorUI/ChangeLog:12 > + Calling `removeChildren` for deteached TreeElements is unnecessary. Typo: deteached => detached 1502110 6 361126 mattbaker 2019-02-04 16:41:20 -0800 Created attachment 361126 Patch for landing 1502130 7 361126 commit-queue 2019-02-04 17:08:46 -0800 Comment on attachment 361126 Patch for landing Clearing flags on attachment: 361126 Committed r240950: <https://trac.webkit.org/changeset/240950> 1502131 8 commit-queue 2019-02-04 17:08:47 -0800 All reviewed patches have been landed. Closing bug. 361124 2019-02-04 16:26:47 -0800 2019-02-04 16:41:18 -0800 Patch bug-194242-20190204162646.patch text/plain 1885 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwOTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA5 MGEzYmY5NGNlODFkZTdiNWVkMjgzNjdiNjliYjk1OTIxYTgzZjU1Li4yYzM4YzBkMWY3NmY4ZmI0 YWYzZGIyOTNkODdkOTljNzExNTAxMTg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wMi0wNCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTjogUmVzb3VyY2VzOiBXSS5UcmVl T3V0bGluZSBhc3NlcnRpb25zIHdoZW4gcmVmcmVzaGluZyB0aGUgcGFnZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MjQyCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS80NzgwMjAyNz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRm9sZGVyaXplZFRyZWVFbGVtZW50 LmpzOgorICAgICAgICAoV0kuRm9sZGVyaXplZFRyZWVFbGVtZW50LnByb3RvdHlwZS5yZW1vdmVD aGlsZHJlbik6CisgICAgICAgIEZvbGRlclRyZWVFbGVtZW50cyBhcmUgcmVtb3ZlZCBieSB0aGUg YmFzZSBjbGFzcyBjYWxsIHRvIHJlbW92ZUNoaWxkcmVuLgorICAgICAgICBDYWxsaW5nIGByZW1v dmVDaGlsZHJlbmAgZm9yIGRldGVhY2hlZCBUcmVlRWxlbWVudHMgaXMgdW5uZWNlc3NhcnkuCisK IDIwMTktMDItMDQgIE1hdHQgQmFrZXIgIDxtYXR0YmFrZXJAYXBwbGUuY29tPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IFJFR1JFU1NJT046IGNsaWNraW5nIGEgc2VsZWN0ZWQgY2FsbCBmcmFt ZSBkb2Vzbid0IHJlLXNjcm9sbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvRm9sZGVyaXplZFRyZWVFbGVtZW50LmpzIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRm9sZGVyaXplZFRyZWVFbGVtZW50LmpzCmlu ZGV4IDFlZGFkMGQ4MmU3NWYwMWM4ZmRkNzk5ZWNkOGY5MzcwZjJkYWU4OGMuLmMxZTU0NmI0Mjcw MmM5MGM4YmIzY2M1YTRiZjRlYTM0MWVhZGUzODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0ZvbGRlcml6ZWRUcmVlRWxlbWVudC5qcworKysg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Gb2xkZXJpemVkVHJl ZUVsZW1lbnQuanMKQEAgLTY5LDE3ICs2OSwxMiBAQCBXSS5Gb2xkZXJpemVkVHJlZUVsZW1lbnQg PSBjbGFzcyBGb2xkZXJpemVkVHJlZUVsZW1lbnQgZXh0ZW5kcyBXSS5HZW5lcmFsVHJlZUVsZQog ICAgICAgICB0aGlzLl9mb2xkZXJpemVTZXR0aW5nc01hcC5zZXQodHlwZSwgc2V0dGluZ3MpOwog ICAgIH0KIAotICAgIC8vIE92ZXJyaWRlcyBmcm9tIFRyZWVFbGVtZW50IChQcml2YXRlKS4KLQog ICAgIHJlbW92ZUNoaWxkcmVuKCkKICAgICB7CiAgICAgICAgIHN1cGVyLnJlbW92ZUNoaWxkcmVu KCk7CiAKICAgICAgICAgdGhpcy5fY2xlYXJOZXdDaGlsZFF1ZXVlKCk7CiAKLSAgICAgICAgZm9y ICh2YXIgZm9sZGVyIG9mIHRoaXMuX2ZvbGRlclR5cGVNYXAudmFsdWVzKCkpCi0gICAgICAgICAg ICBmb2xkZXIucmVtb3ZlQ2hpbGRyZW4oKTsKLQogICAgICAgICB0aGlzLl9mb2xkZXJFeHBhbmRl ZFNldHRpbmdNYXAuY2xlYXIoKTsKICAgICAgICAgdGhpcy5fZm9sZGVyVHlwZU1hcC5jbGVhcigp OwogCg== 361126 2019-02-04 16:41:20 -0800 2019-02-04 17:08:46 -0800 Patch for landing bug-194242-20190204164120.patch text/plain 1885 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwOTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA5 MGEzYmY5NGNlODFkZTdiNWVkMjgzNjdiNjliYjk1OTIxYTgzZjU1Li4zMTA2YzViNWExOTE2YzVl YmQwOWM2ZGYyN2E5YmQ4ZmVhNjc1NjYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wMi0wNCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTjogUmVzb3VyY2VzOiBXSS5UcmVl T3V0bGluZSBhc3NlcnRpb25zIHdoZW4gcmVmcmVzaGluZyB0aGUgcGFnZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MjQyCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS80NzgwMjAyNz4KKworICAgICAgICBSZXZpZXdlZCBieSBKb3NlcGggUGVjb3Jh cm8uCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0ZvbGRlcml6ZWRUcmVlRWxlbWVu dC5qczoKKyAgICAgICAgKFdJLkZvbGRlcml6ZWRUcmVlRWxlbWVudC5wcm90b3R5cGUucmVtb3Zl Q2hpbGRyZW4pOgorICAgICAgICBGb2xkZXJUcmVlRWxlbWVudHMgYXJlIHJlbW92ZWQgYnkgdGhl IGJhc2UgY2xhc3MgY2FsbCB0byByZW1vdmVDaGlsZHJlbi4KKyAgICAgICAgQ2FsbGluZyBgcmVt b3ZlQ2hpbGRyZW5gIGZvciBkZXRhY2hlZCBUcmVlRWxlbWVudHMgaXMgdW5uZWNlc3NhcnkuCisK IDIwMTktMDItMDQgIE1hdHQgQmFrZXIgIDxtYXR0YmFrZXJAYXBwbGUuY29tPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IFJFR1JFU1NJT046IGNsaWNraW5nIGEgc2VsZWN0ZWQgY2FsbCBmcmFt ZSBkb2Vzbid0IHJlLXNjcm9sbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvRm9sZGVyaXplZFRyZWVFbGVtZW50LmpzIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRm9sZGVyaXplZFRyZWVFbGVtZW50LmpzCmlu ZGV4IDFlZGFkMGQ4MmU3NWYwMWM4ZmRkNzk5ZWNkOGY5MzcwZjJkYWU4OGMuLmMxZTU0NmI0Mjcw MmM5MGM4YmIzY2M1YTRiZjRlYTM0MWVhZGUzODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0ZvbGRlcml6ZWRUcmVlRWxlbWVudC5qcworKysg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Gb2xkZXJpemVkVHJl ZUVsZW1lbnQuanMKQEAgLTY5LDE3ICs2OSwxMiBAQCBXSS5Gb2xkZXJpemVkVHJlZUVsZW1lbnQg PSBjbGFzcyBGb2xkZXJpemVkVHJlZUVsZW1lbnQgZXh0ZW5kcyBXSS5HZW5lcmFsVHJlZUVsZQog ICAgICAgICB0aGlzLl9mb2xkZXJpemVTZXR0aW5nc01hcC5zZXQodHlwZSwgc2V0dGluZ3MpOwog ICAgIH0KIAotICAgIC8vIE92ZXJyaWRlcyBmcm9tIFRyZWVFbGVtZW50IChQcml2YXRlKS4KLQog ICAgIHJlbW92ZUNoaWxkcmVuKCkKICAgICB7CiAgICAgICAgIHN1cGVyLnJlbW92ZUNoaWxkcmVu KCk7CiAKICAgICAgICAgdGhpcy5fY2xlYXJOZXdDaGlsZFF1ZXVlKCk7CiAKLSAgICAgICAgZm9y ICh2YXIgZm9sZGVyIG9mIHRoaXMuX2ZvbGRlclR5cGVNYXAudmFsdWVzKCkpCi0gICAgICAgICAg ICBmb2xkZXIucmVtb3ZlQ2hpbGRyZW4oKTsKLQogICAgICAgICB0aGlzLl9mb2xkZXJFeHBhbmRl ZFNldHRpbmdNYXAuY2xlYXIoKTsKICAgICAgICAgdGhpcy5fZm9sZGVyVHlwZU1hcC5jbGVhcigp OwogCg==