<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>194232</bug_id>
          
          <creation_ts>2019-02-04 11:32:49 -0800</creation_ts>
          <short_desc>Use constants for pointer types</short_desc>
          <delta_ts>2019-02-04 14:30:13 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Antoine Quint">graouts</reporter>
          <assigned_to name="Antoine Quint">graouts</assigned_to>
          <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dbates</cc>
    
    <cc>dino</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>kangil.han</cc>
    
    <cc>sam</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1501924</commentid>
    <comment_count>0</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2019-02-04 11:32:49 -0800</bug_when>
    <thetext>Use constants for pointer types</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1501925</commentid>
    <comment_count>1</comment_count>
      <attachid>361077</attachid>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2019-02-04 11:34:22 -0800</bug_when>
    <thetext>Created attachment 361077
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1502001</commentid>
    <comment_count>2</comment_count>
      <attachid>361077</attachid>
    <who name="Sam Weinig">sam</who>
    <bug_when>2019-02-04 13:49:58 -0800</bug_when>
    <thetext>Comment on attachment 361077
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361077&amp;action=review

&gt; Source/WebCore/dom/PointerEvent.h:90
&gt; +    static const String&amp; mousePointerType() { static NeverDestroyed&lt;const String&gt; mouse(MAKE_STATIC_STRING_IMPL(&quot;mouse&quot;)); return mouse; }
&gt; +    static const String&amp; penPointerType() { static NeverDestroyed&lt;const String&gt; pen(MAKE_STATIC_STRING_IMPL(&quot;pen&quot;)); return pen; }
&gt; +    static const String&amp; touchPointerType() { static NeverDestroyed&lt;const String&gt; touch(MAKE_STATIC_STRING_IMPL(&quot;touch&quot;)); return touch; }

Generally we put static NeverDestroyed variables like this in the cpp file so that we only end up with one (otherwise you get one per cpp that includes this header).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1502018</commentid>
    <comment_count>3</comment_count>
      <attachid>361099</attachid>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2019-02-04 14:21:57 -0800</bug_when>
    <thetext>Created attachment 361099
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1502020</commentid>
    <comment_count>4</comment_count>
      <attachid>361100</attachid>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2019-02-04 14:25:45 -0800</bug_when>
    <thetext>Created attachment 361100
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1502022</commentid>
    <comment_count>5</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2019-02-04 14:28:49 -0800</bug_when>
    <thetext>Committed r240943: &lt;https://trac.webkit.org/changeset/240943&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1502024</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-02-04 14:30:13 -0800</bug_when>
    <thetext>&lt;rdar://problem/47799893&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>361077</attachid>
            <date>2019-02-04 11:34:22 -0800</date>
            <delta_ts>2019-02-04 14:21:54 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-194232-20190204203421.patch</filename>
            <type>text/plain</type>
            <size>3272</size>
            <attacher name="Antoine Quint">graouts</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwOTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2ZiMGVlOTQ0M2ZjNGYw
YzI1Njk2MzdlYzBjYThhMDI5ZGNmMzMyMS4uMDY5ZTg4MzJjYWQ4ZDZiYTFkZDhkYWM3MjNiZjUw
YmE5MjRlYWQ4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTAyLTA0ICBBbnRv
aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIGNvbnN0YW50cyBm
b3IgcG9pbnRlciB0eXBlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MTk0MjMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgV2UgY2Fubm90IHVzZSBhbiBlbnVtIGZvciB0aGUgcG9pbnRlciB0eXBlIHNpbmNl
IGEgY3VzdG9tIHBvaW50ZXIgdHlwZSBjYW4gYmUgY3JlYXRlZCBieSBkZXZlbG9wZXJzIHdoZW4g
Y3JlYXRpbmcgYQorICAgICAgICBwb2ludGVyIGV2ZW50IHVzaW5nIEphdmFTY3JpcHQsIGJ1dCB3
ZSBjYW4gYXQgbGVhc3QgdXNlZCBzdHJpbmcgY29uc3RhbnRzIGZvciB0aGUgb25lcyBjcmVhdGVk
IGludGVybmFsbHkuCisKKyAgICAgICAgKiBkb20vUG9pbnRlckV2ZW50Lmg6CisgICAgICAgICog
ZG9tL2lvcy9Qb2ludGVyRXZlbnRJT1MuY3BwOgorCiAyMDE5LTAyLTA0ICBBbnRvaW5lIFF1aW50
ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIGEgZGVkaWNhdGVkIHR5cGUgaW5z
dGVhZCBvZiBpbnQzMl90IGZvciBwb2ludGVyIGlkZW50aWZpZXJzCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViQ29yZS9kb20vUG9pbnRlckV2ZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vUG9pbnRl
ckV2ZW50LmgKaW5kZXggNjRmYWM1ZjQ0YmRmMWIwMjAyMGMyOTFhYmQ4ZDAxY2E1NzRkYTMxYy4u
ODZlZjM0OWU0YzY2YWQ5ZDRlODgzMjAwZjk2ZGI3ZGJhYTc1YzI4MiAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYkNvcmUvZG9tL1BvaW50ZXJFdmVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Q
b2ludGVyRXZlbnQuaApAQCAtNDgsNyArNDgsNyBAQCBwdWJsaWM6CiAgICAgICAgIGxvbmcgdGls
dFggeyAwIH07CiAgICAgICAgIGxvbmcgdGlsdFkgeyAwIH07CiAgICAgICAgIGxvbmcgdHdpc3Qg
eyAwIH07Ci0gICAgICAgIFN0cmluZyBwb2ludGVyVHlwZSB7ICJtb3VzZSJfcyB9OworICAgICAg
ICBTdHJpbmcgcG9pbnRlclR5cGUgeyBQb2ludGVyRXZlbnQ6Om1vdXNlUG9pbnRlclR5cGUoKSB9
OwogICAgICAgICBib29sIGlzUHJpbWFyeSB7IGZhbHNlIH07CiAgICAgfTsKIApAQCAtODUsNiAr
ODUsMTAgQEAgcHVibGljOgogICAgIHN0YXRpYyBSZWY8UG9pbnRlckV2ZW50PiBjcmVhdGUoY29u
c3QgUGxhdGZvcm1Ub3VjaEV2ZW50JiwgdW5zaWduZWQgdG91Y2hJbmRleCwgYm9vbCBpc1ByaW1h
cnksIFJlZjxXaW5kb3dQcm94eT4mJik7CiAjZW5kaWYKIAorICAgIHN0YXRpYyBjb25zdCBTdHJp
bmcmIG1vdXNlUG9pbnRlclR5cGUoKSB7IHN0YXRpYyBOZXZlckRlc3Ryb3llZDxjb25zdCBTdHJp
bmc+IG1vdXNlKE1BS0VfU1RBVElDX1NUUklOR19JTVBMKCJtb3VzZSIpKTsgcmV0dXJuIG1vdXNl
OyB9CisgICAgc3RhdGljIGNvbnN0IFN0cmluZyYgcGVuUG9pbnRlclR5cGUoKSB7IHN0YXRpYyBO
ZXZlckRlc3Ryb3llZDxjb25zdCBTdHJpbmc+IHBlbihNQUtFX1NUQVRJQ19TVFJJTkdfSU1QTCgi
cGVuIikpOyByZXR1cm4gcGVuOyB9CisgICAgc3RhdGljIGNvbnN0IFN0cmluZyYgdG91Y2hQb2lu
dGVyVHlwZSgpIHsgc3RhdGljIE5ldmVyRGVzdHJveWVkPGNvbnN0IFN0cmluZz4gdG91Y2goTUFL
RV9TVEFUSUNfU1RSSU5HX0lNUEwoInRvdWNoIikpOyByZXR1cm4gdG91Y2g7IH0KKwogICAgIHZp
cnR1YWwgflBvaW50ZXJFdmVudCgpOwogCiAgICAgUG9pbnRlcklEIHBvaW50ZXJJZCgpIGNvbnN0
IHsgcmV0dXJuIG1fcG9pbnRlcklkOyB9CkBAIC0xMTcsNyArMTIxLDcgQEAgcHJpdmF0ZToKICAg
ICBsb25nIG1fdGlsdFggeyAwIH07CiAgICAgbG9uZyBtX3RpbHRZIHsgMCB9OwogICAgIGxvbmcg
bV90d2lzdCB7IDAgfTsKLSAgICBTdHJpbmcgbV9wb2ludGVyVHlwZSB7ICJtb3VzZSJfcyB9Owor
ICAgIFN0cmluZyBtX3BvaW50ZXJUeXBlIHsgUG9pbnRlckV2ZW50Ojptb3VzZVBvaW50ZXJUeXBl
KCkgfTsKICAgICBib29sIG1faXNQcmltYXJ5IHsgZmFsc2UgfTsKIH07CiAKZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJDb3JlL2RvbS9pb3MvUG9pbnRlckV2ZW50SU9TLmNwcCBiL1NvdXJjZS9XZWJD
b3JlL2RvbS9pb3MvUG9pbnRlckV2ZW50SU9TLmNwcAppbmRleCA4MDVhZDM0OGM1ZGE5NGI0YWUy
OGU3ODMyMTJlMjFhMDU3YzAxOTE1Li40NTAyNDAwZjhhZDQ5NmU4NzZjMTRiNGZkMmE5OGFmZTBi
ZmVhMDA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vaW9zL1BvaW50ZXJFdmVudElP
Uy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL2lvcy9Qb2ludGVyRXZlbnRJT1MuY3BwCkBA
IC02OSw3ICs2OSw3IEBAIFBvaW50ZXJFdmVudDo6UG9pbnRlckV2ZW50KGNvbnN0IEF0b21pY1N0
cmluZyYgdHlwZSwgY29uc3QgUGxhdGZvcm1Ub3VjaEV2ZW50JiBlCiAgICAgLCBtX3dpZHRoKDIg
KiBldmVudC5yYWRpdXNYQXRJbmRleChpbmRleCkpCiAgICAgLCBtX2hlaWdodCgyICogZXZlbnQu
cmFkaXVzWUF0SW5kZXgoaW5kZXgpKQogICAgICwgbV9wcmVzc3VyZShldmVudC5mb3JjZUF0SW5k
ZXgoaW5kZXgpKQotICAgICwgbV9wb2ludGVyVHlwZShldmVudC50b3VjaFR5cGVBdEluZGV4KGlu
ZGV4KSA9PSBQbGF0Zm9ybVRvdWNoUG9pbnQ6OlRvdWNoVHlwZTo6U3R5bHVzID8gInBlbiJfcyA6
ICJ0b3VjaCJfcykKKyAgICAsIG1fcG9pbnRlclR5cGUoZXZlbnQudG91Y2hUeXBlQXRJbmRleChp
bmRleCkgPT0gUGxhdGZvcm1Ub3VjaFBvaW50OjpUb3VjaFR5cGU6OlN0eWx1cyA/IFBvaW50ZXJF
dmVudDo6cGVuUG9pbnRlclR5cGUoKSA6IFBvaW50ZXJFdmVudDo6dG91Y2hQb2ludGVyVHlwZSgp
KQogICAgICwgbV9pc1ByaW1hcnkoaXNQcmltYXJ5KQogewogICAgIC8vIFNlZSBodHRwczovL2dp
dGh1Yi5jb20vdzNjL3BvaW50ZXJldmVudHMvaXNzdWVzLzI3NC4gV2UgbWlnaHQgZXhwb3NlIHRo
ZSBhemltdXRoIGFuZCBhbHRpdHVkZQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>361099</attachid>
            <date>2019-02-04 14:21:57 -0800</date>
            <delta_ts>2019-02-04 14:25:42 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-194232-20190204232156.patch</filename>
            <type>text/plain</type>
            <size>4098</size>
            <attacher name="Antoine Quint">graouts</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwOTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2ZiMGVlOTQ0M2ZjNGYw
YzI1Njk2MzdlYzBjYThhMDI5ZGNmMzMyMS4uNDRjNGI4NjNiODlkODk2YmNlODY2MDlkMjNiN2M2
YjU2NjYyYmI5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTAyLTA0ICBBbnRv
aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIGNvbnN0YW50cyBm
b3IgcG9pbnRlciB0eXBlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MTk0MjMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgV2UgY2Fubm90IHVzZSBhbiBlbnVtIGZvciB0aGUgcG9pbnRlciB0eXBlIHNpbmNl
IGEgY3VzdG9tIHBvaW50ZXIgdHlwZSBjYW4gYmUgY3JlYXRlZCBieSBkZXZlbG9wZXJzIHdoZW4g
Y3JlYXRpbmcgYQorICAgICAgICBwb2ludGVyIGV2ZW50IHVzaW5nIEphdmFTY3JpcHQsIGJ1dCB3
ZSBjYW4gYXQgbGVhc3QgdXNlZCBzdHJpbmcgY29uc3RhbnRzIGZvciB0aGUgb25lcyBjcmVhdGVk
IGludGVybmFsbHkuCisKKyAgICAgICAgKiBkb20vUG9pbnRlckV2ZW50LmNwcDoKKyAgICAgICAg
KFdlYkNvcmU6OlBvaW50ZXJFdmVudDo6bW91c2VQb2ludGVyVHlwZSk6CisgICAgICAgIChXZWJD
b3JlOjpQb2ludGVyRXZlbnQ6OnBlblBvaW50ZXJUeXBlKToKKyAgICAgICAgKFdlYkNvcmU6OlBv
aW50ZXJFdmVudDo6dG91Y2hQb2ludGVyVHlwZSk6CisgICAgICAgICogZG9tL1BvaW50ZXJFdmVu
dC5oOgorICAgICAgICAqIGRvbS9pb3MvUG9pbnRlckV2ZW50SU9TLmNwcDoKKwogMjAxOS0wMi0w
NCAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBhIGRl
ZGljYXRlZCB0eXBlIGluc3RlYWQgb2YgaW50MzJfdCBmb3IgcG9pbnRlciBpZGVudGlmaWVycwpk
aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1BvaW50ZXJFdmVudC5jcHAgYi9Tb3VyY2Uv
V2ViQ29yZS9kb20vUG9pbnRlckV2ZW50LmNwcAppbmRleCA1MTg0YjI4ZTFmZTliNTBlMzgwNDE0
OGE4MTViMDdkOTE3ZDU2ODI4Li5mYjYyYzM1YTQ3OTMwM2E1ZDE3ZThiY2QyNDQ0OTVkZTA2YjM5
YjExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vUG9pbnRlckV2ZW50LmNwcAorKysg
Yi9Tb3VyY2UvV2ViQ29yZS9kb20vUG9pbnRlckV2ZW50LmNwcApAQCAtMzAsNiArMzAsMjQgQEAK
IAogbmFtZXNwYWNlIFdlYkNvcmUgewogCitjb25zdCBTdHJpbmcmIFBvaW50ZXJFdmVudDo6bW91
c2VQb2ludGVyVHlwZSgpCit7CisgICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPGNvbnN0IFN0cmlu
Zz4gbW91c2VUeXBlKE1BS0VfU1RBVElDX1NUUklOR19JTVBMKCJtb3VzZSIpKTsKKyAgICByZXR1
cm4gbW91c2VUeXBlOworfQorCitjb25zdCBTdHJpbmcmIFBvaW50ZXJFdmVudDo6cGVuUG9pbnRl
clR5cGUoKQoreworICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxjb25zdCBTdHJpbmc+IHBlblR5
cGUoTUFLRV9TVEFUSUNfU1RSSU5HX0lNUEwoInBlbiIpKTsKKyAgICByZXR1cm4gcGVuVHlwZTsK
K30KKworY29uc3QgU3RyaW5nJiBQb2ludGVyRXZlbnQ6OnRvdWNoUG9pbnRlclR5cGUoKQorewor
ICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxjb25zdCBTdHJpbmc+IHRvdWNoVHlwZShNQUtFX1NU
QVRJQ19TVFJJTkdfSU1QTCgidG91Y2giKSk7CisgICAgcmV0dXJuIHRvdWNoVHlwZTsKK30KKwog
UG9pbnRlckV2ZW50OjpQb2ludGVyRXZlbnQoKSA9IGRlZmF1bHQ7CiAKIFBvaW50ZXJFdmVudDo6
UG9pbnRlckV2ZW50KGNvbnN0IEF0b21pY1N0cmluZyYgdHlwZSwgSW5pdCYmIGluaXRpYWxpemVy
KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1BvaW50ZXJFdmVudC5oIGIvU291cmNl
L1dlYkNvcmUvZG9tL1BvaW50ZXJFdmVudC5oCmluZGV4IDY0ZmFjNWY0NGJkZjFiMDIwMjBjMjkx
YWJkOGQwMWNhNTc0ZGEzMWMuLmRlNzgwOTMxYmQ0OTBlMTQ5YTk2ZWRkNGIzMGYxMWVhNTQ0YTIy
YTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Qb2ludGVyRXZlbnQuaAorKysgYi9T
b3VyY2UvV2ViQ29yZS9kb20vUG9pbnRlckV2ZW50LmgKQEAgLTQ4LDcgKzQ4LDcgQEAgcHVibGlj
OgogICAgICAgICBsb25nIHRpbHRYIHsgMCB9OwogICAgICAgICBsb25nIHRpbHRZIHsgMCB9Owog
ICAgICAgICBsb25nIHR3aXN0IHsgMCB9OwotICAgICAgICBTdHJpbmcgcG9pbnRlclR5cGUgeyAi
bW91c2UiX3MgfTsKKyAgICAgICAgU3RyaW5nIHBvaW50ZXJUeXBlIHsgUG9pbnRlckV2ZW50Ojpt
b3VzZVBvaW50ZXJUeXBlKCkgfTsKICAgICAgICAgYm9vbCBpc1ByaW1hcnkgeyBmYWxzZSB9Owog
ICAgIH07CiAKQEAgLTg1LDYgKzg1LDEwIEBAIHB1YmxpYzoKICAgICBzdGF0aWMgUmVmPFBvaW50
ZXJFdmVudD4gY3JlYXRlKGNvbnN0IFBsYXRmb3JtVG91Y2hFdmVudCYsIHVuc2lnbmVkIHRvdWNo
SW5kZXgsIGJvb2wgaXNQcmltYXJ5LCBSZWY8V2luZG93UHJveHk+JiYpOwogI2VuZGlmCiAKKyAg
ICBzdGF0aWMgY29uc3QgU3RyaW5nJiBtb3VzZVBvaW50ZXJUeXBlKCk7CisgICAgc3RhdGljIGNv
bnN0IFN0cmluZyYgcGVuUG9pbnRlclR5cGUoKTsKKyAgICBzdGF0aWMgY29uc3QgU3RyaW5nJiB0
b3VjaFBvaW50ZXJUeXBlKCk7CisKICAgICB2aXJ0dWFsIH5Qb2ludGVyRXZlbnQoKTsKIAogICAg
IFBvaW50ZXJJRCBwb2ludGVySWQoKSBjb25zdCB7IHJldHVybiBtX3BvaW50ZXJJZDsgfQpAQCAt
MTE3LDcgKzEyMSw3IEBAIHByaXZhdGU6CiAgICAgbG9uZyBtX3RpbHRYIHsgMCB9OwogICAgIGxv
bmcgbV90aWx0WSB7IDAgfTsKICAgICBsb25nIG1fdHdpc3QgeyAwIH07Ci0gICAgU3RyaW5nIG1f
cG9pbnRlclR5cGUgeyAibW91c2UiX3MgfTsKKyAgICBTdHJpbmcgbV9wb2ludGVyVHlwZSB7IFBv
aW50ZXJFdmVudDo6bW91c2VQb2ludGVyVHlwZSgpIH07CiAgICAgYm9vbCBtX2lzUHJpbWFyeSB7
IGZhbHNlIH07CiB9OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vaW9zL1BvaW50
ZXJFdmVudElPUy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vaW9zL1BvaW50ZXJFdmVudElPUy5j
cHAKaW5kZXggODA1YWQzNDhjNWRhOTRiNGFlMjhlNzgzMjEyZTIxYTA1N2MwMTkxNS4uNDUwMjQw
MGY4YWQ0OTZlODc2YzE0YjRmZDJhOThhZmUwYmZlYTAwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvZG9tL2lvcy9Qb2ludGVyRXZlbnRJT1MuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Rv
bS9pb3MvUG9pbnRlckV2ZW50SU9TLmNwcApAQCAtNjksNyArNjksNyBAQCBQb2ludGVyRXZlbnQ6
OlBvaW50ZXJFdmVudChjb25zdCBBdG9taWNTdHJpbmcmIHR5cGUsIGNvbnN0IFBsYXRmb3JtVG91
Y2hFdmVudCYgZQogICAgICwgbV93aWR0aCgyICogZXZlbnQucmFkaXVzWEF0SW5kZXgoaW5kZXgp
KQogICAgICwgbV9oZWlnaHQoMiAqIGV2ZW50LnJhZGl1c1lBdEluZGV4KGluZGV4KSkKICAgICAs
IG1fcHJlc3N1cmUoZXZlbnQuZm9yY2VBdEluZGV4KGluZGV4KSkKLSAgICAsIG1fcG9pbnRlclR5
cGUoZXZlbnQudG91Y2hUeXBlQXRJbmRleChpbmRleCkgPT0gUGxhdGZvcm1Ub3VjaFBvaW50OjpU
b3VjaFR5cGU6OlN0eWx1cyA/ICJwZW4iX3MgOiAidG91Y2giX3MpCisgICAgLCBtX3BvaW50ZXJU
eXBlKGV2ZW50LnRvdWNoVHlwZUF0SW5kZXgoaW5kZXgpID09IFBsYXRmb3JtVG91Y2hQb2ludDo6
VG91Y2hUeXBlOjpTdHlsdXMgPyBQb2ludGVyRXZlbnQ6OnBlblBvaW50ZXJUeXBlKCkgOiBQb2lu
dGVyRXZlbnQ6OnRvdWNoUG9pbnRlclR5cGUoKSkKICAgICAsIG1faXNQcmltYXJ5KGlzUHJpbWFy
eSkKIHsKICAgICAvLyBTZWUgaHR0cHM6Ly9naXRodWIuY29tL3czYy9wb2ludGVyZXZlbnRzL2lz
c3Vlcy8yNzQuIFdlIG1pZ2h0IGV4cG9zZSB0aGUgYXppbXV0aCBhbmQgYWx0aXR1ZGUK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>361100</attachid>
            <date>2019-02-04 14:25:45 -0800</date>
            <delta_ts>2019-02-04 14:25:45 -0800</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-194232-20190204232544.patch</filename>
            <type>text/plain</type>
            <size>4096</size>
            <attacher name="Antoine Quint">graouts</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwOTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2ZiMGVlOTQ0M2ZjNGYw
YzI1Njk2MzdlYzBjYThhMDI5ZGNmMzMyMS4uYjM4ZGQ2ZTY3NzFkODczMGNiNzI3N2U5YjhkOTM3
ZDcwNzBmNmViZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTAyLTA0ICBBbnRv
aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIGNvbnN0YW50cyBm
b3IgcG9pbnRlciB0eXBlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MTk0MjMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGVhbiBKYWNrc29uLgorCisg
ICAgICAgIFdlIGNhbm5vdCB1c2UgYW4gZW51bSBmb3IgdGhlIHBvaW50ZXIgdHlwZSBzaW5jZSBh
IGN1c3RvbSBwb2ludGVyIHR5cGUgY2FuIGJlIGNyZWF0ZWQgYnkgZGV2ZWxvcGVycyB3aGVuIGNy
ZWF0aW5nIGEKKyAgICAgICAgcG9pbnRlciBldmVudCB1c2luZyBKYXZhU2NyaXB0LCBidXQgd2Ug
Y2FuIGF0IGxlYXN0IHVzZWQgc3RyaW5nIGNvbnN0YW50cyBmb3IgdGhlIG9uZXMgY3JlYXRlZCBp
bnRlcm5hbGx5LgorCisgICAgICAgICogZG9tL1BvaW50ZXJFdmVudC5jcHA6CisgICAgICAgIChX
ZWJDb3JlOjpQb2ludGVyRXZlbnQ6Om1vdXNlUG9pbnRlclR5cGUpOgorICAgICAgICAoV2ViQ29y
ZTo6UG9pbnRlckV2ZW50OjpwZW5Qb2ludGVyVHlwZSk6CisgICAgICAgIChXZWJDb3JlOjpQb2lu
dGVyRXZlbnQ6OnRvdWNoUG9pbnRlclR5cGUpOgorICAgICAgICAqIGRvbS9Qb2ludGVyRXZlbnQu
aDoKKyAgICAgICAgKiBkb20vaW9zL1BvaW50ZXJFdmVudElPUy5jcHA6CisKIDIwMTktMDItMDQg
IEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KIAogICAgICAgICBVc2UgYSBkZWRp
Y2F0ZWQgdHlwZSBpbnN0ZWFkIG9mIGludDMyX3QgZm9yIHBvaW50ZXIgaWRlbnRpZmllcnMKZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Qb2ludGVyRXZlbnQuY3BwIGIvU291cmNlL1dl
YkNvcmUvZG9tL1BvaW50ZXJFdmVudC5jcHAKaW5kZXggNTE4NGIyOGUxZmU5YjUwZTM4MDQxNDhh
ODE1YjA3ZDkxN2Q1NjgyOC4uZmI2MmMzNWE0NzkzMDNhNWQxN2U4YmNkMjQ0NDk1ZGUwNmIzOWIx
MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1BvaW50ZXJFdmVudC5jcHAKKysrIGIv
U291cmNlL1dlYkNvcmUvZG9tL1BvaW50ZXJFdmVudC5jcHAKQEAgLTMwLDYgKzMwLDI0IEBACiAK
IG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorY29uc3QgU3RyaW5nJiBQb2ludGVyRXZlbnQ6Om1vdXNl
UG9pbnRlclR5cGUoKQoreworICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxjb25zdCBTdHJpbmc+
IG1vdXNlVHlwZShNQUtFX1NUQVRJQ19TVFJJTkdfSU1QTCgibW91c2UiKSk7CisgICAgcmV0dXJu
IG1vdXNlVHlwZTsKK30KKworY29uc3QgU3RyaW5nJiBQb2ludGVyRXZlbnQ6OnBlblBvaW50ZXJU
eXBlKCkKK3sKKyAgICBzdGF0aWMgTmV2ZXJEZXN0cm95ZWQ8Y29uc3QgU3RyaW5nPiBwZW5UeXBl
KE1BS0VfU1RBVElDX1NUUklOR19JTVBMKCJwZW4iKSk7CisgICAgcmV0dXJuIHBlblR5cGU7Cit9
CisKK2NvbnN0IFN0cmluZyYgUG9pbnRlckV2ZW50Ojp0b3VjaFBvaW50ZXJUeXBlKCkKK3sKKyAg
ICBzdGF0aWMgTmV2ZXJEZXN0cm95ZWQ8Y29uc3QgU3RyaW5nPiB0b3VjaFR5cGUoTUFLRV9TVEFU
SUNfU1RSSU5HX0lNUEwoInRvdWNoIikpOworICAgIHJldHVybiB0b3VjaFR5cGU7Cit9CisKIFBv
aW50ZXJFdmVudDo6UG9pbnRlckV2ZW50KCkgPSBkZWZhdWx0OwogCiBQb2ludGVyRXZlbnQ6OlBv
aW50ZXJFdmVudChjb25zdCBBdG9taWNTdHJpbmcmIHR5cGUsIEluaXQmJiBpbml0aWFsaXplcikK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Qb2ludGVyRXZlbnQuaCBiL1NvdXJjZS9X
ZWJDb3JlL2RvbS9Qb2ludGVyRXZlbnQuaAppbmRleCA2NGZhYzVmNDRiZGYxYjAyMDIwYzI5MWFi
ZDhkMDFjYTU3NGRhMzFjLi5kZTc4MDkzMWJkNDkwZTE0OWE5NmVkZDRiMzBmMTFlYTU0NGEyMmEz
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vUG9pbnRlckV2ZW50LmgKKysrIGIvU291
cmNlL1dlYkNvcmUvZG9tL1BvaW50ZXJFdmVudC5oCkBAIC00OCw3ICs0OCw3IEBAIHB1YmxpYzoK
ICAgICAgICAgbG9uZyB0aWx0WCB7IDAgfTsKICAgICAgICAgbG9uZyB0aWx0WSB7IDAgfTsKICAg
ICAgICAgbG9uZyB0d2lzdCB7IDAgfTsKLSAgICAgICAgU3RyaW5nIHBvaW50ZXJUeXBlIHsgIm1v
dXNlIl9zIH07CisgICAgICAgIFN0cmluZyBwb2ludGVyVHlwZSB7IFBvaW50ZXJFdmVudDo6bW91
c2VQb2ludGVyVHlwZSgpIH07CiAgICAgICAgIGJvb2wgaXNQcmltYXJ5IHsgZmFsc2UgfTsKICAg
ICB9OwogCkBAIC04NSw2ICs4NSwxMCBAQCBwdWJsaWM6CiAgICAgc3RhdGljIFJlZjxQb2ludGVy
RXZlbnQ+IGNyZWF0ZShjb25zdCBQbGF0Zm9ybVRvdWNoRXZlbnQmLCB1bnNpZ25lZCB0b3VjaElu
ZGV4LCBib29sIGlzUHJpbWFyeSwgUmVmPFdpbmRvd1Byb3h5PiYmKTsKICNlbmRpZgogCisgICAg
c3RhdGljIGNvbnN0IFN0cmluZyYgbW91c2VQb2ludGVyVHlwZSgpOworICAgIHN0YXRpYyBjb25z
dCBTdHJpbmcmIHBlblBvaW50ZXJUeXBlKCk7CisgICAgc3RhdGljIGNvbnN0IFN0cmluZyYgdG91
Y2hQb2ludGVyVHlwZSgpOworCiAgICAgdmlydHVhbCB+UG9pbnRlckV2ZW50KCk7CiAKICAgICBQ
b2ludGVySUQgcG9pbnRlcklkKCkgY29uc3QgeyByZXR1cm4gbV9wb2ludGVySWQ7IH0KQEAgLTEx
Nyw3ICsxMjEsNyBAQCBwcml2YXRlOgogICAgIGxvbmcgbV90aWx0WCB7IDAgfTsKICAgICBsb25n
IG1fdGlsdFkgeyAwIH07CiAgICAgbG9uZyBtX3R3aXN0IHsgMCB9OwotICAgIFN0cmluZyBtX3Bv
aW50ZXJUeXBlIHsgIm1vdXNlIl9zIH07CisgICAgU3RyaW5nIG1fcG9pbnRlclR5cGUgeyBQb2lu
dGVyRXZlbnQ6Om1vdXNlUG9pbnRlclR5cGUoKSB9OwogICAgIGJvb2wgbV9pc1ByaW1hcnkgeyBm
YWxzZSB9OwogfTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL2lvcy9Qb2ludGVy
RXZlbnRJT1MuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL2lvcy9Qb2ludGVyRXZlbnRJT1MuY3Bw
CmluZGV4IDgwNWFkMzQ4YzVkYTk0YjRhZTI4ZTc4MzIxMmUyMWEwNTdjMDE5MTUuLjQ1MDI0MDBm
OGFkNDk2ZTg3NmMxNGI0ZmQyYTk4YWZlMGJmZWEwMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD
b3JlL2RvbS9pb3MvUG9pbnRlckV2ZW50SU9TLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20v
aW9zL1BvaW50ZXJFdmVudElPUy5jcHAKQEAgLTY5LDcgKzY5LDcgQEAgUG9pbnRlckV2ZW50OjpQ
b2ludGVyRXZlbnQoY29uc3QgQXRvbWljU3RyaW5nJiB0eXBlLCBjb25zdCBQbGF0Zm9ybVRvdWNo
RXZlbnQmIGUKICAgICAsIG1fd2lkdGgoMiAqIGV2ZW50LnJhZGl1c1hBdEluZGV4KGluZGV4KSkK
ICAgICAsIG1faGVpZ2h0KDIgKiBldmVudC5yYWRpdXNZQXRJbmRleChpbmRleCkpCiAgICAgLCBt
X3ByZXNzdXJlKGV2ZW50LmZvcmNlQXRJbmRleChpbmRleCkpCi0gICAgLCBtX3BvaW50ZXJUeXBl
KGV2ZW50LnRvdWNoVHlwZUF0SW5kZXgoaW5kZXgpID09IFBsYXRmb3JtVG91Y2hQb2ludDo6VG91
Y2hUeXBlOjpTdHlsdXMgPyAicGVuIl9zIDogInRvdWNoIl9zKQorICAgICwgbV9wb2ludGVyVHlw
ZShldmVudC50b3VjaFR5cGVBdEluZGV4KGluZGV4KSA9PSBQbGF0Zm9ybVRvdWNoUG9pbnQ6OlRv
dWNoVHlwZTo6U3R5bHVzID8gUG9pbnRlckV2ZW50OjpwZW5Qb2ludGVyVHlwZSgpIDogUG9pbnRl
ckV2ZW50Ojp0b3VjaFBvaW50ZXJUeXBlKCkpCiAgICAgLCBtX2lzUHJpbWFyeShpc1ByaW1hcnkp
CiB7CiAgICAgLy8gU2VlIGh0dHBzOi8vZ2l0aHViLmNvbS93M2MvcG9pbnRlcmV2ZW50cy9pc3N1
ZXMvMjc0LiBXZSBtaWdodCBleHBvc2UgdGhlIGF6aW11dGggYW5kIGFsdGl0dWRlCg==
</data>
<flag name="commit-queue"
          id="377793"
          type_id="3"
          status="+"
          setter="graouts"
    />
          </attachment>
      

    </bug>

</bugzilla>