194231 2019-02-04 11:12:33 -0800 when lowering AssertNotEmpty, create the value before creating the patchpoint 2019-02-04 17:36:35 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rmorisset rmorisset commit-queue ews-watchlist keith_miller mark.lam msaboff saam oldest_to_newest 1501915 0 rmorisset 2019-02-04 11:12:33 -0800 rdar://problem/46447987 1502000 1 361094 rmorisset 2019-02-04 13:48:37 -0800 Created attachment 361094 Patch 1502005 2 361095 rmorisset 2019-02-04 13:53:31 -0800 Created attachment 361095 Patch 1502104 3 361095 ews-watchlist 2019-02-04 16:35:02 -0800 Comment on attachment 361095 Patch Attachment 361095 did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/11030286 New failing tests: stress/ftl-get-by-id-getter-exception-interesting-live-state.js.ftl-eager apiTests 1502157 4 rmorisset 2019-02-04 17:24:58 -0800 I could not reproduce this failure, and according to sbarati@apple.com, this test is known to be flaky. 1502164 5 361095 saam 2019-02-04 17:30:15 -0800 Comment on attachment 361095 Patch r=me 1502175 6 361095 commit-queue 2019-02-04 17:36:33 -0800 Comment on attachment 361095 Patch Clearing flags on attachment: 361095 Committed r240959: <https://trac.webkit.org/changeset/240959> 1502176 7 commit-queue 2019-02-04 17:36:35 -0800 All reviewed patches have been landed. Closing bug. 361094 2019-02-04 13:48:37 -0800 2019-02-04 13:53:30 -0800 Patch bug-194231-20190204134836.patch text/plain 3100 rmorisset SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDA5NDApCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE3IEBACisyMDE5LTAyLTA0ICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBh cHBsZS5jb20+CisKKyAgICAgICAgd2hlbiBsb3dlcmluZyBBc3NlcnROb3RFbXB0eSwgY3JlYXRl IHRoZSB2YWx1ZSBiZWZvcmUgY3JlYXRpbmcgdGhlIHBhdGNocG9pbnQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDIzMQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgdGVzdCBpcyBwYWluZnVsbHkg ZnJhZ2lsZTogaXQgdHJpZXMgdG8gdGVzdCB0aGF0IEFzc2VydE5vdEVtcHR5IG9uIGEgY29uc3Rh bnQgcHJvZHVjZXMgdmFsaWQgQjMgSVIuCisgICAgICAgIFRoZSBwcm9ibGVtIGlzIHRoYXQgQXNz ZXJ0Tm90RW1wdHkgaXMgb25seSBjcmVhdGVkIGJ5IERGR0NvbnN0YW50Rm9sZGluZyB3aGVuIGl0 IGNhbiBzaW1wbGlmeSBhIENoZWNrU3RydWN0dXJlLCBhbmQgY29uc3RhbnQgZm9sZGluZyBpcyBh IGJpdCBjYXByaWNpb3VzIChodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTMzOTQ3KQorICAgICAgICBTbyBldmVuIHRpbnkgY2hhbmdlcyB0byB0aGlzIHRlc3QgY2FuIGNo YW5nZSB0aGUgcGF0aCBjb2RlIHRha2VuLgorCisgICAgICAgICogc3RyZXNzL2Fzc2VydC1ub3Qt ZW1wdHkuanM6IEFkZGVkLgorICAgICAgICAoZm9vKToKKwogMjAxOS0wMi0wMSAgTWFyayBMYW0g IDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGludmFsaWQgYXNzZXJ0aW9u IGluIERGRydzIGNvbXBpbGVEb3VibGVSZXAoKS4KSW5kZXg6IEpTVGVzdHMvc3RyZXNzL2Fzc2Vy dC1ub3QtZW1wdHkuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9zdHJlc3MvYXNzZXJ0LW5vdC1l bXB0eS5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVzcy9hc3NlcnQtbm90LWVtcHR5 LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTAgQEAKK2Z1bmN0aW9uIGZvbyhvKSB7Cisg IGlmICghbykgeworICAgICtldmFsOworICB9CisgIG8ueDsKK307CitsZXQgaT0wOworZm9yICg7 aTwxMDAwMDA7KytpKSB7CisgIGZvbyhPYmplY3QpOworfQpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNDA5MzUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDItMDQgIFJvYmluIE1v cmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KKworICAgICAgICB3aGVuIGxvd2VyaW5nIEFz c2VydE5vdEVtcHR5LCBjcmVhdGUgdGhlIHZhbHVlIGJlZm9yZSBjcmVhdGluZyB0aGUgcGF0Y2hw b2ludAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0 MjMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhp cyBpcyBhIHZlcnkgc2ltcGxlIGNoYW5nZTogd2Ugc2hvdWxkIG5ldmVyIGdlbmVyYXRlIEIzIElS IHdoZXJlIGFuIGluc3RydWN0aW9uIGRlcGVuZHMgb24gYSB2YWx1ZSB0aGF0IGNvbWVzIGxhdGVy IGluIHRoZSBpbnN0cnVjdGlvbiBzdHJlYW0uCisgICAgICAgIEFzc2VydE5vdEVtcHR5IHdhcyBn ZW5lcmF0aW5nIHNvbWUgc3VjaCBJUiwgaXQgcHJvYmFibHkgc2xpcHBlZCB0aHJvdWdoIHVudGls IG5vdyBiZWNhdXNlIGl0IGlzIGEgcmF0aGVyIHJhcmUgYW5kIHRyaWNreSBpbnN0cnVjdGlvbiB0 byBnZW5lcmF0ZS4KKworICAgICAgICAqIGZ0bC9GVExMb3dlckRGR1RvQjMuY3BwOgorICAgICAg ICAoSlNDOjpGVEw6OkRGRzo6TG93ZXJERkdUb0IzOjpjb21waWxlQXNzZXJ0Tm90RW1wdHkpOgor CiAyMDE5LTAyLTA0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBE RkcncyBkb2VzR0MoKSBpcyBpbmNvcnJlY3QgYWJvdXQgdGhlIFNhbWVWYWx1ZSBub2RlJ3MgYmVo YXZpb3IuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9CMy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1Rv QjMuY3BwCShyZXZpc2lvbiAyNDA5MzUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZU TExvd2VyREZHVG9CMy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMxMTEsOCArMzExMSw5IEBAIHBy aXZhdGU6CiAgICAgICAgIGlmICghdmFsaWRhdGlvbkVuYWJsZWQoKSkKICAgICAgICAgICAgIHJl dHVybjsKIAorICAgICAgICBMVmFsdWUgdmFsID0gbG93SlNWYWx1ZShtX25vZGUtPmNoaWxkMSgp KTsKICAgICAgICAgUGF0Y2hwb2ludFZhbHVlKiBwYXRjaHBvaW50ID0gbV9vdXQucGF0Y2hwb2lu dChWb2lkKTsKLSAgICAgICAgcGF0Y2hwb2ludC0+YXBwZW5kU29tZVJlZ2lzdGVyKGxvd0pTVmFs dWUobV9ub2RlLT5jaGlsZDEoKSkpOworICAgICAgICBwYXRjaHBvaW50LT5hcHBlbmRTb21lUmVn aXN0ZXIodmFsKTsKICAgICAgICAgcGF0Y2hwb2ludC0+c2V0R2VuZXJhdG9yKAogICAgICAgICAg ICAgWz1dIChDQ2FsbEhlbHBlcnMmIGppdCwgY29uc3QgU3RhY2ttYXBHZW5lcmF0aW9uUGFyYW1z JiBwYXJhbXMpIHsKICAgICAgICAgICAgICAgICBBbGxvd01hY3JvU2NyYXRjaFJlZ2lzdGVyVXNh Z2UgYWxsb3dTY3JhdGNoKGppdCk7Cg== 361095 2019-02-04 13:53:31 -0800 2019-02-04 17:36:33 -0800 Patch bug-194231-20190204135331.patch text/plain 3152 rmorisset SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDA5NDApCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE3IEBACisyMDE5LTAyLTA0ICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBh cHBsZS5jb20+CisKKyAgICAgICAgd2hlbiBsb3dlcmluZyBBc3NlcnROb3RFbXB0eSwgY3JlYXRl IHRoZSB2YWx1ZSBiZWZvcmUgY3JlYXRpbmcgdGhlIHBhdGNocG9pbnQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDIzMQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgdGVzdCBpcyBwYWluZnVsbHkg ZnJhZ2lsZTogaXQgdHJpZXMgdG8gdGVzdCB0aGF0IEFzc2VydE5vdEVtcHR5IG9uIGEgY29uc3Rh bnQgcHJvZHVjZXMgdmFsaWQgQjMgSVIuCisgICAgICAgIFRoZSBwcm9ibGVtIGlzIHRoYXQgQXNz ZXJ0Tm90RW1wdHkgaXMgb25seSBjcmVhdGVkIGJ5IERGR0NvbnN0YW50Rm9sZGluZyB3aGVuIGl0 IGNhbiBzaW1wbGlmeSBhIENoZWNrU3RydWN0dXJlLCBhbmQgY29uc3RhbnQgZm9sZGluZyBpcyBh IGJpdCBjYXByaWNpb3VzIChodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTMzOTQ3KQorICAgICAgICBTbyBldmVuIHRpbnkgY2hhbmdlcyB0byB0aGlzIHRlc3QgY2FuIGNo YW5nZSB0aGUgcGF0aCBjb2RlIHRha2VuLgorCisgICAgICAgICogc3RyZXNzL2Fzc2VydC1ub3Qt ZW1wdHkuanM6IEFkZGVkLgorICAgICAgICAoZm9vKToKKwogMjAxOS0wMi0wMSAgTWFyayBMYW0g IDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGludmFsaWQgYXNzZXJ0aW9u IGluIERGRydzIGNvbXBpbGVEb3VibGVSZXAoKS4KSW5kZXg6IEpTVGVzdHMvc3RyZXNzL2Fzc2Vy dC1ub3QtZW1wdHkuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9zdHJlc3MvYXNzZXJ0LW5vdC1l bXB0eS5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVzcy9hc3NlcnQtbm90LWVtcHR5 LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTIgQEAKKy8vQCBydW5EZWZhdWx0KCItLXVz ZU9iamVjdEFsbG9jYXRpb25TaW5raW5nPTAiKQorCitmdW5jdGlvbiBmb28obykgeworICBpZiAo IW8pIHsKKyAgICArZXZhbDsKKyAgfQorICBvLng7Cit9OworbGV0IGk9MDsKK2ZvciAoO2k8MTAw MDAwOysraSkgeworICBmb28oT2JqZWN0KTsKK30KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxv ZwkocmV2aXNpb24gMjQwOTM1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTAyLTA0ICBSb2JpbiBNb3Jpc3Nl dCAgPHJtb3Jpc3NldEBhcHBsZS5jb20+CisKKyAgICAgICAgd2hlbiBsb3dlcmluZyBBc3NlcnRO b3RFbXB0eSwgY3JlYXRlIHRoZSB2YWx1ZSBiZWZvcmUgY3JlYXRpbmcgdGhlIHBhdGNocG9pbnQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDIzMQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMg YSB2ZXJ5IHNpbXBsZSBjaGFuZ2U6IHdlIHNob3VsZCBuZXZlciBnZW5lcmF0ZSBCMyBJUiB3aGVy ZSBhbiBpbnN0cnVjdGlvbiBkZXBlbmRzIG9uIGEgdmFsdWUgdGhhdCBjb21lcyBsYXRlciBpbiB0 aGUgaW5zdHJ1Y3Rpb24gc3RyZWFtLgorICAgICAgICBBc3NlcnROb3RFbXB0eSB3YXMgZ2VuZXJh dGluZyBzb21lIHN1Y2ggSVIsIGl0IHByb2JhYmx5IHNsaXBwZWQgdGhyb3VnaCB1bnRpbCBub3cg YmVjYXVzZSBpdCBpcyBhIHJhdGhlciByYXJlIGFuZCB0cmlja3kgaW5zdHJ1Y3Rpb24gdG8gZ2Vu ZXJhdGUuCisKKyAgICAgICAgKiBmdGwvRlRMTG93ZXJERkdUb0IzLmNwcDoKKyAgICAgICAgKEpT Qzo6RlRMOjpERkc6Okxvd2VyREZHVG9CMzo6Y29tcGlsZUFzc2VydE5vdEVtcHR5KToKKwogMjAx OS0wMi0wNCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgREZHJ3Mg ZG9lc0dDKCkgaXMgaW5jb3JyZWN0IGFib3V0IHRoZSBTYW1lVmFsdWUgbm9kZSdzIGJlaGF2aW9y LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvQjMuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNw cAkocmV2aXNpb24gMjQwOTM1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dl ckRGR1RvQjMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMTExLDggKzMxMTEsOSBAQCBwcml2YXRl OgogICAgICAgICBpZiAoIXZhbGlkYXRpb25FbmFibGVkKCkpCiAgICAgICAgICAgICByZXR1cm47 CiAKKyAgICAgICAgTFZhbHVlIHZhbCA9IGxvd0pTVmFsdWUobV9ub2RlLT5jaGlsZDEoKSk7CiAg ICAgICAgIFBhdGNocG9pbnRWYWx1ZSogcGF0Y2hwb2ludCA9IG1fb3V0LnBhdGNocG9pbnQoVm9p ZCk7Ci0gICAgICAgIHBhdGNocG9pbnQtPmFwcGVuZFNvbWVSZWdpc3Rlcihsb3dKU1ZhbHVlKG1f bm9kZS0+Y2hpbGQxKCkpKTsKKyAgICAgICAgcGF0Y2hwb2ludC0+YXBwZW5kU29tZVJlZ2lzdGVy KHZhbCk7CiAgICAgICAgIHBhdGNocG9pbnQtPnNldEdlbmVyYXRvcigKICAgICAgICAgICAgIFs9 XSAoQ0NhbGxIZWxwZXJzJiBqaXQsIGNvbnN0IFN0YWNrbWFwR2VuZXJhdGlvblBhcmFtcyYgcGFy YW1zKSB7CiAgICAgICAgICAgICAgICAgQWxsb3dNYWNyb1NjcmF0Y2hSZWdpc3RlclVzYWdlIGFs bG93U2NyYXRjaChqaXQpOwo=