194230 2019-02-04 11:08:51 -0800 Can't temporarily force light or dark appearance on a page in a WebView 2019-02-04 16:29:37 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue megan_gardner thorton webkit-bug-importer oldest_to_newest 1501913 0 timothy 2019-02-04 11:08:51 -0800 Needed by clients to switch the appearance for DOM processing explicitly in light or dark mode. Similar to the WK2 version added in bug 193327. 1501916 1 361075 timothy 2019-02-04 11:15:12 -0800 Created attachment 361075 Patch 1501929 2 361075 thorton 2019-02-04 11:40:20 -0800 Comment on attachment 361075 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361075&action=review > Source/WebKitLegacy/mac/WebView/WebViewPrivate.h:325 > +- (void)_setUseDarkAppearance:(BOOL)useDarkAppearance; Why not a @property with a getter? 1501974 3 361088 timothy 2019-02-04 13:04:57 -0800 Created attachment 361088 Patch 1502098 4 361088 commit-queue 2019-02-04 16:28:29 -0800 Comment on attachment 361088 Patch Clearing flags on attachment: 361088 Committed r240948: <https://trac.webkit.org/changeset/240948> 1502099 5 commit-queue 2019-02-04 16:28:30 -0800 All reviewed patches have been landed. Closing bug. 1502100 6 webkit-bug-importer 2019-02-04 16:29:37 -0800 <rdar://problem/47804744> 361075 2019-02-04 11:15:12 -0800 2019-02-04 13:04:56 -0800 Patch bug-194230-20190204111512.patch text/plain 2028 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNzk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggYjVjYmNkMzgzYjBmZWE3YjgxNGVhYjgxNzRjMmFiNzYyMWJhMDk1Yy4uNDJhYjZlNTc3ZTMy NjdiMzVjNTI3NjFlNDVlOGViNWY3MmMzYzFjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTAyLTA0ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5 QGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgV2ViVmlldyBTUEkgdG8gdGVtcG9yYXJpbHkgZm9y Y2UgbGlnaHQgb3IgZGFyayBhcHBlYXJhbmNlIG9uIGEgcGFnZS4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDIzMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViVmlldy9XZWJWaWV3Lm1tOgorICAg ICAgICAoLVtXZWJWaWV3IF9zZXRVc2VEYXJrQXBwZWFyYW5jZTpdKTogQWRkZWQuCisgICAgICAg ICogV2ViVmlldy9XZWJWaWV3UHJpdmF0ZS5oOgorCiAyMDE5LTAxLTI4ICBEZXZpbiBSb3Vzc28g IDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBwcm92aWRlIGEg d2F5IHRvIGVkaXQgcGFnZSBXZWJSVEMgc2V0dGluZ3Mgb24gYSByZW1vdGUgdGFyZ2V0CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlZpZXcubW0gYi9Tb3Vy Y2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlZpZXcubW0KaW5kZXggNjYzMDkzNDM5MTYx ZDI4NDhlNWQyOWU2ZmQ5NTY4OTE4ZThkODUyZC4uMWFkZTUwMmFlYjI5YzRiNGQzMTM2ODU4ZTUz M2JiNDlmMDY4M2NmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmll dy9XZWJWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViVmll dy5tbQpAQCAtMjQ4Nyw2ICsyNDg3LDEzIEBAIC0gKFdlYlZpZXcgKilfb3Blbk5ld1dpbmRvd1dp dGhSZXF1ZXN0OihOU1VSTFJlcXVlc3QgKilyZXF1ZXN0CiAgICAgcmV0dXJuIG5ld1dpbmRvd1dl YlZpZXc7CiB9CiAKKy0gKHZvaWQpX3NldFVzZURhcmtBcHBlYXJhbmNlOihCT09MKXVzZURhcmtB cHBlYXJhbmNlCit7CisgICAgaWYgKCFfcHJpdmF0ZSB8fCAhX3ByaXZhdGUtPnBhZ2UpCisgICAg ICAgIHJldHVybjsKKyAgICBfcHJpdmF0ZS0+cGFnZS0+c2V0VXNlRGFya0FwcGVhcmFuY2UodXNl RGFya0FwcGVhcmFuY2UpOworfQorCiArICh2b2lkKV9zZXRJY29uTG9hZGluZ0VuYWJsZWQ6KEJP T0wpZW5hYmxlZAogewogICAgIGljb25Mb2FkaW5nRW5hYmxlZCA9IGVuYWJsZWQ7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlZpZXdQcml2YXRlLmggYi9T b3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlZpZXdQcml2YXRlLmgKaW5kZXggMjk5 ZmU2NzdmMmE3YTZiZGIzNjMyZTNiNTVmOGY0NmNjY2ZhYzljOC4uNjBkMTA4OGZkZmYzNzc5N2Y5 OGUwYTIwNGE1M2QwMTFkNTM2OTY0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS9t YWMvV2ViVmlldy9XZWJWaWV3UHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFj L1dlYlZpZXcvV2ViVmlld1ByaXZhdGUuaApAQCAtMzIyLDYgKzMyMiw4IEBAIHR5cGVkZWYgZW51 bSB7CiArICh2b2lkKV9zZXRJY29uTG9hZGluZ0VuYWJsZWQ6KEJPT0wpZW5hYmxlZDsKICsgKEJP T0wpX2lzSWNvbkxvYWRpbmdFbmFibGVkOwogCistICh2b2lkKV9zZXRVc2VEYXJrQXBwZWFyYW5j ZTooQk9PTCl1c2VEYXJrQXBwZWFyYW5jZTsKKwogLSAoV2ViSW5zcGVjdG9yICopaW5zcGVjdG9y OwogCiAjaWYgRU5BQkxFX1JFTU9URV9JTlNQRUNUT1IK 361088 2019-02-04 13:04:57 -0800 2019-02-04 16:28:29 -0800 Patch bug-194230-20190204130457.patch text/plain 2249 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNzk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggYjVjYmNkMzgzYjBmZWE3YjgxNGVhYjgxNzRjMmFiNzYyMWJhMDk1Yy4uZjU2NTdmYjFiZmQ0 MWQzMTIzNjViYjYyMWNmNDdmMmNiZTM2YTA1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAyLTA0ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5 QGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgV2ViVmlldyBTUEkgdG8gdGVtcG9yYXJpbHkgZm9y Y2UgbGlnaHQgb3IgZGFyayBhcHBlYXJhbmNlIG9uIGEgcGFnZS4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDIzMAorCisgICAgICAgIFJldmlld2Vk IGJ5IFRpbSBIb3J0b24uCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYlZpZXcubW06CisgICAgICAg ICgtW1dlYlZpZXcgX3VzZURhcmtBcHBlYXJhbmNlOl0pOiBBZGRlZC4KKyAgICAgICAgKC1bV2Vi VmlldyBfc2V0VXNlRGFya0FwcGVhcmFuY2U6XSk6IEFkZGVkLgorICAgICAgICAqIFdlYlZpZXcv V2ViVmlld1ByaXZhdGUuaDoKKwogMjAxOS0wMS0yOCAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0Bh cHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogcHJvdmlkZSBhIHdheSB0byBlZGl0 IHBhZ2UgV2ViUlRDIHNldHRpbmdzIG9uIGEgcmVtb3RlIHRhcmdldApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCmluZGV4IDY2MzA5MzQzOTE2MWQyODQ4ZTVkMjll NmZkOTU2ODkxOGU4ZDg1MmQuLmU2YzQ4MmI2ZDhmNjk0MTAwNzljNWZlYjcxY2EzNjc5MTcxMzNi ODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViVmlldy5t bQorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlZpZXcubW0KQEAgLTI0 ODcsNiArMjQ4NywyMCBAQCAtIChXZWJWaWV3ICopX29wZW5OZXdXaW5kb3dXaXRoUmVxdWVzdDoo TlNVUkxSZXF1ZXN0ICopcmVxdWVzdAogICAgIHJldHVybiBuZXdXaW5kb3dXZWJWaWV3OwogfQog CistIChCT09MKV91c2VEYXJrQXBwZWFyYW5jZQoreworICAgIGlmICghX3ByaXZhdGUgfHwgIV9w cml2YXRlLT5wYWdlKQorICAgICAgICByZXR1cm4gTk87CisgICAgcmV0dXJuIF9wcml2YXRlLT5w YWdlLT51c2VEYXJrQXBwZWFyYW5jZSgpOworfQorCistICh2b2lkKV9zZXRVc2VEYXJrQXBwZWFy YW5jZTooQk9PTCl1c2VEYXJrQXBwZWFyYW5jZQoreworICAgIGlmICghX3ByaXZhdGUgfHwgIV9w cml2YXRlLT5wYWdlKQorICAgICAgICByZXR1cm47CisgICAgX3ByaXZhdGUtPnBhZ2UtPnNldFVz ZURhcmtBcHBlYXJhbmNlKHVzZURhcmtBcHBlYXJhbmNlKTsKK30KKwogKyAodm9pZClfc2V0SWNv bkxvYWRpbmdFbmFibGVkOihCT09MKWVuYWJsZWQKIHsKICAgICBpY29uTG9hZGluZ0VuYWJsZWQg PSBlbmFibGVkOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9X ZWJWaWV3UHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJWaWV3 UHJpdmF0ZS5oCmluZGV4IDI5OWZlNjc3ZjJhN2E2YmRiMzYzMmUzYjU1ZjhmNDZjY2NmYWM5Yzgu LmMyNWVlODNiNDMyYjczNWY3ZTgzMThhYTBmNTY0NWEyNDRlZmE4M2IgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViVmlld1ByaXZhdGUuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlZpZXdQcml2YXRlLmgKQEAgLTMyMiw2ICsz MjIsOCBAQCB0eXBlZGVmIGVudW0gewogKyAodm9pZClfc2V0SWNvbkxvYWRpbmdFbmFibGVkOihC T09MKWVuYWJsZWQ7CiArIChCT09MKV9pc0ljb25Mb2FkaW5nRW5hYmxlZDsKIAorQHByb3BlcnR5 IChub25hdG9taWMsIGFzc2lnbiwgc2V0dGVyPV9zZXRVc2VEYXJrQXBwZWFyYW5jZTopIEJPT0wg X3VzZURhcmtBcHBlYXJhbmNlOworCiAtIChXZWJJbnNwZWN0b3IgKilpbnNwZWN0b3I7CiAKICNp ZiBFTkFCTEVfUkVNT1RFX0lOU1BFQ1RPUgo=