194225 2019-02-04 10:22:07 -0800 [ Mac WK2 ] REGRESSION (r239333) Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page.html 2019-03-21 13:32:32 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified CLOSED FIXED InRadar P2 Normal --- 1 sroberts webkit-unassigned beidson cdumez commit-queue lforschler tsavell webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1501881 0 sroberts 2019-02-04 10:22:07 -0800 The following layout test is flaky on Mac WK2 Debug http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page.html Probable cause: Appears to be flaky timeout or missing failure as of 239333. Reproducible with: run-webkit-tests --root d239506 http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page.html --iterations 500 -f --debug --exit-after-n-failures=1 --no-retry-failures Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fcookies%2Fsame-site%2Ffetch-after-top-level-navigation-from-cross-origin-page.html Assertion failure: ASSERTION FAILED: m_uncommittedState.state == State::Committed /Volumes/Data/slave/mojave-debug/build/Source/WebKit/UIProcess/PageLoadState.cpp(298) : void WebKit::PageLoadState::didFinishLoad(const Transaction::Token &) 1 0x10fa349e9 WTFCrash 2 0x119be42cb WTFCrashWithInfo(int, char const*, char const*, int) 3 0x11a33ee3d WebKit::PageLoadState::didFinishLoad(WebKit::PageLoadState::Transaction::Token const&) 4 0x11a4f94c2 WebKit::WebPageProxy::didFinishLoadForFrame(unsigned long long, unsigned long long, WebKit::UserData const&) 1501889 1 sroberts 2019-02-04 10:42:42 -0800 Forgot to link crash log: https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK2%20(Tests)/r240918%20(1446)/http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-stderr.txt 1502393 2 webkit-bug-importer 2019-02-05 09:26:29 -0800 <rdar://problem/47820247> 1502395 3 cdumez 2019-02-05 09:27:47 -0800 Did https://bugs.webkit.org/show_bug.cgi?id=193740 not fix this? It was working for me locally. 1502404 4 ap 2019-02-05 09:57:30 -0800 It did not, there's a crash with newer r240967: https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20(Tests)/builds/1461 1502405 5 cdumez 2019-02-05 10:00:02 -0800 (In reply to Alexey Proskuryakov from comment #4) > It did not, there's a crash with newer r240967: > https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20(Tests)/ > builds/1461 Ok, thanks. I'll investigate further. 1507829 6 362431 sroberts 2019-02-19 14:37:50 -0800 Created attachment 362431 Patch 1507831 7 362431 commit-queue 2019-02-19 14:40:52 -0800 Comment on attachment 362431 Patch Rejecting attachment 362431 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 362431, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=362431&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=194225&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 362431 from bug 194225. Fetching: https://bugs.webkit.org/attachment.cgi?id=362431 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/mac-wk2/TestExpectations Hunk #1 FAILED at 911. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac-wk2/TestExpectations.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/11208643 1508207 8 362530 sroberts 2019-02-20 13:20:30 -0800 Created attachment 362530 Update TestExpectations 1508210 9 362530 tsavell 2019-02-20 13:25:00 -0800 Comment on attachment 362530 Update TestExpectations Clearing flags on attachment: 362530 Committed r241831: <https://trac.webkit.org/changeset/241831> 1519295 10 cdumez 2019-03-20 16:33:10 -0700 Committed r243255: <https://trac.webkit.org/changeset/243255> 362431 2019-02-19 14:37:50 -0800 2019-02-20 13:20:28 -0800 Patch bug-194225-20190219143749.patch text/plain 1675 sroberts U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNzcxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTI2ZWFmNmU5ODQ5MDRhYzQzOThl MTU4MzMyYzJjNjg5ZTIwOTUwMC4uYjA4Y2U5YzIzMGE2ZjRlM2YwYjczZTU0NzI2Mjc3NDcxZTMx MDU5YSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE5LTAyLTE5ICBTaGF3biBSb2JlcnRzICA8 c3JvYmVydHNAYXBwbGUuY29tPgorCisgICAgICAgIFsgTWFjIFdLMiBdIFJFR1JFU1NJT04gKHIy MzkzMzMpIEZsYWt5IEFTU0VSVElPTiBGQUlMRUQ6IG1fdW5jb21taXR0ZWRTdGF0ZS5zdGF0ZSA9 PSBTdGF0ZTo6Q29tbWl0dGVkIG9uIGh0dHAvdGVzdHMvY29va2llcy9zYW1lLXNpdGUvZmV0Y2gt YWZ0ZXItdG9wLWxldmVsLW5hdmlnYXRpb24tZnJvbS1jcm9zcy1vcmlnaW4tcGFnZS5odG1sCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQyMjUKKwor ICAgICAgICBVbnJldmlld2VkIHRlc3QgZ2FyZGVuaW5nLgorCisgICAgICAgICogcGxhdGZvcm0v bWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDE5LTAyLTE5ICBDb21taXQgUXVldWUgIDxj b21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91 dCByMjQxNzIyLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0 RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRp b25zCmluZGV4IDljNGE0MzgwNzlmYzU4MTdmY2QyYTg5YWY1MjllNWQyMTc4MzdhMGEuLmJhYzJi YzYxODhmYWY2ZjhmNWY3NjMxYzY3NzQwM2Y3ZWVmMmI4YTYgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTkxMSw0ICs5MTEsNiBAQCB3ZWJr aXQub3JnL2IvMTkxNjQ0IFsgU2llcnJhIF0gZmFzdC93b3JrZXJzL3dvcmtlci1jbG9uZXBvcnQu aHRtbCBbIFBhc3MgRmFpbHVyZQogCiB3ZWJraXQub3JnL2IvMTkxNjU4IFsgU2llcnJhIFJlbGVh c2UgXSBmYXN0L2xheWVycy9uby1jbGlwcGluZy1vdmVyZmxvdy1oaWRkZW4tYWRkZWQtYWZ0ZXIt dHJhbnNmb3JtLmh0bWwgWyBQYXNzIEltYWdlT25seUZhaWx1cmUgXQogCi13ZWJraXQub3JnL2Iv MTkzOTc2IGh0dHAvdGVzdHMvY2FjaGUtc3RvcmFnZS9jYWNoZS1jbGVhcmluZy1vcmlnaW4uaHR0 cHMuaHRtbCBbIFBhc3MgRmFpbHVyZSBdClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQord2Vi a2l0Lm9yZy9iLzE5Mzk3NiBodHRwL3Rlc3RzL2NhY2hlLXN0b3JhZ2UvY2FjaGUtY2xlYXJpbmct b3JpZ2luLmh0dHBzLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQorCit3ZWJraXQub3JnL2IvMTk0MjI1 IGh0dHAvdGVzdHMvY29va2llcy9zYW1lLXNpdGUvZmV0Y2gtYWZ0ZXItdG9wLWxldmVsLW5hdmln YXRpb24tZnJvbS1jcm9zcy1vcmlnaW4tcGFnZS5odG1sIFsgUGFzcyBGYWlsdXJlIF0KXCBObyBu ZXdsaW5lIGF0IGVuZCBvZiBmaWxlCg== 362530 2019-02-20 13:20:30 -0800 2019-02-20 13:25:00 -0800 Update TestExpectations bug-194225-20190220132029.patch text/plain 1803 sroberts U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxODI5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTE2MTg2ODU5YzcxYjcyZTg1ZWQz ZWZhMWY5NzE1MTgzOGE4YjUzMy4uZTc1YmFlMGIzZjVmZWZiZmJhZThkMTk5MGNjOTM0ZGY3Zjc3 ZTM0MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE5LTAyLTIwICBTaGF3biBSb2JlcnRzICA8 c3JvYmVydHNAYXBwbGUuY29tPgorCisgICAgICAgIFsgTWFjIFdLMiBdIFJFR1JFU1NJT04gKHIy MzkzMzMpIEZsYWt5IEFTU0VSVElPTiBGQUlMRUQ6IG1fdW5jb21taXR0ZWRTdGF0ZS5zdGF0ZSA9 PSBTdGF0ZTo6Q29tbWl0dGVkIG9uIGh0dHAvdGVzdHMvY29va2llcy9zYW1lLXNpdGUvZmV0Y2gt YWZ0ZXItdG9wLWxldmVsLW5hdmlnYXRpb24tZnJvbS1jcm9zcy1vcmlnaW4tcGFnZS5odG1sCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQyMjUKKwor ICAgICAgICBVbnJldmlld2VkIHRlc3QgZ2FyZGVuaW5nLgorCisgICAgICAgICogcGxhdGZvcm0v bWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zOiBNYXJraW5nIGFzIGZsYWt5IHdoaWxlIHdhaXRpbmcg Zm9yIGZpeCB0byBsYW5kCisKIDIwMTktMDItMjAgIFNoYXduIFJvYmVydHMgIDxzcm9iZXJ0c0Bh cHBsZS5jb20+CiAKICAgICAgICAgWyBNYWMgV0syIF0gUkVHUkVTU0lPTiAocjIzODUxOSkgTGF5 b3V0IFRlc3QgZmFzdC9yZXBhaW50L3BsYWNlaG9sZGVyLWFmdGVyLWNhcHMtbG9jay1oaWRkZW4u aHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L21hYy13azIvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIv VGVzdEV4cGVjdGF0aW9ucwppbmRleCBmMGQyMzE2MjBmYTUyYmFhMzU0NDc0NGE4NzUxOTUzNGEy MjkxYjk2Li43NGEwNWY0ZTI2ODU5MmRkNTUwYzdlNmIyODQ1MTVjNmQ0ZGZlYTc5IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCkBAIC05MTYsNCAr OTE2LDYgQEAgd2Via2l0Lm9yZy9iLzE5Mzk3NiBodHRwL3Rlc3RzL2NhY2hlLXN0b3JhZ2UvY2Fj aGUtY2xlYXJpbmctb3JpZ2luLmh0dHBzLmh0bWwgWwogCiB3ZWJraXQub3JnL2IvMTk0ODI2IGh0 dHAvdGVzdHMvcmVzb3VyY2VMb2FkU3RhdGlzdGljcy9kby1ub3QtYmxvY2stdG9wLWxldmVsLW5h dmlnYXRpb24tcmVkaXJlY3QuaHRtbCBbIFBhc3MgVGltZW91dCBdCiAKLXdlYmtpdC5vcmcvYi8x OTQzNjggaHR0cC90ZXN0cy93b3JrZXJzL3NlcnZpY2UvYmFzaWMtcmVnaXN0ZXItZXhjZXB0aW9u cy5odG1sIFsgUGFzcyBGYWlsdXJlIF0KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCit3ZWJr aXQub3JnL2IvMTk0MzY4IGh0dHAvdGVzdHMvd29ya2Vycy9zZXJ2aWNlL2Jhc2ljLXJlZ2lzdGVy LWV4Y2VwdGlvbnMuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCisKK3dlYmtpdC5vcmcvYi8xOTQyMjUg WyBNb2phdmUgRGVidWcgXSBodHRwL3Rlc3RzL2Nvb2tpZXMvc2FtZS1zaXRlL2ZldGNoLWFmdGVy LXRvcC1sZXZlbC1uYXZpZ2F0aW9uLWZyb20tY3Jvc3Mtb3JpZ2luLXBhZ2UuaHRtbCBbIFBhc3Mg Q3Jhc2ggXQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK