194212 2019-02-03 22:48:15 -0800 [JSC] Make StaticStringImpl & StaticSymbolImpl actually static 2019-03-15 14:58:40 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified REOPENED https://bugs.webkit.org/show_bug.cgi?id=185337 InRadar P2 Normal --- 195641 1 ysuzuki ysuzuki benjamin cdumez cmarcelo commit-queue darin dbates ews-watchlist mark.lam simon.fraser webkit-bug-importer oldest_to_newest 1501747 0 ysuzuki 2019-02-03 22:48:15 -0800 Let's try it and see the performance impact. It possibly reduces the memory footprint. 1501748 1 361039 ysuzuki 2019-02-03 22:54:48 -0800 Created attachment 361039 Testing... 1501753 2 dbates 2019-02-03 23:11:03 -0800 This would be the awesome! 1515043 3 ysuzuki 2019-03-11 15:27:46 -0700 *** Bug 195577 has been marked as a duplicate of this bug. *** 1515046 4 364300 ysuzuki 2019-03-11 15:29:13 -0700 Created attachment 364300 Patch 1515050 5 364300 mark.lam 2019-03-11 15:32:41 -0700 Comment on attachment 364300 Patch r=me if this does not regress performance. 1515052 6 ysuzuki 2019-03-11 15:35:07 -0700 (In reply to Mark Lam from comment #5) > Comment on attachment 364300 [details] > Patch > > r=me if this does not regress performance. Yes, let's monitor the bots! 1515057 7 ysuzuki 2019-03-11 15:37:48 -0700 Committed r242747: <https://trac.webkit.org/changeset/242747> 1515063 8 webkit-bug-importer 2019-03-11 15:43:36 -0700 <rdar://problem/48786478> 1515068 9 darin 2019-03-11 16:05:14 -0700 (In reply to Yusuke Suzuki from comment #0) > Let's try it and see the performance impact. Waiting with bated breath. I would be super surprised if we don’t see performance impact. 1515194 10 ysuzuki 2019-03-11 19:19:30 -0700 (In reply to Darin Adler from comment #9) > (In reply to Yusuke Suzuki from comment #0) > > Let's try it and see the performance impact. > > Waiting with bated breath. I would be super surprised if we don’t see > performance impact. Yeah, in A/B test the result seems neutral. And I think it can be neutral since this change does not add additional load / store (isStatic()'s flag resides in ref count number itself). But... I'm not sure, and watching the bots. If we can keep this change, we have a chance to put fully-static-atomic-string-hash-table in front of runtime atomic string table. 1515662 11 ysuzuki 2019-03-12 13:58:52 -0700 It seems that this is perf-neutral in iOS, however, it is a bit hard to check the performance difference right now since r242714 causes large difference, and this patch is involved in the patch set including r242714. I think, 1. Once rolling out this patch 2. See the performance difference 3. After r242714's related changes are landed, let's land it again and see performance difference is better. 1515666 12 commit-queue 2019-03-12 14:00:06 -0700 Re-opened since this is blocked by bug 195641 1517028 13 ysuzuki 2019-03-15 11:23:54 -0700 Maybe, it is a good timing to land it again to see the performance effect! 1517130 14 simon.fraser 2019-03-15 14:29:14 -0700 This seemed to increase binary size quite significantly (and it goes down on the rollout). 1517160 15 ysuzuki 2019-03-15 14:58:40 -0700 (In reply to Simon Fraser (smfr) from comment #14) > This seemed to increase binary size quite significantly (and it goes down on > the rollout). Yes, this is because StringImpl::{ref,deref} code increases. (ReadOnly memory) But if we can avoid all heap allocations for AtomicStringImpls (and other types of WTFString backed by StaticStringImpl) finally, I think we can get net win in dirty memory. (Still, StaticStringImpl includes pointer, so it can be seen as a dirty __DATA memory. But if it is in a shared cache, then it can be a complete ReadOnly memory). 361039 2019-02-03 22:54:48 -0800 2019-03-11 15:29:12 -0700 Testing... bug-194212-20190203225447.patch text/plain 1364 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwOTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDEzY2E5MjIxZmQ5ZTFlMjAzOGZlNDI0 YjlmNjEzY2FhZjA4NDVlMzEuLjczODY5NTk0YjM4ZjRlOGMzMmQ5ZjMxZjcxNTBiNmNlZDI0Yzcx MjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDItMDMgIFl1c3VrZSBTdXp1a2kgIDx5c3V6 dWtpQGFwcGxlLmNvbT4KKworICAgICAgICBbSlNDXSBNYWtlIFN0YXRpY1N0cmluZ0ltcGwgJiBT dGF0aWNTeW1ib2xJbXBsIGFjdHVhbGx5IHN0YXRpYworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MjEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvdGV4dC9TdHJpbmdJbXBsLmg6CisgICAgICAg IChXVEY6OlN0cmluZ0ltcGw6OnJlZik6CisgICAgICAgIChXVEY6OlN0cmluZ0ltcGw6OmRlcmVm KToKKwogMjAxOS0wMi0wMyAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjI0MDg5Ni4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oIGIvU291cmNlL1dURi93dGYvdGV4dC9T dHJpbmdJbXBsLmgKaW5kZXggYmQwMWYyYzI2ODU5OWRkMTEwMGZmMTU3MmM1MWFhYWQ2MDZmM2Q5 Yy4uZTEzYzZkOTQ0MzIwMTk2ZGE3Mzc2NzE0N2MwYmMyNjk5MTVjNGRlOCAxMDA2NDQKLS0tIGEv U291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmgKKysrIGIvU291cmNlL1dURi93dGYvdGV4 dC9TdHJpbmdJbXBsLmgKQEAgLTEwNDcsMTMgKzEwNDcsMTYgQEAgaW5saW5lIHZvaWQgU3RyaW5n SW1wbDo6c2V0SGFzaCh1bnNpZ25lZCBoYXNoKSBjb25zdAogaW5saW5lIHZvaWQgU3RyaW5nSW1w bDo6cmVmKCkKIHsKICAgICBTVFJJTkdfU1RBVFNfUkVGX1NUUklORygqdGhpcyk7Ci0KKyAgICBp ZiAoaXNTdGF0aWMoKSkKKyAgICAgICAgcmV0dXJuOwogICAgIG1fcmVmQ291bnQgKz0gc19yZWZD b3VudEluY3JlbWVudDsKIH0KIAogaW5saW5lIHZvaWQgU3RyaW5nSW1wbDo6ZGVyZWYoKQogewog ICAgIFNUUklOR19TVEFUU19ERVJFRl9TVFJJTkcoKnRoaXMpOworICAgIGlmIChpc1N0YXRpYygp KQorICAgICAgICByZXR1cm47CiAKICAgICB1bnNpZ25lZCB0ZW1wUmVmQ291bnQgPSBtX3JlZkNv dW50IC0gc19yZWZDb3VudEluY3JlbWVudDsKICAgICBpZiAoIXRlbXBSZWZDb3VudCkgewo= 364300 2019-03-11 15:29:13 -0700 2019-03-11 15:32:41 -0700 Patch bug-194212-20190311152912.patch text/plain 1533 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyNzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDY0NjZjYmE3ZDRiODY5NDQ3Zjg2NDlh MGNmZmRhOTgwMmI2Mjg4YzIuLjlkOTlkMzlkMThhOGFiZGJmZjYxOGIwODhkODQxZjkyMmJlYzlm YWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDMtMTEgIFl1c3VrZSBTdXp1a2kgIDx5c3V6 dWtpQGFwcGxlLmNvbT4KKworICAgICAgICBbSlNDXSBNYWtlIFN0YXRpY1N0cmluZ0ltcGwgJiBT dGF0aWNTeW1ib2xJbXBsIGFjdHVhbGx5IHN0YXRpYworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MjEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQXZvaWQgbXV0YXRpb24gb250byByZWZjb3VudHMgaWYg YGlzU3RhdGljKClgIHJldHVybnMgdHJ1ZSBzbyB0aGF0IHRoZSBjb250ZW50IG9mIFN0YXRpY1N0 cmluZ0ltcGwgbmV2ZXIgZ2V0cyBtb2RpZmllZC4KKworICAgICAgICAqIHd0Zi90ZXh0L1N0cmlu Z0ltcGwuaDoKKyAgICAgICAgKFdURjo6U3RyaW5nSW1wbDo6cmVmKToKKyAgICAgICAgKFdURjo6 U3RyaW5nSW1wbDo6ZGVyZWYpOgorCiAyMDE5LTAzLTExICBTaWh1aSBMaXUgIDxzaWh1aV9saXVA YXBwbGUuY29tPgogCiAgICAgICAgIENyYXNoIHVuZGVyIFdlYkNvcmU6OklEQkRhdGFiYXNlOjpj b25uZWN0aW9uVG9TZXJ2ZXJMb3N0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0 cmluZ0ltcGwuaCBiL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oCmluZGV4IGU1NjQ2 NDhjNTQzY2Q4MjNkZThmMjIzYzQyMzdjYzkyNjk1MTkzMDQuLjI5M2U0MmRhZWFlMmJlZTk5NWNj YzI0MDM3YTRkYmNkMzhhNzE4NGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3Ry aW5nSW1wbC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oCkBAIC0xMDY0 LDYgKzEwNjQsOCBAQCBpbmxpbmUgdm9pZCBTdHJpbmdJbXBsOjpyZWYoKQogewogICAgIFNUUklO R19TVEFUU19SRUZfU1RSSU5HKCp0aGlzKTsKIAorICAgIGlmIChVTkxJS0VMWShpc1N0YXRpYygp KSkKKyAgICAgICAgcmV0dXJuOwogICAgIG1fcmVmQ291bnQgKz0gc19yZWZDb3VudEluY3JlbWVu dDsKIH0KIApAQCAtMTA3MSw2ICsxMDczLDggQEAgaW5saW5lIHZvaWQgU3RyaW5nSW1wbDo6ZGVy ZWYoKQogewogICAgIFNUUklOR19TVEFUU19ERVJFRl9TVFJJTkcoKnRoaXMpOwogCisgICAgaWYg KFVOTElLRUxZKGlzU3RhdGljKCkpKQorICAgICAgICByZXR1cm47CiAgICAgdW5zaWduZWQgdGVt cFJlZkNvdW50ID0gbV9yZWZDb3VudCAtIHNfcmVmQ291bnRJbmNyZW1lbnQ7CiAgICAgaWYgKCF0 ZW1wUmVmQ291bnQpIHsKICAgICAgICAgU3RyaW5nSW1wbDo6ZGVzdHJveSh0aGlzKTsK