194211 2019-02-03 20:57:14 -0800 DFG's doesGC() is incorrect about the SameValue node's behavior. 2019-02-04 00:16:49 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1501733 0 mark.lam 2019-02-03 20:57:14 -0800 <rdar://problem/47608913> 1501734 1 361037 mark.lam 2019-02-03 21:02:53 -0800 Created attachment 361037 proposed patch. 1501771 2 mark.lam 2019-02-04 00:16:49 -0800 Thanks for the review. Landed in r240917: <http://trac.webkit.org/r240917>. 361037 2019-02-03 21:02:53 -0800 2019-02-03 21:14:34 -0800 proposed patch. bug-194211.patch text/plain 1649 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQwOTE0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE5LTAyLTAzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBE RkcncyBkb2VzR0MoKSBpcyBpbmNvcnJlY3QgYWJvdXQgdGhlIFNhbWVWYWx1ZSBub2RlJ3MgYmVo YXZpb3IuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTQyMTEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ3NjA4OTEzPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9ubHkgdGhlIERvdWJsZVJlcFVzZSBj YXNlIGlzIGd1YXJhbnRlZWQgdG8gbm90IEdDLiAgVGhlIG90aGVyIGNhc2UgbWF5IEdDIGJlY2F1 c2UKKyAgICAgICAgaXQgY2FsbHMgb3BlcmF0aW9uU2FtZVZhbHVlKCkgd2hpY2ggbWF5IGFsbG9j YXRlIG1lbW9yeSBmb3IgcmVzb2x2aW5nIHJvcGVzLgorCisgICAgICAgICogZGZnL0RGR0RvZXNH Qy5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6ZG9lc0dDKToKKwogMjAxOS0wMi0wMSAgWXVzdWtl IFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIERlY291cGxlIEpJ VCByZWxhdGVkIGRhdGEgZnJvbSBDb2RlQmxvY2sKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHRG9lc0dDLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR0RvZXNHQy5jcHAJKHJldmlzaW9uIDI0MDkxNCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHRG9lc0dDLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU1LDcgKzE1NSw2IEBA IGJvb2wgZG9lc0dDKEdyYXBoJiBncmFwaCwgTm9kZSogbm9kZSkKICAgICBjYXNlIENvbXBhcmVF cToKICAgICBjYXNlIENvbXBhcmVTdHJpY3RFcToKICAgICBjYXNlIENvbXBhcmVFcVB0cjoKLSAg ICBjYXNlIFNhbWVWYWx1ZToKICAgICBjYXNlIENhbGw6CiAgICAgY2FzZSBEaXJlY3RDYWxsOgog ICAgIGNhc2UgVGFpbENhbGxJbmxpbmVkQ2FsbGVyOgpAQCAtNDEzLDYgKzQxMiwxMSBAQCBib29s IGRvZXNHQyhHcmFwaCYgZ3JhcGgsIE5vZGUqIG5vZGUpCiAgICAgY2FzZSBNdWx0aVB1dEJ5T2Zm c2V0OgogICAgICAgICByZXR1cm4gbm9kZS0+bXVsdGlQdXRCeU9mZnNldERhdGEoKS5yZWFsbG9j YXRlc1N0b3JhZ2UoKTsKIAorICAgIGNhc2UgU2FtZVZhbHVlOgorICAgICAgICBpZiAobm9kZS0+ aXNCaW5hcnlVc2VLaW5kKERvdWJsZVJlcFVzZSkpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7 CisgICAgICAgIHJldHVybiB0cnVlOworCiAgICAgY2FzZSBMYXN0Tm9kZVR5cGU6CiAgICAgICAg IFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgICAgIHJldHVybiB0cnVlOwo=