194209 2019-02-03 19:48:05 -0800 REGRESSION(r240785): [SOUP] Broke cookie persistent storage 2019-02-06 00:07:03 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 194075 1 mcatanzaro mcatanzaro aperez bugs-noreply cgarcia commit-queue mcatanzaro webkit-bug-importer oldest_to_newest 1501728 0 mcatanzaro 2019-02-03 19:48:05 -0800 I broke cookie persistent storage in r240785 and should probably fix it. 1501770 1 cgarcia 2019-02-04 00:09:11 -0800 Should probably fix it? 1501806 2 mcatanzaro 2019-02-04 07:05:14 -0800 Yes, probably, unless we want all cookies to be lost at the end of the session. :) Seriously now, I made the mistake of assuming TestWebKitCookieManager would notice if I broke cookies. We should probably check somewhere that the persistent storage file is created. 1502453 3 361207 mcatanzaro 2019-02-05 12:02:44 -0800 Created attachment 361207 Patch 1502706 4 361207 commit-queue 2019-02-06 00:06:02 -0800 Comment on attachment 361207 Patch Clearing flags on attachment: 361207 Committed r241013: <https://trac.webkit.org/changeset/241013> 1502707 5 commit-queue 2019-02-06 00:06:04 -0800 All reviewed patches have been landed. Closing bug. 361207 2019-02-05 12:02:44 -0800 2019-02-06 00:06:02 -0800 Patch bug-194209-20190205140243.patch text/plain 6755 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwOTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNkZmIzODU2NzdlZTc4Njc1 OTRiNzFhMDQ3NDU3MzJmOWI0ZjZjZTMuLmJhMGFiYTJiZDcwZWZjNDQyNDFkYWE4ZGM3ODVhY2Ix NzEyNjUyMzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDItMDUgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04o cjI0MDc4NSk6IFtTT1VQXSBCcm9rZSBjb29raWUgcGVyc2lzdGVudCBzdG9yYWdlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQyMDkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJIG1pc3NlZCBhIHNwb3Qg d2hlbiBtb3ZpbmcgdGhlIHBlcnNpc3RlbnQgc3RvcmFnZSBwYXJhbWV0ZXJzIGZyb20gTmV0d29y a1Byb2Nlc3MgdG8KKyAgICAgICAgTmV0d29ya1Nlc3Npb24uIFRoZXkgaGF2ZSB0byBiZSBpbml0 aWFsaXplZCBzZXBhcmF0ZWx5IGZvciB0aGUgZGVmYXVsdCBzZXNzaW9uLgorCisgICAgICAgICog VUlQcm9jZXNzL3NvdXAvV2ViUHJvY2Vzc1Bvb2xTb3VwLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 V2ViUHJvY2Vzc1Bvb2w6OnBsYXRmb3JtSW5pdGlhbGl6ZU5ldHdvcmtQcm9jZXNzKToKKwogMjAx OS0wMi0wNCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtK U0NdIFNocmluayBzaXplIG9mIFZNIGJ5IGxhemlseSBhbGxvY2F0aW5nIElzb1N1YnNwYWNlcyBm b3Igbm9uLWNvbW1vbiB0eXBlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv c291cC9XZWJQcm9jZXNzUG9vbFNvdXAuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mvc291 cC9XZWJQcm9jZXNzUG9vbFNvdXAuY3BwCmluZGV4IDc4NTIyOTJiY2Y4NDZiZjhiNmY2YzM4NTFi ZjZkMDEzMzM0MzQ0NmIuLmI0NDJmNjcwMjUyM2U2MDE3NmVlYzk0YjdjNWZhMzhiMWJlYzdiMDkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL3NvdXAvV2ViUHJvY2Vzc1Bvb2xT b3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9zb3VwL1dlYlByb2Nlc3NQb29s U291cC5jcHAKQEAgLTM4LDYgKzM4LDkgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiAKIHZvaWQgV2Vi UHJvY2Vzc1Bvb2w6OnBsYXRmb3JtSW5pdGlhbGl6ZU5ldHdvcmtQcm9jZXNzKE5ldHdvcmtQcm9j ZXNzQ3JlYXRpb25QYXJhbWV0ZXJzJiBwYXJhbWV0ZXJzKQogeworICAgIE5ldHdvcmtTZXNzaW9u Q3JlYXRpb25QYXJhbWV0ZXJzJiBkZWZhdWx0U2Vzc2lvblBhcmFtZXRlcnMgPSBwYXJhbWV0ZXJz LmRlZmF1bHREYXRhU3RvcmVQYXJhbWV0ZXJzLm5ldHdvcmtTZXNzaW9uUGFyYW1ldGVyczsKKyAg ICBzdXBwbGVtZW50PFdlYkNvb2tpZU1hbmFnZXJQcm94eT4oKS0+Z2V0Q29va2llUGVyc2lzdGVu dFN0b3JhZ2UoZGVmYXVsdFNlc3Npb25QYXJhbWV0ZXJzLnNlc3Npb25JRCwgZGVmYXVsdFNlc3Np b25QYXJhbWV0ZXJzLmNvb2tpZVBlcnNpc3RlbnRTdG9yYWdlUGF0aCwgZGVmYXVsdFNlc3Npb25Q YXJhbWV0ZXJzLmNvb2tpZVBlcnNpc3RlbnRTdG9yYWdlVHlwZSk7CisKICAgICBwYXJhbWV0ZXJz LmNvb2tpZUFjY2VwdFBvbGljeSA9IG1faW5pdGlhbEhUVFBDb29raWVBY2NlcHRQb2xpY3k7CiAg ICAgcGFyYW1ldGVycy5pZ25vcmVUTFNFcnJvcnMgPSBtX2lnbm9yZVRMU0Vycm9yczsKICAgICBw YXJhbWV0ZXJzLmxhbmd1YWdlcyA9IHVzZXJQcmVmZXJyZWRMYW5ndWFnZXMoKTsKZGlmZiAtLWdp dCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiN2I5ZDIzNTZjY2Jl OWU4MGNlYjcwMWQxNmQ2MWVlYWMzZmI3NGI5Li41N2ZlNzFkOWVjZTJiYjU0MGM1NjcyNGZlZjcw ZjEzMjQzMTRjNzgzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDItMDUgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjI0MDc4NSk6IFtT T1VQXSBCcm9rZSBjb29raWUgcGVyc2lzdGVudCBzdG9yYWdlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQyMDkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbmhhbmNlIFRlc3RDb29raWVNYW5hZ2VyIHRv IGVuc3VyZSB0aGlzIGRvZXNuJ3QgaGFwcGVuIGFnYWluLgorCisgICAgICAgICogVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rlc3RDb29raWVNYW5hZ2VyLmNwcDoKKyAgICAgICAgKHRl c3RDb29raWVNYW5hZ2VyUGVyc2lzdGVudFN0b3JhZ2UpOgorICAgICAgICAoYmVmb3JlQWxsKToK KwogMjAxOS0wMi0wNCAgTXMyZ2VyICA8TXMyZ2VyQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dU S11bV1BFXSBOZWVkIGEgZnVuY3Rpb24gdG8gY29udmVydCBpbnRlcm5hbCBVUkkgdG8gZGlzcGxh eSAoInByZXR0eSIpIFVSSQpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9X ZWJLaXRHTGliL1Rlc3RDb29raWVNYW5hZ2VyLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvV2ViS2l0R0xpYi9UZXN0Q29va2llTWFuYWdlci5jcHAKaW5kZXggOWU0OGQyZTdjODQ0MTE4 MGNkYmQwMjM2YWVjNzY0YmI2YjZjMTFjYi4uNWQ2M2Q0ODI3MDdkNzA1MTdhNTBlZjQwMWU1OTRh OTI5OWQyZTA1MSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRH TGliL1Rlc3RDb29raWVNYW5hZ2VyLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dlYktpdEdMaWIvVGVzdENvb2tpZU1hbmFnZXIuY3BwCkBAIC01Niw5ICs1Niw5IEBAIHB1Ymxp YzoKIAogICAgIENvb2tpZU1hbmFnZXJUZXN0KCkKICAgICAgICAgOiBXZWJWaWV3VGVzdCgpCi0g ICAgICAgICwgbV9jb29raWVNYW5hZ2VyKHdlYmtpdF93ZWJfY29udGV4dF9nZXRfY29va2llX21h bmFnZXIod2Via2l0X3dlYl92aWV3X2dldF9jb250ZXh0KG1fd2ViVmlldykpKQorICAgICAgICAs IG1fY29va2llTWFuYWdlcih3ZWJraXRfd2ViX2NvbnRleHRfZ2V0X2Nvb2tpZV9tYW5hZ2VyKG1f d2ViQ29udGV4dC5nZXQoKSkpCiAgICAgewotICAgICAgICBnX2Fzc2VydF90cnVlKHdlYmtpdF93 ZWJzaXRlX2RhdGFfbWFuYWdlcl9nZXRfY29va2llX21hbmFnZXIod2Via2l0X3dlYl9jb250ZXh0 X2dldF93ZWJzaXRlX2RhdGFfbWFuYWdlcih3ZWJraXRfd2ViX3ZpZXdfZ2V0X2NvbnRleHQobV93 ZWJWaWV3KSkpID09IG1fY29va2llTWFuYWdlcik7CisgICAgICAgIGdfYXNzZXJ0X3RydWUod2Vi a2l0X3dlYnNpdGVfZGF0YV9tYW5hZ2VyX2dldF9jb29raWVfbWFuYWdlcih3ZWJraXRfd2ViX2Nv bnRleHRfZ2V0X3dlYnNpdGVfZGF0YV9tYW5hZ2VyKG1fd2ViQ29udGV4dC5nZXQoKSkpID09IG1f Y29va2llTWFuYWdlcik7CiAgICAgICAgIGdfc2lnbmFsX2Nvbm5lY3QobV9jb29raWVNYW5hZ2Vy LCAiY2hhbmdlZCIsIEdfQ0FMTEJBQ0soY29va2llc0NoYW5nZWRDYWxsYmFjayksIHRoaXMpOwog ICAgIH0KIApAQCAtNTM1LDIzICs1MzUsNDQgQEAgc3RhdGljIHZvaWQgdGVzdENvb2tpZU1hbmFn ZXJDb29raWVzQ2hhbmdlZChDb29raWVNYW5hZ2VyVGVzdCogdGVzdCwgZ2NvbnN0cG9pbnQKICAg ICBnX2Fzc2VydF90cnVlKHRlc3QtPm1fY29va2llc0NoYW5nZWQpOwogfQogCi1zdGF0aWMgdm9p ZCB0ZXN0Q29va2llTWFuYWdlclBlcnNpc3RlbnRTdG9yYWdlKENvb2tpZU1hbmFnZXJUZXN0KiB0 ZXN0LCBnY29uc3Rwb2ludGVyKQorY2xhc3MgQ29va2llUGVyc2lzdGVudFN0b3JhZ2VUZXN0OiBw dWJsaWMgQ29va2llTWFuYWdlclRlc3QgeworcHVibGljOgorICAgIE1BS0VfR0xJQl9URVNUX0ZJ WFRVUkVfV0lUSF9TRVRVUF9URUFSRE9XTihDb29raWVQZXJzaXN0ZW50U3RvcmFnZVRlc3QsIHNl dHVwLCB0ZWFyZG93bik7CisKKyAgICBzdGF0aWMgdm9pZCBzZXR1cCgpCisgICAgeworICAgICAg ICBXZWJWaWV3VGVzdDo6c2hvdWxkSW5pdGlhbGl6ZVdlYlZpZXdJbkNvbnN0cnVjdG9yID0gZmFs c2U7CisgICAgfQorCisgICAgc3RhdGljIHZvaWQgdGVhcmRvd24oKQorICAgIHsKKyAgICAgICAg V2ViVmlld1Rlc3Q6OnNob3VsZEluaXRpYWxpemVXZWJWaWV3SW5Db25zdHJ1Y3RvciA9IHRydWU7 CisgICAgfQorfTsKKworc3RhdGljIHZvaWQgdGVzdENvb2tpZU1hbmFnZXJQZXJzaXN0ZW50U3Rv cmFnZShDb29raWVQZXJzaXN0ZW50U3RvcmFnZVRlc3QqIHRlc3QsIGdjb25zdHBvaW50ZXIpCiB7 CiAgICAgdGVzdC0+c2V0QWNjZXB0UG9saWN5KFdFQktJVF9DT09LSUVfUE9MSUNZX0FDQ0VQVF9B TFdBWVMpOwogCisgICAgZ191bmxpbmsodGVzdC0+bV9jb29raWVzVGV4dEZpbGUuZ2V0KCkpOwor ICAgIGdfdW5saW5rKHRlc3QtPm1fY29va2llc1NRTGl0ZUZpbGUuZ2V0KCkpOworCiAgICAgLy8g VGV4dCBzdG9yYWdlIHVzaW5nIGEgbmV3IGZpbGUuCiAgICAgdGVzdC0+c2V0UGVyc2lzdGVudFN0 b3JhZ2UoV0VCS0lUX0NPT0tJRV9QRVJTSVNURU5UX1NUT1JBR0VfVEVYVCk7CiAgICAgY2hhcioq IGRvbWFpbnMgPSB0ZXN0LT5nZXREb21haW5zKCk7CiAgICAgZ19hc3NlcnRfbm9ubnVsbChkb21h aW5zKTsKICAgICBnX2Fzc2VydF9jbXBpbnQoZ19zdHJ2X2xlbmd0aChkb21haW5zKSwgPT0sIDAp OwogCisgICAgLy8gSW5pdGlhbGl6YXRpb24gb2Ygd2ViIHZpZXcgaXMgZGVmZXJyZWQgdG8gZW5z dXJlIGl0J3Mgbm90IHJlcXVpcmVkIGZvcgorICAgIC8vIHNldHRpbmcgcGVyc2lzdGVudCBzdG9y YWdlIHRvIHdvcmsuCisgICAgdGVzdC0+aW5pdGlhbGl6ZVdlYlZpZXcoKTsKICAgICB0ZXN0LT5s b2FkVVJJKGtTZXJ2ZXItPmdldFVSSUZvclBhdGgoIi9pbmRleC5odG1sIikuZGF0YSgpKTsKICAg ICB0ZXN0LT53YWl0VW50aWxMb2FkRmluaXNoZWQoKTsKICAgICBnX2Fzc2VydF90cnVlKHRlc3Qt Pm1fY29va2llc0NoYW5nZWQpOwogICAgIGRvbWFpbnMgPSB0ZXN0LT5nZXREb21haW5zKCk7CiAg ICAgZ19hc3NlcnRfbm9ubnVsbChkb21haW5zKTsKICAgICBnX2Fzc2VydF9jbXBpbnQoZ19zdHJ2 X2xlbmd0aChkb21haW5zKSwgPT0sIDIpOwotCisgICAgZ19hc3NlcnRfdHJ1ZShnX2ZpbGVfdGVz dCh0ZXN0LT5tX2Nvb2tpZXNUZXh0RmlsZS5nZXQoKSwgR19GSUxFX1RFU1RfRVhJU1RTKSk7CiAK ICAgICAvLyBTUUxpdGUgc3RvcmFnZSB1c2luZyBhIG5ldyBmaWxlLgogICAgIHRlc3QtPnNldFBl cnNpc3RlbnRTdG9yYWdlKFdFQktJVF9DT09LSUVfUEVSU0lTVEVOVF9TVE9SQUdFX1NRTElURSk7 CkBAIC01NjUsNiArNTg2LDcgQEAgc3RhdGljIHZvaWQgdGVzdENvb2tpZU1hbmFnZXJQZXJzaXN0 ZW50U3RvcmFnZShDb29raWVNYW5hZ2VyVGVzdCogdGVzdCwgZ2NvbnN0cG8KICAgICBkb21haW5z ID0gdGVzdC0+Z2V0RG9tYWlucygpOwogICAgIGdfYXNzZXJ0X25vbm51bGwoZG9tYWlucyk7CiAg ICAgZ19hc3NlcnRfY21waW50KGdfc3Rydl9sZW5ndGgoZG9tYWlucyksID09LCAyKTsKKyAgICBn X2Fzc2VydF90cnVlKGdfZmlsZV90ZXN0KHRlc3QtPm1fY29va2llc1NRTGl0ZUZpbGUuZ2V0KCks IEdfRklMRV9URVNUX0VYSVNUUykpOwogCiAgICAgLy8gVGV4dCBzdG9yYWdlIHVzaW5nIGFuIGV4 aXN0aW5nIGZpbGUuCiAgICAgdGVzdC0+c2V0UGVyc2lzdGVudFN0b3JhZ2UoV0VCS0lUX0NPT0tJ RV9QRVJTSVNURU5UX1NUT1JBR0VfVEVYVCk7CkBAIC02OTgsNyArNzIwLDcgQEAgdm9pZCBiZWZv cmVBbGwoKQogICAgIENvb2tpZU1hbmFnZXJUZXN0OjphZGQoIldlYktpdENvb2tpZU1hbmFnZXIi LCAiZGVsZXRlLWNvb2tpZSIsIHRlc3RDb29raWVNYW5hZ2VyRGVsZXRlQ29va2llKTsKICAgICBD b29raWVNYW5hZ2VyVGVzdDo6YWRkKCJXZWJLaXRDb29raWVNYW5hZ2VyIiwgImRlbGV0ZS1jb29r aWVzIiwgdGVzdENvb2tpZU1hbmFnZXJEZWxldGVDb29raWVzKTsKICAgICBDb29raWVNYW5hZ2Vy VGVzdDo6YWRkKCJXZWJLaXRDb29raWVNYW5hZ2VyIiwgImNvb2tpZXMtY2hhbmdlZCIsIHRlc3RD b29raWVNYW5hZ2VyQ29va2llc0NoYW5nZWQpOwotICAgIENvb2tpZU1hbmFnZXJUZXN0OjphZGQo IldlYktpdENvb2tpZU1hbmFnZXIiLCAicGVyc2lzdGVudC1zdG9yYWdlIiwgdGVzdENvb2tpZU1h bmFnZXJQZXJzaXN0ZW50U3RvcmFnZSk7CisgICAgQ29va2llUGVyc2lzdGVudFN0b3JhZ2VUZXN0 OjphZGQoIldlYktpdENvb2tpZU1hbmFnZXIiLCAicGVyc2lzdGVudC1zdG9yYWdlIiwgdGVzdENv b2tpZU1hbmFnZXJQZXJzaXN0ZW50U3RvcmFnZSk7CiAgICAgQ29va2llTWFuYWdlclRlc3Q6OmFk ZCgiV2ViS2l0Q29va2llTWFuYWdlciIsICJwZXJzaXN0ZW50LXN0b3JhZ2UtZGVsZXRlLWFsbCIs IHRlc3RDb29raWVNYW5hZ2VyUGVyc2lzdGVudFN0b3JhZ2VEZWxldGVBbGwpOwogICAgIENvb2tp ZU1hbmFnZXJUZXN0OjphZGQoIldlYktpdENvb2tpZU1hbmFnZXIiLCAiZXBoZW1lcmFsIiwgdGVz dENvb2tpZU1hbmFnZXJFcGhlbWVyYWwpOwogfQo=