194202 2019-02-03 05:51:43 -0800 REGRESSION(r240896): "Fixes leaks, but is probably not the correct fix." (Requested by ddkilzer on #webkit). 2019-02-03 05:54:28 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 193291 1 commit-queue commit-queue ddkilzer keith_miller webkit-bug-importer oldest_to_newest 1501612 0 commit-queue 2019-02-03 05:51:43 -0800 https://trac.webkit.org/changeset/240896 broke the build: "Fixes leaks, but is probably not the correct fix." (Requested by ddkilzer on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1501614 1 361012 commit-queue 2019-02-03 05:51:49 -0800 Created attachment 361012 ROLLOUT of r240896 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1501615 2 361012 commit-queue 2019-02-03 05:54:00 -0800 Comment on attachment 361012 ROLLOUT of r240896 Clearing flags on attachment: 361012 Committed r240903: <https://trac.webkit.org/changeset/240903> 1501616 3 commit-queue 2019-02-03 05:54:01 -0800 All reviewed patches have been landed. Closing bug. 1501617 4 webkit-bug-importer 2019-02-03 05:54:28 -0800 <rdar://problem/47769873> 361012 2019-02-03 05:51:49 -0800 2019-02-03 05:54:00 -0800 ROLLOUT of r240896 bug-194202-20190203055148.patch text/plain 1752 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwOTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDM4NjQ3MTUzNDdkYjNhNTlkMmI0Mzdm MDc2MTRiN2JjMzExMzJkYjMuLjEzY2E5MjIxZmQ5ZTFlMjAzOGZlNDI0YjlmNjEzY2FhZjA4NDVl MzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDItMDMgIENvbW1pdCBRdWV1ZSAgPGNvbW1p dC1xdWV1ZUB3ZWJraXQub3JnPgorCisgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIy NDA4OTYuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTQyMDIKKworICAgICAgICAiRml4ZXMgbGVha3MsIGJ1dCBpcyBwcm9iYWJseSBub3QgdGhlIGNv cnJlY3QgZml4LiIgKFJlcXVlc3RlZAorICAgICAgICBieSBkZGtpbHplciBvbiAjd2Via2l0KS4K KworICAgICAgICBSZXZlcnRlZCBjaGFuZ2VzZXQ6CisKKyAgICAgICAgIkxlYWsgb2YgV1RGOjpT dHJpbmdJbXBsIHVuZGVyIFN5bWJvbEltcGw6OmNyZWF0ZU51bGxTeW1ib2woKQorICAgICAgICAo NDggYnl0ZXMpIGluIGNvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudCBydW5uaW5nIGxheW91dAor ICAgICAgICB0ZXN0cyIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE5MzI5MQorICAgICAgICBodHRwczovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQv MjQwODk2CisKIDIwMTktMDItMDIgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4K IAogICAgICAgICBMZWFrIG9mIFdURjo6U3RyaW5nSW1wbCB1bmRlciBTeW1ib2xJbXBsOjpjcmVh dGVOdWxsU3ltYm9sKCkgKDQ4IGJ5dGVzKSBpbiBjb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQg cnVubmluZyBsYXlvdXQgdGVzdHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3lt Ym9sSW1wbC5oIGIvU291cmNlL1dURi93dGYvdGV4dC9TeW1ib2xJbXBsLmgKaW5kZXggZTA4MmUx ZTljMWZjNWNlYzU4MzI1MGVmYjU4NWJiYjI1ZmFhMjllNC4uNDJmZjAzNmY3ZmQ1NjgzOTVmYTc4 MDhiZGU3NDhjNDM1M2U4ZTNkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4dC9TeW1i b2xJbXBsLmgKKysrIGIvU291cmNlL1dURi93dGYvdGV4dC9TeW1ib2xJbXBsLmgKQEAgLTExNiwx MyArMTE2LDYgQEAgcHJvdGVjdGVkOgogICAgICAgICBBU1NFUlQoU3RyaW5nSW1wbDo6dGFpbE9m ZnNldDxTdHJpbmdJbXBsKj4oKSA9PSBPQkpFQ1RfT0ZGU0VUT0YoU3ltYm9sSW1wbCwgbV9vd25l cikpOwogICAgIH0KIAotICAgIH5TeW1ib2xJbXBsKCkKLSAgICB7Ci0gICAgICAgIGlmIChtX293 bmVyICE9IFN0cmluZ0ltcGw6OmVtcHR5KCkpCi0gICAgICAgICAgICBtX293bmVyLT5kZXJlZigp OwotICAgICAgICBtX293bmVyID0gbnVsbHB0cjsKLSAgICB9Ci0KICAgICAvLyBUaGUgcG9pbnRl ciB0byB0aGUgb3duZXIgc3RyaW5nIHNob3VsZCBiZSBpbW1lZGlhdGVseSBmb2xsb3dpbmcgYWZ0 ZXIgdGhlIFN0cmluZ0ltcGwgbGF5b3V0LAogICAgIC8vIHNpbmNlIHdlIHdvdWxkIGxpa2UgdG8g YWxpZ24gdGhlIGxheW91dCBvZiBTeW1ib2xJbXBsIHRvIHRoZSBvbmUgb2YgQnVmZmVyU3Vic3Ry aW5nIFN0cmluZ0ltcGwuCiAgICAgU3RyaW5nSW1wbCogbV9vd25lcjsK