194201 2019-02-03 05:37:03 -0800 [GTK] Allow pinch zoom on touchpad 2019-02-05 08:03:05 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Enhancement --- 1 alicem webkit-unassigned berto bugs-noreply cgarcia commit-queue ews-watchlist gustavo mcatanzaro webkit-bug-importer oldest_to_newest 1501608 0 alicem 2019-02-03 05:37:03 -0800 A follow-up to bug 193919, another touchpad gesture missing in GTK port. 1501609 1 361011 alicem 2019-02-03 05:43:51 -0800 Created attachment 361011 Patch 1501610 2 ews-watchlist 2019-02-03 05:46:27 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1501660 3 361011 mcatanzaro 2019-02-03 12:32:47 -0800 Comment on attachment 361011 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361011&action=review Does this depend on the other patch? If not, you can request cq? for commit-queue. > Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1202 > + if (event->type == GDK_TOUCHPAD_PINCH) { > + WebKitWebViewBase* webViewBase = WEBKIT_WEB_VIEW_BASE(widget); > + GestureController& controller = webkitWebViewBaseGestureController(webViewBase); > + controller.handleEvent(event); > + } Style: just do it on one line: if (event->type == GDK_TOUCHPAD_PINCH) webkitWebViewBaseGestureController(WEBKIT_WEB_VIEW_BASE(widget)).handleEvent(event); In C it would be too hard to read if we don't use multiple lines, but this is C++. :) 1501661 4 361023 alicem 2019-02-03 12:36:49 -0800 Created attachment 361023 Patch 1501663 5 alicem 2019-02-03 12:37:43 -0800 > Does this depend on the other patch? No > just do it on one line: Ok 1501680 6 361028 alicem 2019-02-03 14:07:35 -0800 Created attachment 361028 Patch 1501684 7 361030 alicem 2019-02-03 14:20:52 -0800 Created attachment 361030 Patch 1501685 8 alicem 2019-02-03 14:21:23 -0800 I've added #if HAVE(GTK_GESTURES) checks around the added code. 1501721 9 361030 mcatanzaro 2019-02-03 18:31:43 -0800 Comment on attachment 361030 Patch Remember to request cq? for commit queue when it's ready to land! 1501773 10 alicem 2019-02-04 00:29:28 -0800 > Remember to request cq? for commit queue when it's ready to land! Done 1501820 11 361030 commit-queue 2019-02-04 07:47:12 -0800 Comment on attachment 361030 Patch Clearing flags on attachment: 361030 Committed r240922: <https://trac.webkit.org/changeset/240922> 1501821 12 commit-queue 2019-02-04 07:47:14 -0800 All reviewed patches have been landed. Closing bug. 361011 2019-02-03 05:43:51 -0800 2019-02-03 12:36:43 -0800 Patch bug-194201-20190203184349.patch text/plain 2774 alicem U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwOTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI5Njc4YzJjMjM3YWYwNWE1 MjQ5ZjgzY2UxN2JkMzgzMTNkODRjMGUuLjJlMjFkMzFlM2FhMzE2N2VhYTFiOTgwMjQzODhiY2E1 NmRjOGM2ZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDItMDMgIEFsZXhhbmRl ciBNaWtoYXlsZW5rbyAgPGV4YWxtNzY1OUBnbWFpbC5jb20+CisKKyAgICAgICAgW0dUS10gQWxs b3cgcGluY2ggem9vbSBvbiB0b3VjaHBhZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MjAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRW5hYmxlIHRvdWNocGFkIGV2ZW50cyBmb3IgV2Via2l0V2ViVmll d0Jhc2UsIHRoZW4gZmVlZCB0b3VjaHBhZAorICAgICAgICBwaW5jaCBldmVudHMgdG8gR2VzdHVy ZUNvbnRyb2xsZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3 QmFzZS5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZVJlYWxpemUpOiBBZGRlZCBHREtf VE9VQ0hQQURfR0VTVFVSRV9NQVNLIHRvIGV2ZW50IG1hc2suCisgICAgICAgICh3ZWJraXRXZWJW aWV3QmFzZUV2ZW50KTogQWRkZWQuCisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfYmFzZV9jbGFz c19pbml0KTogT3ZlcnJpZGUgZXZlbnQgdmZ1bmMuCisKIDIwMTktMDItMDMgIE1lZ2FuIEdhcmRu ZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBUdXJuIG9uIFNtYXJ0IFBh c3RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdl YlZpZXdCYXNlLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2Vi Vmlld0Jhc2UuY3BwCmluZGV4IGUyMjRhMWU2NTczNWUwNDNlZDJjZTc2YWUxYjY1NzllNWM5MGFl NzMuLjYxY2E5YjkyMWRjYjVjYzJhMzYxYTQ2Yjk2NjI3YzQ5NDRmMDdhZDIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3Bw CkBAIC0zNjMsNyArMzYzLDggQEAgc3RhdGljIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VSZWFsaXpl KEd0a1dpZGdldCogd2lkZ2V0KQogICAgICAgICB8IEdES19CVVRUT04xX01PVElPTl9NQVNLCiAg ICAgICAgIHwgR0RLX0JVVFRPTjJfTU9USU9OX01BU0sKICAgICAgICAgfCBHREtfQlVUVE9OM19N T1RJT05fTUFTSwotICAgICAgICB8IEdES19UT1VDSF9NQVNLOworICAgICAgICB8IEdES19UT1VD SF9NQVNLCisgICAgICAgIHwgR0RLX1RPVUNIUEFEX0dFU1RVUkVfTUFTSzsKIAogICAgIGdpbnQg YXR0cmlidXRlc01hc2sgPSBHREtfV0FfWCB8IEdES19XQV9ZIHwgR0RLX1dBX1ZJU1VBTDsKIApA QCAtMTE5Miw2ICsxMTkzLDE3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlRHJhZ0Rh dGFSZWNlaXZlZChHdGtXaWRnZXQqIHdpZGdldCwgR2RrRHJhZ0NvbnRleHQqCiB9CiAjZW5kaWYg Ly8gRU5BQkxFKERSQUdfU1VQUE9SVCkKIAorc3RhdGljIGdib29sZWFuIHdlYmtpdFdlYlZpZXdC YXNlRXZlbnQoR3RrV2lkZ2V0KiB3aWRnZXQsIEdka0V2ZW50KiBldmVudCkKK3sKKyAgICBpZiAo ZXZlbnQtPnR5cGUgPT0gR0RLX1RPVUNIUEFEX1BJTkNIKSB7CisgICAgICAgIFdlYktpdFdlYlZp ZXdCYXNlKiB3ZWJWaWV3QmFzZSA9IFdFQktJVF9XRUJfVklFV19CQVNFKHdpZGdldCk7CisgICAg ICAgIEdlc3R1cmVDb250cm9sbGVyJiBjb250cm9sbGVyID0gd2Via2l0V2ViVmlld0Jhc2VHZXN0 dXJlQ29udHJvbGxlcih3ZWJWaWV3QmFzZSk7CisgICAgICAgIGNvbnRyb2xsZXIuaGFuZGxlRXZl bnQoZXZlbnQpOworICAgIH0KKworICAgIHJldHVybiBHREtfRVZFTlRfUFJPUEFHQVRFOworfQor CiBzdGF0aWMgQXRrT2JqZWN0KiB3ZWJraXRXZWJWaWV3QmFzZUdldEFjY2Vzc2libGUoR3RrV2lk Z2V0KiB3aWRnZXQpCiB7CiAgICAgLy8gSWYgdGhlIHNvY2tldCBoYXMgYWxyZWFkeSBiZWVuIGNy ZWF0ZWQgYW5kIGVtYmVkZGVkIGEgcGx1ZyBJRCwgcmV0dXJuIGl0LgpAQCAtMTMxNSw2ICsxMzI3 LDcgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X2Jhc2VfY2xhc3NfaW5pdChXZWJLaXRX ZWJWaWV3QmFzZUNsYXNzKiB3ZWJraXRXZWJWaWUKICAgICB3aWRnZXRDbGFzcy0+ZHJhZ19kcm9w ID0gd2Via2l0V2ViVmlld0Jhc2VEcmFnRHJvcDsKICAgICB3aWRnZXRDbGFzcy0+ZHJhZ19kYXRh X3JlY2VpdmVkID0gd2Via2l0V2ViVmlld0Jhc2VEcmFnRGF0YVJlY2VpdmVkOwogI2VuZGlmIC8v IEVOQUJMRShEUkFHX1NVUFBPUlQpCisgICAgd2lkZ2V0Q2xhc3MtPmV2ZW50ID0gd2Via2l0V2Vi Vmlld0Jhc2VFdmVudDsKICAgICB3aWRnZXRDbGFzcy0+Z2V0X2FjY2Vzc2libGUgPSB3ZWJraXRX ZWJWaWV3QmFzZUdldEFjY2Vzc2libGU7CiAgICAgd2lkZ2V0Q2xhc3MtPmhpZXJhcmNoeV9jaGFu Z2VkID0gd2Via2l0V2ViVmlld0Jhc2VIaWVyYXJjaHlDaGFuZ2VkOwogICAgIHdpZGdldENsYXNz LT5kZXN0cm95ID0gd2Via2l0V2ViVmlld0Jhc2VEZXN0cm95Owo= 361023 2019-02-03 12:36:49 -0800 2019-02-03 14:07:28 -0800 Patch bug-194201-20190204013648.patch text/plain 2657 alicem U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwOTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI5Njc4YzJjMjM3YWYwNWE1 MjQ5ZjgzY2UxN2JkMzgzMTNkODRjMGUuLjJlMjFkMzFlM2FhMzE2N2VhYTFiOTgwMjQzODhiY2E1 NmRjOGM2ZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDItMDMgIEFsZXhhbmRl ciBNaWtoYXlsZW5rbyAgPGV4YWxtNzY1OUBnbWFpbC5jb20+CisKKyAgICAgICAgW0dUS10gQWxs b3cgcGluY2ggem9vbSBvbiB0b3VjaHBhZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MjAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRW5hYmxlIHRvdWNocGFkIGV2ZW50cyBmb3IgV2Via2l0V2ViVmll d0Jhc2UsIHRoZW4gZmVlZCB0b3VjaHBhZAorICAgICAgICBwaW5jaCBldmVudHMgdG8gR2VzdHVy ZUNvbnRyb2xsZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3 QmFzZS5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZVJlYWxpemUpOiBBZGRlZCBHREtf VE9VQ0hQQURfR0VTVFVSRV9NQVNLIHRvIGV2ZW50IG1hc2suCisgICAgICAgICh3ZWJraXRXZWJW aWV3QmFzZUV2ZW50KTogQWRkZWQuCisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfYmFzZV9jbGFz c19pbml0KTogT3ZlcnJpZGUgZXZlbnQgdmZ1bmMuCisKIDIwMTktMDItMDMgIE1lZ2FuIEdhcmRu ZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBUdXJuIG9uIFNtYXJ0IFBh c3RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdl YlZpZXdCYXNlLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2Vi Vmlld0Jhc2UuY3BwCmluZGV4IGUyMjRhMWU2NTczNWUwNDNlZDJjZTc2YWUxYjY1NzllNWM5MGFl NzMuLmUzNzBjMjFlMWE2ODZmMGQ1MThhN2I1YjNlYzhhOTVmZWE3ZDE5YzEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3Bw CkBAIC0zNjMsNyArMzYzLDggQEAgc3RhdGljIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VSZWFsaXpl KEd0a1dpZGdldCogd2lkZ2V0KQogICAgICAgICB8IEdES19CVVRUT04xX01PVElPTl9NQVNLCiAg ICAgICAgIHwgR0RLX0JVVFRPTjJfTU9USU9OX01BU0sKICAgICAgICAgfCBHREtfQlVUVE9OM19N T1RJT05fTUFTSwotICAgICAgICB8IEdES19UT1VDSF9NQVNLOworICAgICAgICB8IEdES19UT1VD SF9NQVNLCisgICAgICAgIHwgR0RLX1RPVUNIUEFEX0dFU1RVUkVfTUFTSzsKIAogICAgIGdpbnQg YXR0cmlidXRlc01hc2sgPSBHREtfV0FfWCB8IEdES19XQV9ZIHwgR0RLX1dBX1ZJU1VBTDsKIApA QCAtMTE5Miw2ICsxMTkzLDE0IEBAIHN0YXRpYyB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlRHJhZ0Rh dGFSZWNlaXZlZChHdGtXaWRnZXQqIHdpZGdldCwgR2RrRHJhZ0NvbnRleHQqCiB9CiAjZW5kaWYg Ly8gRU5BQkxFKERSQUdfU1VQUE9SVCkKIAorc3RhdGljIGdib29sZWFuIHdlYmtpdFdlYlZpZXdC YXNlRXZlbnQoR3RrV2lkZ2V0KiB3aWRnZXQsIEdka0V2ZW50KiBldmVudCkKK3sKKyAgICBpZiAo ZXZlbnQtPnR5cGUgPT0gR0RLX1RPVUNIUEFEX1BJTkNIKQorICAgICAgICB3ZWJraXRXZWJWaWV3 QmFzZUdlc3R1cmVDb250cm9sbGVyKFdFQktJVF9XRUJfVklFV19CQVNFKHdpZGdldCkpLmhhbmRs ZUV2ZW50KGV2ZW50KTsKKworICAgIHJldHVybiBHREtfRVZFTlRfUFJPUEFHQVRFOworfQorCiBz dGF0aWMgQXRrT2JqZWN0KiB3ZWJraXRXZWJWaWV3QmFzZUdldEFjY2Vzc2libGUoR3RrV2lkZ2V0 KiB3aWRnZXQpCiB7CiAgICAgLy8gSWYgdGhlIHNvY2tldCBoYXMgYWxyZWFkeSBiZWVuIGNyZWF0 ZWQgYW5kIGVtYmVkZGVkIGEgcGx1ZyBJRCwgcmV0dXJuIGl0LgpAQCAtMTMxNSw2ICsxMzI0LDcg QEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X2Jhc2VfY2xhc3NfaW5pdChXZWJLaXRXZWJW aWV3QmFzZUNsYXNzKiB3ZWJraXRXZWJWaWUKICAgICB3aWRnZXRDbGFzcy0+ZHJhZ19kcm9wID0g d2Via2l0V2ViVmlld0Jhc2VEcmFnRHJvcDsKICAgICB3aWRnZXRDbGFzcy0+ZHJhZ19kYXRhX3Jl Y2VpdmVkID0gd2Via2l0V2ViVmlld0Jhc2VEcmFnRGF0YVJlY2VpdmVkOwogI2VuZGlmIC8vIEVO QUJMRShEUkFHX1NVUFBPUlQpCisgICAgd2lkZ2V0Q2xhc3MtPmV2ZW50ID0gd2Via2l0V2ViVmll d0Jhc2VFdmVudDsKICAgICB3aWRnZXRDbGFzcy0+Z2V0X2FjY2Vzc2libGUgPSB3ZWJraXRXZWJW aWV3QmFzZUdldEFjY2Vzc2libGU7CiAgICAgd2lkZ2V0Q2xhc3MtPmhpZXJhcmNoeV9jaGFuZ2Vk ID0gd2Via2l0V2ViVmlld0Jhc2VIaWVyYXJjaHlDaGFuZ2VkOwogICAgIHdpZGdldENsYXNzLT5k ZXN0cm95ID0gd2Via2l0V2ViVmlld0Jhc2VEZXN0cm95Owo= 361028 2019-02-03 14:07:35 -0800 2019-02-03 14:20:46 -0800 Patch bug-194201-20190204030734.patch text/plain 2689 alicem U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwOTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI5Njc4YzJjMjM3YWYwNWE1 MjQ5ZjgzY2UxN2JkMzgzMTNkODRjMGUuLjJlMjFkMzFlM2FhMzE2N2VhYTFiOTgwMjQzODhiY2E1 NmRjOGM2ZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDItMDMgIEFsZXhhbmRl ciBNaWtoYXlsZW5rbyAgPGV4YWxtNzY1OUBnbWFpbC5jb20+CisKKyAgICAgICAgW0dUS10gQWxs b3cgcGluY2ggem9vbSBvbiB0b3VjaHBhZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MjAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRW5hYmxlIHRvdWNocGFkIGV2ZW50cyBmb3IgV2Via2l0V2ViVmll d0Jhc2UsIHRoZW4gZmVlZCB0b3VjaHBhZAorICAgICAgICBwaW5jaCBldmVudHMgdG8gR2VzdHVy ZUNvbnRyb2xsZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3 QmFzZS5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZVJlYWxpemUpOiBBZGRlZCBHREtf VE9VQ0hQQURfR0VTVFVSRV9NQVNLIHRvIGV2ZW50IG1hc2suCisgICAgICAgICh3ZWJraXRXZWJW aWV3QmFzZUV2ZW50KTogQWRkZWQuCisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfYmFzZV9jbGFz c19pbml0KTogT3ZlcnJpZGUgZXZlbnQgdmZ1bmMuCisKIDIwMTktMDItMDMgIE1lZ2FuIEdhcmRu ZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBUdXJuIG9uIFNtYXJ0IFBh c3RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdl YlZpZXdCYXNlLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2Vi Vmlld0Jhc2UuY3BwCmluZGV4IGUyMjRhMWU2NTczNWUwNDNlZDJjZTc2YWUxYjY1NzllNWM5MGFl NzMuLjhjZWRlZmQ1ZTdhNzFkMWM3OThjZGNhNjI5NTg4ZjdlMzg4MWJiM2EgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3Bw CkBAIC0zNjMsNyArMzYzLDggQEAgc3RhdGljIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VSZWFsaXpl KEd0a1dpZGdldCogd2lkZ2V0KQogICAgICAgICB8IEdES19CVVRUT04xX01PVElPTl9NQVNLCiAg ICAgICAgIHwgR0RLX0JVVFRPTjJfTU9USU9OX01BU0sKICAgICAgICAgfCBHREtfQlVUVE9OM19N T1RJT05fTUFTSwotICAgICAgICB8IEdES19UT1VDSF9NQVNLOworICAgICAgICB8IEdES19UT1VD SF9NQVNLCisgICAgICAgIHwgR0RLX1RPVUNIUEFEX0dFU1RVUkVfTUFTSzsKIAogICAgIGdpbnQg YXR0cmlidXRlc01hc2sgPSBHREtfV0FfWCB8IEdES19XQV9ZIHwgR0RLX1dBX1ZJU1VBTDsKIApA QCAtMTE5Miw2ICsxMTkzLDE2IEBAIHN0YXRpYyB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlRHJhZ0Rh dGFSZWNlaXZlZChHdGtXaWRnZXQqIHdpZGdldCwgR2RrRHJhZ0NvbnRleHQqCiB9CiAjZW5kaWYg Ly8gRU5BQkxFKERSQUdfU1VQUE9SVCkKIAorc3RhdGljIGdib29sZWFuIHdlYmtpdFdlYlZpZXdC YXNlRXZlbnQoR3RrV2lkZ2V0KiB3aWRnZXQsIEdka0V2ZW50KiBldmVudCkKK3sKKyNpZiBIQVZF KEdUS19HRVNUVVJFUykKKyAgICBpZiAoZXZlbnQtPnR5cGUgPT0gR0RLX1RPVUNIUEFEX1BJTkNI KQorICAgICAgICB3ZWJraXRXZWJWaWV3QmFzZUdlc3R1cmVDb250cm9sbGVyKFdFQktJVF9XRUJf VklFV19CQVNFKHdpZGdldCkpLmhhbmRsZUV2ZW50KGV2ZW50KTsKKyNlbmRpZgorCisgICAgcmV0 dXJuIEdES19FVkVOVF9QUk9QQUdBVEU7Cit9CisKIHN0YXRpYyBBdGtPYmplY3QqIHdlYmtpdFdl YlZpZXdCYXNlR2V0QWNjZXNzaWJsZShHdGtXaWRnZXQqIHdpZGdldCkKIHsKICAgICAvLyBJZiB0 aGUgc29ja2V0IGhhcyBhbHJlYWR5IGJlZW4gY3JlYXRlZCBhbmQgZW1iZWRkZWQgYSBwbHVnIElE LCByZXR1cm4gaXQuCkBAIC0xMzE1LDYgKzEzMjYsNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2Vi X3ZpZXdfYmFzZV9jbGFzc19pbml0KFdlYktpdFdlYlZpZXdCYXNlQ2xhc3MqIHdlYmtpdFdlYlZp ZQogICAgIHdpZGdldENsYXNzLT5kcmFnX2Ryb3AgPSB3ZWJraXRXZWJWaWV3QmFzZURyYWdEcm9w OwogICAgIHdpZGdldENsYXNzLT5kcmFnX2RhdGFfcmVjZWl2ZWQgPSB3ZWJraXRXZWJWaWV3QmFz ZURyYWdEYXRhUmVjZWl2ZWQ7CiAjZW5kaWYgLy8gRU5BQkxFKERSQUdfU1VQUE9SVCkKKyAgICB3 aWRnZXRDbGFzcy0+ZXZlbnQgPSB3ZWJraXRXZWJWaWV3QmFzZUV2ZW50OwogICAgIHdpZGdldENs YXNzLT5nZXRfYWNjZXNzaWJsZSA9IHdlYmtpdFdlYlZpZXdCYXNlR2V0QWNjZXNzaWJsZTsKICAg ICB3aWRnZXRDbGFzcy0+aGllcmFyY2h5X2NoYW5nZWQgPSB3ZWJraXRXZWJWaWV3QmFzZUhpZXJh cmNoeUNoYW5nZWQ7CiAgICAgd2lkZ2V0Q2xhc3MtPmRlc3Ryb3kgPSB3ZWJraXRXZWJWaWV3QmFz ZURlc3Ryb3k7Cg== 361030 2019-02-03 14:20:52 -0800 2019-02-04 07:47:12 -0800 Patch bug-194201-20190204032051.patch text/plain 2679 alicem U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwOTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI5Njc4YzJjMjM3YWYwNWE1 MjQ5ZjgzY2UxN2JkMzgzMTNkODRjMGUuLjJlMjFkMzFlM2FhMzE2N2VhYTFiOTgwMjQzODhiY2E1 NmRjOGM2ZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDItMDMgIEFsZXhhbmRl ciBNaWtoYXlsZW5rbyAgPGV4YWxtNzY1OUBnbWFpbC5jb20+CisKKyAgICAgICAgW0dUS10gQWxs b3cgcGluY2ggem9vbSBvbiB0b3VjaHBhZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MjAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRW5hYmxlIHRvdWNocGFkIGV2ZW50cyBmb3IgV2Via2l0V2ViVmll d0Jhc2UsIHRoZW4gZmVlZCB0b3VjaHBhZAorICAgICAgICBwaW5jaCBldmVudHMgdG8gR2VzdHVy ZUNvbnRyb2xsZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3 QmFzZS5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZVJlYWxpemUpOiBBZGRlZCBHREtf VE9VQ0hQQURfR0VTVFVSRV9NQVNLIHRvIGV2ZW50IG1hc2suCisgICAgICAgICh3ZWJraXRXZWJW aWV3QmFzZUV2ZW50KTogQWRkZWQuCisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfYmFzZV9jbGFz c19pbml0KTogT3ZlcnJpZGUgZXZlbnQgdmZ1bmMuCisKIDIwMTktMDItMDMgIE1lZ2FuIEdhcmRu ZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBUdXJuIG9uIFNtYXJ0IFBh c3RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdl YlZpZXdCYXNlLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2Vi Vmlld0Jhc2UuY3BwCmluZGV4IGUyMjRhMWU2NTczNWUwNDNlZDJjZTc2YWUxYjY1NzllNWM5MGFl NzMuLmMzY2M5ZWFiNTgyZDMyNmIzZmEzODM5NjQyOTJmODAyMzBiZDdiNmMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3Bw CkBAIC0zNjQsNiArMzY0LDkgQEAgc3RhdGljIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VSZWFsaXpl KEd0a1dpZGdldCogd2lkZ2V0KQogICAgICAgICB8IEdES19CVVRUT04yX01PVElPTl9NQVNLCiAg ICAgICAgIHwgR0RLX0JVVFRPTjNfTU9USU9OX01BU0sKICAgICAgICAgfCBHREtfVE9VQ0hfTUFT SzsKKyNpZiBIQVZFKEdUS19HRVNUVVJFUykKKyAgICBhdHRyaWJ1dGVzLmV2ZW50X21hc2sgfD0g R0RLX1RPVUNIUEFEX0dFU1RVUkVfTUFTSzsKKyNlbmRpZgogCiAgICAgZ2ludCBhdHRyaWJ1dGVz TWFzayA9IEdES19XQV9YIHwgR0RLX1dBX1kgfCBHREtfV0FfVklTVUFMOwogCkBAIC0xMTkyLDYg KzExOTUsMTYgQEAgc3RhdGljIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VEcmFnRGF0YVJlY2VpdmVk KEd0a1dpZGdldCogd2lkZ2V0LCBHZGtEcmFnQ29udGV4dCoKIH0KICNlbmRpZiAvLyBFTkFCTEUo RFJBR19TVVBQT1JUKQogCitzdGF0aWMgZ2Jvb2xlYW4gd2Via2l0V2ViVmlld0Jhc2VFdmVudChH dGtXaWRnZXQqIHdpZGdldCwgR2RrRXZlbnQqIGV2ZW50KQoreworI2lmIEhBVkUoR1RLX0dFU1RV UkVTKQorICAgIGlmIChldmVudC0+dHlwZSA9PSBHREtfVE9VQ0hQQURfUElOQ0gpCisgICAgICAg IHdlYmtpdFdlYlZpZXdCYXNlR2VzdHVyZUNvbnRyb2xsZXIoV0VCS0lUX1dFQl9WSUVXX0JBU0Uo d2lkZ2V0KSkuaGFuZGxlRXZlbnQoZXZlbnQpOworI2VuZGlmCisKKyAgICByZXR1cm4gR0RLX0VW RU5UX1BST1BBR0FURTsKK30KKwogc3RhdGljIEF0a09iamVjdCogd2Via2l0V2ViVmlld0Jhc2VH ZXRBY2Nlc3NpYmxlKEd0a1dpZGdldCogd2lkZ2V0KQogewogICAgIC8vIElmIHRoZSBzb2NrZXQg aGFzIGFscmVhZHkgYmVlbiBjcmVhdGVkIGFuZCBlbWJlZGRlZCBhIHBsdWcgSUQsIHJldHVybiBp dC4KQEAgLTEzMTUsNiArMTMyOCw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19iYXNl X2NsYXNzX2luaXQoV2ViS2l0V2ViVmlld0Jhc2VDbGFzcyogd2Via2l0V2ViVmllCiAgICAgd2lk Z2V0Q2xhc3MtPmRyYWdfZHJvcCA9IHdlYmtpdFdlYlZpZXdCYXNlRHJhZ0Ryb3A7CiAgICAgd2lk Z2V0Q2xhc3MtPmRyYWdfZGF0YV9yZWNlaXZlZCA9IHdlYmtpdFdlYlZpZXdCYXNlRHJhZ0RhdGFS ZWNlaXZlZDsKICNlbmRpZiAvLyBFTkFCTEUoRFJBR19TVVBQT1JUKQorICAgIHdpZGdldENsYXNz LT5ldmVudCA9IHdlYmtpdFdlYlZpZXdCYXNlRXZlbnQ7CiAgICAgd2lkZ2V0Q2xhc3MtPmdldF9h Y2Nlc3NpYmxlID0gd2Via2l0V2ViVmlld0Jhc2VHZXRBY2Nlc3NpYmxlOwogICAgIHdpZGdldENs YXNzLT5oaWVyYXJjaHlfY2hhbmdlZCA9IHdlYmtpdFdlYlZpZXdCYXNlSGllcmFyY2h5Q2hhbmdl ZDsKICAgICB3aWRnZXRDbGFzcy0+ZGVzdHJveSA9IHdlYmtpdFdlYlZpZXdCYXNlRGVzdHJveTsK