194178 2019-02-01 16:18:27 -0800 Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator 2019-02-17 09:26:02 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=194761 InRadar P2 Normal --- 1 ddkilzer ddkilzer commit-queue darin lforschler mmaxfield webkit-bug-importer oldest_to_newest 1501343 0 ddkilzer 2019-02-01 16:18:27 -0800 Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator. NOTE: Requires patch in Bug 193772 to gather leaks for the com.apple.WebKit.WebContent.Development process. STACK OF 664 INSTANCES OF 'ROOT LEAK: <NSArray>': [thread 0x10f76c5c0]: 28 libdyld.dylib 0x10c003575 start + 1 27 com.apple.WebKit.WebContent 0x10854f3e5 invocation function for block in WebKit::XPCServiceEventHandler(NSObject<OS_xpc_object>*) + 0 XPCServiceMain.mm:46 26 com.apple.WebKit.WebContent 0x10854f268 WebKit::XPCServiceMain(int, char const**) + 403 XPCServiceMain.mm:157 25 libxpc.dylib 0x10c31cc75 xpc_main + 143 24 libxpc.dylib 0x10c31a7ca _xpc_objc_main + 460 23 com.apple.Foundation 0x108608522 -[NSRunLoop(NSRunLoop) run] + 76 22 com.apple.Foundation 0x1086083b2 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277 21 com.apple.CoreFoundation 0x10a643e51 CFRunLoopRunSpecific + 625 20 com.apple.CoreFoundation 0x10a64467f __CFRunLoopRun + 1263 19 com.apple.CoreFoundation 0x10a649fd3 __CFRunLoopDoSources0 + 243 18 com.apple.CoreFoundation 0x10a64a761 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 17 JavaScriptCore 0x3100d92a2 WTF::RunLoop::performWork(void*) + 34 RunLoopCF.cpp:39 16 JavaScriptCore 0x3100d9017 WTF::RunLoop::performWork() + 231 Function.h:56 15 com.apple.WebKit 0x108b98894 IPC::Connection::dispatchOneIncomingMessage() + 180 Connection.cpp:1074 14 com.apple.WebKit 0x108b95262 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) + 108 memory:2567 13 com.apple.WebKit 0x108e78ae2 WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 28 WebProcess.cpp:677 12 com.apple.WebKit 0x108ba2b03 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) + 127 MessageReceiverMap.cpp:0 11 com.apple.WebKit 0x108f4d7f4 WebKit::WebPage::didReceiveWebPageMessage(IPC::Connection&, IPC::Decoder&) + 17292 tuple:170 10 com.apple.WebKit 0x108f36db8 WebKit::WebPage::postInjectedBundleMessage(WTF::String const&, WebKit::UserData const&) + 78 utility:896 9 com.apple.WebKit 0x108e9d299 WebKit::InjectedBundleClient::didReceiveMessageToPage(WebKit::InjectedBundle&, WebKit::WebPage&, WTF::String const&, API::Object*) + 179 RefPtr.h:43 8 WebKitTestRunnerInjectedBundle 0x321d850ec WTR::InjectedBundle::didReceiveMessageToPage(OpaqueWKBundlePage const*, OpaqueWKString const*, void const*) + 1370 InjectedBundle.cpp:0 7 WebKitTestRunnerInjectedBundle 0x321d8897d WTR::InjectedBundlePage::resetAfterTest() + 95 InjectedBundlePage.cpp:447 6 WebKitTestRunnerInjectedBundle 0x321d819ad WTR::uninstallFakeHelvetica() + 532 ActivateFontsCocoa.mm:0 5 com.apple.CoreText 0x10d7ce946 CTFontManagerUnregisterFontsForURLs + 478 4 com.apple.CoreFoundation 0x10a632c65 +[__NSSingleObjectArrayI __new::] + 21 3 com.apple.CoreFoundation 0x10a704d11 __CFAllocateObject + 17 2 libobjc.A.dylib 0x109be1faf class_createInstance + 73 1 libsystem_malloc.dylib 0x10c26a67d calloc + 30 0 libsystem_malloc.dylib 0x10c26a015 malloc_zone_calloc + 139 ==== 15037 (2.16M) << TOTAL >> ---- 28 (4.25K) ROOT LEAK: <NSArray 0x7ff65cc0e6c0> [16] 27 (4.23K) __strong _object --> <CFError 0x7ff65cc14880> [48] 26 (4.19K) _userInfo --> <CFDictionary 0x7ff65cc148b0> [64] 24 (4.09K) <CFDictionary (Value Storage) 0x7ff65cc0fcc0> [32] 22 (4.00K) <NSMutableArray 0x7ff65cc14010> [48] 21 (3.95K) <NSMutableArray (Storage) 0x7ff65cc14850> [48] 4 (800 bytes) <NSURL 0x7ff65cc05bc0> [96] 2 (400 bytes) <_FileCache 0x7ff65cc0bf50> [336] 1 (64 bytes) <CFString 0x7ff65cc05ce0> [64] 1 (304 bytes) _clients --> <CFString 0x7ff65cc0aad0> [304] 4 (800 bytes) <NSURL 0x7ff65cc093f0> [96] 2 (400 bytes) <_FileCache 0x7ff65cc10e80> [336] 1 (64 bytes) <CFString 0x7ff65cc0f320> [64] 1 (304 bytes) _clients --> <CFString 0x7ff65cc0d7b0> [304] 4 (800 bytes) <NSURL 0x7ff65cc11450> [96] 2 (400 bytes) <_FileCache 0x7ff65cc11300> [336] 1 (64 bytes) <CFString 0x7ff65cc0fe90> [64] 1 (304 bytes) _clients --> <CFString 0x7ff65cc092c0> [304] 4 (800 bytes) <NSURL 0x7ff65cc12e20> [96] 2 (400 bytes) <_FileCache 0x7ff65cc12ba0> [336] 1 (64 bytes) <CFString 0x7ff65cc0bc90> [64] 1 (304 bytes) _clients --> <CFString 0x7ff65cc12cf0> [304] 4 (800 bytes) <NSURL 0x7ff65cc13450> [96] 2 (400 bytes) <_FileCache 0x7ff65cc13190> [336] 1 (64 bytes) <CFString 0x7ff65cc132e0> [64] 1 (304 bytes) _clients --> <CFString 0x7ff65cc13320> [304] 1 (64 bytes) <CFString 0x7ff65cc15200> [64] 1 (32 bytes) <CFDictionary (Key Storage) 0x7ff65cc0c300> [32] 1501344 1 ddkilzer 2019-02-01 16:18:34 -0800 <rdar://problem/47753473> 1501348 2 360923 ddkilzer 2019-02-01 16:22:26 -0800 Created attachment 360923 Patch v1 1501430 3 360923 darin 2019-02-01 20:21:58 -0800 Comment on attachment 360923 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=360923&action=review > Tools/WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:163 > CFArrayRef errors = nullptr; > CTFontManagerUnregisterFontsForURLs(static_cast<CFArrayRef>(fontsToRemove), kCTFontManagerScopeProcess, &errors); > + if (errors) { > + for (id error in (__bridge NSArray *)errors) > + NSLog(@"%@", (__bridge CFErrorRef)error); > + CFRelease(errors); > + } A better fix is to get rid of the "errors" local variable, and pass "nullptr" instead of "&errors" to CTFontManagerUnregisterFontsForURLs. Then there is no need for CFRelease. CTFontManagerUnregisterFontsForURLs won't generate an array of errors if we don’t pass a pointer to a place to put the CFArrayRef. Also, we should not land that logging code. 1501453 4 360923 ddkilzer 2019-02-01 22:15:36 -0800 Comment on attachment 360923 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=360923&action=review >> Tools/WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:163 >> + } > > A better fix is to get rid of the "errors" local variable, and pass "nullptr" instead of "&errors" to CTFontManagerUnregisterFontsForURLs. Then there is no need for CFRelease. CTFontManagerUnregisterFontsForURLs won't generate an array of errors if we don’t pass a pointer to a place to put the CFArrayRef. > > Also, we should not land that logging code. Yep, I had assumed that since Myles originally added the `errors` variable that we cared about the errors returned from CTFontManagerUnregisterFontsForURLs(). Easy enough to fix. 1501454 5 360964 ddkilzer 2019-02-01 22:16:03 -0800 Created attachment 360964 Patch v2 1501519 6 360964 commit-queue 2019-02-02 12:20:41 -0800 Comment on attachment 360964 Patch v2 Clearing flags on attachment: 360964 Committed r240900: <https://trac.webkit.org/changeset/240900> 1501520 7 commit-queue 2019-02-02 12:20:43 -0800 All reviewed patches have been landed. Closing bug. 360923 2019-02-01 16:22:26 -0800 2019-02-01 22:16:01 -0800 Patch v1 bug-194178-20190201162225.patch text/plain 1594 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNjY0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmQwNDI3NzMyY2RmN2IxODA2MjQ0ZDVkMjM2NWNiODBj MzEwM2VlYi4uYjM2ZWQ0OGFhYjEzM2U2NWM5NDU5NDgwNWI1Nzg1MDYyYzIxYTVmOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE5LTAyLTAxICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgTGVhayBvZiBOU0FycmF5ICg0LjI1IEtieXRlcykgaW4gY29tLmFwcGxlLldlYktpdC5X ZWJDb250ZW50IHJ1bm5pbmcgV2ViS2l0IGxheW91dCB0ZXN0cyBvbiBpT1MgU2ltdWxhdG9yCisg ICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xOTQxNzg+CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS80Nzc1MzQ3Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvY29jb2EvQWN0aXZhdGVG b250c0NvY29hLm1tOgorICAgICAgICAoV1RSOjp1bmluc3RhbGxGYWtlSGVsdmV0aWNhKTogUmVs ZWFzZSBgZXJyb3JzYCBpZiBzZXQgYWZ0ZXIKKyAgICAgICAgY2FsbGluZyBDVEZvbnRNYW5hZ2Vy VW5yZWdpc3RlckZvbnRzRm9yVVJMcygpLgorCiAyMDE4LTEyLTA3ICBEYXZpZCBLaWx6ZXIgIDxk ZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgSWdub3JlIGZhbHNlLXBvc2l0aXZlIGxlYWtz IHVuZGVyIGJtYWxsb2M6OkhlYXA6OkhlYXAKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvSW5qZWN0ZWRCdW5kbGUvY29jb2EvQWN0aXZhdGVGb250c0NvY29hLm1tIGIvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9jb2NvYS9BY3RpdmF0ZUZvbnRzQ29jb2Eu bW0KaW5kZXggM2ZlZjJkNTgxOGM5OTc0ZDljYjlhMGY3MzRiY2NhZGM1OTkxOTU2Ny4uYzA5NjNm MDMxNmViYTYwMjg5OGU0ZDY5YmZmMmQyMTg1MzhkYzhmOCAxMDA2NDQKLS0tIGEvVG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9jb2NvYS9BY3RpdmF0ZUZvbnRzQ29jb2EubW0K KysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9jb2NvYS9BY3RpdmF0 ZUZvbnRzQ29jb2EubW0KQEAgLTE1Niw2ICsxNTYsMTEgQEAgdm9pZCB1bmluc3RhbGxGYWtlSGVs dmV0aWNhKCkKICAgICB9CiAgICAgQ0ZBcnJheVJlZiBlcnJvcnMgPSBudWxscHRyOwogICAgIENU Rm9udE1hbmFnZXJVbnJlZ2lzdGVyRm9udHNGb3JVUkxzKHN0YXRpY19jYXN0PENGQXJyYXlSZWY+ KGZvbnRzVG9SZW1vdmUpLCBrQ1RGb250TWFuYWdlclNjb3BlUHJvY2VzcywgJmVycm9ycyk7Cisg ICAgaWYgKGVycm9ycykgeworICAgICAgICBmb3IgKGlkIGVycm9yIGluIChfX2JyaWRnZSBOU0Fy cmF5ICopZXJyb3JzKQorICAgICAgICAgICAgTlNMb2coQCIlQCIsIChfX2JyaWRnZSBDRkVycm9y UmVmKWVycm9yKTsKKyAgICAgICAgQ0ZSZWxlYXNlKGVycm9ycyk7CisgICAgfQogfQogCiB9Cg== 360964 2019-02-01 22:16:03 -0800 2019-02-02 12:20:41 -0800 Patch v2 bug-194178-20190201221602.patch text/plain 1661 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNjY0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmQwNDI3NzMyY2RmN2IxODA2MjQ0ZDVkMjM2NWNiODBj MzEwM2VlYi4uMzRhNmM1YWMzOGQ3NTZkMTFjYzUzZDhmNWRiNTA0NmY4ZjZhNWE1YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE5LTAyLTAxICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgTGVhayBvZiBOU0FycmF5ICg0LjI1IEtieXRlcykgaW4gY29tLmFwcGxlLldlYktpdC5X ZWJDb250ZW50IHJ1bm5pbmcgV2ViS2l0IGxheW91dCB0ZXN0cyBvbiBpT1MgU2ltdWxhdG9yCisg ICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xOTQxNzg+CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS80Nzc1MzQ3Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvY29jb2EvQWN0aXZhdGVG b250c0NvY29hLm1tOgorICAgICAgICAoV1RSOjp1bmluc3RhbGxGYWtlSGVsdmV0aWNhKTogUGFz cyBudWxscHRyIGludG8KKyAgICAgICAgQ1RGb250TWFuYWdlclVucmVnaXN0ZXJGb250c0ZvclVS THMoKSB0byBpZ25vcmUgYW55IGVycm9ycy4KKwogMjAxOC0xMi0wNyAgRGF2aWQgS2lsemVyICA8 ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIElnbm9yZSBmYWxzZS1wb3NpdGl2ZSBsZWFr cyB1bmRlciBibWFsbG9jOjpIZWFwOjpIZWFwCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0 UnVubmVyL0luamVjdGVkQnVuZGxlL2NvY29hL0FjdGl2YXRlRm9udHNDb2NvYS5tbSBiL1Rvb2xz L1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvY29jb2EvQWN0aXZhdGVGb250c0NvY29h Lm1tCmluZGV4IDNmZWYyZDU4MThjOTk3NGQ5Y2I5YTBmNzM0YmNjYWRjNTk5MTk1NjcuLjNkNmFk ZjYyM2Y3YTI2NjUyYzZhZDQ4MTliZDEzMTdmNjA4YmFjY2EgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dl YktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvY29jb2EvQWN0aXZhdGVGb250c0NvY29hLm1t CisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvY29jb2EvQWN0aXZh dGVGb250c0NvY29hLm1tCkBAIC0xNTQsOCArMTU0LDcgQEAgdm9pZCB1bmluc3RhbGxGYWtlSGVs dmV0aWNhKCkKICAgICAgICAgaWYgKFtbdXJsIGxhc3RQYXRoQ29tcG9uZW50XSBoYXNQcmVmaXg6 QCJGYWtlSGVsdmV0aWNhIl0pCiAgICAgICAgICAgICBbZm9udHNUb1JlbW92ZSBhZGRPYmplY3Q6 dXJsXTsKICAgICB9Ci0gICAgQ0ZBcnJheVJlZiBlcnJvcnMgPSBudWxscHRyOwotICAgIENURm9u dE1hbmFnZXJVbnJlZ2lzdGVyRm9udHNGb3JVUkxzKHN0YXRpY19jYXN0PENGQXJyYXlSZWY+KGZv bnRzVG9SZW1vdmUpLCBrQ1RGb250TWFuYWdlclNjb3BlUHJvY2VzcywgJmVycm9ycyk7CisgICAg Q1RGb250TWFuYWdlclVucmVnaXN0ZXJGb250c0ZvclVSTHMoc3RhdGljX2Nhc3Q8Q0ZBcnJheVJl Zj4oZm9udHNUb1JlbW92ZSksIGtDVEZvbnRNYW5hZ2VyU2NvcGVQcm9jZXNzLCBudWxscHRyKTsK IH0KIAogfQo=