194152 2019-02-01 03:43:45 -0800 [ews-build] Add unit test to verify builder keys 2019-02-01 18:20:29 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue lforschler webkit-bug-importer oldest_to_newest 1501075 0 aakash_jain 2019-02-01 03:43:45 -0800 We should add a unit test to ensure that the builder doesn't contain any unexpected keys. 1501077 1 360856 aakash_jain 2019-02-01 03:46:31 -0800 Created attachment 360856 Proposed patch 1501394 2 360856 commit-queue 2019-02-01 18:19:49 -0800 Comment on attachment 360856 Proposed patch Clearing flags on attachment: 360856 Committed r240890: <https://trac.webkit.org/changeset/240890> 1501395 3 commit-queue 2019-02-01 18:19:50 -0800 All reviewed patches have been landed. Closing bug. 1501397 4 webkit-bug-importer 2019-02-01 18:20:29 -0800 <rdar://problem/47757341> 360856 2019-02-01 03:46:31 -0800 2019-02-01 18:19:49 -0800 Proposed patch ews-build-unittest-builder-keys.patch text/plain 2040 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MDg0MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTAyLTAxICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBBZGQgdW5pdCB0ZXN0IHRvIHZlcmlmeSBidWlsZGVy IGtleXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 NDE1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog QnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2xvYWRDb25maWdfdW5pdHRlc3QucHk6CisgICAg ICAgIChDb25maWdEb3RKU09OVGVzdC50ZXN0X2J1aWxkZXJfa2V5cyk6IEFkZGVkIHVuaXQtdGVz dC4KKwogMjAxOS0wMi0wMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5j b20+CiAKICAgICAgICAgW1dQRV0gTWluaUJyb3dzZXI6IHVzZSBnX2ZpbGVfbmV3X2Zvcl9jb21t YW5kbGluZV9hcmcKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9sb2Fk Q29uZmlnX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2V3cy1idWlsZC9sb2FkQ29uZmlnX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyNDA4NDEpCisrKyBU b29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvbG9hZENvbmZpZ191bml0dGVzdC5weQko d29ya2luZyBjb3B5KQpAQCAtMjMsNiArMjMsNyBAQAogIyBPRiBUSElTIFNPRlRXQVJFLCBFVkVO IElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogCiAKK2ltcG9y dCBqc29uCiBpbXBvcnQgb3MKIGltcG9ydCB1bml0dGVzdAogCkBAIC0zNCw2ICszNSwxNiBAQCBj bGFzcyBDb25maWdEb3RKU09OVGVzdCh1bml0dGVzdC5UZXN0Q2FzCiAgICAgICAgIGN3ZCA9IG9z LnBhdGguZGlybmFtZShvcy5wYXRoLmFic3BhdGgoX19maWxlX18pKQogICAgICAgICBsb2FkQ29u ZmlnLmxvYWRCdWlsZGVyQ29uZmlnKHt9LCBtYXN0ZXJfcHJlZml4X3BhdGg9Y3dkKQogCisgICAg ZGVmIHRlc3RfYnVpbGRlcl9rZXlzKHNlbGYpOgorICAgICAgICBjd2QgPSBvcy5wYXRoLmRpcm5h bWUob3MucGF0aC5hYnNwYXRoKF9fZmlsZV9fKSkKKyAgICAgICAgY29uZmlnID0ganNvbi5sb2Fk KG9wZW4ob3MucGF0aC5qb2luKGN3ZCwgJ2NvbmZpZy5qc29uJykpKQorICAgICAgICB2YWxpZF9i dWlsZGVyX2tleXMgPSBbJ2FkZGl0aW9uYWxBcmd1bWVudHMnLCAnYXJjaGl0ZWN0dXJlcycsICdi dWlsZGRpcicsICdjb25maWd1cmF0aW9uJywgJ2Rlc2NyaXB0aW9uJywKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICdkZWZhdWx0UHJvcGVydGllcycsICdlbnYnLCAnZmFjdG9yeScsICds b2NrcycsICduYW1lJywgJ3BsYXRmb3JtJywgJ3Byb3BlcnRpZXMnLCAndGFncycsCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAndHJpZ2dlcnMnLCAnd29ya2VybmFtZXMnLCAnd29ya2Vy YnVpbGRkaXInXQorICAgICAgICBmb3IgYnVpbGRlciBpbiBjb25maWcuZ2V0KCdidWlsZGVycycs IFtdKToKKyAgICAgICAgICAgIGZvciBrZXkgaW4gYnVpbGRlcjoKKyAgICAgICAgICAgICAgICBz ZWxmLmFzc2VydFRydWUoa2V5IGluIHZhbGlkX2J1aWxkZXJfa2V5cywgJ1VuZXhwZWN0ZWQga2V5 IHt9IGZvciBidWlsZGVyIHt9Jy5mb3JtYXQoa2V5LCBidWlsZGVyLmdldCgnbmFtZScpKSkKKwog CiBjbGFzcyBUYWdzRm9yQnVpbGRlclRlZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICBkZWYg dmVyaWZ5VGFncyhzZWxmLCBidWlsZGVyTmFtZSwgZXhwZWN0ZWRUYWdzKToK