194151 2019-02-01 03:43:34 -0800 [WPE] MiniBrowser: add ky bindings for back/forward navigation 2019-02-05 08:03:07 -0800 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply webkit-bug-importer zan oldest_to_newest 1501074 0 cgarcia 2019-02-01 03:43:34 -0800 ALT + <- go back ALT + -> go forward 1501076 1 360855 cgarcia 2019-02-01 03:46:05 -0800 Created attachment 360855 Patch 1501089 2 cgarcia 2019-02-01 06:27:41 -0800 Committed r240843: <https://trac.webkit.org/changeset/240843> 360855 2019-02-01 03:46:05 -0800 2019-02-01 03:47:32 -0800 Patch wpe-mb-key-navigation.diff text/plain 3776 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyNjVm OTE5NDVhZS4uNTc5NzUwMDMxYWMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxOS0wMi0wMSAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dQRV0gTWluaUJyb3dz ZXI6IGFkZCBreSBiaW5kaW5ncyBmb3IgYmFjay9mb3J3YXJkIG5hdmlnYXRpb24KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDE1MQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFMVCArIDwtIGdvIGJhY2sK KyAgICAgICAgQUxUICsgLT4gZ28gZm9yd2FyZAorCisgICAgICAgICogTWluaUJyb3dzZXIvd3Bl L21haW4uY3BwOgorICAgICAgICAobWFpbik6CisKIDIwMTktMDItMDEgIENhcmxvcyBHYXJjaWEg Q2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdIFNob3cgdGVzdCBy ZXN1bHRzIGluIG1pbmlicm93c2VyCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci93cGUv bWFpbi5jcHAgYi9Ub29scy9NaW5pQnJvd3Nlci93cGUvbWFpbi5jcHAKaW5kZXggODA3MDA4MGM4 M2IuLjI1Y2M4ODQ5M2ZmIDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci93cGUvbWFpbi5j cHAKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvd3BlL21haW4uY3BwCkBAIC02MSwyMyArNjEsNDAg QEAgc3RhdGljIGNvbnN0IEdPcHRpb25FbnRyeSBjb21tYW5kTGluZU9wdGlvbnNbXSA9CiAKIGNs YXNzIElucHV0Q2xpZW50IGZpbmFsIDogcHVibGljIFdQRVRvb2xpbmdCYWNrZW5kczo6Vmlld0Jh Y2tlbmQ6OklucHV0Q2xpZW50IHsKIHB1YmxpYzoKLSAgICBJbnB1dENsaWVudChHTWFpbkxvb3Aq IGxvb3ApCisgICAgSW5wdXRDbGllbnQoR01haW5Mb29wKiBsb29wLCBXZWJLaXRXZWJWaWV3KiB3 ZWJWaWV3KQogICAgICAgICA6IG1fbG9vcChsb29wKQorICAgICAgICAsIG1fd2ViVmlldyh3ZWJW aWV3KQogICAgIHsKICAgICB9CiAKICAgICBib29sIGRpc3BhdGNoS2V5Ym9hcmRFdmVudChzdHJ1 Y3Qgd3BlX2lucHV0X2tleWJvYXJkX2V2ZW50KiBldmVudCkgb3ZlcnJpZGUKICAgICB7Ci0gICAg ICAgIGlmIChldmVudC0+cHJlc3NlZCAmJiBldmVudC0+bW9kaWZpZXJzICYgd3BlX2lucHV0X2tl eWJvYXJkX21vZGlmaWVyX2NvbnRyb2wgJiYgZXZlbnQtPmtleV9jb2RlID09IFdQRV9LRVlfcSkg eworICAgICAgICBpZiAoIWV2ZW50LT5wcmVzc2VkKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNl OworCisgICAgICAgIGlmIChldmVudC0+bW9kaWZpZXJzICYgd3BlX2lucHV0X2tleWJvYXJkX21v ZGlmaWVyX2NvbnRyb2wgJiYgZXZlbnQtPmtleV9jb2RlID09IFdQRV9LRVlfcSkgewogICAgICAg ICAgICAgZ19tYWluX2xvb3BfcXVpdChtX2xvb3ApOwogICAgICAgICAgICAgcmV0dXJuIHRydWU7 CiAgICAgICAgIH0KIAorICAgICAgICBpZiAoZXZlbnQtPm1vZGlmaWVycyAmIHdwZV9pbnB1dF9r ZXlib2FyZF9tb2RpZmllcl9hbHQpIHsKKyAgICAgICAgICAgIGlmICgoZXZlbnQtPmtleV9jb2Rl ID09IFdQRV9LRVlfTGVmdCB8fCBldmVudC0+a2V5X2NvZGUgPT0gV1BFX0tFWV9LUF9MZWZ0KSAm JiB3ZWJraXRfd2ViX3ZpZXdfY2FuX2dvX2JhY2sobV93ZWJWaWV3KSkgeworICAgICAgICAgICAg ICAgIHdlYmtpdF93ZWJfdmlld19nb19iYWNrKG1fd2ViVmlldyk7CisgICAgICAgICAgICAgICAg cmV0dXJuIHRydWU7CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIGlmICgoZXZlbnQtPmtl eV9jb2RlID09IFdQRV9LRVlfUmlnaHQgfHwgZXZlbnQtPmtleV9jb2RlID09IFdQRV9LRVlfS1Bf UmlnaHQpICYmIHdlYmtpdF93ZWJfdmlld19jYW5fZ29fZm9yd2FyZChtX3dlYlZpZXcpKSB7Cisg ICAgICAgICAgICAgICAgd2Via2l0X3dlYl92aWV3X2dvX2ZvcndhcmQobV93ZWJWaWV3KTsKKyAg ICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorCiAg ICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAKIHByaXZhdGU6CiAgICAgR01haW5Mb29wKiBt X2xvb3AgeyBudWxscHRyIH07CisgICAgV2ViS2l0V2ViVmlldyogbV93ZWJWaWV3IHsgbnVsbHB0 ciB9OwogfTsKIAogc3RhdGljIFdlYktpdFdlYlZpZXcqIGNyZWF0ZVdlYlZpZXdGb3JBdXRvbWF0 aW9uQ2FsbGJhY2soV2ViS2l0QXV0b21hdGlvblNlc3Npb24qLCBXZWJLaXRXZWJWaWV3KiB2aWV3 KQpAQCAtMTQyLDEyICsxNTksNiBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciAqYXJndltdKQog ICAgICAgICByZXR1cm4gMTsKICAgICB9CiAKLSAgICBiYWNrZW5kLT5zZXRJbnB1dENsaWVudChz dGQ6Om1ha2VfdW5pcXVlPElucHV0Q2xpZW50Pihsb29wKSk7Ci0KLSAgICBhdXRvKiB2aWV3QmFj a2VuZCA9IHdlYmtpdF93ZWJfdmlld19iYWNrZW5kX25ldyh3cGVCYWNrZW5kLCBbXShncG9pbnRl ciBkYXRhKSB7Ci0gICAgICAgIGRlbGV0ZSBzdGF0aWNfY2FzdDxXUEVUb29saW5nQmFja2VuZHM6 OlZpZXdCYWNrZW5kKj4oZGF0YSk7Ci0gICAgfSwgYmFja2VuZC5yZWxlYXNlKCkpOwotCiAgICAg YXV0byogd2ViQ29udGV4dCA9IChwcml2YXRlTW9kZSB8fCBhdXRvbWF0aW9uTW9kZSkgPyB3ZWJr aXRfd2ViX2NvbnRleHRfbmV3X2VwaGVtZXJhbCgpIDogd2Via2l0X3dlYl9jb250ZXh0X2dldF9k ZWZhdWx0KCk7CiAKICAgICBpZiAoY29va2llc1BvbGljeSkgewpAQCAtMTgyLDYgKzE5MywxMSBA QCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciAqYXJndltdKQogICAgICAgICAiZW5hYmxlLWVuY3J5 cHRlZC1tZWRpYSIsIFRSVUUsCiAgICAgICAgIG51bGxwdHIpOwogCisgICAgYXV0byogYmFja2Vu ZFB0ciA9IGJhY2tlbmQuZ2V0KCk7CisgICAgYXV0byogdmlld0JhY2tlbmQgPSB3ZWJraXRfd2Vi X3ZpZXdfYmFja2VuZF9uZXcod3BlQmFja2VuZCwgW10oZ3BvaW50ZXIgZGF0YSkgeworICAgICAg ICBkZWxldGUgc3RhdGljX2Nhc3Q8V1BFVG9vbGluZ0JhY2tlbmRzOjpWaWV3QmFja2VuZCo+KGRh dGEpOworICAgIH0sIGJhY2tlbmQucmVsZWFzZSgpKTsKKwogICAgIGF1dG8qIHdlYlZpZXcgPSBX RUJLSVRfV0VCX1ZJRVcoZ19vYmplY3RfbmV3KFdFQktJVF9UWVBFX1dFQl9WSUVXLAogICAgICAg ICAiYmFja2VuZCIsIHZpZXdCYWNrZW5kLAogICAgICAgICAid2ViLWNvbnRleHQiLCB3ZWJDb250 ZXh0LApAQCAtMTkwLDYgKzIwNiw4IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICphcmd2W10p CiAgICAgICAgIG51bGxwdHIpKTsKICAgICBnX29iamVjdF91bnJlZihzZXR0aW5ncyk7CiAKKyAg ICBiYWNrZW5kUHRyLT5zZXRJbnB1dENsaWVudChzdGQ6Om1ha2VfdW5pcXVlPElucHV0Q2xpZW50 Pihsb29wLCB3ZWJWaWV3KSk7CisKICAgICB3ZWJraXRfd2ViX2NvbnRleHRfc2V0X2F1dG9tYXRp b25fYWxsb3dlZCh3ZWJDb250ZXh0LCBhdXRvbWF0aW9uTW9kZSk7CiAgICAgZ19zaWduYWxfY29u bmVjdCh3ZWJDb250ZXh0LCAiYXV0b21hdGlvbi1zdGFydGVkIiwgR19DQUxMQkFDSyhhdXRvbWF0 aW9uU3RhcnRlZENhbGxiYWNrKSwgd2ViVmlldyk7CiAgICAgZ19zaWduYWxfY29ubmVjdCh3ZWJW aWV3LCAicGVybWlzc2lvbi1yZXF1ZXN0IiwgR19DQUxMQkFDSyhkZWNpZGVQZXJtaXNzaW9uUmVx dWVzdCksIE5VTEwpOwo=