194145 2019-01-31 23:32:43 -0800 [JSC] Remove cellJSValueOOBSpace 2019-02-04 17:34:58 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 193606 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1501029 0 ysuzuki 2019-01-31 23:32:43 -0800 [JSC] Remove cellJSValueOOBSpace 1501030 1 360841 ysuzuki 2019-01-31 23:34:06 -0800 Created attachment 360841 Patch 1501149 2 360841 mark.lam 2019-02-01 10:02:11 -0800 Comment on attachment 360841 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360841&action=review > Source/JavaScriptCore/ChangeLog:3 > + [JSC] Remove cellJSValueOOBSpace Can you provide some context on why this is needed and appropriate? 1501157 3 360841 mark.lam 2019-02-01 10:55:23 -0800 Comment on attachment 360841 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360841&action=review >> Source/JavaScriptCore/ChangeLog:3 >> + [JSC] Remove cellJSValueOOBSpace > > Can you provide some context on why this is needed and appropriate? Spoke to Yusuke offline. This subspace does not currently add any value. So, we're removing it. 1501165 4 ysuzuki 2019-02-01 11:00:00 -0800 Committed r240859: <https://trac.webkit.org/changeset/240859> 1501167 5 webkit-bug-importer 2019-02-01 11:01:01 -0800 <rdar://problem/47741849> 1501180 6 saam 2019-02-01 11:17:50 -0800 Can we go back to our previous naming of these subspaces too? DangerousBits doesn't make much sense anymore given we're ripping this out. 1501182 7 ysuzuki 2019-02-01 11:18:59 -0800 (In reply to Saam Barati from comment #6) > Can we go back to our previous naming of these subspaces too? DangerousBits > doesn't make much sense anymore given we're ripping this out. Nice catch! I'll do that soon. 1501184 8 ysuzuki 2019-02-01 11:22:00 -0800 (In reply to Yusuke Suzuki from comment #7) > (In reply to Saam Barati from comment #6) > > Can we go back to our previous naming of these subspaces too? DangerousBits > > doesn't make much sense anymore given we're ripping this out. > > Nice catch! I'll do that soon. The previous name was cellSpace. 1501191 9 ysuzuki 2019-02-01 11:33:26 -0800 Committed r240860: <https://trac.webkit.org/changeset/240860> 360841 2019-01-31 23:34:06 -0800 2019-02-01 10:55:23 -0800 Patch bug-194145-20190131233405.patch text/plain 3688 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwODM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk Yjg4ZGY4OGQ4NmU5ZmFkZTlhOTc0NmFlYzRkNzlmYjVkNzI2ZjdmLi4zMWVlMjUwZGZmNDU4NWMy MzI2Nzc1YzE5NTJkNGFlNTY1OThhYzBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wMS0zMSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFJlbW92ZSBjZWxsSlNWYWx1ZU9PQlNwYWNlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQxNDUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvSlNPYmplY3Qu aDoKKyAgICAgICAgKEpTQzo6SlNPYmplY3Q6OnN1YnNwYWNlRm9yKTogRGVsZXRlZC4KKyAgICAg ICAgKiBydW50aW1lL1ZNLmNwcDoKKyAgICAgICAgKEpTQzo6Vk06OlZNKToKKyAgICAgICAgKiBy dW50aW1lL1ZNLmg6CisKIDIwMTktMDEtMzEgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29t PgogCiAgICAgICAgIFJlbW92ZSBwb2lzb25pbmcgZnJvbSBDb2RlQmxvY2sgYW5kIExMSW50IGNv ZGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5o IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuaAppbmRleCAxOTJkYjVl ZWVhNzEzZTYxN2I3MTIxOWFmN2Y3NDlhMjBlYTA0ODFmLi5lMGNhYWYzMDAyZDdhMDdlMTQ2MDZh M2Y1ZWZiNDliZGNiZWNkNDFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9KU09iamVjdC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2Jq ZWN0LmgKQEAgLTEwNCwxMiArMTA0LDYgQEAgY2xhc3MgSlNPYmplY3QgOiBwdWJsaWMgSlNDZWxs IHsKIHB1YmxpYzoKICAgICB0eXBlZGVmIEpTQ2VsbCBCYXNlOwogCi0gICAgdGVtcGxhdGU8dHlw ZW5hbWU+Ci0gICAgc3RhdGljIENvbXBsZXRlU3Vic3BhY2UqIHN1YnNwYWNlRm9yKFZNJiB2bSkK LSAgICB7Ci0gICAgICAgIHJldHVybiAmdm0uY2VsbEpTVmFsdWVPT0JTcGFjZTsKLSAgICB9Ci0K ICAgICAvLyBUaGlzIGlzIGEgc3VwZXIgZGFuZ2Vyb3VzIG1ldGhvZCBmb3IgSklUcy4gU29tZXRp bWVzIHRoZSBKSVRzIHdpbGwgd2FudCB0byBjcmVhdGUgZWl0aGVyIGEKICAgICAvLyBKU0ZpbmFs T2JqZWN0IG9yIGEgSlNBcnJheS4gVGhpcyBpcyB0aGUgbWV0aG9kIHRoYXQgd2lsbCBkbyB0aGF0 LgogICAgIHN0YXRpYyBKU09iamVjdCogY3JlYXRlUmF3T2JqZWN0KEV4ZWNTdGF0ZSogZXhlYywg U3RydWN0dXJlKiBzdHJ1Y3R1cmUsIEJ1dHRlcmZseSogPSBudWxscHRyKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL1ZNLmNwcAppbmRleCBkOTFiM2I4NTQxN2YwZDFhOWRmM2VhZTRlOWQ4MzQx ODY0YjIwNzcyLi4zYjI5YWMxNTcwYWU5YTQ3OWY2ZjQ3NzAyOTE2ODQyZDc2NmZkMmVlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5jcHAKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uY3BwCkBAIC0yODEsNyArMjgxLDYgQEAgVk06OlZN KFZNVHlwZSB2bVR5cGUsIEhlYXBUeXBlIGhlYXBUeXBlKQogICAgICwgcHJpbWl0aXZlR2lnYWNh Z2VBdXhpbGlhcnlTcGFjZSgiUHJpbWl0aXZlIEdpZ2FjYWdlIEF1eGlsaWFyeSIsIGhlYXAsIGF1 eGlsaWFyeUhlYXBDZWxsVHlwZS5nZXQoKSwgcHJpbWl0aXZlR2lnYWNhZ2VBbGxvY2F0b3IuZ2V0 KCkpCiAgICAgLCBqc1ZhbHVlR2lnYWNhZ2VBdXhpbGlhcnlTcGFjZSgiSlNWYWx1ZSBHaWdhY2Fn ZSBBdXhpbGlhcnkiLCBoZWFwLCBhdXhpbGlhcnlIZWFwQ2VsbFR5cGUuZ2V0KCksIGpzVmFsdWVH aWdhY2FnZUFsbG9jYXRvci5nZXQoKSkKICAgICAsIGltbXV0YWJsZUJ1dHRlcmZseUpTVmFsdWVH aWdhY2FnZUF1eGlsaWFyeVNwYWNlKCJJbW11dGFibGVCdXR0ZXJmbHkgR2lnYWNhZ2UgSlNDZWxs V2l0aEludGVyaW9yUG9pbnRlcnMiLCBoZWFwLCBpbW11dGFibGVCdXR0ZXJmbHlIZWFwQ2VsbFR5 cGUuZ2V0KCksIGpzVmFsdWVHaWdhY2FnZUFsbG9jYXRvci5nZXQoKSkKLSAgICAsIGNlbGxKU1Zh bHVlT09CU3BhY2UoIkpTQ2VsbCBKU1ZhbHVlT09CIiwgaGVhcCwgY2VsbEpTVmFsdWVPT0JIZWFw Q2VsbFR5cGUuZ2V0KCksIGZhc3RNYWxsb2NBbGxvY2F0b3IuZ2V0KCkpCiAgICAgLCBjZWxsRGFu Z2Vyb3VzQml0c1NwYWNlKCJKU0NlbGwgRGFuZ2Vyb3VzQml0cyIsIGhlYXAsIGNlbGxEYW5nZXJv dXNCaXRzSGVhcENlbGxUeXBlLmdldCgpLCBmYXN0TWFsbG9jQWxsb2NhdG9yLmdldCgpKQogICAg ICwganNWYWx1ZUdpZ2FjYWdlQ2VsbFNwYWNlKCJKU1ZhbHVlIEdpZ2FjYWdlIEpTQ2VsbCIsIGhl YXAsIGNlbGxKU1ZhbHVlT09CSGVhcENlbGxUeXBlLmdldCgpLCBqc1ZhbHVlR2lnYWNhZ2VBbGxv Y2F0b3IuZ2V0KCkpCiAgICAgLCBkZXN0cnVjdGlibGVDZWxsU3BhY2UoIkRlc3RydWN0aWJsZSBK U0NlbGwiLCBoZWFwLCBkZXN0cnVjdGlibGVDZWxsSGVhcENlbGxUeXBlLmdldCgpLCBmYXN0TWFs bG9jQWxsb2NhdG9yLmdldCgpKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvVk0uaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmgKaW5kZXggNTgz OWUyMDdmZTM3NWQyNGQ5YzUyNjA5MGRjM2JkNmJhMjA1NWM5My4uMzFhMTNjYjBmOGU2NTZkYzdi Y2NkOThiY2NmM2VjMTIzZGYwNjdiMyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvVk0uaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5oCkBA IC0zNTksNyArMzU5LDYgQEAgY2xhc3MgVk0gOiBwdWJsaWMgVGhyZWFkU2FmZVJlZkNvdW50ZWQ8 Vk0+LCBwdWJsaWMgRG91Ymx5TGlua2VkTGlzdE5vZGU8Vk0+IHsKICAgICB9CiAgICAgCiAgICAg Ly8gV2hlbmV2ZXIgcG9zc2libGUsIHVzZSBzdWJzcGFjZUZvcjxDZWxsVHlwZT4odm0pIHRvIGdl dCBvbmUgb2YgdGhlc2Ugc3Vic3BhY2VzLgotICAgIENvbXBsZXRlU3Vic3BhY2UgY2VsbEpTVmFs dWVPT0JTcGFjZTsKICAgICBDb21wbGV0ZVN1YnNwYWNlIGNlbGxEYW5nZXJvdXNCaXRzU3BhY2U7 CiAgICAgQ29tcGxldGVTdWJzcGFjZSBqc1ZhbHVlR2lnYWNhZ2VDZWxsU3BhY2U7IC8vIEZJWE1F OiBUaGlzIHNwYWNlIGlzIHByb2JsZW1hdGljIGJlY2F1c2Ugd2UgaGF2ZSB0aGluZ3MgaW4gaGVy ZSBsaWtlIERpcmVjdEFyZ3VtZW50cyBhbmQgU2NvcGVkQXJndW1lbnRzOyB0aG9zZSBzaG91bGQg YmUgc3BsaXQgaW50byBKU1ZhbHVlT09CIGNlbGxzIGFuZCBKU1ZhbHVlU3RyaWN0IGF1eGlsaWFy aWVzLiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyODU4CiAgICAg Q29tcGxldGVTdWJzcGFjZSBkZXN0cnVjdGlibGVDZWxsU3BhY2U7Cg==