194130 2019-01-31 17:21:41 -0800 Remove invalid assertion in DFG's compileDoubleRep(). 2019-02-01 14:47:26 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue ews-watchlist fpizlo keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1500927 0 mark.lam 2019-01-31 17:21:41 -0800 Also remove an invalid assertion in DFG's compileDoubleRep(). <rdar://problem/47699474> 1500931 1 360815 mark.lam 2019-01-31 17:30:53 -0800 Created attachment 360815 proposed patch. 1500939 2 360815 saam 2019-01-31 17:47:32 -0800 Comment on attachment 360815 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=360815&action=review > Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:793 > + m_graph.convertToConstant(node, JSValue(node->child1()->asNumber())); do we need purifyNaN here? 1500946 3 360815 saam 2019-01-31 17:56:01 -0800 Comment on attachment 360815 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=360815&action=review > Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:792 > + if (node->child1()->isNumberConstant()) { You should put this in AI. 1500947 4 360815 saam 2019-01-31 17:59:03 -0800 Comment on attachment 360815 proposed patch. r=me to remove the assert. It's worth figuring out why the already present rule in AI isn't working. 1500992 5 360815 ews-watchlist 2019-01-31 21:07:07 -0800 Comment on attachment 360815 proposed patch. Attachment 360815 did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/10985070 New failing tests: stress/op_add.js.misc-ftl-no-cjit stress/ftl-get-by-id-getter-exception-interesting-live-state.js.ftl-eager-no-cjit apiTests 1501162 6 mark.lam 2019-02-01 10:58:51 -0800 (In reply to Saam Barati from comment #4) > Comment on attachment 360815 [details] > proposed patch. > > r=me to remove the assert. It's worth figuring out why the already present > rule in AI isn't working. OK, I'm just going to remove the assertion in this patch. Will look into the DoubleRep constant folding issue in https://bugs.webkit.org/show_bug.cgi?id=194165. 1501186 7 360877 mark.lam 2019-02-01 11:27:41 -0800 Created attachment 360877 patch for landing. 1501298 8 360877 commit-queue 2019-02-01 14:47:25 -0800 Comment on attachment 360877 patch for landing. Clearing flags on attachment: 360877 Committed r240878: <https://trac.webkit.org/changeset/240878> 1501299 9 commit-queue 2019-02-01 14:47:26 -0800 All reviewed patches have been landed. Closing bug. 360815 2019-01-31 17:30:53 -0800 2019-02-01 11:27:41 -0800 proposed patch. bug-194130.patch text/plain 3561 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDA4MzEpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE5LTAxLTMxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBDb25zdGFudCBmb2xkIERvdWJsZVJlcCBvZiBhIG51bWVyaWMgY29uc3Rh bnQgaW50byBhIERvdWJsZUNvbnN0YW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MTMwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzY5OTQ3 ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0 cmVzcy9jb25zdGFudC1mb2xkLWRvdWJsZS1yZXAtaW50by1kb3VibGUtY29uc3RhbnQuanM6IEFk ZGVkLgorCiAyMDE5LTAxLTMwICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNv bT4KIAogICAgICAgICBJbXBvcnQgbGF0ZXN0IFRlc3QyNjIgdXBkYXRlcy4KSW5kZXg6IEpTVGVz dHMvc3RyZXNzL2NvbnN0YW50LWZvbGQtZG91YmxlLXJlcC1pbnRvLWRvdWJsZS1jb25zdGFudC5q cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9jb25zdGFudC1mb2xkLWRvdWJsZS1yZXAt aW50by1kb3VibGUtY29uc3RhbnQuanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3Mv Y29uc3RhbnQtZm9sZC1kb3VibGUtcmVwLWludG8tZG91YmxlLWNvbnN0YW50LmpzCSh3b3JraW5n IGNvcHkpCkBAIC0wLDAgKzEsMTQgQEAKK2Z1bmN0aW9uIGJhcihvKSB7CisgICAgZm9yIChsZXQg aSA9IDA7IGkgPCAyOyBpKyspCisgICAgICAgIG9baV0gPSB1bmRlZmluZWQ7CisgICAgby5sZW5n dGggPSB1bmRlZmluZWQ7CisgICAgcmV0dXJuIG87Cit9CisKK2Z1bmN0aW9uIGZvbyhhKSB7Cisg ICAgYmFyKGEpOworICAgIHVuZGVmaW5lZCArIGJhcigwKSArIGJhcigwKTsKKyAgICBmb3IobGV0 IGkgPSAwOyBpIDwgMTAwMDAwMDA7IGkrKykge30KK30KKworZm9vKHt9KTsKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQwODEyKQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAxLTMx ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBDb25zdGFudCBmb2xk IERvdWJsZVJlcCBvZiBhIG51bWVyaWMgY29uc3RhbnQgaW50byBhIERvdWJsZUNvbnN0YW50Lgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MTMwCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzY5OTQ3ND4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbHNvIHJlbW92ZSBhbiBpbnZhbGlkIGFzc2VydGlv biBpbiBERkcncyBjb21waWxlRG91YmxlUmVwKCkuCisKKyAgICAgICAgKiBkZmcvREZHQ29uc3Rh bnRGb2xkaW5nUGhhc2UuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkNvbnN0YW50Rm9sZGluZ1Bo YXNlOjpmb2xkQ29uc3RhbnRzKToKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQuY3Bw OgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpjb21waWxlRG91YmxlUmVwKToK KwogMjAxOS0wMS0zMSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIGZvbGxvdy11cCBhZnRlciByMjQwNzk2CkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR0NvbnN0YW50Rm9sZGluZ1BoYXNlLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0NvbnN0YW50Rm9sZGluZ1BoYXNlLmNwcAko cmV2aXNpb24gMjQwODEyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDb25zdGFu dEZvbGRpbmdQaGFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc4OCw2ICs3ODgsMTQgQEAgcHJp dmF0ZToKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIH0KIAorICAgICAgICAg ICAgY2FzZSBEb3VibGVSZXA6IHsKKyAgICAgICAgICAgICAgICBpZiAobm9kZS0+Y2hpbGQxKCkt PmlzTnVtYmVyQ29uc3RhbnQoKSkgeworICAgICAgICAgICAgICAgICAgICBtX2dyYXBoLmNvbnZl cnRUb0NvbnN0YW50KG5vZGUsIEpTVmFsdWUobm9kZS0+Y2hpbGQxKCktPmFzTnVtYmVyKCkpKTsK KyAgICAgICAgICAgICAgICAgICAgY2hhbmdlZCA9IHRydWU7CisgICAgICAgICAgICAgICAgfQor ICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgfQorCiAgICAgICAgICAgICBjYXNl IE5vcm1hbGl6ZU1hcEtleTogewogICAgICAgICAgICAgICAgIFNwZWN1bGF0ZWRUeXBlIHR5cGVN YXliZU5vcm1hbGl6ZWQgPSAoU3BlY0Z1bGxOdW1iZXIgJiB+U3BlY0ludDMyT25seSk7CiAgICAg ICAgICAgICAgICAgaWYgKG1fc3RhdGUuZm9yTm9kZShub2RlLT5jaGlsZDEoKSkubV90eXBlICYg dHlwZU1heWJlTm9ybWFsaXplZCkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH U3BlY3VsYXRpdmVKSVQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCShyZXZpc2lvbiAyNDA4MTIpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAkod29ya2luZyBjb3B5KQpAQCAt MjU4NSw4ICsyNTg1LDYgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZURvdWJsZVJlcChO bwogICAgIAogICAgIGNhc2UgTm90Q2VsbFVzZToKICAgICBjYXNlIE51bWJlclVzZTogewotICAg ICAgICBBU1NFUlQoIW5vZGUtPmNoaWxkMSgpLT5pc051bWJlckNvbnN0YW50KCkpOyAvLyBUaGlz IHNob3VsZCBoYXZlIGJlZW4gY29uc3RhbnQgZm9sZGVkLgotCiAgICAgICAgIFNwZWN1bGF0ZWRU eXBlIHBvc3NpYmxlVHlwZXMgPSBtX3N0YXRlLmZvck5vZGUobm9kZS0+Y2hpbGQxKCkpLm1fdHlw ZTsKICAgICAgICAgaWYgKGlzSW50MzJTcGVjdWxhdGlvbihwb3NzaWJsZVR5cGVzKSkgewogICAg ICAgICAgICAgU3BlY3VsYXRlSW50MzJPcGVyYW5kIG9wMSh0aGlzLCBub2RlLT5jaGlsZDEoKSwg TWFudWFsT3BlcmFuZFNwZWN1bGF0aW9uKTsK 360877 2019-02-01 11:27:41 -0800 2019-02-01 14:47:25 -0800 patch for landing. bug-194130.patch text/plain 2808 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDA4NTkpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE5LTAyLTAxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBSZW1vdmUgaW52YWxpZCBhc3NlcnRpb24gaW4gREZHJ3MgY29tcGlsZURv dWJsZVJlcCgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk0MTMwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzY5OTQ3ND4KKworICAgICAgICBS ZXZpZXdlZCBieSBTYWFtIEJhcmF0aS4KKworICAgICAgICAqIHN0cmVzcy9jb25zdGFudC1mb2xk LWRvdWJsZS1yZXAtaW50by1kb3VibGUtY29uc3RhbnQuanM6IEFkZGVkLgorCiAyMDE5LTAxLTMw ICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBJbXBv cnQgbGF0ZXN0IFRlc3QyNjIgdXBkYXRlcy4KSW5kZXg6IEpTVGVzdHMvc3RyZXNzL2NvbnN0YW50 LWZvbGQtZG91YmxlLXJlcC1pbnRvLWRvdWJsZS1jb25zdGFudC5qcwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBK U1Rlc3RzL3N0cmVzcy9jb25zdGFudC1mb2xkLWRvdWJsZS1yZXAtaW50by1kb3VibGUtY29uc3Rh bnQuanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3MvY29uc3RhbnQtZm9sZC1kb3Vi bGUtcmVwLWludG8tZG91YmxlLWNvbnN0YW50LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEs MTQgQEAKK2Z1bmN0aW9uIGJhcihvKSB7CisgICAgZm9yIChsZXQgaSA9IDA7IGkgPCAyOyBpKysp CisgICAgICAgIG9baV0gPSB1bmRlZmluZWQ7CisgICAgby5sZW5ndGggPSB1bmRlZmluZWQ7Cisg ICAgcmV0dXJuIG87Cit9CisKK2Z1bmN0aW9uIGZvbyhhKSB7CisgICAgYmFyKGEpOworICAgIHVu ZGVmaW5lZCArIGJhcigwKSArIGJhcigwKTsKKyAgICBmb3IobGV0IGkgPSAwOyBpIDwgMTAwMDAw MDA7IGkrKykge30KK30KKworZm9vKHt9KTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9D aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwko cmV2aXNpb24gMjQwODU4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE5LTAyLTAxICBNYXJrIExhbSAgPG1hcmsu bGFtQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgaW52YWxpZCBhc3NlcnRpb24gaW4gREZH J3MgY29tcGlsZURvdWJsZVJlcCgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTk0MTMwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzY5OTQ3ND4K KworICAgICAgICBSZXZpZXdlZCBieSBTYWFtIEJhcmF0aS4KKworICAgICAgICAqIGRmZy9ERkdT cGVjdWxhdGl2ZUpJVC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNv bXBpbGVEb3VibGVSZXApOgorCiAyMDE5LTAxLTMxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxl LmNvbT4KIAogICAgICAgICBSZW1vdmUgcG9pc29uaW5nIGZyb20gQ29kZUJsb2NrIGFuZCBMTElu dCBjb2RlLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJ VC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxh dGl2ZUpJVC5jcHAJKHJldmlzaW9uIDI0MDg1OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAog LyoKLSAqIENvcHlyaWdodCAoQykgMjAxMS0yMDE4IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNl cnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxMS0yMDE5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyBy ZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmlu YXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRl ZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMjU4NSw4ICsyNTg1 LDYgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZURvdWJsZVJlcChObwogICAgIAogICAg IGNhc2UgTm90Q2VsbFVzZToKICAgICBjYXNlIE51bWJlclVzZTogewotICAgICAgICBBU1NFUlQo IW5vZGUtPmNoaWxkMSgpLT5pc051bWJlckNvbnN0YW50KCkpOyAvLyBUaGlzIHNob3VsZCBoYXZl IGJlZW4gY29uc3RhbnQgZm9sZGVkLgotCiAgICAgICAgIFNwZWN1bGF0ZWRUeXBlIHBvc3NpYmxl VHlwZXMgPSBtX3N0YXRlLmZvck5vZGUobm9kZS0+Y2hpbGQxKCkpLm1fdHlwZTsKICAgICAgICAg aWYgKGlzSW50MzJTcGVjdWxhdGlvbihwb3NzaWJsZVR5cGVzKSkgewogICAgICAgICAgICAgU3Bl Y3VsYXRlSW50MzJPcGVyYW5kIG9wMSh0aGlzLCBub2RlLT5jaGlsZDEoKSwgTWFudWFsT3BlcmFu ZFNwZWN1bGF0aW9uKTsK