194118 2019-01-31 15:31:24 -0800 Web Inspector: Make WI.CircleChart a WI.View subclass 2019-02-01 13:27:28 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck hi inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1500847 0 joepeck 2019-01-31 15:31:24 -0800 Make WI.CircleChart a WI.View subclass It can eliminate its own needsLayout/updateLayout logic and participate in normal view drawing. 1500848 1 360794 joepeck 2019-01-31 15:31:51 -0800 Created attachment 360794 [PATCH] Proposed Fix 1500850 2 360794 mattbaker 2019-01-31 15:35:22 -0800 Comment on attachment 360794 [PATCH] Proposed Fix r=me 1500855 3 mattbaker 2019-01-31 15:38:21 -0800 CircleChart could also implement View.prototype.initalLayout, and then you could lazily create the chart/path elements instead of creating them in the constructor. 1500857 4 360794 hi 2019-01-31 15:38:31 -0800 Comment on attachment 360794 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=360794&action=review > Source/WebInspectorUI/UserInterface/Views/CircleChart.js:79 > get points() { return this._points; } > get size() { return this._size; } NIT: I think we can drop these as well. 1501244 5 joepeck 2019-02-01 13:26:46 -0800 https://trac.webkit.org/changeset/240870/webkit 1501249 6 webkit-bug-importer 2019-02-01 13:27:28 -0800 <rdar://problem/47747266> 360794 2019-01-31 15:31:51 -0800 2019-02-01 12:07:09 -0800 [PATCH] Proposed Fix circle-chart-1.patch text/plain 6225 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDVjODEwYmNiZTM4Li5mY2RhNDJmNzhkMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDEtMzEgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBNYWtlIFdJLkNpcmNsZUNoYXJ0IGEgV0kuVmlldyBzdWJjbGFzcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MTE4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0Np cmNsZUNoYXJ0LmpzOgorICAgICAgICAoV0kuQ2lyY2xlQ2hhcnQucHJvdG90eXBlLmdldCBjZW50 ZXJFbGVtZW50KToKKyAgICAgICAgKFdJLkNpcmNsZUNoYXJ0LnByb3RvdHlwZS5sYXlvdXQpOgor ICAgICAgICAoV0kuQ2lyY2xlQ2hhcnQucHJvdG90eXBlLmdldCBlbGVtZW50KTogRGVsZXRlZC4K KyAgICAgICAgKFdJLkNpcmNsZUNoYXJ0LnByb3RvdHlwZS5uZWVkc0xheW91dCk6IERlbGV0ZWQu CisgICAgICAgIChXSS5DaXJjbGVDaGFydC5wcm90b3R5cGUudXBkYXRlTGF5b3V0KTogRGVsZXRl ZC4KKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL01lbW9yeVRpbWVsaW5lVmlldy5qczoK KyAgICAgICAgKFdJLk1lbW9yeVRpbWVsaW5lVmlldyk6CisKIDIwMTktMDEtMzEgIEpvc2VwaCBQ ZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBU aW1lbGluZSBEZXRhaWwgVmlld3MgZG8gbm90IHJlc2V0IHByb3Blcmx5IHdoZW4gbmV3IHRpbWUg cmFuZ2Ugc2VsZWN0aW9uIGNvbnRhaW5zIG5vdGhpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NpcmNsZUNoYXJ0LmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2lyY2xlQ2hhcnQuanMKaW5kZXggZmNl NTQ2OTFhYjUuLmJlNDQwYjFiZGMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9DaXJjbGVDaGFydC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DaXJjbGVDaGFydC5qcwpAQCAtMzcsNyArMzcsNyBA QAogLy8gLSBJZiB5b3Ugd2FudCB0byBwdXQgc29tZXRoaW5nIGluc2lkZSB0aGUgbWlkZGxlIG9m IHRoZSBjaGFydCB5b3UgY2FuIHVzZSBgY2VudGVyRWxlbWVudGAuCiAvLwogLy8gIDxkaXYgY2xh c3M9ImNpcmNsZS1jaGFydCI+Ci0vLyAgICAgIDxzdmcgd2lkdGg9IjEyMCIgaGVpZ2h0PSIxMjAi IHZpZXdib3g9IjAgMCAxMjAgMTIwIj4KKy8vICAgICAgPHN2ZyB3aWR0aD0iMTIwIiBoZWlnaHQ9 IjEyMCIgdmlld0JveD0iMCAwIDEyMCAxMjAiPgogLy8gICAgICAgICAgPHBhdGggY2xhc3M9ImJh Y2tncm91bmQiIGQ9Ii4uLiIvPgogLy8gICAgICAgICAgPHBhdGggY2xhc3M9InNlZ21lbnQgc2Vn bWVudC1jbGFzcy1uYW1lLTEiIGQ9Ii4uLiIvPgogLy8gICAgICAgICAgPHBhdGggY2xhc3M9InNl Z21lbnQgc2VnbWVudC1jbGFzcy1uYW1lLTIiIGQ9Ii4uLiIvPgpAQCAtNDYsMjIgKzQ2LDIzIEBA CiAvLyAgICAgIDxkaXYgY2xhc3M9ImNlbnRlciI+PC9kaXY+CiAvLyAgPC9kaXY+CiAKLVdJLkNp cmNsZUNoYXJ0ID0gY2xhc3MgQ2lyY2xlQ2hhcnQKK1dJLkNpcmNsZUNoYXJ0ID0gY2xhc3MgQ2ly Y2xlQ2hhcnQgZXh0ZW5kcyBXSS5WaWV3CiB7CiAgICAgY29uc3RydWN0b3Ioe3NpemUsIGlubmVy UmFkaXVzUmF0aW99KQogICAgIHsKKyAgICAgICAgc3VwZXIoKTsKKwogICAgICAgICB0aGlzLl9k YXRhID0gW107CiAgICAgICAgIHRoaXMuX3NpemUgPSBzaXplOwogICAgICAgICB0aGlzLl9yYWRp dXMgPSAoc2l6ZSAvIDIpIC0gMTsKICAgICAgICAgdGhpcy5faW5uZXJSYWRpdXMgPSBpbm5lclJh ZGl1c1JhdGlvID8gTWF0aC5mbG9vcih0aGlzLl9yYWRpdXMgKiBpbm5lclJhZGl1c1JhdGlvKSA6 IDA7CiAKLSAgICAgICAgdGhpcy5fZWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRp diIpOwotICAgICAgICB0aGlzLl9lbGVtZW50LmNsYXNzTGlzdC5hZGQoImNpcmNsZS1jaGFydCIp OworICAgICAgICB0aGlzLmVsZW1lbnQuY2xhc3NMaXN0LmFkZCgiY2lyY2xlLWNoYXJ0Iik7CiAK LSAgICAgICAgdGhpcy5fY2hhcnRFbGVtZW50ID0gdGhpcy5fZWxlbWVudC5hcHBlbmRDaGlsZChj cmVhdGVTVkdFbGVtZW50KCJzdmciKSk7CisgICAgICAgIHRoaXMuX2NoYXJ0RWxlbWVudCA9IHRo aXMuZWxlbWVudC5hcHBlbmRDaGlsZChjcmVhdGVTVkdFbGVtZW50KCJzdmciKSk7CiAgICAgICAg IHRoaXMuX2NoYXJ0RWxlbWVudC5zZXRBdHRyaWJ1dGUoIndpZHRoIiwgc2l6ZSk7CiAgICAgICAg IHRoaXMuX2NoYXJ0RWxlbWVudC5zZXRBdHRyaWJ1dGUoImhlaWdodCIsIHNpemUpOwotICAgICAg ICB0aGlzLl9jaGFydEVsZW1lbnQuc2V0QXR0cmlidXRlKCJ2aWV3Ym94IiwgYDAgMCAke3NpemV9 ICR7c2l6ZX1gKTsKKyAgICAgICAgdGhpcy5fY2hhcnRFbGVtZW50LnNldEF0dHJpYnV0ZSgidmll d0JveCIsIGAwIDAgJHtzaXplfSAke3NpemV9YCk7CiAKICAgICAgICAgdGhpcy5fcGF0aEVsZW1l bnRzID0gW107CiAgICAgICAgIHRoaXMuX3ZhbHVlcyA9IFtdOwpAQCAtNzQsMTQgKzc1LDEzIEBA IFdJLkNpcmNsZUNoYXJ0ID0gY2xhc3MgQ2lyY2xlQ2hhcnQKIAogICAgIC8vIFB1YmxpYwogCi0g ICAgZ2V0IGVsZW1lbnQoKSB7IHJldHVybiB0aGlzLl9lbGVtZW50OyB9CiAgICAgZ2V0IHBvaW50 cygpIHsgcmV0dXJuIHRoaXMuX3BvaW50czsgfQogICAgIGdldCBzaXplKCkgeyByZXR1cm4gdGhp cy5fc2l6ZTsgfQogCiAgICAgZ2V0IGNlbnRlckVsZW1lbnQoKQogICAgIHsKICAgICAgICAgaWYg KCF0aGlzLl9jZW50ZXJFbGVtZW50KSB7Ci0gICAgICAgICAgICB0aGlzLl9jZW50ZXJFbGVtZW50 ID0gdGhpcy5fZWxlbWVudC5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYi KSk7CisgICAgICAgICAgICB0aGlzLl9jZW50ZXJFbGVtZW50ID0gdGhpcy5lbGVtZW50LmFwcGVu ZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpKTsKICAgICAgICAgICAgIHRoaXMu X2NlbnRlckVsZW1lbnQuY2xhc3NMaXN0LmFkZCgiY2VudGVyIik7CiAgICAgICAgICAgICB0aGlz Ll9jZW50ZXJFbGVtZW50LnN0eWxlLndpZHRoID0gdGhpcy5fY2VudGVyRWxlbWVudC5zdHlsZS5o ZWlnaHQgPSB0aGlzLl9yYWRpdXMgKyAicHgiOwogICAgICAgICAgICAgdGhpcy5fY2VudGVyRWxl bWVudC5zdHlsZS50b3AgPSB0aGlzLl9jZW50ZXJFbGVtZW50LnN0eWxlLmxlZnQgPSAodGhpcy5f cmFkaXVzIC0gdGhpcy5faW5uZXJSYWRpdXMpICsgInB4IjsKQEAgLTEzMCwyMSArMTMwLDE1IEBA IFdJLkNpcmNsZUNoYXJ0ID0gY2xhc3MgQ2lyY2xlQ2hhcnQKICAgICAgICAgdGhpcy52YWx1ZXMg PSBuZXcgQXJyYXkodGhpcy5fdmFsdWVzLmxlbmd0aCkuZmlsbCgwKTsKICAgICB9CiAKLSAgICBu ZWVkc0xheW91dCgpCisgICAgLy8gUHJvdGVjdGVkCisKKyAgICBsYXlvdXQoKQogICAgIHsKLSAg ICAgICAgaWYgKHRoaXMuX3NjaGVkdWxlZExheW91dFVwZGF0ZUlkZW50aWZpZXIpCisgICAgICAg IHN1cGVyLmxheW91dCgpOworCisgICAgICAgIGlmICh0aGlzLmxheW91dFJlYXNvbiA9PT0gV0ku Vmlldy5MYXlvdXRSZWFzb24uUmVzaXplKQogICAgICAgICAgICAgcmV0dXJuOwogCi0gICAgICAg IHRoaXMuX3NjaGVkdWxlZExheW91dFVwZGF0ZUlkZW50aWZpZXIgPSByZXF1ZXN0QW5pbWF0aW9u RnJhbWUodGhpcy51cGRhdGVMYXlvdXQuYmluZCh0aGlzKSk7Ci0gICAgfQotCi0gICAgdXBkYXRl TGF5b3V0KCkKLSAgICB7Ci0gICAgICAgIGlmICh0aGlzLl9zY2hlZHVsZWRMYXlvdXRVcGRhdGVJ ZGVudGlmaWVyKSB7Ci0gICAgICAgICAgICBjYW5jZWxBbmltYXRpb25GcmFtZSh0aGlzLl9zY2hl ZHVsZWRMYXlvdXRVcGRhdGVJZGVudGlmaWVyKTsKLSAgICAgICAgICAgIHRoaXMuX3NjaGVkdWxl ZExheW91dFVwZGF0ZUlkZW50aWZpZXIgPSB1bmRlZmluZWQ7Ci0gICAgICAgIH0KLQogICAgICAg ICBpZiAoIXRoaXMuX3ZhbHVlcy5sZW5ndGgpCiAgICAgICAgICAgICByZXR1cm47CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL01lbW9yeVRp bWVsaW5lVmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L01lbW9yeVRpbWVsaW5lVmlldy5qcwppbmRleCA3MzAzZDhlNTAyNS4uOGVhZDMwZTcwNzEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL01lbW9y eVRpbWVsaW5lVmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9NZW1vcnlUaW1lbGluZVZpZXcuanMKQEAgLTU4LDYgKzU4LDcgQEAgV0kuTWVtb3J5 VGltZWxpbmVWaWV3ID0gY2xhc3MgTWVtb3J5VGltZWxpbmVWaWV3IGV4dGVuZHMgV0kuVGltZWxp bmVWaWV3CiAgICAgICAgIGxldCB1c2FnZVRvb2x0aXAgPSBXSS5VSVN0cmluZygiQnJlYWtkb3du IG9mIGVhY2ggbWVtb3J5IGNhdGVnb3J5IGF0IHRoZSBlbmQgb2YgdGhlIHNlbGVjdGVkIHRpbWUg cmFuZ2UiKTsKICAgICAgICAgbGV0IHVzYWdlQ2hhcnRDb250YWluZXJFbGVtZW50ID0gY3JlYXRl Q2hhcnRDb250YWluZXIob3ZlcnZpZXdFbGVtZW50LCBXSS5VSVN0cmluZygiQnJlYWtkb3duIiks IHVzYWdlVG9vbHRpcCk7CiAgICAgICAgIHRoaXMuX3VzYWdlQ2lyY2xlQ2hhcnQgPSBuZXcgV0ku Q2lyY2xlQ2hhcnQoe3NpemU6IDEyMCwgaW5uZXJSYWRpdXNSYXRpbzogMC41fSk7CisgICAgICAg IHRoaXMuYWRkU3Vidmlldyh0aGlzLl91c2FnZUNpcmNsZUNoYXJ0KTsKICAgICAgICAgdXNhZ2VD aGFydENvbnRhaW5lckVsZW1lbnQuYXBwZW5kQ2hpbGQodGhpcy5fdXNhZ2VDaXJjbGVDaGFydC5l bGVtZW50KTsKICAgICAgICAgdGhpcy5fdXNhZ2VMZWdlbmRFbGVtZW50ID0gdXNhZ2VDaGFydENv bnRhaW5lckVsZW1lbnQuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iikp OwogICAgICAgICB0aGlzLl91c2FnZUxlZ2VuZEVsZW1lbnQuY2xhc3NMaXN0LmFkZCgibGVnZW5k IiwgInVzYWdlIik7CkBAIC02OCw2ICs2OSw3IEBAIFdJLk1lbW9yeVRpbWVsaW5lVmlldyA9IGNs YXNzIE1lbW9yeVRpbWVsaW5lVmlldyBleHRlbmRzIFdJLlRpbWVsaW5lVmlldwogICAgICAgICBs ZXQgbWF4Q29tcGFyaXNvblRvb2x0aXAgPSBXSS5VSVN0cmluZygiQ29tcGFyaXNvbiBvZiB0b3Rh bCBtZW1vcnkgc2l6ZSBhdCB0aGUgZW5kIG9mIHRoZSBzZWxlY3RlZCB0aW1lIHJhbmdlIHRvIHRo ZSBtYXhpbXVtIG1lbW9yeSBzaXplIGluIHRoaXMgcmVjb3JkaW5nIik7CiAgICAgICAgIGxldCBt YXhDb21wYXJpc29uQ2hhcnRDb250YWluZXJFbGVtZW50ID0gY3JlYXRlQ2hhcnRDb250YWluZXIo b3ZlcnZpZXdFbGVtZW50LCBXSS5VSVN0cmluZygiTWF4IENvbXBhcmlzb24iKSwgbWF4Q29tcGFy aXNvblRvb2x0aXApOwogICAgICAgICB0aGlzLl9tYXhDb21wYXJpc29uQ2lyY2xlQ2hhcnQgPSBu ZXcgV0kuQ2lyY2xlQ2hhcnQoe3NpemU6IDEyMCwgaW5uZXJSYWRpdXNSYXRpbzogMC41fSk7Cisg ICAgICAgIHRoaXMuYWRkU3Vidmlldyh0aGlzLl9tYXhDb21wYXJpc29uQ2lyY2xlQ2hhcnQpOwog ICAgICAgICBtYXhDb21wYXJpc29uQ2hhcnRDb250YWluZXJFbGVtZW50LmFwcGVuZENoaWxkKHRo aXMuX21heENvbXBhcmlzb25DaXJjbGVDaGFydC5lbGVtZW50KTsKICAgICAgICAgdGhpcy5fbWF4 Q29tcGFyaXNvbkxlZ2VuZEVsZW1lbnQgPSBtYXhDb21wYXJpc29uQ2hhcnRDb250YWluZXJFbGVt ZW50LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpKTsKICAgICAgICAg dGhpcy5fbWF4Q29tcGFyaXNvbkxlZ2VuZEVsZW1lbnQuY2xhc3NMaXN0LmFkZCgibGVnZW5kIiwg Im1heGltdW0iKTsK