194115 2019-01-31 14:35:12 -0800 Web Inspector: Timeline Detail Views do not reset properly when new time range selection contains nothing 2019-02-01 13:26:37 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1500815 0 joepeck 2019-01-31 14:35:12 -0800 Timeline Detail Views do not reset properly when new time range selection contains nothing Steps to Reproduce: 1. Inspect this page 2. Show Memory Timeline 3. Make a short recording 4. Select an empty time range (like 4s-5s) => Memory Detail View circle charts still filled Notes: - layout() should be resetting instead of bailing 1500816 1 webkit-bug-importer 2019-01-31 14:35:43 -0800 <rdar://problem/47716693> 1500830 2 360791 joepeck 2019-01-31 14:59:07 -0800 Created attachment 360791 [PATCH] Proposed Fix 1500836 3 360791 hi 2019-01-31 15:15:39 -0800 Comment on attachment 360791 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=360791&action=review rs=me > Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js:83 > + this.clear(); I think this deserves a ChangeLog comment. Something like "Calling `.clear()` will remove all UI from the selected range, but keep any non-range-specific values (e.g. maximum usage) as they were in the UI.". 1501242 4 joepeck 2019-02-01 13:26:37 -0800 https://trac.webkit.org/changeset/240869/webkit 360791 2019-01-31 14:59:07 -0800 2019-02-01 11:59:04 -0800 [PATCH] Proposed Fix clear-1.patch text/plain 3748 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGE3MzhjMzEyYzI4Li41YzgxMGJjYmUzOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTktMDEtMzEgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBUaW1lbGluZSBEZXRhaWwgVmlld3MgZG8gbm90IHJlc2V0IHByb3Blcmx5IHdoZW4gbmV3IHRp bWUgcmFuZ2Ugc2VsZWN0aW9uIGNvbnRhaW5zIG5vdGhpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDExNQorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNDc3MTY2OTM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0NQVVRpbWVsaW5lVmlldy5qczoKKyAgICAgICAg KFdJLkNQVVRpbWVsaW5lVmlldy5wcm90b3R5cGUucmVzZXQpOgorICAgICAgICAoV0kuQ1BVVGlt ZWxpbmVWaWV3LnByb3RvdHlwZS5jbGVhcik6CisgICAgICAgIChXSS5DUFVUaW1lbGluZVZpZXcu cHJvdG90eXBlLmxheW91dCk6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9NZW1vcnlU aW1lbGluZVZpZXcuanM6CisgICAgICAgIChXSS5NZW1vcnlUaW1lbGluZVZpZXcucHJvdG90eXBl LnJlc2V0KToKKyAgICAgICAgKFdJLk1lbW9yeVRpbWVsaW5lVmlldy5wcm90b3R5cGUuY2xlYXIp OgorICAgICAgICAoV0kuTWVtb3J5VGltZWxpbmVWaWV3LnByb3RvdHlwZS5sYXlvdXQpOgorICAg ICAgICBXaGVuIHRoZXJlIGFyZSBubyB2aXNpYmxlIHJlY29yZHMgaW4gdGhlIHNlbGVjdGVkIHJh bmdlIGNsZWFyIG91ciBVSS4KKwogMjAxOS0wMS0zMSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jh cm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFRpbWVsaW5lIGdyYXBocyBo YXZlIGRyYXdpbmcgaXNzdWVzIHdpdGggbXVsdGlwbGUgZGlzY29udGludWl0aWVzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DUFVUaW1lbGlu ZVZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DUFVU aW1lbGluZVZpZXcuanMKaW5kZXggNzQxY2FmNDA2YmEuLmQ3YTUzY2UyOTM4IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DUFVUaW1lbGluZVZp ZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1BV VGltZWxpbmVWaWV3LmpzCkBAIC04MCw2ICs4MCwxMSBAQCBXSS5DUFVUaW1lbGluZVZpZXcgPSBj bGFzcyBDUFVUaW1lbGluZVZpZXcgZXh0ZW5kcyBXSS5UaW1lbGluZVZpZXcKIAogICAgICAgICB0 aGlzLl9tYXhVc2FnZSA9IC1JbmZpbml0eTsKIAorICAgICAgICB0aGlzLmNsZWFyKCk7CisgICAg fQorCisgICAgY2xlYXIoKQorICAgIHsKICAgICAgICAgdGhpcy5fY3B1VXNhZ2VWaWV3LmNsZWFy KCk7CiAgICAgfQogCkBAIC0xMTQsOCArMTE5LDEwIEBAIFdJLkNQVVRpbWVsaW5lVmlldyA9IGNs YXNzIENQVVRpbWVsaW5lVmlldyBleHRlbmRzIFdJLlRpbWVsaW5lVmlldwogICAgICAgICAvLyBE b24ndCBpbmNsdWRlIHRoZSByZWNvcmQgYmVmb3JlIHRoZSBncmFwaCBzdGFydCBpZiB0aGUgZ3Jh cGggc3RhcnQgaXMgd2l0aGluIGEgZ2FwLgogICAgICAgICBsZXQgaW5jbHVkZVJlY29yZEJlZm9y ZVN0YXJ0ID0gIWRpc2NvbnRpbnVpdGllcy5sZW5ndGggfHwgZGlzY29udGludWl0aWVzWzBdLnN0 YXJ0VGltZSA+IGdyYXBoU3RhcnRUaW1lOwogICAgICAgICBsZXQgdmlzaWJsZVJlY29yZHMgPSB0 aGlzLnJlcHJlc2VudGVkT2JqZWN0LnJlY29yZHNJblRpbWVSYW5nZShncmFwaFN0YXJ0VGltZSwg dmlzaWJsZUVuZFRpbWUsIGluY2x1ZGVSZWNvcmRCZWZvcmVTdGFydCk7Ci0gICAgICAgIGlmICgh dmlzaWJsZVJlY29yZHMubGVuZ3RoKQorICAgICAgICBpZiAoIXZpc2libGVSZWNvcmRzLmxlbmd0 aCB8fCAodmlzaWJsZVJlY29yZHMubGVuZ3RoID09PSAxICYmIHZpc2libGVSZWNvcmRzWzBdLmVu ZFRpbWUgPCBncmFwaFN0YXJ0VGltZSkpIHsKKyAgICAgICAgICAgIHRoaXMuY2xlYXIoKTsKICAg ICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQogCiAgICAgICAgIC8vIFVwZGF0ZSB0b3RhbCB1 c2FnZSBjaGFydCB3aXRoIHRoZSBsYXN0IHJlY29yZCdzIGRhdGEuCiAgICAgICAgIGxldCBsYXN0 UmVjb3JkID0gdmlzaWJsZVJlY29yZHMubGFzdFZhbHVlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTWVtb3J5VGltZWxpbmVWaWV3LmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTWVtb3J5VGltZWxpbmVW aWV3LmpzCmluZGV4IGM2OTJlMGJlYjJjLi43MzAzZDhlNTAyNSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTWVtb3J5VGltZWxpbmVWaWV3Lmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL01lbW9yeVRp bWVsaW5lVmlldy5qcwpAQCAtMTMxLDYgKzEzMSwxMSBAQCBXSS5NZW1vcnlUaW1lbGluZVZpZXcg PSBjbGFzcyBNZW1vcnlUaW1lbGluZVZpZXcgZXh0ZW5kcyBXSS5UaW1lbGluZVZpZXcKIAogICAg ICAgICB0aGlzLl9tYXhTaXplID0gMDsKIAorICAgICAgICB0aGlzLmNsZWFyKCk7CisgICAgfQor CisgICAgY2xlYXIoKQorICAgIHsKICAgICAgICAgdGhpcy5fY2FjaGVkTGVnZW5kUmVjb3JkID0g bnVsbDsKICAgICAgICAgdGhpcy5fY2FjaGVkTGVnZW5kTWF4U2l6ZSA9IHVuZGVmaW5lZDsKICAg ICAgICAgdGhpcy5fY2FjaGVkTGVnZW5kQ3VycmVudFNpemUgPSB1bmRlZmluZWQ7CkBAIC0xODMs OCArMTg4LDEwIEBAIFdJLk1lbW9yeVRpbWVsaW5lVmlldyA9IGNsYXNzIE1lbW9yeVRpbWVsaW5l VmlldyBleHRlbmRzIFdJLlRpbWVsaW5lVmlldwogCiAgICAgICAgIC8vIEZJWE1FOiA8aHR0cHM6 Ly93ZWJraXQub3JnL2IvMTUzNzU5PiBXZWIgSW5zcGVjdG9yOiBNZW1vcnkgVGltZWxpbmVzIHNo b3VsZCBiZXR0ZXIgZXh0ZW5kIHRvIGZ1dHVyZSBkYXRhCiAgICAgICAgIGxldCB2aXNpYmxlUmVj b3JkcyA9IHRoaXMucmVwcmVzZW50ZWRPYmplY3QucmVjb3Jkc0luVGltZVJhbmdlKGdyYXBoU3Rh cnRUaW1lLCB2aXNpYmxlRW5kVGltZSwgaW5jbHVkZVJlY29yZEJlZm9yZVN0YXJ0KTsKLSAgICAg ICAgaWYgKCF2aXNpYmxlUmVjb3Jkcy5sZW5ndGgpCisgICAgICAgIGlmICghdmlzaWJsZVJlY29y ZHMubGVuZ3RoIHx8ICh2aXNpYmxlUmVjb3Jkcy5sZW5ndGggPT09IDEgJiYgdmlzaWJsZVJlY29y ZHNbMF0uZW5kVGltZSA8IGdyYXBoU3RhcnRUaW1lKSkgeworICAgICAgICAgICAgdGhpcy5jbGVh cigpOwogICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CiAKICAgICAgICAgLy8gVXBkYXRl IHRvdGFsIHVzYWdlIGNoYXJ0IHdpdGggdGhlIGxhc3QgcmVjb3JkJ3MgZGF0YS4KICAgICAgICAg bGV0IGxhc3RSZWNvcmQgPSB2aXNpYmxlUmVjb3Jkcy5sYXN0VmFsdWU7Cg==