194106 2019-01-31 13:18:41 -0800 Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr 2019-02-01 07:05:32 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=194155 InRadar P2 Normal --- 1 youennf youennf aakash_jain commit-queue eric.carlson ggaren rniwa webkit-bug-importer youennf oldest_to_newest 1500730 0 youennf 2019-01-31 13:18:41 -0800 Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr 1500735 1 youennf 2019-01-31 13:25:29 -0800 <rdar://problem/47676333> 1500738 2 360764 youennf 2019-01-31 13:29:00 -0800 Created attachment 360764 Patch 1500893 3 360764 commit-queue 2019-01-31 16:45:24 -0800 Comment on attachment 360764 Patch Clearing flags on attachment: 360764 Committed r240830: <https://trac.webkit.org/changeset/240830> 1500894 4 commit-queue 2019-01-31 16:45:26 -0800 All reviewed patches have been landed. Closing bug. 1501101 5 aakash_jain 2019-02-01 07:05:32 -0800 This seems to have broken API Test: TestWebKitAPI.WebKit2.GetUserMediaReprompt See https://bugs.webkit.org/show_bug.cgi?id=194155 360764 2019-01-31 13:29:00 -0800 2019-01-31 16:45:24 -0800 Patch bug-194106-20190131132858.patch text/plain 4156 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNzk1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTZjOWQ0Njc4NzRiZTg1YTdlZTBjN2MzYWQ2Y2JjNGJh MzYxNjZkMy4uODMyNWIxNzUyZDcxYzE0MTJkYzkzMzg4NzU3YzhkNWM2ZDU1NTMyOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE5LTAxLTMxICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAg ICAgICBBZGQgYW4gQVBJIHRlc3QgdG8gY292ZXIgVUlDbGllbnQgY2hlY2tVc2VyTWVkaWFQZXJt aXNzaW9uRm9yT3JpZ2luIGJlaW5nIG51bGxwdHIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDEwNgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDc2 NzYzMzM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9Vc2VyTWVkaWEuY3BwOgorICAgICAgICAoVGVz dFdlYktpdEFQSTo6ZGlkRmluaXNoTmF2aWdhdGlvbik6CisgICAgICAgIChUZXN0V2ViS2l0QVBJ OjpURVNUKToKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9nZXRVc2VyTWVk aWEuaHRtbDoKKwogMjAxOS0wMS0zMSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgog CiAgICAgICAgIFtMRkNdIE1hcmdpbiBiZWZvcmUvYWZ0ZXIvc3RhcnQvZW5kIGluaXRpYWwgdmFs dWUgaXMgMCBhbmQgbm90IGF1dG8uCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYktpdC9Vc2VyTWVkaWEuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXQvVXNlck1lZGlhLmNwcAppbmRleCAyYjA2YjBiOGFkNjEzYWM0OTg5Yjc0N2E5YTVmYTQ1ODZl ODk5MDAxLi5hMGMyMWQ3MWM4NWI3MDI4MTViYzU1OTcxMWUzODc2NzcyODhhMjY0IDEwMDY0NAot LS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9Vc2VyTWVkaWEuY3BwCisrKyBi L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0L1VzZXJNZWRpYS5jcHAKQEAgLTE1Nyw2 ICsxNTcsNDQgQEAgVEVTVChXZWJLaXQsIE9uRGV2aWNlQ2hhbmdlQ3Jhc2gpCiAgICAgRVhQRUNU X1RSVUUoIWRpZENyYXNoKTsKIH0KIAorc3RhdGljIGJvb2wgZGlkUmVjZWl2ZU1lc3NhZ2U7Citz dGF0aWMgdm9pZCBkaWRGaW5pc2hOYXZpZ2F0aW9uKFdLUGFnZVJlZiwgV0tOYXZpZ2F0aW9uUmVm LCBXS1R5cGVSZWYsIGNvbnN0IHZvaWQqKQoreworICAgIGRpZFJlY2VpdmVNZXNzYWdlID0gdHJ1 ZTsKK30KKworVEVTVChXZWJLaXQsIEVudW1lcmF0ZURldmljZXNDcmFzaCkKK3sKKyAgICBhdXRv IGNvbnRleHQgPSBhZG9wdFdLKFdLQ29udGV4dENyZWF0ZVdpdGhDb25maWd1cmF0aW9uKG51bGxw dHIpKTsKKworICAgIFdLUmV0YWluUHRyPFdLUGFnZUdyb3VwUmVmPiBwYWdlR3JvdXAoQWRvcHRX SywgV0tQYWdlR3JvdXBDcmVhdGVXaXRoSWRlbnRpZmllcihVdGlsOjp0b1dLKCJHZXRVc2VyTWVk aWEiKS5nZXQoKSkpOworICAgIFdLUHJlZmVyZW5jZXNSZWYgcHJlZmVyZW5jZXMgPSBXS1BhZ2VH cm91cEdldFByZWZlcmVuY2VzKHBhZ2VHcm91cC5nZXQoKSk7CisgICAgV0tQcmVmZXJlbmNlc1Nl dE1lZGlhRGV2aWNlc0VuYWJsZWQocHJlZmVyZW5jZXMsIHRydWUpOworICAgIFdLUHJlZmVyZW5j ZXNTZXRGaWxlQWNjZXNzRnJvbUZpbGVVUkxzQWxsb3dlZChwcmVmZXJlbmNlcywgdHJ1ZSk7Cisg ICAgV0tQcmVmZXJlbmNlc1NldE1lZGlhQ2FwdHVyZVJlcXVpcmVzU2VjdXJlQ29ubmVjdGlvbihw cmVmZXJlbmNlcywgZmFsc2UpOworICAgIFdLUHJlZmVyZW5jZXNTZXRNb2NrQ2FwdHVyZURldmlj ZXNFbmFibGVkKHByZWZlcmVuY2VzLCB0cnVlKTsKKworICAgIFdLUGFnZVVJQ2xpZW50VjYgdWlD bGllbnQ7CisgICAgLy8gV2Ugd2FudCB1aUNsaWVudC5jaGVja1VzZXJNZWRpYVBlcm1pc3Npb25G b3JPcmlnaW4gdG8gYmUgbnVsbC4KKyAgICBtZW1zZXQoJnVpQ2xpZW50LCAwLCBzaXplb2YodWlD bGllbnQpKTsKKyAgICB1aUNsaWVudC5iYXNlLnZlcnNpb24gPSA2OworCisgICAgV0tQYWdlTmF2 aWdhdGlvbkNsaWVudFYzIGxvYWRlckNsaWVudDsKKyAgICBtZW1zZXQoJmxvYWRlckNsaWVudCwg MCwgc2l6ZW9mKGxvYWRlckNsaWVudCkpOworICAgIGxvYWRlckNsaWVudC5iYXNlLnZlcnNpb24g PSAzOworICAgIGxvYWRlckNsaWVudC5kaWRGaW5pc2hOYXZpZ2F0aW9uID0gZGlkRmluaXNoTmF2 aWdhdGlvbjsKKworICAgIFBsYXRmb3JtV2ViVmlldyB3ZWJWaWV3KGNvbnRleHQuZ2V0KCksIHBh Z2VHcm91cC5nZXQoKSk7CisgICAgV0tQYWdlU2V0UGFnZVVJQ2xpZW50KHdlYlZpZXcucGFnZSgp LCAmdWlDbGllbnQuYmFzZSk7CisgICAgV0tQYWdlU2V0UGFnZU5hdmlnYXRpb25DbGllbnQod2Vi Vmlldy5wYWdlKCksICZsb2FkZXJDbGllbnQuYmFzZSk7CisKKyAgICAvLyBMb2FkIGEgcGFnZSBk b2luZyBlbnVtZXJhdGVEZXZpY2VzLgorICAgIGRpZFJlY2VpdmVNZXNzYWdlID0gZmFsc2U7Cisg ICAgYXV0byB1cmwgPSBhZG9wdFdLKFV0aWw6OmNyZWF0ZVVSTEZvclJlc291cmNlKCJnZXRVc2Vy TWVkaWEiLCAiaHRtbCIpKTsKKyAgICBXS1BhZ2VMb2FkVVJMKHdlYlZpZXcucGFnZSgpLCB1cmwu Z2V0KCkpOworICAgIFV0aWw6OnJ1bigmZGlkUmVjZWl2ZU1lc3NhZ2UpOworfQorCiB9IC8vIG5h bWVzcGFjZSBUZXN0V2ViS2l0QVBJCiAKICNlbmRpZiAvLyBFTkFCTEUoTUVESUFfU1RSRUFNKQpk aWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQvZ2V0VXNlck1lZGlh Lmh0bWwgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9nZXRVc2VyTWVkaWEuaHRt bAppbmRleCA3M2Y3MWI5MTIzYjg3MThkMDIzMDFjMjU2ZDMyYmE2NjU2M2E4NTI3Li5kNzJjZTgw OWIxOTU0YTEzZTkwNjZjNzE3ZDM3MWYxNTZiNWM3YjFhIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9nZXRVc2VyTWVkaWEuaHRtbAorKysgYi9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9nZXRVc2VyTWVkaWEuaHRtbApAQCAtNSwxNSArNSwxNiBA QAogCiAgICAgICAgICAgICBsZXQgc3RyZWFtID0gbnVsbDsKIAotICAgICAgICAgICAgZnVuY3Rp b24gcHJvbXB0Rm9yQ2FwdHVyZSgpCisgICAgICAgICAgICBhc3luYyBmdW5jdGlvbiBwcm9tcHRG b3JDYXB0dXJlKCkKICAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICBuYXZpZ2F0b3IubWVk aWFEZXZpY2VzLmdldFVzZXJNZWRpYSh7IGF1ZGlvOiBmYWxzZSwgdmlkZW86IHRydWUgfSkKLSAg ICAgICAgICAgICAgICAudGhlbigocykgPT4gewotICAgICAgICAgICAgICAgICAgICAgIHN0cmVh bSA9IHM7Ci0gICAgICAgICAgICAgICAgICAgICAgdmlkZW8uc3JjT2JqZWN0ID0gc3RyZWFtOwot ICAgICAgICAgICAgICAgICAgICAgIGNvbnNvbGUubG9nKCJHb3QgdXNlciBtZWRpYSIpOwotICAg ICAgICAgICAgICAgIH0pCi0gICAgICAgICAgICAgICAgLmNhdGNoKChlcnJvcikgPT4gY29uc29s ZS5sb2coYEZhaWxlZCB3aXRoIGVycm9yOiAke2Vycm9yfWApKTsKKyAgICAgICAgICAgICAgICB0 cnkgeworICAgICAgICAgICAgICAgICAgICBhd2FpdCBuYXZpZ2F0b3IubWVkaWFEZXZpY2VzLmVu dW1lcmF0ZURldmljZXMoKTsKKyAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RyZWFtID0gYXdh aXQgbmF2aWdhdG9yLm1lZGlhRGV2aWNlcy5nZXRVc2VyTWVkaWEoeyBhdWRpbzogZmFsc2UsIHZp ZGVvOiB0cnVlIH0pCisgICAgICAgICAgICAgICAgICAgIHZpZGVvLnNyY09iamVjdCA9IHN0cmVh bTsKKyAgICAgICAgICAgICAgICAgICAgY29uc29sZS5sb2coIkdvdCB1c2VyIG1lZGlhIik7Cisg ICAgICAgICAgICAgICAgfSBjYXRjaChlcnJvcikgeworICAgICAgICAgICAgICAgICAgICBjb25z b2xlLmxvZyhgRmFpbGVkIHdpdGggZXJyb3I6ICR7ZXJyb3J9YCk7CisgICAgICAgICAgICAgICAg fQogICAgICAgICAgICAgfQogCiAgICAgICAgICAgICBmdW5jdGlvbiBzdG9wKGtpbmQpCg==