194097 2019-01-31 10:32:09 -0800 Fix LSAppLink deprecation warnings 2019-01-31 11:50:33 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1500634 0 timothy 2019-01-31 10:32:09 -0800 There are a couple deprecation warnings we need to fix in WKActionSheetAssistant. 1500639 1 360740 timothy 2019-01-31 10:35:54 -0800 Created attachment 360740 Patch 1500644 2 timothy 2019-01-31 10:46:07 -0800 <rdar://problem/47697219> 1500659 3 360740 commit-queue 2019-01-31 11:15:04 -0800 Comment on attachment 360740 Patch Clearing flags on attachment: 360740 Committed r240798: <https://trac.webkit.org/changeset/240798> 1500660 4 commit-queue 2019-01-31 11:15:05 -0800 All reviewed patches have been landed. Closing bug. 1500681 5 360740 ap 2019-01-31 11:50:33 -0800 Comment on attachment 360740 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360740&action=review > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:442 > +#pragma clang diagnostic push > +#pragma clang diagnostic ignored "-Wdeprecated-declarations" ALLOW_DEPRECATED_DECLARATIONS_BEGIN > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:444 > +#pragma clang diagnostic pop ALLOW_DEPRECATED_DECLARATIONS_END 360740 2019-01-31 10:35:54 -0800 2019-01-31 11:15:04 -0800 Patch bug-194097-20190131103554.patch text/plain 2780 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNzk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRkMDllMWJjZDc3YzEzOTA0 ZjBlZGVmNjUyNTNmMTE5Mzk1ZTBhMDUuLmJiOTI0NTVkNjUxNWUzMDU5N2Y1MmQwYTMzZWJmMzkw MTgyYmI5MjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDEtMzEgIFRpbW90aHkg SGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBMU0FwcExpbmsgZGVw cmVjYXRpb24gd2FybmluZ3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTQwOTcKKworICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tBY3Rpb25TaGVldEFzc2lzdGFudC5tbToKKyAgICAgICAg KC1bV0tBY3Rpb25TaGVldEFzc2lzdGFudCBfYXBwZW5kT3BlbkFjdGlvbnNGb3JVUkw6YWN0aW9u czplbGVtZW50SW5mbzpdKToKKwogMjAxOS0wMS0zMCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJh c2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXSBJbXBsZW1lbnQgYmFzaWMgaGl0IHRlc3Rp bmcgaW4gdGhlIHNjcm9sbGluZyB0cmVlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9pb3MvV0tBY3Rpb25TaGVldEFzc2lzdGFudC5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL2lvcy9XS0FjdGlvblNoZWV0QXNzaXN0YW50Lm1tCmluZGV4IDE0ODM0OWFiM2IwY2ZlM2Vl ZjFiMGQ4NTllZmYyYzk3OGYxNWY3ZTcuLjVmMmRkMmU1Y2JmZjI3NGJhN2M5YTllZDI3MTYyMTEw MDdlZjA2ODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0FjdGlv blNoZWV0QXNzaXN0YW50Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0Fj dGlvblNoZWV0QXNzaXN0YW50Lm1tCkBAIC00MzgsNyArNDM4LDEwIEBAIC0gKHZvaWQpX2FwcGVu ZE9wZW5BY3Rpb25zRm9yVVJMOihOU1VSTCAqKXVybCBhY3Rpb25zOihOU011dGFibGVBcnJheSAq KWRlZmF1bHRBCiAgICAgICAgIGlmIChhcHBMaW5rKSB7CiAgICAgICAgICAgICBOU1N0cmluZyAq dGl0bGUgPSBXRUJfVUlfU1RSSU5HKCJPcGVuIGluIFNhZmFyaSIsICJUaXRsZSBmb3IgT3BlbiBp biBTYWZhcmkgTGluayBhY3Rpb24gYnV0dG9uIik7CiAgICAgICAgICAgICBfV0tFbGVtZW50QWN0 aW9uICpvcGVuSW5EZWZhdWx0QnJvd3NlckFjdGlvbiA9IFtfV0tFbGVtZW50QWN0aW9uIF9lbGVt ZW50QWN0aW9uV2l0aFR5cGU6X1dLRWxlbWVudEFjdGlvblR5cGVPcGVuSW5EZWZhdWx0QnJvd3Nl ciB0aXRsZTp0aXRsZSBhY3Rpb25IYW5kbGVyOl4oX1dLQWN0aXZhdGVkRWxlbWVudEluZm8gKikg eworI3ByYWdtYSBjbGFuZyBkaWFnbm9zdGljIHB1c2gKKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3Rp YyBpZ25vcmVkICItV2RlcHJlY2F0ZWQtZGVjbGFyYXRpb25zIgogICAgICAgICAgICAgICAgIFth cHBMaW5rIG9wZW5JbldlYkJyb3dzZXI6WUVTIHNldEFwcHJvcHJpYXRlT3BlblN0cmF0ZWd5QW5k V2ViQnJvd3NlclN0YXRlOm5pbCBjb21wbGV0aW9uSGFuZGxlcjpeKEJPT0wgc3VjY2VzcywgTlNF cnJvciAqZXJyb3IpIHsgfV07CisjcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgcG9wCiAgICAgICAg ICAgICB9XTsKICAgICAgICAgICAgIFtkZWZhdWx0QWN0aW9ucyBhZGRPYmplY3Q6b3BlbkluRGVm YXVsdEJyb3dzZXJBY3Rpb25dOwogCkBAIC00NDYsNyArNDQ5LDEwIEBAIC0gKHZvaWQpX2FwcGVu ZE9wZW5BY3Rpb25zRm9yVVJMOihOU1VSTCAqKXVybCBhY3Rpb25zOihOU011dGFibGVBcnJheSAq KWRlZmF1bHRBCiAgICAgICAgICAgICBpZiAoZXh0ZXJuYWxBcHBsaWNhdGlvbk5hbWUpIHsKICAg ICAgICAgICAgICAgICBOU1N0cmluZyAqdGl0bGUgPSBbTlNTdHJpbmcgc3RyaW5nV2l0aEZvcm1h dDpXRUJfVUlfU1RSSU5HKCJPcGVuIGluIOKAnCVA4oCdIiwgIlRpdGxlIGZvciBPcGVuIGluIEV4 dGVybmFsIEFwcGxpY2F0aW9uIExpbmsgYWN0aW9uIGJ1dHRvbiIpLCBleHRlcm5hbEFwcGxpY2F0 aW9uTmFtZV07CiAgICAgICAgICAgICAgICAgX1dLRWxlbWVudEFjdGlvbiAqb3BlbkluRXh0ZXJu YWxBcHBsaWNhdGlvbkFjdGlvbiA9IFtfV0tFbGVtZW50QWN0aW9uIF9lbGVtZW50QWN0aW9uV2l0 aFR5cGU6X1dLRWxlbWVudEFjdGlvblR5cGVPcGVuSW5FeHRlcm5hbEFwcGxpY2F0aW9uIHRpdGxl OnRpdGxlIGFjdGlvbkhhbmRsZXI6XihfV0tBY3RpdmF0ZWRFbGVtZW50SW5mbyAqKSB7CisjcHJh Z21hIGNsYW5nIGRpYWdub3N0aWMgcHVzaAorI3ByYWdtYSBjbGFuZyBkaWFnbm9zdGljIGlnbm9y ZWQgIi1XZGVwcmVjYXRlZC1kZWNsYXJhdGlvbnMiCiAgICAgICAgICAgICAgICAgICAgIFthcHBM aW5rIG9wZW5JbldlYkJyb3dzZXI6Tk8gc2V0QXBwcm9wcmlhdGVPcGVuU3RyYXRlZ3lBbmRXZWJC cm93c2VyU3RhdGU6bmlsIGNvbXBsZXRpb25IYW5kbGVyOl4oQk9PTCBzdWNjZXNzLCBOU0Vycm9y ICplcnJvcikgeyB9XTsKKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwb3AKICAgICAgICAgICAg ICAgICB9XTsKICAgICAgICAgICAgICAgICBbZGVmYXVsdEFjdGlvbnMgYWRkT2JqZWN0Om9wZW5J bkV4dGVybmFsQXBwbGljYXRpb25BY3Rpb25dOwogICAgICAgICAgICAgfQo=