194086 2019-01-31 04:03:23 -0800 [GLIB] WebDriver: race condition when session starts 2019-01-31 05:07:28 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg bugs-noreply pnormand svillar webkit-bug-importer oldest_to_newest 1500534 0 cgarcia 2019-01-31 04:03:23 -0800 This is causing flakiness in WebDriver bots, I can only reproduce it locally when my CPUs are at 100%. The thing is that sometimes we receive an empty target list right after the connection is established because RemoteInspector::setClient() calls pushListingsSoon() before a target has been registered. Most of the times the target is registered before the listing is pushed, but it can happen that when pushed the listing is still empty. After the target is registered an empty target list means the connection was lost, so we clear the connection and target. We need to ensure we do that only after the target has been registered. 1500535 1 360716 cgarcia 2019-01-31 04:06:46 -0800 Created attachment 360716 Patch 1500536 2 360716 pnormand 2019-01-31 04:17:32 -0800 Comment on attachment 360716 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360716&action=review > Source/WebDriver/glib/SessionHostGlib.cpp:335 > m_connectionID = 0; > - if (m_dbusConnection) > + if (m_connectionID && m_dbusConnection) So now this condition is always false because m_connectionID is set to 0 before the if. Is this correct? Why not remove the if block then? 1500538 3 cgarcia 2019-01-31 04:49:27 -0800 (In reply to Philippe Normand from comment #2) > Comment on attachment 360716 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=360716&action=review > > > Source/WebDriver/glib/SessionHostGlib.cpp:335 > > m_connectionID = 0; > > - if (m_dbusConnection) > > + if (m_connectionID && m_dbusConnection) > > So now this condition is always false because m_connectionID is set to 0 > before the if. Is this correct? Why not remove the if block then? Oops, you are right! 1500539 4 360717 cgarcia 2019-01-31 04:53:21 -0800 Created attachment 360717 Updated patch 1500540 5 cgarcia 2019-01-31 05:06:22 -0800 Committed r240778: <https://trac.webkit.org/changeset/240778> 1500541 6 webkit-bug-importer 2019-01-31 05:07:28 -0800 <rdar://problem/47699722> 360716 2019-01-31 04:06:46 -0800 2019-01-31 04:53:21 -0800 Patch wd-flaky.diff text/plain 1876 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggYzlmODM1OWI4OGMuLmEzZTc4N2FmZTZlIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTAxLTMxICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR0xJQl0gV2ViRHJpdmVyOiByYWNlIGNvbmRp dGlvbiB3aGVuIHNlc3Npb24gc3RhcnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTQwODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGlzIGlzIGNhdXNpbmcgZmxha2luZXNzIGluIHRoZSBib3RzLCBJ IGNhbiBvbmx5IHJlcHJvZHVjZSBpdCBsb2NhbGx5IHdoZW4gbXkgQ1BVcyBhcmUgYXQgMTAwJS4g VGhlIHRoaW5nCisgICAgICAgIGlzIHRoYXQgc29tZXRpbWVzIHdlIHJlY2VpdmUgYW4gZW1wdHkg dGFyZ2V0IGxpc3QgcmlnaHQgYWZ0ZXIgdGhlIGNvbm5lY3Rpb24gaXMgZXN0YWJsaXNoZWQgYmVj YXVzZQorICAgICAgICBSZW1vdGVJbnNwZWN0b3I6OnNldENsaWVudCgpIGNhbGxzIHB1c2hMaXN0 aW5nc1Nvb24oKSBiZWZvcmUgYSB0YXJnZXQgaGFzIGJlZW4gcmVnaXN0ZXJlZC4gTW9zdCBvZiB0 aGUgdGltZXMgdGhlCisgICAgICAgIHRhcmdldCBpcyByZWdpc3RlcmVkIGJlZm9yZSB0aGUgbGlz dGluZyBpcyBwdXNoZWQsIGJ1dCBpdCBjYW4gaGFwcGVuIHRoYXQgd2hlbiBwdXNoZWQsIHRoZSBs aXN0aW5nIGlzIHN0aWxsCisgICAgICAgIGVtcHR5LiBBZnRlciB0aGUgdGFyZ2V0IGlzIHJlZ2lz dGVyZWQgYW4gZW1wdHkgdGFyZ2V0IGxpc3QgbWVhbnMgdGhlIGNvbm5lY3Rpb24gd2FzIGxvc3Qs IHNvIHdlIGNsZWFyIHRoZQorICAgICAgICBjb25uZWN0aW9uIGFuZCB0YXJnZXQuIFdlIG5lZWQg dG8gZW5zdXJlIHdlIGRvIHRoYXQgb25seSBhZnRlciB0aGUgdGFyZ2V0IGhhcyBiZWVuIHJlZ2lz dGVyZWQuCisKKyAgICAgICAgKiBnbGliL1Nlc3Npb25Ib3N0R2xpYi5jcHA6CisKIDIwMTktMDEt MjkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAg IFdlYkRyaXZlcjogUE9TVCBjb21tYW5kcyByZXF1aXJlIGEgdmFsaWQgcGFyYW1ldGVycyBvYmpl Y3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvZ2xpYi9TZXNzaW9uSG9zdEdsaWIuY3Bw IGIvU291cmNlL1dlYkRyaXZlci9nbGliL1Nlc3Npb25Ib3N0R2xpYi5jcHAKaW5kZXggMzRmOWJj YTJiODcuLmY0OTY1MmRlMmIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViRHJpdmVyL2dsaWIvU2Vz c2lvbkhvc3RHbGliLmNwcAorKysgYi9Tb3VyY2UvV2ViRHJpdmVyL2dsaWIvU2Vzc2lvbkhvc3RH bGliLmNwcApAQCAtMzMyLDcgKzMzMiw3IEBAIHZvaWQgU2Vzc2lvbkhvc3Q6OnNldFRhcmdldExp c3QodWludDY0X3QgY29ubmVjdGlvbklELCBWZWN0b3I8VGFyZ2V0PiYmIHRhcmdldExpCiAgICAg aWYgKHRhcmdldExpc3QuaXNFbXB0eSgpKSB7CiAgICAgICAgIG1fdGFyZ2V0ID0gVGFyZ2V0KCk7 CiAgICAgICAgIG1fY29ubmVjdGlvbklEID0gMDsKLSAgICAgICAgaWYgKG1fZGJ1c0Nvbm5lY3Rp b24pCisgICAgICAgIGlmIChtX2Nvbm5lY3Rpb25JRCAmJiBtX2RidXNDb25uZWN0aW9uKQogICAg ICAgICAgICAgZ19kYnVzX2Nvbm5lY3Rpb25fY2xvc2UobV9kYnVzQ29ubmVjdGlvbi5nZXQoKSwg bnVsbHB0ciwgbnVsbHB0ciwgbnVsbHB0cik7CiAgICAgICAgIHJldHVybjsKICAgICB9Cg== 360717 2019-01-31 04:53:21 -0800 2019-01-31 05:01:42 -0800 Updated patch wd-flaky.diff text/plain 2070 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggYzlmODM1OWI4OGMuLmEzZTc4N2FmZTZlIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTAxLTMxICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR0xJQl0gV2ViRHJpdmVyOiByYWNlIGNvbmRp dGlvbiB3aGVuIHNlc3Npb24gc3RhcnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTQwODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGlzIGlzIGNhdXNpbmcgZmxha2luZXNzIGluIHRoZSBib3RzLCBJ IGNhbiBvbmx5IHJlcHJvZHVjZSBpdCBsb2NhbGx5IHdoZW4gbXkgQ1BVcyBhcmUgYXQgMTAwJS4g VGhlIHRoaW5nCisgICAgICAgIGlzIHRoYXQgc29tZXRpbWVzIHdlIHJlY2VpdmUgYW4gZW1wdHkg dGFyZ2V0IGxpc3QgcmlnaHQgYWZ0ZXIgdGhlIGNvbm5lY3Rpb24gaXMgZXN0YWJsaXNoZWQgYmVj YXVzZQorICAgICAgICBSZW1vdGVJbnNwZWN0b3I6OnNldENsaWVudCgpIGNhbGxzIHB1c2hMaXN0 aW5nc1Nvb24oKSBiZWZvcmUgYSB0YXJnZXQgaGFzIGJlZW4gcmVnaXN0ZXJlZC4gTW9zdCBvZiB0 aGUgdGltZXMgdGhlCisgICAgICAgIHRhcmdldCBpcyByZWdpc3RlcmVkIGJlZm9yZSB0aGUgbGlz dGluZyBpcyBwdXNoZWQsIGJ1dCBpdCBjYW4gaGFwcGVuIHRoYXQgd2hlbiBwdXNoZWQsIHRoZSBs aXN0aW5nIGlzIHN0aWxsCisgICAgICAgIGVtcHR5LiBBZnRlciB0aGUgdGFyZ2V0IGlzIHJlZ2lz dGVyZWQgYW4gZW1wdHkgdGFyZ2V0IGxpc3QgbWVhbnMgdGhlIGNvbm5lY3Rpb24gd2FzIGxvc3Qs IHNvIHdlIGNsZWFyIHRoZQorICAgICAgICBjb25uZWN0aW9uIGFuZCB0YXJnZXQuIFdlIG5lZWQg dG8gZW5zdXJlIHdlIGRvIHRoYXQgb25seSBhZnRlciB0aGUgdGFyZ2V0IGhhcyBiZWVuIHJlZ2lz dGVyZWQuCisKKyAgICAgICAgKiBnbGliL1Nlc3Npb25Ib3N0R2xpYi5jcHA6CisKIDIwMTktMDEt MjkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAg IFdlYkRyaXZlcjogUE9TVCBjb21tYW5kcyByZXF1aXJlIGEgdmFsaWQgcGFyYW1ldGVycyBvYmpl Y3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvZ2xpYi9TZXNzaW9uSG9zdEdsaWIuY3Bw IGIvU291cmNlL1dlYkRyaXZlci9nbGliL1Nlc3Npb25Ib3N0R2xpYi5jcHAKaW5kZXggMzRmOWJj YTJiODcuLjdhMjBiODk0MWFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViRHJpdmVyL2dsaWIvU2Vz c2lvbkhvc3RHbGliLmNwcAorKysgYi9Tb3VyY2UvV2ViRHJpdmVyL2dsaWIvU2Vzc2lvbkhvc3RH bGliLmNwcApAQCAtMzMxLDkgKzMzMSwxMSBAQCB2b2lkIFNlc3Npb25Ib3N0OjpzZXRUYXJnZXRM aXN0KHVpbnQ2NF90IGNvbm5lY3Rpb25JRCwgVmVjdG9yPFRhcmdldD4mJiB0YXJnZXRMaQogICAg IEFTU0VSVCh0YXJnZXRMaXN0LnNpemUoKSA8PSAxKTsKICAgICBpZiAodGFyZ2V0TGlzdC5pc0Vt cHR5KCkpIHsKICAgICAgICAgbV90YXJnZXQgPSBUYXJnZXQoKTsKLSAgICAgICAgbV9jb25uZWN0 aW9uSUQgPSAwOwotICAgICAgICBpZiAobV9kYnVzQ29ubmVjdGlvbikKLSAgICAgICAgICAgIGdf ZGJ1c19jb25uZWN0aW9uX2Nsb3NlKG1fZGJ1c0Nvbm5lY3Rpb24uZ2V0KCksIG51bGxwdHIsIG51 bGxwdHIsIG51bGxwdHIpOworICAgICAgICBpZiAobV9jb25uZWN0aW9uSUQpIHsKKyAgICAgICAg ICAgIGlmIChtX2RidXNDb25uZWN0aW9uKQorICAgICAgICAgICAgICAgIGdfZGJ1c19jb25uZWN0 aW9uX2Nsb3NlKG1fZGJ1c0Nvbm5lY3Rpb24uZ2V0KCksIG51bGxwdHIsIG51bGxwdHIsIG51bGxw dHIpOworICAgICAgICAgICAgbV9jb25uZWN0aW9uSUQgPSAwOworICAgICAgICB9CiAgICAgICAg IHJldHVybjsKICAgICB9CiAK