194076 2019-01-30 21:01:32 -0800 Enable swipe tests on iOS 2019-01-31 17:09:13 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa ggaren lforschler megan_gardner simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1500406 0 rniwa 2019-01-30 21:01:32 -0800 Tests in LayoutTests/swipe are currently skipped on iOS. Enable all six of them. 1500410 1 360688 rniwa 2019-01-30 21:10:00 -0800 Created attachment 360688 Enables the tests 1500416 2 360688 ggaren 2019-01-30 21:34:34 -0800 Comment on attachment 360688 Enables the tests r=me 1500418 3 360688 thorton 2019-01-30 21:48:02 -0800 Comment on attachment 360688 Enables the tests View in context: https://bugs.webkit.org/attachment.cgi?id=360688&action=review > LayoutTests/platform/ios/swipe/main-frame-pinning-requirement-expected.txt:2 > +Failure. Should never begin a swipe, because we were in the middle of a scrolling gesture that started when the main frame was not pinned to the left. This test doesn't make sense on iOS because we don't require the main frame to be pinned to swipe... but maybe it's OK to turn it on with the expected failure with the understanding that it's truly an *expected* failure? 1500445 4 rniwa 2019-01-30 23:10:45 -0800 (In reply to Tim Horton from comment #3) > Comment on attachment 360688 [details] > Enables the tests > > View in context: > https://bugs.webkit.org/attachment.cgi?id=360688&action=review > > > LayoutTests/platform/ios/swipe/main-frame-pinning-requirement-expected.txt:2 > > +Failure. Should never begin a swipe, because we were in the middle of a scrolling gesture that started when the main frame was not pinned to the left. > > This test doesn't make sense on iOS because we don't require the main frame > to be pinned to swipe... but maybe it's OK to turn it on with the expected > failure with the understanding that it's truly an *expected* failure? Yeah, I'm simply turning on the tests here. This is definitely not expected on iOS as you say. Having a failing test is better than no tests :) 1500447 5 rniwa 2019-01-30 23:12:41 -0800 I'd mention that WebKitTestRunner doesn't seem to support back-forward swipe gesture even when we turn it on via testRunner.setNavigationGesturesEnabled(true). I can't manually trigger back-forward navigation via swiping for example. 1500457 6 360688 rniwa 2019-01-30 23:31:23 -0800 Comment on attachment 360688 Enables the tests Clearing flags on attachment: 360688 Committed r240765: <https://trac.webkit.org/changeset/240765> 1500458 7 rniwa 2019-01-30 23:31:25 -0800 All reviewed patches have been landed. Closing bug. 1500459 8 webkit-bug-importer 2019-01-30 23:32:50 -0800 <rdar://problem/47694943> 1500643 9 360688 simon.fraser 2019-01-31 10:45:24 -0800 Comment on attachment 360688 Enables the tests View in context: https://bugs.webkit.org/attachment.cgi?id=360688&action=review > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:-827 > TestRunnerWKWebView *webView = TestController::singleton().mainWebView()->platformView(); > [webView _beginBackSwipeForTesting]; > - > - unsigned callbackID = m_context->prepareForAsyncTask(callback, CallbackTypeNonPersistent); > - m_context->asyncTaskComplete(callbackID); Is beginBackSwipe async or not? Who calls the callback? > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:827 > void UIScriptController::completeBackSwipe(JSValueRef callback) Odd that the API is not just "doBackswipe" with an async completion handler. 1500904 10 rniwa 2019-01-31 16:55:58 -0800 (In reply to Simon Fraser (smfr) from comment #9) > Comment on attachment 360688 [details] > Enables the tests > > View in context: > https://bugs.webkit.org/attachment.cgi?id=360688&action=review > > > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:-827 > > TestRunnerWKWebView *webView = TestController::singleton().mainWebView()->platformView(); > > [webView _beginBackSwipeForTesting]; > > - > > - unsigned callbackID = m_context->prepareForAsyncTask(callback, CallbackTypeNonPersistent); > > - m_context->asyncTaskComplete(callbackID); > > Is beginBackSwipe async or not? Who calls the callback? It's a sync test API. > > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:827 > > void UIScriptController::completeBackSwipe(JSValueRef callback) > > Odd that the API is not just "doBackswipe" with an async completion handler. Yeah. 1500907 11 thorton 2019-01-31 16:58:56 -0800 (In reply to Ryosuke Niwa from comment #10) > (In reply to Simon Fraser (smfr) from comment #9) > > Comment on attachment 360688 [details] > > Enables the tests > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=360688&action=review > > > > > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:-827 > > > TestRunnerWKWebView *webView = TestController::singleton().mainWebView()->platformView(); > > > [webView _beginBackSwipeForTesting]; > > > - > > > - unsigned callbackID = m_context->prepareForAsyncTask(callback, CallbackTypeNonPersistent); > > > - m_context->asyncTaskComplete(callbackID); > > > > Is beginBackSwipe async or not? Who calls the callback? > > It's a sync test API. > > > > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:827 > > > void UIScriptController::completeBackSwipe(JSValueRef callback) > > > > Odd that the API is not just "doBackswipe" with an async completion handler. > > Yeah. Don't some of the tests depend on being able to do things in the middle? 1500913 12 rniwa 2019-01-31 17:05:50 -0800 (In reply to Tim Horton from comment #11) > (In reply to Ryosuke Niwa from comment #10) > > (In reply to Simon Fraser (smfr) from comment #9) > > > Comment on attachment 360688 [details] > > > Enables the tests > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=360688&action=review > > > > > > > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:-827 > > > > TestRunnerWKWebView *webView = TestController::singleton().mainWebView()->platformView(); > > > > [webView _beginBackSwipeForTesting]; > > > > - > > > > - unsigned callbackID = m_context->prepareForAsyncTask(callback, CallbackTypeNonPersistent); > > > > - m_context->asyncTaskComplete(callbackID); > > > > > > Is beginBackSwipe async or not? Who calls the callback? > > > > It's a sync test API. > > > > > > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:827 > > > > void UIScriptController::completeBackSwipe(JSValueRef callback) > > > > > > Odd that the API is not just "doBackswipe" with an async completion handler. > > > > Yeah. > > Don't some of the tests depend on being able to do things in the middle? They do but you'd think we can have a higher level API which does the whole swipe too. 1500916 13 thorton 2019-01-31 17:09:13 -0800 > They do but you'd think we can have a higher level API which does the whole > swipe too. Ah, yes, sure. 360688 2019-01-30 21:10:00 -0800 2019-01-30 23:31:23 -0800 Enables the tests bug-194076-20190130210959.patch text/plain 4945 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNjkyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODhmMWMyYTQ2OTM1N2Q2NDFmZjZjMWY0MDA3ZDZmNDAz NDU1ZWEyMi4uYzBmZjAyMDg1N2JlMDgyOTFmZmYzNmQwMjI1YjczZDQ5ZDU2ZTMyNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE5LTAxLTMwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAg ICAgIEVuYWJsZSBzd2lwZSB0ZXN0cyBvbiBpT1MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDA3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZWQgdGhlIHN1cGVyZmxvdXMgY2FsbCB0byBwcmVw YXJlRm9yQXN5bmNUYXNrIGFuZCBhc3luY1Rhc2tDb21wbGV0ZSBhcworICAgICAgICBpdCBjYXVz ZXMgYSBkZWJ1ZyBhc3NlcnRpb24gZmFpbHVyZSBpbiBydW5VSVNjcmlwdC4KKworICAgICAgICAq IFdlYktpdFRlc3RSdW5uZXIvaW9zL1VJU2NyaXB0Q29udHJvbGxlcklPUy5tbToKKyAgICAgICAg KFdUUjo6VUlTY3JpcHRDb250cm9sbGVyOjpiZWdpbkJhY2tTd2lwZSk6CisgICAgICAgIChXVFI6 OlVJU2NyaXB0Q29udHJvbGxlcjo6Y29tcGxldGVCYWNrU3dpcGUpOgorCiAyMDE5LTAxLTI5ICBZ b3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBBZG9wdCBuZXcgU1BJ IHRvIGV2YWx1YXRlIHNlcnZlciBjZXJ0aWZpY2F0ZSB0cnVzdApkaWZmIC0tZ2l0IGEvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9pb3MvVUlTY3JpcHRDb250cm9sbGVySU9TLm1tIGIvVG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci9pb3MvVUlTY3JpcHRDb250cm9sbGVySU9TLm1tCmluZGV4IDAyN2JjMzc1 NjgyYmVkNzhkMWJlNzJhZDYyZjZlMTg1YTcwNWFlOWIuLjQ5NTI3NjVhMGFjZmQzZGUzZjE4MmJl MjhlMmZlOGUxOTM5NTY4M2IgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvaW9z L1VJU2NyaXB0Q29udHJvbGxlcklPUy5tbQorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2lv cy9VSVNjcmlwdENvbnRyb2xsZXJJT1MubW0KQEAgLTgyMiwxOCArODIyLDEyIEBAIHZvaWQgVUlT Y3JpcHRDb250cm9sbGVyOjpiZWdpbkJhY2tTd2lwZShKU1ZhbHVlUmVmIGNhbGxiYWNrKQogewog ICAgIFRlc3RSdW5uZXJXS1dlYlZpZXcgKndlYlZpZXcgPSBUZXN0Q29udHJvbGxlcjo6c2luZ2xl dG9uKCkubWFpbldlYlZpZXcoKS0+cGxhdGZvcm1WaWV3KCk7CiAgICAgW3dlYlZpZXcgX2JlZ2lu QmFja1N3aXBlRm9yVGVzdGluZ107Ci0KLSAgICB1bnNpZ25lZCBjYWxsYmFja0lEID0gbV9jb250 ZXh0LT5wcmVwYXJlRm9yQXN5bmNUYXNrKGNhbGxiYWNrLCBDYWxsYmFja1R5cGVOb25QZXJzaXN0 ZW50KTsKLSAgICBtX2NvbnRleHQtPmFzeW5jVGFza0NvbXBsZXRlKGNhbGxiYWNrSUQpOwogfQog CiB2b2lkIFVJU2NyaXB0Q29udHJvbGxlcjo6Y29tcGxldGVCYWNrU3dpcGUoSlNWYWx1ZVJlZiBj YWxsYmFjaykKIHsKICAgICBUZXN0UnVubmVyV0tXZWJWaWV3ICp3ZWJWaWV3ID0gVGVzdENvbnRy b2xsZXI6OnNpbmdsZXRvbigpLm1haW5XZWJWaWV3KCktPnBsYXRmb3JtVmlldygpOwogICAgIFt3 ZWJWaWV3IF9jb21wbGV0ZUJhY2tTd2lwZUZvclRlc3RpbmddOwotCi0gICAgdW5zaWduZWQgY2Fs bGJhY2tJRCA9IG1fY29udGV4dC0+cHJlcGFyZUZvckFzeW5jVGFzayhjYWxsYmFjaywgQ2FsbGJh Y2tUeXBlTm9uUGVyc2lzdGVudCk7Ci0gICAgbV9jb250ZXh0LT5hc3luY1Rhc2tDb21wbGV0ZShj YWxsYmFja0lEKTsKIH0KIAogc3RhdGljIEJPT0wgZm9yRWFjaFZpZXdJbkhpZXJhcmNoeShVSVZp ZXcgKnZpZXcsIHZvaWQoXm1hcEZ1bmN0aW9uKShVSVZpZXcgKnN1YnZpZXcsIEJPT0wgKnN0b3Ap KQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCmluZGV4IDUyODczZTY3NDBlOWZiYWZiYWE5ZTg0NDAwZTQ1OWEwNTU0ODMxYzEuLmM2MGVk ZWIxMDEwZjM5MzUyNjQ3ZDI3YTU1NWQ1MGViMjI2YTAzMDcgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBA QAorMjAxOS0wMS0zMCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KKworICAgICAg ICBFbmFibGUgc3dpcGUgdGVzdHMgb24gaU9TCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQwNzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBFbmFibGVkIHRlc3RzIGluIExheW91dFRlc3RzL3N3aXBlIGFu ZCBhZGRlZCBpT1Mgc3BlY2lmaWMgcmVzdWx0cyBmb3IgdGhlIGZhaWxpbmcgdGVzdHMuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9pb3MvVGVzdEV4cGVjdGF0aW9uczoKKyAgICAgICAgKiBwbGF0Zm9y bS9pb3Mvc3dpcGUvYmFzaWMtY2FjaGVkLWJhY2stc3dpcGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4K KyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mvc3dpcGUvbWFpbi1mcmFtZS1waW5uaW5nLXJlcXVpcmVt ZW50LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vaW9zL3N3aXBlL3B1 c2hTdGF0ZS1jYWNoZWQtYmFjay1zd2lwZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorCiAyMDE5LTAx LTI5ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBBZG9wdCBu ZXcgU1BJIHRvIGV2YWx1YXRlIHNlcnZlciBjZXJ0aWZpY2F0ZSB0cnVzdApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9pb3MvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA4NDJkYjliMDQ3NjQ5OTYyYmNiNWYx NGNiMjdjOGRhNGY3ZTMwYzgxLi4yNWYwMjcwNjQ0NThiNzI4MjE4NjAyOTAwZmIwM2E1ODA2NjI3 OTgwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3MvVGVzdEV4cGVjdGF0aW9u cworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3MvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTEs NiArMTEsNyBAQCBkaXNwbGF5bGlzdHMgWyBQYXNzIF0KIGh0dHAvdGVzdHMvcXVpY2tsb29rIFsg UGFzcyBdCiBtZWRpYS9pb3MgWyBQYXNzIF0KIHF1aWNrbG9vayBbIFBhc3MgXQorc3dpcGUgWyBQ YXNzIF0KIAogZmFzdC90ZXh0LWF1dG9zaXppbmcvaW9zIFsgUGFzcyBdCiBmYXN0L3pvb21pbmcv aW9zIFsgUGFzcyBdCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mvc3dpcGUv YmFzaWMtY2FjaGVkLWJhY2stc3dpcGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vaW9zL3N3aXBlL2Jhc2ljLWNhY2hlZC1iYWNrLXN3aXBlLWV4cGVjdGVkLnR4dApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi41NmYxNGRlMmQwMWViY2E4MmE4MzVlMjljODliZjc0ZmQ4MWY4YTQ1Ci0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zL3N3aXBlL2Jhc2ljLWNhY2hlZC1iYWNr LXN3aXBlLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDYgQEAKK3N0YXJ0U3dpcGVHZXN0dXJlCitk aWRCZWdpblN3aXBlCitjb21wbGV0ZVN3aXBlR2VzdHVyZQorZGlkRW5kU3dpcGUKK2RpZFJlbW92 ZVN3aXBlU25hcHNob3QKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zL3N3 aXBlL21haW4tZnJhbWUtcGlubmluZy1yZXF1aXJlbWVudC1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9pb3Mvc3dpcGUvbWFpbi1mcmFtZS1waW5uaW5nLXJlcXVpcmVtZW50LWV4 cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4zOWIwZDk0OWVhMzAxMGI2ZjdhN2NkYTk1M2U2ODM3Y2Ni ZDMxNzBjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zL3N3aXBl L21haW4tZnJhbWUtcGlubmluZy1yZXF1aXJlbWVudC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw3 IEBACitzdGFydFN3aXBlR2VzdHVyZQorRmFpbHVyZS4gU2hvdWxkIG5ldmVyIGJlZ2luIGEgc3dp cGUsIGJlY2F1c2Ugd2Ugd2VyZSBpbiB0aGUgbWlkZGxlIG9mIGEgc2Nyb2xsaW5nIGdlc3R1cmUg dGhhdCBzdGFydGVkIHdoZW4gdGhlIG1haW4gZnJhbWUgd2FzIG5vdCBwaW5uZWQgdG8gdGhlIGxl ZnQuCitkaWRFbmRTd2lwZQorY29tcGxldGVTd2lwZUdlc3R1cmUKK3N0YXJ0U3dpcGVHZXN0dXJl CitkaWRSZW1vdmVTd2lwZVNuYXBzaG90CisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL2lvcy9zd2lwZS9wdXNoU3RhdGUtY2FjaGVkLWJhY2stc3dpcGUtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zL3N3aXBlL3B1c2hTdGF0ZS1jYWNoZWQtYmFjay1zd2lw ZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNTZmMTRkZTJkMDFlYmNhODJhODM1ZTI5Yzg5YmY3 NGZkODFmOGE0NQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy9z d2lwZS9wdXNoU3RhdGUtY2FjaGVkLWJhY2stc3dpcGUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEs NiBAQAorc3RhcnRTd2lwZUdlc3R1cmUKK2RpZEJlZ2luU3dpcGUKK2NvbXBsZXRlU3dpcGVHZXN0 dXJlCitkaWRFbmRTd2lwZQorZGlkUmVtb3ZlU3dpcGVTbmFwc2hvdAorCg==