194071 2019-01-30 19:06:16 -0800 [LFC][BFC] Add support for block level replaced box. 2019-01-31 05:40:53 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1500358 0 zalan 2019-01-30 19:06:16 -0800 <iframe style="display: block"> 1500363 1 360673 zalan 2019-01-30 19:10:21 -0800 Created attachment 360673 Patch 1500549 2 360673 koivisto 2019-01-31 05:30:44 -0800 Comment on attachment 360673 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360673&action=review > Source/WebCore/layout/layouttree/LayoutBox.h:71 > typedef unsigned BaseTypeFlags; OptionSet! 1500550 3 zalan 2019-01-31 05:38:18 -0800 Committed r240779: <https://trac.webkit.org/changeset/240779> 1500551 4 webkit-bug-importer 2019-01-31 05:39:27 -0800 <rdar://problem/47700108> 1500554 5 zalan 2019-01-31 05:40:53 -0800 (In reply to Antti Koivisto from comment #2) > Comment on attachment 360673 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=360673&action=review > > > Source/WebCore/layout/layouttree/LayoutBox.h:71 > > typedef unsigned BaseTypeFlags; > > OptionSet! It's coming!!! 360673 2019-01-30 19:10:21 -0800 2019-01-31 05:30:44 -0800 Patch bug-194071-20190130191008.patch text/plain 6804 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGMyYWVmMmJmMGNmNTBk M2EzYTZiNjJlZjk0ZTRlOWUyZjQyMjkwOS4uNWFhYjRhMjRiMDk5M2MwZjU1MTI5MjFjMzU1ZTRi OGEyOWYzNTUwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTAxLTMwICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bQkZDXSBBZGQgc3Vw cG9ydCBmb3IgYmxvY2sgbGV2ZWwgcmVwbGFjZWQgYm94LgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MDcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBsYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRCb3gu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpCb3g6OkJveCk6CisgICAgICAgICogbGF5 b3V0L2xheW91dHRyZWUvTGF5b3V0Qm94Lmg6CisgICAgICAgICogbGF5b3V0L2xheW91dHRyZWUv TGF5b3V0VHJlZUJ1aWxkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpUcmVlQnVp bGRlcjo6Y3JlYXRlU3ViVHJlZSk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6Om91dHB1dExh eW91dEJveCk6CisKIDIwMTktMDEtMzAgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgog CiAgICAgICAgIFBvaW50ZXJFdmVudHMgLSB0aWx0WCBhbmQgdGlsdFkgYXJlIHJldmVyc2VkCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRCb3guY3Bw IGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0Qm94LmNwcAppbmRleCA2 ZDA1OTAzZDQxNmFiZmZjNzUzMzgwYjEyNTgyMTVhNzQ1Y2VjMTczLi4zOTI2NTlkZmFlZWJiNTcz Zjg4MDkzNjI3N2RkYWZjNGQ2NGEyNjRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlv dXQvbGF5b3V0dHJlZS9MYXlvdXRCb3guY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9s YXlvdXR0cmVlL0xheW91dEJveC5jcHAKQEAgLTQ2LDYgKzQ2LDExIEBAIEJveDo6Qm94KE9wdGlv bmFsPEVsZW1lbnRBdHRyaWJ1dGVzPiBhdHRyaWJ1dGVzLCBSZW5kZXJTdHlsZSYmIHN0eWxlLCBC YXNlVHlwZUZsCiAgICAgICAgIG1fcmVwbGFjZWQgPSBzdGQ6Om1ha2VfdW5pcXVlPFJlcGxhY2Vk PigqdGhpcyk7CiB9CiAKK0JveDo6Qm94KE9wdGlvbmFsPEVsZW1lbnRBdHRyaWJ1dGVzPiBhdHRy aWJ1dGVzLCBSZW5kZXJTdHlsZSYmIHN0eWxlKQorICAgIDogQm94KGF0dHJpYnV0ZXMsIFdURk1v dmUoc3R5bGUpLCBCYXNlVHlwZUZsYWc6OkJveEZsYWcpCit7Cit9CisKIEJveDo6fkJveCgpCiB7 CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRC b3guaCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dEJveC5oCmluZGV4 IDUyZjc0MDZjY2YxMGI3MGQxZjllYTMwMmUzZGU3MmMyZmEzOTFjYmIuLjBhMTUxMTA3Mjc4ZmEz NjQ3YzdlYjBkNjA0Zjk3MGQ4MjIzNDc5ZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9sYXlvdXR0cmVlL0xheW91dEJveC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9s YXlvdXR0cmVlL0xheW91dEJveC5oCkBAIC02MSwxNSArNjEsMTYgQEAgcHVibGljOgogICAgIH07 CiAKICAgICBlbnVtIEJhc2VUeXBlRmxhZyB7Ci0gICAgICAgIENvbnRhaW5lckZsYWcgICAgICAg ICA9IDEgPDwgMCwKLSAgICAgICAgQmxvY2tDb250YWluZXJGbGFnICAgID0gMSA8PCAxLAotICAg ICAgICBJbmxpbmVCb3hGbGFnICAgICAgICAgPSAxIDw8IDIsCi0gICAgICAgIElubGluZUNvbnRh aW5lckZsYWcgICA9IDEgPDwgMywKLSAgICAgICAgTGluZUJyZWFrQm94RmxhZyAgICAgID0gMSA8 PCA0CisgICAgICAgIEJveEZsYWcgICAgICAgICAgICAgICA9IDEgPDwgMCwKKyAgICAgICAgQ29u dGFpbmVyRmxhZyAgICAgICAgID0gMSA8PCAxLAorICAgICAgICBCbG9ja0NvbnRhaW5lckZsYWcg ICAgPSAxIDw8IDIsCisgICAgICAgIElubGluZUJveEZsYWcgICAgICAgICA9IDEgPDwgMywKKyAg ICAgICAgSW5saW5lQ29udGFpbmVyRmxhZyAgID0gMSA8PCA0LAorICAgICAgICBMaW5lQnJlYWtC b3hGbGFnICAgICAgPSAxIDw8IDUKICAgICB9OwogICAgIHR5cGVkZWYgdW5zaWduZWQgQmFzZVR5 cGVGbGFnczsKIAotICAgIEJveChPcHRpb25hbDxFbGVtZW50QXR0cmlidXRlcz4sIFJlbmRlclN0 eWxlJiYsIEJhc2VUeXBlRmxhZ3MpOworICAgIEJveChPcHRpb25hbDxFbGVtZW50QXR0cmlidXRl cz4sIFJlbmRlclN0eWxlJiYpOwogICAgIHZpcnR1YWwgfkJveCgpOwogCiAgICAgYm9vbCBlc3Rh Ymxpc2hlc0Zvcm1hdHRpbmdDb250ZXh0KCkgY29uc3Q7CkBAIC0xMzUsNiArMTM2LDkgQEAgcHVi bGljOgogICAgIHZvaWQgc2V0TmV4dFNpYmxpbmcoQm94JiBuZXh0U2libGluZykgeyBtX25leHRT aWJsaW5nID0gJm5leHRTaWJsaW5nOyB9CiAgICAgdm9pZCBzZXRQcmV2aW91c1NpYmxpbmcoQm94 JiBwcmV2aW91c1NpYmxpbmcpIHsgbV9wcmV2aW91c1NpYmxpbmcgPSAmcHJldmlvdXNTaWJsaW5n OyB9CiAKK3Byb3RlY3RlZDoKKyAgICBCb3goT3B0aW9uYWw8RWxlbWVudEF0dHJpYnV0ZXM+LCBS ZW5kZXJTdHlsZSYmLCBCYXNlVHlwZUZsYWdzKTsKKwogcHJpdmF0ZToKICAgICBSZW5kZXJTdHls ZSBtX3N0eWxlOwogICAgIE9wdGlvbmFsPEVsZW1lbnRBdHRyaWJ1dGVzPiBtX2VsZW1lbnRBdHRy aWJ1dGVzOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUvTGF5 b3V0VHJlZUJ1aWxkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUvTGF5 b3V0VHJlZUJ1aWxkZXIuY3BwCmluZGV4IDgwMDYyOWI1MTQzYWU5N2U3NzFjMmU5ZDI3ODMxYTQ2 YjNkZGU0YjcuLmY4ZGEwYmQ3MjQ0ZTk3NGEyZGJkODFjYWE2OWZkZjNjZjU2NDNkOGQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dFRyZWVCdWlsZGVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRUcmVlQnVp bGRlci5jcHAKQEAgLTc3LDcgKzc3LDcgQEAgdm9pZCBUcmVlQnVpbGRlcjo6Y3JlYXRlU3ViVHJl ZShjb25zdCBSZW5kZXJFbGVtZW50JiByb290UmVuZGVyZXIsIENvbnRhaW5lciYgcm8KICAgICAg ICAgICAgICAgICByZXR1cm4gQm94OjpFbGVtZW50QXR0cmlidXRlcyB7IEJveDo6RWxlbWVudFR5 cGU6OlRhYmxlRm9vdGVyR3JvdXAgfTsKICAgICAgICAgICAgIGlmIChlbGVtZW50LT5oYXNUYWdO YW1lKEhUTUxOYW1lczo6dGZvb3RUYWcpKQogICAgICAgICAgICAgICAgIHJldHVybiBCb3g6OkVs ZW1lbnRBdHRyaWJ1dGVzIHsgQm94OjpFbGVtZW50VHlwZTo6VGFibGVGb290ZXJHcm91cCB9Owot ICAgICAgICAgICAgaWYgKGVsZW1lbnQtPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjppbWdUYWcpKQor ICAgICAgICAgICAgaWYgKGVsZW1lbnQtPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjppbWdUYWcpIHx8 IGVsZW1lbnQtPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjppZnJhbWVUYWcpKQogICAgICAgICAgICAg ICAgIHJldHVybiBCb3g6OkVsZW1lbnRBdHRyaWJ1dGVzIHsgQm94OjpFbGVtZW50VHlwZTo6UmVw bGFjZWQgfTsKICAgICAgICAgICAgIHJldHVybiBCb3g6OkVsZW1lbnRBdHRyaWJ1dGVzIHsgQm94 OjpFbGVtZW50VHlwZTo6R2VuZXJpY0VsZW1lbnQgfTsKICAgICAgICAgfQpAQCAtOTIsNyArOTIs MTEgQEAgdm9pZCBUcmVlQnVpbGRlcjo6Y3JlYXRlU3ViVHJlZShjb25zdCBSZW5kZXJFbGVtZW50 JiByb290UmVuZGVyZXIsIENvbnRhaW5lciYgcm8KICAgICAgICAgICAgIGRvd25jYXN0PElubGlu ZUJveD4oKmJveCkuc2V0VGV4dENvbnRlbnQoZG93bmNhc3Q8UmVuZGVyVGV4dD4oY2hpbGQpLm9y aWdpbmFsVGV4dCgpKTsKICAgICAgICAgfSBlbHNlIGlmIChpczxSZW5kZXJSZXBsYWNlZD4oY2hp bGQpKSB7CiAgICAgICAgICAgICBhdXRvJiByZW5kZXJlciA9IGRvd25jYXN0PFJlbmRlclJlcGxh Y2VkPihjaGlsZCk7Ci0gICAgICAgICAgICBib3ggPSBzdGQ6Om1ha2VfdW5pcXVlPElubGluZUJv eD4oZWxlbWVudEF0dHJpYnV0ZXMocmVuZGVyZXIpLCBSZW5kZXJTdHlsZTo6Y2xvbmUocmVuZGVy ZXIuc3R5bGUoKSkpOworICAgICAgICAgICAgYXV0byBkaXNwbGF5ID0gcmVuZGVyZXIuc3R5bGUo KS5kaXNwbGF5KCk7CisgICAgICAgICAgICBpZiAoZGlzcGxheSA9PSBEaXNwbGF5VHlwZTo6Qmxv Y2spCisgICAgICAgICAgICAgICAgYm94ID0gc3RkOjptYWtlX3VuaXF1ZTxCb3g+KGVsZW1lbnRB dHRyaWJ1dGVzKHJlbmRlcmVyKSwgUmVuZGVyU3R5bGU6OmNsb25lKHJlbmRlcmVyLnN0eWxlKCkp KTsKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBib3ggPSBzdGQ6Om1ha2VfdW5p cXVlPElubGluZUJveD4oZWxlbWVudEF0dHJpYnV0ZXMocmVuZGVyZXIpLCBSZW5kZXJTdHlsZTo6 Y2xvbmUocmVuZGVyZXIuc3R5bGUoKSkpOwogICAgICAgICB9IGVsc2UgaWYgKGlzPFJlbmRlckVs ZW1lbnQ+KGNoaWxkKSkgewogICAgICAgICAgICAgYXV0byYgcmVuZGVyZXIgPSBkb3duY2FzdDxS ZW5kZXJFbGVtZW50PihjaGlsZCk7CiAgICAgICAgICAgICBhdXRvIGRpc3BsYXkgPSByZW5kZXJl ci5zdHlsZSgpLmRpc3BsYXkoKTsKQEAgLTE3Niw3ICsxODAsOSBAQCBzdGF0aWMgdm9pZCBvdXRw dXRMYXlvdXRCb3goVGV4dFN0cmVhbSYgc3RyZWFtLCBjb25zdCBCb3gmIGxheW91dEJveCwgY29u c3QgRGlzcAogICAgICAgICBpZiAoIWxheW91dEJveC5wYXJlbnQoKSkKICAgICAgICAgICAgIHN0 cmVhbSA8PCAiaW5pdGlhbCAiOwogICAgICAgICBzdHJlYW0gPDwgImJsb2NrIGNvbnRhaW5lciI7 Ci0gICAgfSBlbHNlCisgICAgfSBlbHNlIGlmIChsYXlvdXRCb3guaXNCbG9ja0xldmVsQm94KCkp CisgICAgICAgIHN0cmVhbSA8PCAiYmxvY2sgYm94IjsKKyAgICBlbHNlCiAgICAgICAgIHN0cmVh bSA8PCAiYm94IjsKICAgICAvLyBGSVhNRTogSW5saW5lIHRleHQgcnVucyBkb24ndCBjcmVhdGUg ZGlzcGxheSBib3hlcyB5ZXQuCiAgICAgaWYgKGRpc3BsYXlCb3gpIHsKZGlmZiAtLWdpdCBhL1Rv b2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0ZWFmOTYxYjNkYWM1MDhlYmVl ODk0MGJlZDcxMWNlMmY0NTZjZjdiLi44MDA5YzBkZDRkOWJmYzAxM2U5YmYyOTdjOTNlMzBiMTIx MDc1MzdkIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTIgQEAKKzIwMTktMDEtMzAgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxl LmNvbT4KKworICAgICAgICBbTEZDXVtCRkNdIEFkZCBzdXBwb3J0IGZvciBibG9jayBsZXZlbCBy ZXBsYWNlZCBib3guCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTQwNzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIExheW91dFJlbG9hZGVkL21pc2MvTEZDLXBhc3NpbmctdGVzdHMudHh0OgorCiAyMDE5 LTAxLTMwICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ10g RXhwYW5kIHRlc3RzIGNvdmVyYWdlLgpkaWZmIC0tZ2l0IGEvVG9vbHMvTGF5b3V0UmVsb2FkZWQv bWlzYy9MRkMtcGFzc2luZy10ZXN0cy50eHQgYi9Ub29scy9MYXlvdXRSZWxvYWRlZC9taXNjL0xG Qy1wYXNzaW5nLXRlc3RzLnR4dAppbmRleCA0ZTcyZjQ1N2M5ZjMxMjNiOTRkZDlkMmZkNzQwNWYx MTVhZmMzMzYwLi4xYTk1NDhlYTUxZWJlYzVhZDA2MTI5NDUyZWM2MDNjYmQzNWFiZGM5IDEwMDY0 NAotLS0gYS9Ub29scy9MYXlvdXRSZWxvYWRlZC9taXNjL0xGQy1wYXNzaW5nLXRlc3RzLnR4dAor KysgYi9Ub29scy9MYXlvdXRSZWxvYWRlZC9taXNjL0xGQy1wYXNzaW5nLXRlc3RzLnR4dApAQCAt NDE0LDYgKzQxNCwxMiBAQCBjc3MyLjEvMjAxMTAzMjMvYWJzb2x1dGUtbm9uLXJlcGxhY2VkLXdp ZHRoLTAxMy5odG0KIGNzczIuMS8yMDExMDMyMy9hYnNvbHV0ZS1ub24tcmVwbGFjZWQtd2lkdGgt MDE0Lmh0bQogY3NzMi4xLzIwMTEwMzIzL2Fic29sdXRlLW5vbi1yZXBsYWNlZC13aWR0aC0wMTUu aHRtCiBjc3MyLjEvMjAxMTAzMjMvYWJzb2x1dGUtbm9uLXJlcGxhY2VkLXdpZHRoLTAxNi5odG0K K2NzczIuMS8yMDExMDMyMy9hYnNvbHV0ZS1yZXBsYWNlZC1oZWlnaHQtMDA0Lmh0bQorY3NzMi4x LzIwMTEwMzIzL2Fic29sdXRlLXJlcGxhY2VkLWhlaWdodC0wMDUuaHRtCitjc3MyLjEvMjAxMTAz MjMvYWJzb2x1dGUtcmVwbGFjZWQtaGVpZ2h0LTAwNy5odG0KK2NzczIuMS8yMDExMDMyMy9hYnNv bHV0ZS1yZXBsYWNlZC1oZWlnaHQtMDExLmh0bQorY3NzMi4xLzIwMTEwMzIzL2Fic29sdXRlLXJl cGxhY2VkLWhlaWdodC0wMTIuaHRtCitjc3MyLjEvMjAxMTAzMjMvYWJzb2x1dGUtcmVwbGFjZWQt aGVpZ2h0LTAxNC5odG0KIGNzczIuMS90MDQwMi1jNzEtZndkLXBhcnNpbmctMDAtZi5odG1sCiBj c3MyLjEvdDA0MDItYzcxLWZ3ZC1wYXJzaW5nLTAxLWYuaHRtbAogY3NzMi4xL3QwNDAyLWM3MS1m d2QtcGFyc2luZy0wMy1mLmh0bWwK