194069 2019-01-30 17:39:30 -0800 [MSE][GStreamer] Remove if (m_playerPrivate) from MediaSourceClientGStreamerMSE 2019-02-05 08:03:20 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya aboya bugs-noreply calvaris commit-queue mcatanzaro webkit-bug-importer oldest_to_newest 1500318 0 aboya 2019-01-30 17:39:30 -0800 m_playerPrivate is non-NULL since MediaSourceClientGStreamerMSE creation well until its destruction. The only case that could make a NULL m_playerPrivate is clearPlayerPrivate() but that method is not used anymore. 1500319 1 360658 aboya 2019-01-30 17:40:32 -0800 Created attachment 360658 Patch 1500414 2 360658 mcatanzaro 2019-01-30 21:14:26 -0800 Comment on attachment 360658 Patch I think you should also change m_playerPrivate from MediaPlayerPrivateGStreamerMSE* to MediaPlayerPrivateGStreamerMSE&. 1500563 3 360658 commit-queue 2019-01-31 06:52:50 -0800 Comment on attachment 360658 Patch Clearing flags on attachment: 360658 Committed r240783: <https://trac.webkit.org/changeset/240783> 1500564 4 commit-queue 2019-01-31 06:52:52 -0800 All reviewed patches have been landed. Closing bug. 1500579 5 aboya 2019-01-31 08:05:13 -0800 (In reply to Michael Catanzaro from comment #2) > Comment on attachment 360658 [details] > Patch > > I think you should also change m_playerPrivate from > MediaPlayerPrivateGStreamerMSE* to MediaPlayerPrivateGStreamerMSE&. I agree that's better in this case. https://bugs.webkit.org/show_bug.cgi?id=194091 360658 2019-01-30 17:40:32 -0800 2019-01-31 06:52:50 -0800 Patch bug-194069-20190131024030.patch text/plain 6488 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNzI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDc3MDI2YjI2NzdiNzYw OTQwMzcxMjczZjJmZThhNmRhYjM3NTUyMi4uMjBhYThkZTYyNzg1MjhmOWJmYjViOGM1Yzc0YWYx YjQ5NDk4MjEwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDE5LTAxLTMwICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbTVNFXVtHU3Ry ZWFtZXJdIFJlbW92ZSBpZiAobV9wbGF5ZXJQcml2YXRlKSBmcm9tIE1lZGlhU291cmNlQ2xpZW50 R1N0cmVhbWVyTVNFCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTQwNjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBtX3BsYXllclByaXZhdGUgaXMgbm9uLU5VTEwgc2luY2UgTWVkaWFTb3VyY2VDbGllbnRH U3RyZWFtZXJNU0UKKyAgICAgICAgY3JlYXRpb24gd2VsbCB1bnRpbCBpdHMgZGVzdHJ1Y3Rpb24u CisKKyAgICAgICAgVGhlIG9ubHkgY2FzZSB0aGF0IGNvdWxkIG1ha2UgYSBOVUxMIG1fcGxheWVy UHJpdmF0ZSBpcworICAgICAgICBjbGVhclBsYXllclByaXZhdGUoKSBidXQgdGhhdCBtZXRob2Qg aXMgbm90IHVzZWQgYW55bW9yZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9tc2UvTWVkaWFTb3VyY2VDbGllbnRHU3RyZWFtZXJNU0UuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6TWVkaWFTb3VyY2VDbGllbnRHU3RyZWFtZXJNU0U6OmFkZFNvdXJjZUJ1ZmZlcik6Cisg ICAgICAgIChXZWJDb3JlOjpNZWRpYVNvdXJjZUNsaWVudEdTdHJlYW1lck1TRTo6ZHVyYXRpb25D aGFuZ2VkKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU291cmNlQ2xpZW50R1N0cmVhbWVyTVNF OjphYm9ydCk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVNvdXJjZUNsaWVudEdTdHJlYW1lck1T RTo6cmVzZXRQYXJzZXJTdGF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVNvdXJjZUNsaWVu dEdTdHJlYW1lck1TRTo6bWFya0VuZE9mU3RyZWFtKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlh U291cmNlQ2xpZW50R1N0cmVhbWVyTVNFOjpyZW1vdmVkRnJvbU1lZGlhU291cmNlKToKKyAgICAg ICAgKFdlYkNvcmU6Ok1lZGlhU291cmNlQ2xpZW50R1N0cmVhbWVyTVNFOjpmbHVzaCk6CisgICAg ICAgIChXZWJDb3JlOjpNZWRpYVNvdXJjZUNsaWVudEdTdHJlYW1lck1TRTo6ZW5xdWV1ZVNhbXBs ZSk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVNvdXJjZUNsaWVudEdTdHJlYW1lck1TRTo6YWxs U2FtcGxlc0luVHJhY2tFbnF1ZXVlZCk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVNvdXJjZUNs aWVudEdTdHJlYW1lck1TRTo6d2ViS2l0TWVkaWFTcmMpOgorICAgICAgICAoV2ViQ29yZTo6TWVk aWFTb3VyY2VDbGllbnRHU3RyZWFtZXJNU0U6OmNsZWFyUGxheWVyUHJpdmF0ZSk6IERlbGV0ZWQu CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9NZWRpYVNvdXJjZUNs aWVudEdTdHJlYW1lck1TRS5oOgorCiAyMDE5LTAxLTE3ICBBbGljaWEgQm95YSBHYXJjw61hICA8 YWJveWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbTVNFXVtHU3RyZWFtZXJdIFJlbW92ZSB1bnVz ZWQgR3N0Rmxvd1JldHVybiBpbiBBcHBlbmRQaXBlbGluZSBtZXRob2RzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL01lZGlhU291cmNl Q2xpZW50R1N0cmVhbWVyTVNFLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9tc2UvTWVkaWFTb3VyY2VDbGllbnRHU3RyZWFtZXJNU0UuY3BwCmluZGV4IDE5 NGU5MjE5MjNkMWEwNzE0YmY3MjAzNTc0NzJlNTczMDc2MmVhZjQuLjNmZTQ4YmJmNTQ3ZGRkYTAx NmYyZmRiYzgyZjEwNzNiNDVhNDRlOTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvTWVkaWFTb3VyY2VDbGllbnRHU3RyZWFtZXJNU0Uu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2Uv TWVkaWFTb3VyY2VDbGllbnRHU3RyZWFtZXJNU0UuY3BwCkBAIC02MCw5ICs2MCw2IEBAIE1lZGlh U291cmNlUHJpdmF0ZTo6QWRkU3RhdHVzIE1lZGlhU291cmNlQ2xpZW50R1N0cmVhbWVyTVNFOjph ZGRTb3VyY2VCdWZmZXIoUmVmCiB7CiAgICAgQVNTRVJUKFdURjo6aXNNYWluVGhyZWFkKCkpOwog Ci0gICAgaWYgKCFtX3BsYXllclByaXZhdGUpCi0gICAgICAgIHJldHVybiBNZWRpYVNvdXJjZVBy aXZhdGU6OkFkZFN0YXR1czo6Tm90U3VwcG9ydGVkOwotCiAgICAgQVNTRVJUKG1fcGxheWVyUHJp dmF0ZS0+bV9wbGF5YmFja1BpcGVsaW5lKTsKICAgICBBU1NFUlQoc291cmNlQnVmZmVyUHJpdmF0 ZSk7CiAKQEAgLTg5LDggKzg2LDcgQEAgdm9pZCBNZWRpYVNvdXJjZUNsaWVudEdTdHJlYW1lck1T RTo6ZHVyYXRpb25DaGFuZ2VkKGNvbnN0IE1lZGlhVGltZSYgZHVyYXRpb24pCiAgICAgICAgIHJl dHVybjsKIAogICAgIG1fZHVyYXRpb24gPSBkdXJhdGlvbjsKLSAgICBpZiAobV9wbGF5ZXJQcml2 YXRlKQotICAgICAgICBtX3BsYXllclByaXZhdGUtPmR1cmF0aW9uQ2hhbmdlZCgpOworICAgIG1f cGxheWVyUHJpdmF0ZS0+ZHVyYXRpb25DaGFuZ2VkKCk7CiB9CiAKIHZvaWQgTWVkaWFTb3VyY2VD bGllbnRHU3RyZWFtZXJNU0U6OmFib3J0KFJlZlB0cjxTb3VyY2VCdWZmZXJQcml2YXRlR1N0cmVh bWVyPiBzb3VyY2VCdWZmZXJQcml2YXRlKQpAQCAtOTksOSArOTUsNiBAQCB2b2lkIE1lZGlhU291 cmNlQ2xpZW50R1N0cmVhbWVyTVNFOjphYm9ydChSZWZQdHI8U291cmNlQnVmZmVyUHJpdmF0ZUdT dHJlYW1lcj4gcwogCiAgICAgR1NUX0RFQlVHKCJhYm9ydGluZyIpOwogCi0gICAgaWYgKCFtX3Bs YXllclByaXZhdGUpCi0gICAgICAgIHJldHVybjsKLQogICAgIFJlZlB0cjxBcHBlbmRQaXBlbGlu ZT4gYXBwZW5kUGlwZWxpbmUgPSBtX3BsYXllclByaXZhdGUtPm1fYXBwZW5kUGlwZWxpbmVzTWFw LmdldChzb3VyY2VCdWZmZXJQcml2YXRlKTsKIAogICAgIEFTU0VSVChhcHBlbmRQaXBlbGluZSk7 CkBAIC0xMTUsOSArMTA4LDYgQEAgdm9pZCBNZWRpYVNvdXJjZUNsaWVudEdTdHJlYW1lck1TRTo6 cmVzZXRQYXJzZXJTdGF0ZShSZWZQdHI8U291cmNlQnVmZmVyUHJpdmF0ZUcKIAogICAgIEdTVF9E RUJVRygicmVzZXR0aW5nIHBhcnNlciBzdGF0ZSIpOwogCi0gICAgaWYgKCFtX3BsYXllclByaXZh dGUpCi0gICAgICAgIHJldHVybjsKLQogICAgIFJlZlB0cjxBcHBlbmRQaXBlbGluZT4gYXBwZW5k UGlwZWxpbmUgPSBtX3BsYXllclByaXZhdGUtPm1fYXBwZW5kUGlwZWxpbmVzTWFwLmdldChzb3Vy Y2VCdWZmZXJQcml2YXRlKTsKIAogICAgIEFTU0VSVChhcHBlbmRQaXBlbGluZSk7CkBAIC0xNTMs OSArMTQzLDYgQEAgdm9pZCBNZWRpYVNvdXJjZUNsaWVudEdTdHJlYW1lck1TRTo6bWFya0VuZE9m U3RyZWFtKE1lZGlhU291cmNlUHJpdmF0ZTo6RW5kT2ZTdHIKIHsKICAgICBBU1NFUlQoV1RGOjpp c01haW5UaHJlYWQoKSk7CiAKLSAgICBpZiAoIW1fcGxheWVyUHJpdmF0ZSkKLSAgICAgICAgcmV0 dXJuOwotCiAgICAgbV9wbGF5ZXJQcml2YXRlLT5tYXJrRW5kT2ZTdHJlYW0oc3RhdHVzKTsKIH0K IApAQCAtMTYzLDkgKzE1MCw2IEBAIHZvaWQgTWVkaWFTb3VyY2VDbGllbnRHU3RyZWFtZXJNU0U6 OnJlbW92ZWRGcm9tTWVkaWFTb3VyY2UoUmVmUHRyPFNvdXJjZUJ1ZmZlclByCiB7CiAgICAgQVNT RVJUKFdURjo6aXNNYWluVGhyZWFkKCkpOwogCi0gICAgaWYgKCFtX3BsYXllclByaXZhdGUpCi0g ICAgICAgIHJldHVybjsKLQogICAgIEFTU0VSVChtX3BsYXllclByaXZhdGUtPm1fcGxheWJhY2tQ aXBlbGluZSk7CiAKICAgICAvLyBSZW1vdmUgdGhlIEFwcGVuZFBpcGVsaW5lIGZyb20gdGhlIG1h cC4gVGhpcyBzaG91bGQgY2F1c2UgaXRzIGRlc3RydWN0aW9uIHNpbmNlIHRoZXJlIHNob3VsZCBi ZSBubyBhbGl2ZQpAQCAtMTgxLDcgKzE2NSw3IEBAIHZvaWQgTWVkaWFTb3VyY2VDbGllbnRHU3Ry ZWFtZXJNU0U6OmZsdXNoKEF0b21pY1N0cmluZyB0cmFja0lkKQogICAgIEFTU0VSVChXVEY6Omlz TWFpblRocmVhZCgpKTsKIAogICAgIC8vIFRoaXMgaXMgb25seSBmb3Igb24tdGhlLWZseSByZWVu cXVldWVzIGFmdGVyIGFwcGVuZHMuIFdoZW4gc2Vla2luZywgdGhlIHNlZWsgd2lsbCBkbyBpdHMg b3duIGZsdXNoLgotICAgIGlmIChtX3BsYXllclByaXZhdGUgJiYgIW1fcGxheWVyUHJpdmF0ZS0+ bV9zZWVraW5nKQorICAgIGlmICghbV9wbGF5ZXJQcml2YXRlLT5tX3NlZWtpbmcpCiAgICAgICAg IG1fcGxheWVyUHJpdmF0ZS0+bV9wbGF5YmFja1BpcGVsaW5lLT5mbHVzaCh0cmFja0lkKTsKIH0K IApAQCAtMTg5LDI1ICsxNzMsMjAgQEAgdm9pZCBNZWRpYVNvdXJjZUNsaWVudEdTdHJlYW1lck1T RTo6ZW5xdWV1ZVNhbXBsZShSZWY8TWVkaWFTYW1wbGU+JiYgc2FtcGxlKQogewogICAgIEFTU0VS VChXVEY6OmlzTWFpblRocmVhZCgpKTsKIAotICAgIGlmIChtX3BsYXllclByaXZhdGUpCi0gICAg ICAgIG1fcGxheWVyUHJpdmF0ZS0+bV9wbGF5YmFja1BpcGVsaW5lLT5lbnF1ZXVlU2FtcGxlKFdU Rk1vdmUoc2FtcGxlKSk7CisgICAgbV9wbGF5ZXJQcml2YXRlLT5tX3BsYXliYWNrUGlwZWxpbmUt PmVucXVldWVTYW1wbGUoV1RGTW92ZShzYW1wbGUpKTsKIH0KIAogdm9pZCBNZWRpYVNvdXJjZUNs aWVudEdTdHJlYW1lck1TRTo6YWxsU2FtcGxlc0luVHJhY2tFbnF1ZXVlZChjb25zdCBBdG9taWNT dHJpbmcmIHRyYWNrSWQpCiB7CiAgICAgQVNTRVJUKFdURjo6aXNNYWluVGhyZWFkKCkpOwogCi0g ICAgaWYgKG1fcGxheWVyUHJpdmF0ZSkKLSAgICAgICAgbV9wbGF5ZXJQcml2YXRlLT5tX3BsYXli YWNrUGlwZWxpbmUtPmFsbFNhbXBsZXNJblRyYWNrRW5xdWV1ZWQodHJhY2tJZCk7CisgICAgbV9w bGF5ZXJQcml2YXRlLT5tX3BsYXliYWNrUGlwZWxpbmUtPmFsbFNhbXBsZXNJblRyYWNrRW5xdWV1 ZWQodHJhY2tJZCk7CiB9CiAKIEdSZWZQdHI8V2ViS2l0TWVkaWFTcmM+IE1lZGlhU291cmNlQ2xp ZW50R1N0cmVhbWVyTVNFOjp3ZWJLaXRNZWRpYVNyYygpCiB7CiAgICAgQVNTRVJUKFdURjo6aXNN YWluVGhyZWFkKCkpOwogCi0gICAgaWYgKCFtX3BsYXllclByaXZhdGUpCi0gICAgICAgIHJldHVy biBudWxscHRyOwotCiAgICAgV2ViS2l0TWVkaWFTcmMqIHNvdXJjZSA9IFdFQktJVF9NRURJQV9T UkMobV9wbGF5ZXJQcml2YXRlLT5tX3NvdXJjZS5nZXQoKSk7CiAKICAgICBBU1NFUlQoV0VCS0lU X0lTX01FRElBX1NSQyhzb3VyY2UpKTsKQEAgLTIxNSwxMyArMTk0LDYgQEAgR1JlZlB0cjxXZWJL aXRNZWRpYVNyYz4gTWVkaWFTb3VyY2VDbGllbnRHU3RyZWFtZXJNU0U6OndlYktpdE1lZGlhU3Jj KCkKICAgICByZXR1cm4gc291cmNlOwogfQogCi12b2lkIE1lZGlhU291cmNlQ2xpZW50R1N0cmVh bWVyTVNFOjpjbGVhclBsYXllclByaXZhdGUoKQotewotICAgIEFTU0VSVChXVEY6OmlzTWFpblRo cmVhZCgpKTsKLQotICAgIG1fcGxheWVyUHJpdmF0ZSA9IG51bGxwdHI7Ci19Ci0KIH0gLy8gbmFt ZXNwYWNlIFdlYkNvcmUuCiAKICNlbmRpZiAvLyBVU0UoR1NUUkVBTUVSKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9NZWRpYVNvdXJj ZUNsaWVudEdTdHJlYW1lck1TRS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL21zZS9NZWRpYVNvdXJjZUNsaWVudEdTdHJlYW1lck1TRS5oCmluZGV4IDViMmM5 MzY4NDBjMDI3ZmVlOGJlNjlkZDRjOGZhM2JkMmMwYTllZjQuLmEyMzYwYmNkYzBjMDMwYTZhODU2 MmYyYzEzYmE5MDYxNzcxOTdjNGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvTWVkaWFTb3VyY2VDbGllbnRHU3RyZWFtZXJNU0UuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL01lZGlh U291cmNlQ2xpZW50R1N0cmVhbWVyTVNFLmgKQEAgLTU0LDggKzU0LDYgQEAgcHVibGljOgogICAg IHZvaWQgZW5xdWV1ZVNhbXBsZShSZWY8TWVkaWFTYW1wbGU+JiYpOwogICAgIHZvaWQgYWxsU2Ft cGxlc0luVHJhY2tFbnF1ZXVlZChjb25zdCBBdG9taWNTdHJpbmcmKTsKIAotICAgIHZvaWQgY2xl YXJQbGF5ZXJQcml2YXRlKCk7Ci0KICAgICBjb25zdCBNZWRpYVRpbWUmIGR1cmF0aW9uKCk7CiAg ICAgR1JlZlB0cjxXZWJLaXRNZWRpYVNyYz4gd2ViS2l0TWVkaWFTcmMoKTsKIAo=