194058 2019-01-30 16:03:10 -0800 Add default constructor for NetworkActivityTracker 2019-01-30 17:55:34 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin bfulgham cdumez commit-queue webkit-bug-importer oldest_to_newest 1500252 0 krollin 2019-01-30 16:03:10 -0800 ResourceNetworkActivityTracker has a default constructor. It also has a NetworkActivityTracker data member, which does not have a default constructor. This will cause some compilers to complain -- they can't default-create a ResourceNetworkActivityTracker because they can't default-create its data members. Address this by adding a default constructor for NetworkActivityTracker. 1500253 1 webkit-bug-importer 2019-01-30 16:03:28 -0800 <rdar://problem/47685457> 1500254 2 360638 krollin 2019-01-30 16:05:40 -0800 Created attachment 360638 Patch 1500256 3 360638 cdumez 2019-01-30 16:07:49 -0800 Comment on attachment 360638 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360638&action=review > Source/WebKit/NetworkProcess/NetworkActivityTracker.h:68 > NetworkActivityTracker(Label, Domain = Domain::WebKit); explicit ? 1500272 4 360644 krollin 2019-01-30 16:32:54 -0800 Created attachment 360644 Patch 1500328 5 360644 commit-queue 2019-01-30 17:55:33 -0800 Comment on attachment 360644 Patch Clearing flags on attachment: 360644 Committed r240747: <https://trac.webkit.org/changeset/240747> 1500329 6 commit-queue 2019-01-30 17:55:34 -0800 All reviewed patches have been landed. Closing bug. 360638 2019-01-30 16:05:40 -0800 2019-01-30 16:32:53 -0800 Patch bug-194058-20190130160539.patch text/plain 1923 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDNiY2U3NGQzYWIxZGVlMjg4 MDc2ZjcyNTg5YjIxMmUxNjRjNGFhMGUuLjllNzdmYWI1N2E4NzI2NDMyMzAxNGIzM2RmOTVlYWEz ODIwZDZlYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMDEtMzAgIEtlaXRoIFJv bGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBkZWZhdWx0IGNvbnN0cnVj dG9yIGZvciBOZXR3b3JrQWN0aXZpdHlUcmFja2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQwNTgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ3 Njg1NDU3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlc291cmNlTmV0d29ya0FjdGl2aXR5VHJhY2tlciBoYXMgYSBkZWZhdWx0IGNvbnN0cnVjdG9y LiBJdCBhbHNvIGhhcworICAgICAgICBhIE5ldHdvcmtBY3Rpdml0eVRyYWNrZXIgZGF0YSBtZW1i ZXIsIHdoaWNoIGRvZXMgbm90IGhhdmUgYSBkZWZhdWx0CisgICAgICAgIGNvbnN0cnVjdG9yLiBU aGlzIHdpbGwgY2F1c2Ugc29tZSBjb21waWxlcnMgdG8gY29tcGxhaW4gLS0gdGhleSBjYW4ndAor ICAgICAgICBkZWZhdWx0LWNyZWF0ZSBhIFJlc291cmNlTmV0d29ya0FjdGl2aXR5VHJhY2tlciBi ZWNhdXNlIHRoZXkgY2FuJ3QKKyAgICAgICAgZGVmYXVsdC1jcmVhdGUgaXRzIGRhdGEgbWVtYmVy cy4gQWRkcmVzcyB0aGlzIGJ5IGFkZGluZyBhIGRlZmF1bHQKKyAgICAgICAgY29uc3RydWN0b3Ig Zm9yIE5ldHdvcmtBY3Rpdml0eVRyYWNrZXIuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9O ZXR3b3JrQWN0aXZpdHlUcmFja2VyLmg6CisKIDIwMTktMDEtMzAgIEFudHRpIEtvaXZpc3RvICA8 YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIENyYXNoIGluIFdlYktpdDo6UmVtb3RlTGF5ZXJU cmVlUHJvcGVydHlBcHBsaWVyOjp1cGRhdGVDaGlsZHJlbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQWN0aXZpdHlUcmFja2VyLmggYi9Tb3VyY2UvV2Vi S2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtBY3Rpdml0eVRyYWNrZXIuaAppbmRleCA4OGUzMjA2 YjhiZmMxYWMwYThlZTk5NDdiMDdmOWU2ZjgyZGNhYzI5Li4xMTllZmMwZWY4YjBkNTdlYWVlMWI3 ODkwYTUwYTU5YjQzZTcyYmQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL05ldHdvcmtBY3Rpdml0eVRyYWNrZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQ cm9jZXNzL05ldHdvcmtBY3Rpdml0eVRyYWNrZXIuaApAQCAtNjQsNiArNjQsNyBAQCBwdWJsaWM6 CiAgICAgICAgIEZhaWx1cmUsCiAgICAgfTsKIAorICAgIE5ldHdvcmtBY3Rpdml0eVRyYWNrZXIo KSA9IGRlZmF1bHQ7CiAgICAgTmV0d29ya0FjdGl2aXR5VHJhY2tlcihMYWJlbCwgRG9tYWluID0g RG9tYWluOjpXZWJLaXQpOwogICAgIH5OZXR3b3JrQWN0aXZpdHlUcmFja2VyKCk7CiAKQEAgLTc3 LDggKzc4LDggQEAgcHVibGljOgogCiBwcml2YXRlOgogI2lmIEhBVkUoTldfQUNUSVZJVFkpCi0g ICAgRG9tYWluIG1fZG9tYWluOwotICAgIExhYmVsIG1fbGFiZWw7CisgICAgRG9tYWluIG1fZG9t YWluIHsgRG9tYWluOjpJbnZhbGlkIH07CisgICAgTGFiZWwgbV9sYWJlbCB7IExhYmVsOjpJbnZh bGlkIH07CiAgICAgYm9vbCBtX2lzQ29tcGxldGVkIHsgZmFsc2UgfTsKICAgICBSZXRhaW5QdHI8 bndfYWN0aXZpdHlfdD4gbV9uZXR3b3JrQWN0aXZpdHk7CiAjZW5kaWYK 360644 2019-01-30 16:32:54 -0800 2019-01-30 17:55:33 -0800 Patch bug-194058-20190130163253.patch text/plain 2036 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDNiY2U3NGQzYWIxZGVlMjg4 MDc2ZjcyNTg5YjIxMmUxNjRjNGFhMGUuLjc4ZjVkOWYzODEzNzc3MjgzYTkxMWVhYjIzZmE5Y2Fk NDg1N2NhYmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMDEtMzAgIEtlaXRoIFJv bGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBkZWZhdWx0IGNvbnN0cnVj dG9yIGZvciBOZXR3b3JrQWN0aXZpdHlUcmFja2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQwNTgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ3 Njg1NDU3PgorCisgICAgICAgIFJldmlld2VkIGJ5IENocmlzIER1bWV6LgorCisgICAgICAgIFJl c291cmNlTmV0d29ya0FjdGl2aXR5VHJhY2tlciBoYXMgYSBkZWZhdWx0IGNvbnN0cnVjdG9yLiBJ dCBhbHNvIGhhcworICAgICAgICBhIE5ldHdvcmtBY3Rpdml0eVRyYWNrZXIgZGF0YSBtZW1iZXIs IHdoaWNoIGRvZXMgbm90IGhhdmUgYSBkZWZhdWx0CisgICAgICAgIGNvbnN0cnVjdG9yLiBUaGlz IHdpbGwgY2F1c2Ugc29tZSBjb21waWxlcnMgdG8gY29tcGxhaW4gLS0gdGhleSBjYW4ndAorICAg ICAgICBkZWZhdWx0LWNyZWF0ZSBhIFJlc291cmNlTmV0d29ya0FjdGl2aXR5VHJhY2tlciBiZWNh dXNlIHRoZXkgY2FuJ3QKKyAgICAgICAgZGVmYXVsdC1jcmVhdGUgaXRzIGRhdGEgbWVtYmVycy4g QWRkcmVzcyB0aGlzIGJ5IGFkZGluZyBhIGRlZmF1bHQKKyAgICAgICAgY29uc3RydWN0b3IgZm9y IE5ldHdvcmtBY3Rpdml0eVRyYWNrZXIuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3 b3JrQWN0aXZpdHlUcmFja2VyLmg6CisKIDIwMTktMDEtMzAgIEFudHRpIEtvaXZpc3RvICA8YW50 dGlAYXBwbGUuY29tPgogCiAgICAgICAgIENyYXNoIGluIFdlYktpdDo6UmVtb3RlTGF5ZXJUcmVl UHJvcGVydHlBcHBsaWVyOjp1cGRhdGVDaGlsZHJlbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQWN0aXZpdHlUcmFja2VyLmggYi9Tb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL05ldHdvcmtBY3Rpdml0eVRyYWNrZXIuaAppbmRleCA4OGUzMjA2Yjhi ZmMxYWMwYThlZTk5NDdiMDdmOWU2ZjgyZGNhYzI5Li5mMmEwNjk0ZWVmZmJmMTU0MGQ4YTFlZWNk MjVjZTZmNDRmMWNlMTA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNz L05ldHdvcmtBY3Rpdml0eVRyYWNrZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL05ldHdvcmtBY3Rpdml0eVRyYWNrZXIuaApAQCAtNjQsNyArNjQsOCBAQCBwdWJsaWM6CiAg ICAgICAgIEZhaWx1cmUsCiAgICAgfTsKIAotICAgIE5ldHdvcmtBY3Rpdml0eVRyYWNrZXIoTGFi ZWwsIERvbWFpbiA9IERvbWFpbjo6V2ViS2l0KTsKKyAgICBOZXR3b3JrQWN0aXZpdHlUcmFja2Vy KCkgPSBkZWZhdWx0OworICAgIGV4cGxpY2l0IE5ldHdvcmtBY3Rpdml0eVRyYWNrZXIoTGFiZWws IERvbWFpbiA9IERvbWFpbjo6V2ViS2l0KTsKICAgICB+TmV0d29ya0FjdGl2aXR5VHJhY2tlcigp OwogCiAgICAgdm9pZCBzZXRQYXJlbnQoTmV0d29ya0FjdGl2aXR5VHJhY2tlciYpOwpAQCAtNzcs OCArNzgsOCBAQCBwdWJsaWM6CiAKIHByaXZhdGU6CiAjaWYgSEFWRShOV19BQ1RJVklUWSkKLSAg ICBEb21haW4gbV9kb21haW47Ci0gICAgTGFiZWwgbV9sYWJlbDsKKyAgICBEb21haW4gbV9kb21h aW4geyBEb21haW46OkludmFsaWQgfTsKKyAgICBMYWJlbCBtX2xhYmVsIHsgTGFiZWw6OkludmFs aWQgfTsKICAgICBib29sIG1faXNDb21wbGV0ZWQgeyBmYWxzZSB9OwogICAgIFJldGFpblB0cjxu d19hY3Rpdml0eV90PiBtX25ldHdvcmtBY3Rpdml0eTsKICNlbmRpZgo=