194057 2019-01-30 15:56:35 -0800 FloatWithRect has invalid and inaccessible default constructor 2019-01-30 17:35:34 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin commit-queue webkit-bug-importer zalan oldest_to_newest 1500249 0 krollin 2019-01-30 15:56:35 -0800 FloatWithRect has a default constructor declared as 'default'. This constructor is invalid because FloatWithRect has a data member that's a reference that will not get initialized with this constructor. Since its invalid, and since it's private and not accessed by anything, remove this constructor. 1500250 1 webkit-bug-importer 2019-01-30 15:56:53 -0800 <rdar://problem/47685211> 1500251 2 360637 krollin 2019-01-30 15:58:27 -0800 Created attachment 360637 Patch 1500314 3 360637 commit-queue 2019-01-30 17:35:32 -0800 Comment on attachment 360637 Patch Clearing flags on attachment: 360637 Committed r240744: <https://trac.webkit.org/changeset/240744> 1500315 4 commit-queue 2019-01-30 17:35:34 -0800 All reviewed patches have been landed. Closing bug. 360637 2019-01-30 15:58:27 -0800 2019-01-30 17:35:32 -0800 Patch bug-194057-20190130155827.patch text/plain 1818 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDlhOWUzOWYwOTNlYWNk NzhlYWMwMjRkOTE0NTY0OGM0MDE1MTk1ZC4uMmEwZmU2NTE2NmFjYWFmZTZjZDYyY2JkZjQ0YTg3 NzVlNzFlZmI5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTAxLTMwICBLZWl0 aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBGbG9hdFdpdGhSZWN0IGhh cyBpbnZhbGlkIGFuZCBpbmFjY2Vzc2libGUgZGVmYXVsdCBjb25zdHJ1Y3RvcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MDU3CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS80NzY4NTIxMT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGbG9hdFdpdGhSZWN0IGhhcyBhIGRlZmF1bHQgY29uc3RydWN0b3Ig ZGVjbGFyZWQgYXMgJ2RlZmF1bHQnLiBUaGlzCisgICAgICAgIGNvbnN0cnVjdG9yIGlzIGludmFs aWQgYmVjYXVzZSBGbG9hdFdpdGhSZWN0IGhhcyBhIGRhdGEgbWVtYmVyIHRoYXQncworICAgICAg ICBhIHJlZmVyZW5jZSB0aGF0IHdpbGwgbm90IGdldCBpbml0aWFsaXplZCB3aXRoIHRoaXMgY29u c3RydWN0b3IuIFNpbmNlCisgICAgICAgIGl0J3MgaW52YWxpZCwgYW5kIHNpbmNlIGl0J3MgcHJp dmF0ZSBhbmQgbm90IGFjY2Vzc2VkIGJ5IGFueXRoaW5nLAorICAgICAgICByZW1vdmUgdGhpcyBj b25zdHJ1Y3Rvci4KKworICAgICAgICBObyBuZXcgdGVzdHMgc2luY2UgdGhlcmUgc2hvdWxkIGJl IG5vIG9ic2VydmFibGUgYmVoYXZpb3IgZGlmZmVyZW5jZS4KKworICAgICAgICAqIHJlbmRlcmlu Zy9saW5lL0xpbmVMYXlvdXRTdGF0ZS5oOgorCiAyMDE5LTAxLTMwICBLZWl0aCBSb2xsaW4gIDxr cm9sbGluQGFwcGxlLmNvbT4KIAogICAgICAgICBHQ0dhbWVwYWQgaXMgZGVwcmVjYXRlZApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL2xpbmUvTGluZUxheW91dFN0YXRlLmgg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvbGluZS9MaW5lTGF5b3V0U3RhdGUuaAppbmRleCA3 OTJmNTRhZTFhNGJlNTFjNjRmNzQ1MzUxZDcwYzQ5NDU5ZjU4MWIwLi5kMDY4OWI0ODFmNTc4MjM5 Nzk3MWFkZWZjOWJkMWY2MzZiMDdkMTQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvbGluZS9MaW5lTGF5b3V0U3RhdGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvbGluZS9MaW5lTGF5b3V0U3RhdGUuaApAQCAtNTQsOCArNTQsNiBAQCBwdWJsaWM6CiAgICAg dm9pZCBhZGp1c3RSZWN0KGNvbnN0IExheW91dFJlY3QmIHJlY3QpIHsgbV9yZWN0ID0gcmVjdDsg fQogCiBwcml2YXRlOgotICAgIEZsb2F0V2l0aFJlY3QoKSA9IGRlZmF1bHQ7Ci0gICAgCiAgICAg RmxvYXRXaXRoUmVjdChSZW5kZXJCb3gmIHJlbmRlcmVyKQogICAgICAgICA6IG1fcmVuZGVyZXIo cmVuZGVyZXIpCiAgICAgICAgICwgbV9yZWN0KExheW91dFJlY3QocmVuZGVyZXIueCgpIC0gcmVu ZGVyZXIubWFyZ2luTGVmdCgpLCByZW5kZXJlci55KCkgLSByZW5kZXJlci5tYXJnaW5Ub3AoKSwg cmVuZGVyZXIud2lkdGgoKSArIHJlbmRlcmVyLmhvcml6b250YWxNYXJnaW5FeHRlbnQoKSwgcmVu ZGVyZXIuaGVpZ2h0KCkgKyByZW5kZXJlci52ZXJ0aWNhbE1hcmdpbkV4dGVudCgpKSkK