194054 2019-01-30 15:36:07 -0800 Fix crashes when trying to ref the CallbackAggregator in NetworkProcess 2019-01-30 16:58:29 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 193556 1 cdumez cdumez achristensen beidson bfulgham commit-queue ggaren webkit-bug-importer youennf oldest_to_newest 1500232 0 cdumez 2019-01-30 15:36:07 -0800 Fix crashes when trying to ref the CallbackAggregator in NetworkProcess: Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x000000010d3aeb10 WTFCrash + 16 (Assertions.cpp:255) 1 com.apple.JavaScriptCore 0x000000010d3aeb29 WTFCrashWithSecurityImplication + 9 2 com.apple.WebKit 0x0000000105a2a262 WTF::RefCountedBase::ref() const + 66 (RefCounted.h:43) Assertion failure: ASSERTION FAILED: !m_deletionHasBegun /Volumes/Data/slave/highsierra-debug/build/WebKitBuild/Debug/usr/local/include/wtf/RefCounted.h(43) : void WTF::RefCountedBase::ref() const 1 0x10d3aeb09 WTFCrash 2 0x10d3aeb29 WTFCrashWithSecurityImplication 3 0x105a2a262 WTF::RefCountedBase::ref() const 4 0x105d516e7 WTF::Ref<WebKit::NetworkProcess::deleteWebsiteDataForTopPrivatelyControlledDomainsInAllPersistentDataStores(PAL::SessionID, WTF::OptionSet<WebKit::WebsiteDataType>, WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul>&&, bool, WTF::CompletionHandler<void (WTF::HashSet<WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String> > const&)>&&)::CallbackAggregator, WTF::DumbPtrTraits<WebKit::NetworkProcess::deleteWebsiteDataForTopPrivatelyControlledDomainsInAllPersistentDataStores(PAL::SessionID, WTF::OptionSet<WebKit::WebsiteDataType>, WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul>&&, bool, WTF::CompletionHandler<void (WTF::HashSet<WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String> > const&)>&&)::CallbackAggregator> >::Ref(WebKit::NetworkProcess::deleteWebsiteDataForTopPrivatelyControlledDomainsInAllPersistentDataStores(PAL::SessionID, WTF::OptionSet<WebKit::WebsiteDataType>, WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul>&&, bool, WTF::CompletionHandler<void (WTF::HashSet<WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String> > const&)>&&)::CallbackAggregator&) 1500235 1 360634 cdumez 2019-01-30 15:37:24 -0800 Created attachment 360634 Patch 1500241 2 360634 bfulgham 2019-01-30 15:42:47 -0800 Comment on attachment 360634 Patch Whoops! Thank you for fixing this. 1500291 3 360634 commit-queue 2019-01-30 16:57:02 -0800 Comment on attachment 360634 Patch Clearing flags on attachment: 360634 Committed r240743: <https://trac.webkit.org/changeset/240743> 1500292 4 commit-queue 2019-01-30 16:57:03 -0800 All reviewed patches have been landed. Closing bug. 1500294 5 webkit-bug-importer 2019-01-30 16:58:29 -0800 <rdar://problem/47687539> 360634 2019-01-30 15:37:24 -0800 2019-01-30 16:57:02 -0800 Patch bug-194054-20190130153723.patch text/plain 3054 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDE3MTk0MDNjNTI3ZmM0ZWNh Zjg3YmY1ZGI3NDdmZjNiZmRmYzM5NWIuLjFjMTAxZThmMzRlNWNmMWM4MGZiZGMyODIxNGRhNjkx MWU3Nzg5YzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDEtMzAgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBGaXggY3Jhc2hlcyB3aGVuIHRyeWlu ZyB0byByZWYgdGhlIENhbGxiYWNrQWdncmVnYXRvciBpbiBOZXR3b3JrUHJvY2VzcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MDU0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNhbGxiYWNrIGFn Z3JlZ2F0b3JzIHNob3VsZCBiZSBUaHJlYWRTYWZlUmVmQ291bnRlZCBzaW5jZSB0aGV5IGFyZSBw YXNzZWQgdG8gb3RoZXIgdGhyZWFkcy4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL05ldHdv cmtQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya1Byb2Nlc3M6OmZldGNoV2Vi c2l0ZURhdGEpOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUHJvY2Vzczo6ZGVsZXRlV2Vic2l0 ZURhdGFGb3JUb3BQcml2YXRlbHlDb250cm9sbGVkRG9tYWluc0luQWxsUGVyc2lzdGVudERhdGFT dG9yZXMpOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUHJvY2Vzczo6dG9wUHJpdmF0ZWx5Q29u dHJvbGxlZERvbWFpbnNXaXRoV2Vic2l0ZURhdGEpOgorCiAyMDE5LTAxLTI5ICBDb25yYWQgU2h1 bHR6ICA8Y29ucmFkX3NodWx0ekBhcHBsZS5jb20+CiAKICAgICAgICAgRW5zdXJlIGltYWdlIHBp Y2tlciBzb3VyY2VUeXBlIGlzIHNldCBiZWZvcmUgY2FtZXJhRGV2aWNlCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcCBiL1NvdXJjZS9X ZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuY3BwCmluZGV4IGNhNTdjNGRiY2Qx ZDlkNDk5MDc3MzgxNGJjMjMwNmFmZjYzMTA1ZjQuLjA1NzA5NTNmMjdkNzViMDcxZThkYzg2N2M3 M2FmYjM5ZWEwZTE3MDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mv TmV0d29ya1Byb2Nlc3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0 d29ya1Byb2Nlc3MuY3BwCkBAIC0xMjE1LDcgKzEyMTUsNyBAQCBzdGF0aWMgdm9pZCBmZXRjaERp c2tDYWNoZUVudHJpZXMoTmV0d29ya0NhY2hlOjpDYWNoZSogY2FjaGUsIFBBTDo6U2Vzc2lvbklE IHNlcwogCiB2b2lkIE5ldHdvcmtQcm9jZXNzOjpmZXRjaFdlYnNpdGVEYXRhKFBBTDo6U2Vzc2lv bklEIHNlc3Npb25JRCwgT3B0aW9uU2V0PFdlYnNpdGVEYXRhVHlwZT4gd2Vic2l0ZURhdGFUeXBl cywgT3B0aW9uU2V0PFdlYnNpdGVEYXRhRmV0Y2hPcHRpb24+IGZldGNoT3B0aW9ucywgdWludDY0 X3QgY2FsbGJhY2tJRCkKIHsKLSAgICBzdHJ1Y3QgQ2FsbGJhY2tBZ2dyZWdhdG9yIGZpbmFsIDog cHVibGljIFJlZkNvdW50ZWQ8Q2FsbGJhY2tBZ2dyZWdhdG9yPiB7CisgICAgc3RydWN0IENhbGxi YWNrQWdncmVnYXRvciBmaW5hbCA6IHB1YmxpYyBUaHJlYWRTYWZlUmVmQ291bnRlZDxDYWxsYmFj a0FnZ3JlZ2F0b3I+IHsKICAgICAgICAgZXhwbGljaXQgQ2FsbGJhY2tBZ2dyZWdhdG9yKEZ1bmN0 aW9uPHZvaWQgKFdlYnNpdGVEYXRhKT4mJiBjb21wbGV0aW9uSGFuZGxlcikKICAgICAgICAgICAg IDogbV9jb21wbGV0aW9uSGFuZGxlcihXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSkKICAgICAg ICAgewpAQCAtMTQzNyw3ICsxNDM3LDcgQEAgdm9pZCBOZXR3b3JrUHJvY2Vzczo6ZGVsZXRlV2Vi c2l0ZURhdGFGb3JUb3BQcml2YXRlbHlDb250cm9sbGVkRG9tYWluc0luQWxsUGVyc2kKIHsKICAg ICBPcHRpb25TZXQ8V2Vic2l0ZURhdGFGZXRjaE9wdGlvbj4gZmV0Y2hPcHRpb25zID0gV2Vic2l0 ZURhdGFGZXRjaE9wdGlvbjo6RG9Ob3RDcmVhdGVQcm9jZXNzZXM7CiAKLSAgICBzdHJ1Y3QgQ2Fs bGJhY2tBZ2dyZWdhdG9yIGZpbmFsIDogcHVibGljIFJlZkNvdW50ZWQ8Q2FsbGJhY2tBZ2dyZWdh dG9yPiB7CisgICAgc3RydWN0IENhbGxiYWNrQWdncmVnYXRvciBmaW5hbCA6IHB1YmxpYyBUaHJl YWRTYWZlUmVmQ291bnRlZDxDYWxsYmFja0FnZ3JlZ2F0b3I+IHsKICAgICAgICAgZXhwbGljaXQg Q2FsbGJhY2tBZ2dyZWdhdG9yKENvbXBsZXRpb25IYW5kbGVyPHZvaWQoY29uc3QgSGFzaFNldDxT dHJpbmc+Jik+JiYgY29tcGxldGlvbkhhbmRsZXIpCiAgICAgICAgICAgICA6IG1fY29tcGxldGlv bkhhbmRsZXIoV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcikpCiAgICAgICAgIHsKQEAgLTE1Njks NyArMTU2OSw3IEBAIHZvaWQgTmV0d29ya1Byb2Nlc3M6OnRvcFByaXZhdGVseUNvbnRyb2xsZWRE b21haW5zV2l0aFdlYnNpdGVEYXRhKFBBTDo6U2Vzc2lvbklECiB7CiAgICAgT3B0aW9uU2V0PFdl YnNpdGVEYXRhRmV0Y2hPcHRpb24+IGZldGNoT3B0aW9ucyA9IFdlYnNpdGVEYXRhRmV0Y2hPcHRp b246OkRvTm90Q3JlYXRlUHJvY2Vzc2VzOwogICAgIAotICAgIHN0cnVjdCBDYWxsYmFja0FnZ3Jl Z2F0b3IgZmluYWwgOiBwdWJsaWMgUmVmQ291bnRlZDxDYWxsYmFja0FnZ3JlZ2F0b3I+IHsKKyAg ICBzdHJ1Y3QgQ2FsbGJhY2tBZ2dyZWdhdG9yIGZpbmFsIDogcHVibGljIFRocmVhZFNhZmVSZWZD b3VudGVkPENhbGxiYWNrQWdncmVnYXRvcj4gewogICAgICAgICBleHBsaWNpdCBDYWxsYmFja0Fn Z3JlZ2F0b3IoQ29tcGxldGlvbkhhbmRsZXI8dm9pZChIYXNoU2V0PFN0cmluZz4mJik+JiYgY29t cGxldGlvbkhhbmRsZXIpCiAgICAgICAgICAgICA6IG1fY29tcGxldGlvbkhhbmRsZXIoV1RGTW92 ZShjb21wbGV0aW9uSGFuZGxlcikpCiAgICAgICAgIHsK