194045 2019-01-30 13:51:43 -0800 CachedBytecode move constructor should not call `freeDataIfOwned` 2019-02-01 08:25:32 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tzagallo tzagallo commit-queue darin ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1500161 0 tzagallo 2019-01-30 13:51:43 -0800 That might result in freeing a garbage value 1500162 1 360615 tzagallo 2019-01-30 13:53:12 -0800 Created attachment 360615 Patch 1500171 2 360615 mark.lam 2019-01-30 14:02:51 -0800 Comment on attachment 360615 Patch r=me 1500215 3 360615 commit-queue 2019-01-30 14:56:52 -0800 Comment on attachment 360615 Patch Clearing flags on attachment: 360615 Committed r240732: <https://trac.webkit.org/changeset/240732> 1500216 4 commit-queue 2019-01-30 14:56:53 -0800 All reviewed patches have been landed. Closing bug. 1500217 5 webkit-bug-importer 2019-01-30 14:57:30 -0800 <rdar://problem/47682823> 1501110 6 darin 2019-02-01 08:25:32 -0800 Just a meta-note about the mistake that led to this bug. Generally speaking in any non-trivial cases, we can implement operator= by calling the constructor in an appropriate way, and that's often a good pattern, but it's typically not good in such cases to attempt to implement a constructor by calling operator=. 360615 2019-01-30 13:53:12 -0800 2019-01-30 14:56:52 -0800 Patch bug-194045-20190130135252.patch text/plain 1452 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 YzJkMjhiYjdkYzYwMjgxZDljMWY0NTgwN2RlMWVmY2M2MjdmY2Y0Li42M2QzZjk1M2E1NTMzMzY1 Y2ExNGE2N2IyYzlmMTMwOWViZjU3YTk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOS0wMS0zMCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBDYWNoZWRCeXRlY29kZSdzIG1vdmUgY29uc3RydWN0b3Igc2hvdWxkIG5v dCBjYWxsIGBmcmVlRGF0YUlmT3duZWRgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTQwNDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGF0IG1pZ2h0IHJlc3VsdCBpbiBmcmVlaW5nIGEgZ2FyYmFnZSB2 YWx1ZQorCisgICAgICAgICogcGFyc2VyL1NvdXJjZVByb3ZpZGVyLmg6CisgICAgICAgIChKU0M6 OkNhY2hlZEJ5dGVjb2RlOjpDYWNoZWRCeXRlY29kZSk6CisKIDIwMTktMDEtMzAgIFl1c3VrZSBT dXp1a2kgIDx5dXN1a2VzdXp1a2lAc2xvd3N0YXJ0Lm9yZz4KIAogICAgICAgICBbSlNDXSBNYWtl IGdsb2JhbCBzdGF0aWMgdmFyaWFibGVzICJjb25zdCIgYXMgbXVjaCBhcyBwb3NzaWJsZQpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9Tb3VyY2VQcm92aWRlci5oIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9Tb3VyY2VQcm92aWRlci5oCmluZGV4IGE1ZTgy NWI3NzI3MTE1NDI5ZjBhNzRkMmU1MTkwYjJhZGRiM2Y1OWUuLjM3NzhiZjk0MWFkN2ZhYzg2NGQ2 Y2E3ODBhMDZkODI4OWU5MWFlNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9w YXJzZXIvU291cmNlUHJvdmlkZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2Vy L1NvdXJjZVByb3ZpZGVyLmgKQEAgLTY3LDcgKzY3LDEwIEBAIG5hbWVzcGFjZSBKU0MgewogCiAg ICAgICAgIENhY2hlZEJ5dGVjb2RlKENhY2hlZEJ5dGVjb2RlJiYgb3RoZXIpCiAgICAgICAgIHsK LSAgICAgICAgICAgICp0aGlzID0gV1RGTW92ZShvdGhlcik7CisgICAgICAgICAgICBtX293bmVk ID0gb3RoZXIubV9vd25lZDsKKyAgICAgICAgICAgIG1fc2l6ZSA9IG90aGVyLm1fc2l6ZTsKKyAg ICAgICAgICAgIG1fZGF0YSA9IG90aGVyLm1fZGF0YTsKKyAgICAgICAgICAgIG90aGVyLm1fb3du ZWQgPSBmYWxzZTsKICAgICAgICAgfQogCiAgICAgICAgIENhY2hlZEJ5dGVjb2RlJiBvcGVyYXRv cj0oQ2FjaGVkQnl0ZWNvZGUmJiBvdGhlcikK