<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>194041</bug_id>
          
          <creation_ts>2019-01-30 13:41:01 -0800</creation_ts>
          <short_desc>[JSC] Make disassembler data structures constant read-only data</short_desc>
          <delta_ts>2019-01-31 01:45:44 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=194085</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>193606</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Yusuke Suzuki">ysuzuki</reporter>
          <assigned_to name="Yusuke Suzuki">ysuzuki</assigned_to>
          <cc>ews-watchlist</cc>
    
    <cc>fujii</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1500149</commentid>
    <comment_count>0</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-01-30 13:41:01 -0800</bug_when>
    <thetext>[JSC] Make disassembler data structures constant ro data</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1500151</commentid>
    <comment_count>1</comment_count>
      <attachid>360611</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-01-30 13:42:26 -0800</bug_when>
    <thetext>Created attachment 360611
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1500153</commentid>
    <comment_count>2</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2019-01-30 13:44:06 -0800</bug_when>
    <thetext>Attachment 360611 did not pass style-queue:


ERROR: Source/JavaScriptCore/disassembler/udis86/ud_itab.py:252:  whitespace after &apos;(&apos;  [pep8/E201] [5]
ERROR: Source/JavaScriptCore/disassembler/udis86/ud_itab.py:263:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/disassembler/udis86/ud_itab.py:263:  whitespace after &apos;(&apos;  [pep8/E201] [5]
ERROR: Source/JavaScriptCore/disassembler/udis86/ud_itab.py:296:  whitespace after &apos;(&apos;  [pep8/E201] [5]
ERROR: Source/JavaScriptCore/disassembler/udis86/ud_itab.py:326:  whitespace after &apos;(&apos;  [pep8/E201] [5]
Total errors found: 5 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1500155</commentid>
    <comment_count>3</comment_count>
      <attachid>360611</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2019-01-30 13:45:04 -0800</bug_when>
    <thetext>Comment on attachment 360611
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360611&amp;action=review

r=me

&gt; Source/JavaScriptCore/ChangeLog:3
&gt; +        [JSC] Make disassembler data structures constant ro data

can you spell out read-only please?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1500156</commentid>
    <comment_count>4</comment_count>
      <attachid>360611</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-01-30 13:45:37 -0800</bug_when>
    <thetext>Comment on attachment 360611
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360611&amp;action=review

&gt;&gt; Source/JavaScriptCore/ChangeLog:3
&gt;&gt; +        [JSC] Make disassembler data structures constant ro data
&gt; 
&gt; can you spell out read-only please?

Fixed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1500181</commentid>
    <comment_count>5</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-01-30 14:12:57 -0800</bug_when>
    <thetext>Committed r240730: &lt;https://trac.webkit.org/changeset/240730&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1500183</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-01-30 14:13:31 -0800</bug_when>
    <thetext>&lt;rdar://problem/47680981&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1500367</commentid>
    <comment_count>7</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-01-30 19:28:03 -0800</bug_when>
    <thetext>Committed r240755: &lt;https://trac.webkit.org/changeset/240755&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1500369</commentid>
    <comment_count>8</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-01-30 19:29:40 -0800</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #7)
&gt; Committed r240755: &lt;https://trac.webkit.org/changeset/240755&gt;

The output is kinda ugly:

const struct ud_lookup_table_list_entry ud_lookup_table_list[] = {
    /* 000 */ { ud_itab__0, UD_TAB__OPC_TABLE, (const char* const)&quot;opctbl&quot; },
    /* 001 */ { ud_itab__1, UD_TAB__OPC_MODE, (const char* const)&quot;/m&quot; },
    /* 002 */ { ud_itab__2, UD_TAB__OPC_MODE, (const char* const)&quot;/m&quot; },
    /* 003 */ { ud_itab__3, UD_TAB__OPC_MODE, (const char* const)&quot;/m&quot; },
    /* 004 */ { ud_itab__4, UD_TAB__OPC_TABLE, (const char* const)&quot;opctbl&quot; },

etc. But it&apos;s needed to avoid:

In file included from ../../Source/JavaScriptCore/disassembler/udis86/udis86_itab_holder.c:30:
DerivedSources/JavaScriptCore/udis86_itab.c:2677:35: error: conflicting types for ‘ud_lookup_table_list’
 struct ud_lookup_table_list_entry ud_lookup_table_list[] = {
                                   ^~~~~~~~~~~~~~~~~~~~
In file included from DerivedSources/JavaScriptCore/udis86_itab.c:2,
                 from ../../Source/JavaScriptCore/disassembler/udis86/udis86_itab_holder.c:30:
../../Source/JavaScriptCore/disassembler/udis86/udis86_decode.h:189:48: note: previous declaration of ‘ud_lookup_table_list’ was here
 extern const struct ud_lookup_table_list_entry ud_lookup_table_list[];
                                                ^~~~~~~~~~~~~~~~~~~~
In file included from ../../Source/JavaScriptCore/disassembler/udis86/udis86_itab_holder.c:30:
DerivedSources/JavaScriptCore/udis86_itab.c:3272:22: error: conflicting types for ‘ud_itab’
 struct ud_itab_entry ud_itab[] = {
                      ^~~~~~~
In file included from DerivedSources/JavaScriptCore/udis86_itab.c:2,
                 from ../../Source/JavaScriptCore/disassembler/udis86/udis86_itab_holder.c:30:
../../Source/JavaScriptCore/disassembler/udis86/udis86_decode.h:188:35: note: previous declaration of ‘ud_itab’ was here
 extern const struct ud_itab_entry ud_itab[];
                                   ^~~~~~~</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1500378</commentid>
    <comment_count>9</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2019-01-30 19:51:08 -0800</bug_when>
    <thetext>Same error message was reported for WinCairo.
https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Build%29/builds/6570

They are solved by triggering Force Clean Build.
https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Build%29/builds/6581

Seems a Ninja incremental build issue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1500383</commentid>
    <comment_count>10</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2019-01-30 19:59:28 -0800</bug_when>
    <thetext>According to the GTK build log, it seems that udis86_itab_holder.c was recompiled without regenerating udis86_itab.c by invoking ud_itab.py.
https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/18892/steps/compile-webkit/logs/stdio</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1500408</commentid>
    <comment_count>11</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-01-30 21:03:01 -0800</bug_when>
    <thetext>Hmm, OK I tricked myself then; I manually deleted udis86_itab.c to test that change, just deleting it was probably enough. Indeed, changes to ud_itab.py don&apos;t result in a rebuild of the generated files.

I&apos;ll rollout my &quot;fix.&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1500409</commentid>
    <comment_count>12</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-01-30 21:04:36 -0800</bug_when>
    <thetext>Reverted r240755 for reason:

This was not correct

Committed r240760: &lt;https://trac.webkit.org/changeset/240760&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1500411</commentid>
    <comment_count>13</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-01-30 21:10:00 -0800</bug_when>
    <thetext>Triggered clean builds on all the WPE and GTK bots. Surprisingly, the JSCOnly bots don&apos;t seem to need it for some reason, not sure why.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1500422</commentid>
    <comment_count>14</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2019-01-30 22:08:18 -0800</bug_when>
    <thetext>Because we have no JSCOnly x86 bots compiling UDIS86 code path.

It seems difficult to attach a source dependency from ud_itab.py custom commad to udis86_itab_holder.c because it is difficult to determine which unified source bundle will includes udis86_itab_holder.c.
Anyway, I think ud_itab.py won&apos;t be modified frequently.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1500506</commentid>
    <comment_count>15</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2019-01-31 01:45:44 -0800</bug_when>
    <thetext>I&apos;m wrong. C files are not bundled. File a new ticker Bug 194085 to the incremental Ninja build issue.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>360611</attachid>
            <date>2019-01-30 13:42:26 -0800</date>
            <delta_ts>2019-01-30 13:45:04 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-194041-20190130134225.patch</filename>
            <type>text/plain</type>
            <size>6517</size>
            <attacher name="Yusuke Suzuki">ysuzuki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNzI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw
NWQwMTdlMjAwZmNmOWQyOWNlMzBjY2E2M2Q3YzMzMDI0ZjYzNzcxLi4yYTI3ZmRkN2I4Zjg4YmMy
NjA5NmNlNGE1NGViNmZhNTQ5ZGVhMjM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwyNCBAQAorMjAxOS0wMS0zMCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t
PgorCisgICAgICAgIFtKU0NdIE1ha2UgZGlzYXNzZW1ibGVyIGRhdGEgc3RydWN0dXJlcyBjb25z
dGFudCBybyBkYXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0xOTQwNDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg
ICAgICBCdW5jaCBvZiBkaXNhc3NlbWJsZXIgZGF0YSBzdHJ1Y3R1cmVzIGFyZSBub3QgbWFya2Vk
ICJjb25zdCIsIHdoaWNoIHByZXZlbnRzIHRoZSBsb2FkZXIgdG8gcHV0IHRoZW0gaW4gUk8gcmVn
aW9uLgorICAgICAgICBUaGlzIHBhdGNoIG1ha2VzIHRoZW0gImNvbnN0Ii4KKworICAgICAgICAq
IGRpc2Fzc2VtYmxlci9BUk02NC9BNjRET3Bjb2RlLmNwcDoKKyAgICAgICAgKiBkaXNhc3NlbWJs
ZXIvdWRpczg2L3VkX2l0YWIucHk6CisgICAgICAgIChVZEl0YWJHZW5lcmF0b3IuZ2VuT3Bjb2Rl
VGFibGVzTG9va3VwSW5kZXgpOgorICAgICAgICAoVWRJdGFiR2VuZXJhdG9yLmdlbkluc25UYWJs
ZSk6CisgICAgICAgIChVZEl0YWJHZW5lcmF0b3IuZ2VuTW5lbW9uaWNzTGlzdCk6CisgICAgICAg
IChnZW5JdGFiSCk6CisgICAgICAgICogZGlzYXNzZW1ibGVyL3VkaXM4Ni91ZGlzODZfZGVjb2Rl
Lmg6CisgICAgICAgICogZGlzYXNzZW1ibGVyL3VkaXM4Ni91ZGlzODZfc3luLmM6CisgICAgICAg
ICogZGlzYXNzZW1ibGVyL3VkaXM4Ni91ZGlzODZfc3luLmg6CisgICAgICAgICogZGlzYXNzZW1i
bGVyL3VkaXM4Ni91ZGlzODZfdHlwZXMuaDoKKwogMjAxOS0wMS0zMCAgWXVzdWtlIFN1enVraSAg
PHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHVwZGF0ZSB0aGUgYnVp
bHRpbiB0ZXN0IHJlc3VsdHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNh
c3NlbWJsZXIvQVJNNjQvQTY0RE9wY29kZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlz
YXNzZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuY3BwCmluZGV4IDU0MzA1MjYyOWE3MGQ4N2RiMDhk
OWI2NGMyMDg0YjUzZjNlN2U1MGEuLmUyOGQ1Zjk5MDkyNGRjNDQ2ZWFmNzdmYTFjYzBkMDg5MzU0
MGY1NTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvQVJN
NjQvQTY0RE9wY29kZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxl
ci9BUk02NC9BNjRET3Bjb2RlLmNwcApAQCAtNjQsNyArNjQsNyBAQCBzdHJ1Y3QgT3Bjb2RlR3Jv
dXBJbml0aWFsaXplciB7CiAjZGVmaW5lIE9QQ09ERV9HUk9VUF9FTlRSWShncm91cEluZGV4LCBn
cm91cENsYXNzKSBcCiB7IGdyb3VwSW5kZXgsIGdyb3VwQ2xhc3M6Om1hc2ssIGdyb3VwQ2xhc3M6
OnBhdHRlcm4sIGdyb3VwQ2xhc3M6OmZvcm1hdCB9CiAKLXN0YXRpYyBPcGNvZGVHcm91cEluaXRp
YWxpemVyIG9wY29kZUdyb3VwTGlzdFtdID0geworc3RhdGljIGNvbnN0IE9wY29kZUdyb3VwSW5p
dGlhbGl6ZXIgb3Bjb2RlR3JvdXBMaXN0W10gPSB7CiAgICAgT1BDT0RFX0dST1VQX0VOVFJZKDB4
MDgsIEE2NERPcGNvZGVMb2FkU3RvcmVSZWdpc3RlclBhaXIpLAogICAgIE9QQ09ERV9HUk9VUF9F
TlRSWSgweDA4LCBBNjRET3Bjb2RlTG9hZFN0b3JlRXhjbHVzaXZlKSwKICAgICBPUENPREVfR1JP
VVBfRU5UUlkoMHgwOSwgQTY0RE9wY29kZUxvYWRTdG9yZVJlZ2lzdGVyUGFpciksCmRpZmYgLS1n
aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL3VkaXM4Ni91ZF9pdGFiLnB5
IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci91ZGlzODYvdWRfaXRhYi5weQpp
bmRleCBlZjAxMWQyZWM0MmNmNjc0ZDAzNDMxNDI4ZmY0MGZkM2IyYjQyMDA3Li40MWY3MTBlODY4
ZDRkNzAzNDgwOTk1MGJlYjE5ODhkZmI5ZDc4NDVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj
cmlwdENvcmUvZGlzYXNzZW1ibGVyL3VkaXM4Ni91ZF9pdGFiLnB5CisrKyBiL1NvdXJjZS9KYXZh
U2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvdWRpczg2L3VkX2l0YWIucHkKQEAgLTI0OSw3ICsyNDks
NyBAQCBkZWYgZ2VuT3Bjb2RlVGFibGVzKHNlbGYpOgogCiAgICAgZGVmIGdlbk9wY29kZVRhYmxl
c0xvb2t1cEluZGV4KHNlbGYpOgogICAgICAgICBzZWxmLkl0YWJDLndyaXRlKCAiXG5cbiIgICk7
Ci0gICAgICAgIHNlbGYuSXRhYkMud3JpdGUoICJzdHJ1Y3QgdWRfbG9va3VwX3RhYmxlX2xpc3Rf
ZW50cnkgdWRfbG9va3VwX3RhYmxlX2xpc3RbXSA9IHtcbiIgKQorICAgICAgICBzZWxmLkl0YWJD
LndyaXRlKCAiY29uc3Qgc3RydWN0IHVkX2xvb2t1cF90YWJsZV9saXN0X2VudHJ5IHVkX2xvb2t1
cF90YWJsZV9saXN0W10gPSB7XG4iICkKICAgICAgICAgZm9yIHRhYmxlIGluIHNlbGYudGFibGVz
LmdldFRhYmxlTGlzdCgpOgogICAgICAgICAgICAgZjAgPSBzZWxmLmdldFRhYmxlTmFtZSh0YWJs
ZSkgKyAiLCIKICAgICAgICAgICAgIGYxID0gdGFibGUubGFiZWwoKSArICIsIgpAQCAtMjYwLDcg
KzI2MCw3IEBAIGRlZiBnZW5PcGNvZGVUYWJsZXNMb29rdXBJbmRleChzZWxmKToKIAogCiAgICAg
ZGVmIGdlbkluc25UYWJsZSggc2VsZiApOgotICAgICAgICBzZWxmLkl0YWJDLndyaXRlKCAic3Ry
dWN0IHVkX2l0YWJfZW50cnkgdWRfaXRhYltdID0ge1xuIiApOworICAgICAgICBzZWxmLkl0YWJD
LndyaXRlKCAiY29uc3Qgc3RydWN0IHVkX2l0YWJfZW50cnkgdWRfaXRhYltdID0ge1xuIiApOwog
ICAgICAgICBmb3IgaW5zbiBpbiBzZWxmLnRhYmxlcy5nZXRJbnNuTGlzdCgpOgogICAgICAgICAg
ICAgb3ByX2MgPSBbICJPX05PTkUiLCAiT19OT05FIiwgIk9fTk9ORSIsICJPX05PTkUiIF0KICAg
ICAgICAgICAgIHBmeF9jID0gW10KQEAgLTI5Myw3ICsyOTMsNyBAQCBkZWYgZ2V0TW5lbW9uaWNz
TGlzdChzZWxmKToKICAgICBkZWYgZ2VuTW5lbW9uaWNzTGlzdChzZWxmKToKICAgICAgICAgbW5l
bW9uaWNzID0gc2VsZi5nZXRNbmVtb25pY3NMaXN0KCkKICAgICAgICAgc2VsZi5JdGFiQy53cml0
ZSggIlxuXG4iICApOwotICAgICAgICBzZWxmLkl0YWJDLndyaXRlKCAiY29uc3QgY2hhciogdWRf
bW5lbW9uaWNzX3N0cltdID0ge1xuICAgICIgKQorICAgICAgICBzZWxmLkl0YWJDLndyaXRlKCAi
Y29uc3QgY2hhciogY29uc3QgdWRfbW5lbW9uaWNzX3N0cltdID0ge1xuICAgICIgKQogICAgICAg
ICBzZWxmLkl0YWJDLndyaXRlKCAiLFxuICAgICIuam9pbiggWyAiXCIlc1wiIiAlIG0gZm9yIG0g
aW4gbW5lbW9uaWNzIF0gKSApCiAgICAgICAgIHNlbGYuSXRhYkMud3JpdGUoICJcbn07XG4iICkK
ICAKQEAgLTMyMyw3ICszMjMsNyBAQCBkZWYgZ2VuSXRhYkgoIHNlbGYsIGZpbGVQYXRoICk6CiAg
ICAgICAgIHNlbGYuSXRhYkgud3JpdGUoIGVudW0gKQogICAgICAgICBzZWxmLkl0YWJILndyaXRl
KCAiXG4iICkKIAotICAgICAgICBzZWxmLkl0YWJILndyaXRlKCAiZXh0ZXJuIGNvbnN0IGNoYXIg
KiB1ZF9tbmVtb25pY3Nfc3RyW107XG4iICkKKyAgICAgICAgc2VsZi5JdGFiSC53cml0ZSggImV4
dGVybiBjb25zdCBjaGFyICogY29uc3QgdWRfbW5lbW9uaWNzX3N0cltdO1xuIiApCiAKICAgICAg
ICAgc2VsZi5JdGFiSC53cml0ZSggIlxuI2VuZGlmIC8qIFVEX0lUQUJfSCAqL1xuIiApCiAgICAg
CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL3VkaXM4Ni91
ZGlzODZfZGVjb2RlLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL3VkaXM4
Ni91ZGlzODZfZGVjb2RlLmgKaW5kZXggNDExYzg4MzBlYzQ2ZGU5MmI3YmE4MWYyOWQ3MmRjODdl
Yjk5ZDNlMS4uZDkyNWQxMDU0YzY5M2VhYTIwZGQzMzVhODlkOTc5MjdhODAzNTEwMSAxMDA2NDQK
LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci91ZGlzODYvdWRpczg2X2Rl
Y29kZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvdWRpczg2L3Vk
aXM4Nl9kZWNvZGUuaApAQCAtMTg1LDggKzE4NSw4IEBAIHN0cnVjdCB1ZF9sb29rdXBfdGFibGVf
bGlzdF9lbnRyeSB7CiAgICAgY29uc3QgY2hhciAqbWV0YTsKIH07CiAgICAgIAotZXh0ZXJuIHN0
cnVjdCB1ZF9pdGFiX2VudHJ5IHVkX2l0YWJbXTsKLWV4dGVybiBzdHJ1Y3QgdWRfbG9va3VwX3Rh
YmxlX2xpc3RfZW50cnkgdWRfbG9va3VwX3RhYmxlX2xpc3RbXTsKK2V4dGVybiBjb25zdCBzdHJ1
Y3QgdWRfaXRhYl9lbnRyeSB1ZF9pdGFiW107CitleHRlcm4gY29uc3Qgc3RydWN0IHVkX2xvb2t1
cF90YWJsZV9saXN0X2VudHJ5IHVkX2xvb2t1cF90YWJsZV9saXN0W107CiAKICNlbmRpZiAvKiBV
RF9ERUNPREVfSCAqLwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNz
ZW1ibGVyL3VkaXM4Ni91ZGlzODZfc3luLmMgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNz
ZW1ibGVyL3VkaXM4Ni91ZGlzODZfc3luLmMKaW5kZXggNDQxN2Q5OTk3YzIxNDgyMzZhNjk2YjI4
ZTYzMWYyZjI2MTZiYjY2OC4uZTllMGFkM2MwOGM5ZGM0YTM4NGQ2NjE0NGQ2ZTM1ZDMzMDE1Yjlk
OSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci91ZGlzODYv
dWRpczg2X3N5bi5jCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvdWRp
czg2L3VkaXM4Nl9zeW4uYwpAQCAtMzcsNyArMzcsNyBAQAogICogUmVnaXN0ZXIgVGFibGUgLSBP
cmRlciBNYXR0ZXJzICh0eXBlcy5oKSEKICAqCiAgKi8KLWNvbnN0IGNoYXIqIHVkX3JlZ190YWJb
XSA9IAorY29uc3QgY2hhciogY29uc3QgdWRfcmVnX3RhYltdID0gCiB7CiAgICJhbCIsICAgImNs
IiwgICAiZGwiLCAgICJibCIsCiAgICJhaCIsICAgImNoIiwgICAiZGgiLCAgICJiaCIsCmRpZmYg
LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL3VkaXM4Ni91ZGlzODZf
c3luLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL3VkaXM4Ni91ZGlzODZf
c3luLmgKaW5kZXggNzEyZWMzN2FlYTRiMmVmOWNmYmQwMjM5NzFmNDMzMGU3N2NkOGM3MC4uNzNm
NDI1MTFkYzZjMTlhY2RiNWUzYzAyNzM2ODAzYzVlODgxNWQ0ZSAxMDA2NDQKLS0tIGEvU291cmNl
L0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci91ZGlzODYvdWRpczg2X3N5bi5oCisrKyBiL1Nv
dXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvdWRpczg2L3VkaXM4Nl9zeW4uaApAQCAt
MzEsNyArMzEsNyBAQAogIyBpbmNsdWRlIDxzdGRhcmcuaD4KICNlbmRpZiAvKiBfX1VEX1NUQU5E
QUxPTkVfXyAqLwogCi1leHRlcm4gY29uc3QgY2hhciogdWRfcmVnX3RhYltdOworZXh0ZXJuIGNv
bnN0IGNoYXIqIGNvbnN0IHVkX3JlZ190YWJbXTsKIAogdWludDY0X3QgdWRfc3luX3JlbF90YXJn
ZXQoc3RydWN0IHVkKiwgc3RydWN0IHVkX29wZXJhbmQqKTsKIApkaWZmIC0tZ2l0IGEvU291cmNl
L0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci91ZGlzODYvdWRpczg2X3R5cGVzLmggYi9Tb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL3VkaXM4Ni91ZGlzODZfdHlwZXMuaAppbmRl
eCA2MDRmMDhlNTEwMjIwNmYwYTBiZWZkY2YwODRjODEwOTkyZDgyOWU5Li40NWJkNzVmOGZlMjU2
YzFkMzJkNDAxZTNmNWFiMmRkY2E2M2MwNGNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvZGlzYXNzZW1ibGVyL3VkaXM4Ni91ZGlzODZfdHlwZXMuaAorKysgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL3VkaXM4Ni91ZGlzODZfdHlwZXMuaApAQCAtMjMxLDgg
KzIzMSw4IEBAIHN0cnVjdCB1ZAogICB1aW50OF90ICAgdmV4X2IyOwogICB1aW50OF90ICAgcHJp
bWFyeV9vcGNvZGU7CiAgIHZvaWQgKiAgICB1c2VyX29wYXF1ZV9kYXRhOwotICBzdHJ1Y3QgdWRf
aXRhYl9lbnRyeSAqIGl0YWJfZW50cnk7Ci0gIHN0cnVjdCB1ZF9sb29rdXBfdGFibGVfbGlzdF9l
bnRyeSAqbGU7CisgIGNvbnN0IHN0cnVjdCB1ZF9pdGFiX2VudHJ5ICogaXRhYl9lbnRyeTsKKyAg
Y29uc3Qgc3RydWN0IHVkX2xvb2t1cF90YWJsZV9saXN0X2VudHJ5ICpsZTsKIH07CiAKIC8qIC0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tCg==
</data>
<flag name="review"
          id="377305"
          type_id="1"
          status="+"
          setter="mark.lam"
    />
          </attachment>
      

    </bug>

</bugzilla>