194037 2019-01-30 13:22:52 -0800 Remove assertion that CachedSymbolTables should have no RareData 2019-02-08 00:55:46 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tzagallo tzagallo commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1500133 0 tzagallo 2019-01-30 13:22:52 -0800 It turns out that we don't need to cache the SymbolTableRareData, but we should not assert that it's null. 1500157 1 360612 tzagallo 2019-01-30 13:45:59 -0800 Created attachment 360612 Patch 1500177 2 360612 mark.lam 2019-01-30 14:06:39 -0800 Comment on attachment 360612 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360612&action=review r=me > Source/JavaScriptCore/ChangeLog:9 > + It turns out that we don't need to cache the SymbolTableRareData, but > + we should not assert that it's empty. nit: Do you mean 'and we should not assert ..."? 1500178 3 360619 tzagallo 2019-01-30 14:08:42 -0800 Created attachment 360619 Patch for landing 1500218 4 360629 tzagallo 2019-01-30 15:03:50 -0800 Created attachment 360629 Patch for landing 1500279 5 360629 commit-queue 2019-01-30 16:47:04 -0800 Comment on attachment 360629 Patch for landing Clearing flags on attachment: 360629 Committed r240739: <https://trac.webkit.org/changeset/240739> 1500280 6 commit-queue 2019-01-30 16:47:06 -0800 All reviewed patches have been landed. Closing bug. 1500282 7 webkit-bug-importer 2019-01-30 16:48:38 -0800 <rdar://problem/47687176> 1500468 8 360629 saam 2019-01-30 23:41:48 -0800 Comment on attachment 360629 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=360629&action=review > Source/JavaScriptCore/ChangeLog:8 > + It turns out that we don't need to cache the SymbolTableRareData and It’s worth describing why here. 1504133 9 tzagallo 2019-02-08 00:55:46 -0800 *** Bug 194430 has been marked as a duplicate of this bug. *** 360612 2019-01-30 13:45:59 -0800 2019-01-30 14:08:40 -0800 Patch bug-194037-20190130134539.patch text/plain 1847 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 YzJkMjhiYjdkYzYwMjgxZDljMWY0NTgwN2RlMWVmY2M2MjdmY2Y0Li5iZDkyZjlhZDcwNmVkMThm YTM4OWQ0N2QwZDczMzcwMDRkYTQ3ZjMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wMS0zMCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBSZW1vdmUgYXNzZXJ0aW9uIHRoYXQgQ2FjaGVkU3ltYm9sVGFibGVzIHNo b3VsZCBoYXZlIG5vIFJhcmVEYXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xOTQwMzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBJdCB0dXJucyBvdXQgdGhhdCB3ZSBkb24ndCBuZWVkIHRvIGNhY2hlIHRo ZSBTeW1ib2xUYWJsZVJhcmVEYXRhLCBidXQKKyAgICAgICAgd2Ugc2hvdWxkIG5vdCBhc3NlcnQg dGhhdCBpdCdzIGVtcHR5LgorCisgICAgICAgICogcnVudGltZS9DYWNoZWRUeXBlcy5jcHA6Cisg ICAgICAgIChKU0M6OkNhY2hlZFN5bWJvbFRhYmxlOjplbmNvZGUpOgorCiAyMDE5LTAxLTMwICBZ dXN1a2UgU3V6dWtpICA8eXVzdWtlc3V6dWtpQHNsb3dzdGFydC5vcmc+CiAKICAgICAgICAgW0pT Q10gTWFrZSBnbG9iYWwgc3RhdGljIHZhcmlhYmxlcyAiY29uc3QiIGFzIG11Y2ggYXMgcG9zc2li bGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NhY2hlZFR5cGVz LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NhY2hlZFR5cGVzLmNwcAppbmRl eCA5ZDk1NTRjNWE3ODRlNjJjYWI1ZDBkMTMyYTAzZmM5ZDI1MDM5YjNhLi4wNWU4ZjA3ODYzMjA1 MjJkNjgyZTdkZTk1NjllMzBhMGEyZmJhYjcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9DYWNoZWRUeXBlcy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvQ2FjaGVkVHlwZXMuY3BwCkBAIC05MDYsNyArOTA2LDYgQEAgY2xhc3MgQ2FjaGVk U3ltYm9sVGFibGUgOiBwdWJsaWMgQ2FjaGVkT2JqZWN0PFN5bWJvbFRhYmxlPiB7CiBwdWJsaWM6 CiAgICAgdm9pZCBlbmNvZGUoRW5jb2RlciYgZW5jb2RlciwgY29uc3QgU3ltYm9sVGFibGUmIHN5 bWJvbFRhYmxlKQogICAgIHsKLSAgICAgICAgQVNTRVJUKCFzeW1ib2xUYWJsZS5tX3JhcmVEYXRh KTsKICAgICAgICAgbV9tYXAuZW5jb2RlKGVuY29kZXIsIHN5bWJvbFRhYmxlLm1fbWFwKTsKICAg ICAgICAgbV9tYXhTY29wZU9mZnNldCA9IHN5bWJvbFRhYmxlLm1fbWF4U2NvcGVPZmZzZXQ7CiAg ICAgICAgIG1fdXNlc05vblN0cmljdEV2YWwgPSBzeW1ib2xUYWJsZS5tX3VzZXNOb25TdHJpY3RF dmFsOwpAQCAtOTM1LDggKzkzNCw2IEBAIHByaXZhdGU6CiAgICAgdW5zaWduZWQgbV91c2VzTm9u U3RyaWN0RXZhbCA6IDE7CiAgICAgdW5zaWduZWQgbV9uZXN0ZWRMZXhpY2FsU2NvcGUgOiAxOwog ICAgIHVuc2lnbmVkIG1fc2NvcGVUeXBlIDogMzsKLSAgICAvLyBGSVhNRTogZG8gd2UgbmVlZCB0 byBjYWNoZWQgdGhpcyBldmVudHVhbGx5PwotICAgIC8vIENhY2hlZFB0cjxTeW1ib2xUYWJsZVJh cmVEYXRhPiByYXJlRGF0YTsKICAgICBDYWNoZWRQdHI8Q2FjaGVkU2NvcGVkQXJndW1lbnRzVGFi bGU+IG1fYXJndW1lbnRzOwogfTsKIAo= 360619 2019-01-30 14:08:42 -0800 2019-01-30 15:03:49 -0800 Patch for landing bug-194037-20190130140822.patch text/plain 1847 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 YzJkMjhiYjdkYzYwMjgxZDljMWY0NTgwN2RlMWVmY2M2MjdmY2Y0Li5iZDkyZjlhZDcwNmVkMThm YTM4OWQ0N2QwZDczMzcwMDRkYTQ3ZjMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wMS0zMCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBSZW1vdmUgYXNzZXJ0aW9uIHRoYXQgQ2FjaGVkU3ltYm9sVGFibGVzIHNo b3VsZCBoYXZlIG5vIFJhcmVEYXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xOTQwMzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBJdCB0dXJucyBvdXQgdGhhdCB3ZSBkb24ndCBuZWVkIHRvIGNhY2hlIHRo ZSBTeW1ib2xUYWJsZVJhcmVEYXRhLCBidXQKKyAgICAgICAgd2Ugc2hvdWxkIG5vdCBhc3NlcnQg dGhhdCBpdCdzIGVtcHR5LgorCisgICAgICAgICogcnVudGltZS9DYWNoZWRUeXBlcy5jcHA6Cisg ICAgICAgIChKU0M6OkNhY2hlZFN5bWJvbFRhYmxlOjplbmNvZGUpOgorCiAyMDE5LTAxLTMwICBZ dXN1a2UgU3V6dWtpICA8eXVzdWtlc3V6dWtpQHNsb3dzdGFydC5vcmc+CiAKICAgICAgICAgW0pT Q10gTWFrZSBnbG9iYWwgc3RhdGljIHZhcmlhYmxlcyAiY29uc3QiIGFzIG11Y2ggYXMgcG9zc2li bGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NhY2hlZFR5cGVz LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NhY2hlZFR5cGVzLmNwcAppbmRl eCA5ZDk1NTRjNWE3ODRlNjJjYWI1ZDBkMTMyYTAzZmM5ZDI1MDM5YjNhLi4wNWU4ZjA3ODYzMjA1 MjJkNjgyZTdkZTk1NjllMzBhMGEyZmJhYjcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9DYWNoZWRUeXBlcy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvQ2FjaGVkVHlwZXMuY3BwCkBAIC05MDYsNyArOTA2LDYgQEAgY2xhc3MgQ2FjaGVk U3ltYm9sVGFibGUgOiBwdWJsaWMgQ2FjaGVkT2JqZWN0PFN5bWJvbFRhYmxlPiB7CiBwdWJsaWM6 CiAgICAgdm9pZCBlbmNvZGUoRW5jb2RlciYgZW5jb2RlciwgY29uc3QgU3ltYm9sVGFibGUmIHN5 bWJvbFRhYmxlKQogICAgIHsKLSAgICAgICAgQVNTRVJUKCFzeW1ib2xUYWJsZS5tX3JhcmVEYXRh KTsKICAgICAgICAgbV9tYXAuZW5jb2RlKGVuY29kZXIsIHN5bWJvbFRhYmxlLm1fbWFwKTsKICAg ICAgICAgbV9tYXhTY29wZU9mZnNldCA9IHN5bWJvbFRhYmxlLm1fbWF4U2NvcGVPZmZzZXQ7CiAg ICAgICAgIG1fdXNlc05vblN0cmljdEV2YWwgPSBzeW1ib2xUYWJsZS5tX3VzZXNOb25TdHJpY3RF dmFsOwpAQCAtOTM1LDggKzkzNCw2IEBAIHByaXZhdGU6CiAgICAgdW5zaWduZWQgbV91c2VzTm9u U3RyaWN0RXZhbCA6IDE7CiAgICAgdW5zaWduZWQgbV9uZXN0ZWRMZXhpY2FsU2NvcGUgOiAxOwog ICAgIHVuc2lnbmVkIG1fc2NvcGVUeXBlIDogMzsKLSAgICAvLyBGSVhNRTogZG8gd2UgbmVlZCB0 byBjYWNoZWQgdGhpcyBldmVudHVhbGx5PwotICAgIC8vIENhY2hlZFB0cjxTeW1ib2xUYWJsZVJh cmVEYXRhPiByYXJlRGF0YTsKICAgICBDYWNoZWRQdHI8Q2FjaGVkU2NvcGVkQXJndW1lbnRzVGFi bGU+IG1fYXJndW1lbnRzOwogfTsKIAo= 360629 2019-01-30 15:03:50 -0800 2019-01-30 16:47:04 -0800 Patch for landing bug-194037-20190130150330.patch text/plain 1840 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 YzJkMjhiYjdkYzYwMjgxZDljMWY0NTgwN2RlMWVmY2M2MjdmY2Y0Li4wZTRlZGZkNGZmMmQwMmNl ZTFkYTY0NjI3ZGM0MTVkMmNiZDBjMzcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wMS0zMCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBSZW1vdmUgYXNzZXJ0aW9uIHRoYXQgQ2FjaGVkU3ltYm9sVGFibGVzIHNo b3VsZCBoYXZlIG5vIFJhcmVEYXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xOTQwMzcKKworICAgICAgICBSZXZpZXdlZCBieSBNYXJrIExhbS4KKwor ICAgICAgICBJdCB0dXJucyBvdXQgdGhhdCB3ZSBkb24ndCBuZWVkIHRvIGNhY2hlIHRoZSBTeW1i b2xUYWJsZVJhcmVEYXRhIGFuZAorICAgICAgICB3ZSBzaG91bGQgbm90IGFzc2VydCB0aGF0IGl0 J3MgZW1wdHkuCisKKyAgICAgICAgKiBydW50aW1lL0NhY2hlZFR5cGVzLmNwcDoKKyAgICAgICAg KEpTQzo6Q2FjaGVkU3ltYm9sVGFibGU6OmVuY29kZSk6CisKIDIwMTktMDEtMzAgIFl1c3VrZSBT dXp1a2kgIDx5dXN1a2VzdXp1a2lAc2xvd3N0YXJ0Lm9yZz4KIAogICAgICAgICBbSlNDXSBNYWtl IGdsb2JhbCBzdGF0aWMgdmFyaWFibGVzICJjb25zdCIgYXMgbXVjaCBhcyBwb3NzaWJsZQpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ2FjaGVkVHlwZXMuY3BwIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ2FjaGVkVHlwZXMuY3BwCmluZGV4IDlkOTU1 NGM1YTc4NGU2MmNhYjVkMGQxMzJhMDNmYzlkMjUwMzliM2EuLjA1ZThmMDc4NjMyMDUyMmQ2ODJl N2RlOTU2OWUzMGEwYTJmYmFiNzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0NhY2hlZFR5cGVzLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9DYWNoZWRUeXBlcy5jcHAKQEAgLTkwNiw3ICs5MDYsNiBAQCBjbGFzcyBDYWNoZWRTeW1ib2xU YWJsZSA6IHB1YmxpYyBDYWNoZWRPYmplY3Q8U3ltYm9sVGFibGU+IHsKIHB1YmxpYzoKICAgICB2 b2lkIGVuY29kZShFbmNvZGVyJiBlbmNvZGVyLCBjb25zdCBTeW1ib2xUYWJsZSYgc3ltYm9sVGFi bGUpCiAgICAgewotICAgICAgICBBU1NFUlQoIXN5bWJvbFRhYmxlLm1fcmFyZURhdGEpOwogICAg ICAgICBtX21hcC5lbmNvZGUoZW5jb2Rlciwgc3ltYm9sVGFibGUubV9tYXApOwogICAgICAgICBt X21heFNjb3BlT2Zmc2V0ID0gc3ltYm9sVGFibGUubV9tYXhTY29wZU9mZnNldDsKICAgICAgICAg bV91c2VzTm9uU3RyaWN0RXZhbCA9IHN5bWJvbFRhYmxlLm1fdXNlc05vblN0cmljdEV2YWw7CkBA IC05MzUsOCArOTM0LDYgQEAgcHJpdmF0ZToKICAgICB1bnNpZ25lZCBtX3VzZXNOb25TdHJpY3RF dmFsIDogMTsKICAgICB1bnNpZ25lZCBtX25lc3RlZExleGljYWxTY29wZSA6IDE7CiAgICAgdW5z aWduZWQgbV9zY29wZVR5cGUgOiAzOwotICAgIC8vIEZJWE1FOiBkbyB3ZSBuZWVkIHRvIGNhY2hl ZCB0aGlzIGV2ZW50dWFsbHk/Ci0gICAgLy8gQ2FjaGVkUHRyPFN5bWJvbFRhYmxlUmFyZURhdGE+ IHJhcmVEYXRhOwogICAgIENhY2hlZFB0cjxDYWNoZWRTY29wZWRBcmd1bWVudHNUYWJsZT4gbV9h cmd1bWVudHM7CiB9OwogCg==