<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>194035</bug_id>
          
          <creation_ts>2019-01-30 12:55:25 -0800</creation_ts>
          <short_desc>[macOS] Sandbox fails to compile on 10.12</short_desc>
          <delta_ts>2019-01-30 15:11:23 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Per Arne Vollan">pvollan</reporter>
          <assigned_to name="Per Arne Vollan">pvollan</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1500124</commentid>
    <comment_count>0</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2019-01-30 12:55:25 -0800</bug_when>
    <thetext>This was caused by &lt;https://trac.webkit.org/changeset/239994&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1500126</commentid>
    <comment_count>1</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2019-01-30 12:59:31 -0800</bug_when>
    <thetext>rdar://problem/47651260</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1500127</commentid>
    <comment_count>2</comment_count>
      <attachid>360605</attachid>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2019-01-30 12:59:53 -0800</bug_when>
    <thetext>Created attachment 360605
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1500150</commentid>
    <comment_count>3</comment_count>
      <attachid>360605</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2019-01-30 13:41:50 -0800</bug_when>
    <thetext>Comment on attachment 360605
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360605&amp;action=review

&gt; Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:615
&gt; +#endif

It seems like this could be combined with the guard below it. But not worth changing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1500174</commentid>
    <comment_count>4</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2019-01-30 14:05:25 -0800</bug_when>
    <thetext>(In reply to Brent Fulgham from comment #3)
&gt; Comment on attachment 360605 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=360605&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:615
&gt; &gt; +#endif
&gt; 
&gt; It seems like this could be combined with the guard below it. But not worth
&gt; changing.

Thanks for reviewing, Brent!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1500221</commentid>
    <comment_count>5</comment_count>
      <attachid>360605</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-01-30 15:11:22 -0800</bug_when>
    <thetext>Comment on attachment 360605
Patch

Clearing flags on attachment: 360605

Committed r240733: &lt;https://trac.webkit.org/changeset/240733&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1500222</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-01-30 15:11:23 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>360605</attachid>
            <date>2019-01-30 12:59:53 -0800</date>
            <delta_ts>2019-01-30 15:11:22 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-194035-20190130125952.patch</filename>
            <type>text/plain</type>
            <size>1936</size>
            <attacher name="Per Arne Vollan">pvollan</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDA3MjYpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE5LTAxLTMwICBQZXIgQXJuZSBW
b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIFNhbmRib3ggZmFp
bHMgdG8gY29tcGlsZSBvbiAxMC4xMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MTk0MDM1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzY1MTI2MD4K
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHdh
cyBjYXVzZWQgYnkgdGhlIGNvbW1pdCA8aHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0
LzIzOTk5ND4sIHdoaWNoIGlzIG9ubHkgdmFsaWQgZm9yCisgICAgICAgIDEwLjE0IGFuZCBsYXRl
ci4KKworICAgICAgICAqIFBsdWdpblByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQucGx1Z2lu
LWNvbW1vbi5zYi5pbjoKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNz
LnNiLmluOgorCiAyMDE5LTAxLTMwICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAK
ICAgICAgICAgUmVncmVzc2lvbihQU09OKSBMb2FkIGhhbmcgY2FuIG9jY3VyIG9uIGhpc3Rvcnkg
bmF2aWdhdGlvbgpJbmRleDogU291cmNlL1dlYktpdC9QbHVnaW5Qcm9jZXNzL21hYy9jb20uYXBw
bGUuV2ViS2l0LnBsdWdpbi1jb21tb24uc2IuaW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp
dC9QbHVnaW5Qcm9jZXNzL21hYy9jb20uYXBwbGUuV2ViS2l0LnBsdWdpbi1jb21tb24uc2IuaW4J
KHJldmlzaW9uIDI0MDcxNSkKKysrIFNvdXJjZS9XZWJLaXQvUGx1Z2luUHJvY2Vzcy9tYWMvY29t
LmFwcGxlLldlYktpdC5wbHVnaW4tY29tbW9uLnNiLmluCSh3b3JraW5nIGNvcHkpCkBAIC0xNjAs
OCArMTYwLDEwIEBACiApCiAjZW5kaWYKIAorI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVR
VUlSRUQgPj0gMTAxNDAwCiA7OyA8cmRhcjovL3Byb2JsZW0vNDcyNjgxNjY+CiAoYWxsb3cgbWFj
aC1sb29rdXAgKHhwYy1zZXJ2aWNlLW5hbWUgImNvbS5hcHBsZS5NVExDb21waWxlclNlcnZpY2Ui
KSkKKyNlbmRpZgogCiA7OyBVdGlsaXR5IGZ1bmN0aW9ucwogKGRlZmluZSAoaG9tZS1saXRlcmFs
IGhvbWUtcmVsYXRpdmUtbGl0ZXJhbCkKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9j
b20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1dl
YlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4JKHJldmlzaW9uIDI0MDcxNSkKKysr
IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgkod29y
a2luZyBjb3B5KQpAQCAtNjA5LDggKzYwOSwxMCBAQAogI2VuZGlmCiApCiAKKyNpZiBfX01BQ19P
U19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTQwMAogOzsgPHJkYXI6Ly9wcm9ibGVtLzQ3
MjY4MTY2PgogKGFsbG93IG1hY2gtbG9va3VwICh4cGMtc2VydmljZS1uYW1lICJjb20uYXBwbGUu
TVRMQ29tcGlsZXJTZXJ2aWNlIikpCisjZW5kaWYKIAogI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9N
SU5fUkVRVUlSRUQgPj0gMTAxNDAwCiAoZGVueSBtYWNoLWxvb2t1cCAod2l0aCBuby1sb2cpCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>