194014 2019-01-30 03:09:51 -0800 Fix deadlock on Linux/x64 between SamplingProfiler and VMTraps 2019-02-15 05:42:26 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dominik.infuehr webkit-unassigned benjamin cdumez cmarcelo commit-queue dbates ews-watchlist guijemont mcatanzaro webkit-bug-importer ysuzuki oldest_to_newest 1499949 0 dominik.infuehr 2019-01-30 03:09:51 -0800 Fix deadlock on Linux/x64 between SamplingProfiler and VMTraps 1499950 1 360565 dominik.infuehr 2019-01-30 03:11:30 -0800 Created attachment 360565 Patch 1499951 2 360566 dominik.infuehr 2019-01-30 03:39:01 -0800 Created attachment 360566 Patch 1499954 3 360568 dominik.infuehr 2019-01-30 03:51:36 -0800 Created attachment 360568 Patch 1500004 4 dominik.infuehr 2019-01-30 08:12:21 -0800 There was a deadlock in the following situation: Thread 1 (Sampling): In SamplingProfiler.cpp:takeSample it takes all locks and then tries to suspend the main thread. Thread 2 (Watchdog/VMTraps): Before the Sampling-Thread suspends the main thread a signal is caught and signal handler is invoked (VMTraps.cpp:SignalSender). SignalSender tries to lock codeBlockSet, but this is already locked by the SamplingProfiler. The SamplingProfiler can only give up the lock when it suspends the thread. However since the VMTraps signal handler is active, all other signals blocked, therefore the SamplingProfiler also waits until its signal handler is invoked. The patch fixes this by only blocking all signals except for SIGUSR1, which is used for suspending/resuming threads. 1500095 5 mcatanzaro 2019-01-30 11:19:53 -0800 I would add that nice explanation of the deadlock to the ChangeLog, and also mention the flaky test this fixes. 1506115 6 362007 dominik.infuehr 2019-02-14 02:45:58 -0800 Created attachment 362007 Patch 1506554 7 362007 commit-queue 2019-02-15 05:41:51 -0800 Comment on attachment 362007 Patch Clearing flags on attachment: 362007 Committed r241583: <https://trac.webkit.org/changeset/241583> 1506555 8 commit-queue 2019-02-15 05:41:53 -0800 All reviewed patches have been landed. Closing bug. 1506556 9 webkit-bug-importer 2019-02-15 05:42:26 -0800 <rdar://problem/48108626> 360565 2019-01-30 03:11:30 -0800 2019-01-30 03:38:54 -0800 Patch bug-194014-20190130121128.patch text/plain 3346 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNzA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDNiNWIxMDE3N2RlNTFkNjA4NDk3YWNh MGYzZmEwOGIzMTg5NzZkNjYuLmE5NzNlN2RlNjBmM2NmMzMwNTM0OWVkMWQ5NTljZWIwZjk3NGIw OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDEtMzAgIERvbWluaWsgSW5mdWVociAgPGRp bmZ1ZWhyQGlnYWxpYS5jb20+CisKKyAgICAgICAgRml4IGRlYWRsb2NrIG9uIExpbnV4L3g2NCBi ZXR3ZWVuIFNhbXBsaW5nUHJvZmlsZXIgYW5kIFZNVHJhcHMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDAxNAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvIG5vdCBibG9jayBTSUdVU1IxIHdoZW4gaW5z dGFsbGluZyBzaWduYWwgaGFuZGxlcnMsIHNpbmNlIHRoaXMgc2lnbmFsCisgICAgICAgIGlzIHVz ZWQgdG8gc3VzcGVuZC9yZXN1bWUgbWFjaGluZSB0aHJlYWRzIG9uIExpbnV4LgorCisgICAgICAg ICogd3RmL1RocmVhZGluZy5oOgorICAgICAgICAqIHd0Zi9wb3NpeC9UaHJlYWRpbmdQT1NJWC5j cHA6CisgICAgICAgICogd3RmL3RocmVhZHMvU2lnbmFscy5jcHA6CisgICAgICAgIChXVEY6Omlu c3RhbGxTaWduYWxIYW5kbGVyKToKKwogMjAxOS0wMS0yOSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpA YXBwbGUuY29tPgogCiAgICAgICAgIE1ha2Ugc3VyZSBXVEY6OmdlbmVyYXRlT2JqZWN0SWRlbnRp ZmllcigpIGludGVybmFsIGNvdW50ZXIgZG9lcyBub3QgZ2V0IGR1cGxpY2F0ZWQKZGlmZiAtLWdp dCBhL1NvdXJjZS9XVEYvd3RmL1RocmVhZGluZy5oIGIvU291cmNlL1dURi93dGYvVGhyZWFkaW5n LmgKaW5kZXggM2E4YTRhNTVkMzM5YTBmZTQ5ZmNjYTZjZmU5MzliZWNjY2QxMWY4NC4uZDBjMGU1 OGE2ZGY4NjQxOTc3OTkyM2FiOTFkOTVjZTk3MDBjYWEwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dU Ri93dGYvVGhyZWFkaW5nLmgKKysrIGIvU291cmNlL1dURi93dGYvVGhyZWFkaW5nLmgKQEAgLTY0 LDYgKzY0LDEzIEBAIGNsYXNzIFByaW50U3RyZWFtOwogLy8gVGhpcyBmdW5jdGlvbiBjYW4gYmUg Y2FsbGVkIGZyb20gYW55IHRocmVhZHMuCiBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBpbml0aWFs aXplVGhyZWFkaW5nKCk7CiAKKyNpZiAhT1MoREFSV0lOKQorCisvLyBXZSB1c2UgU0lHVVNSMSB0 byBzdXNwZW5kIGFuZCByZXN1bWUgbWFjaGluZSB0aHJlYWRzIGluIEphdmFTY3JpcHRDb3JlLgor Y29uc3RleHByIGNvbnN0IGludCBTaWdUaHJlYWRTdXNwZW5kUmVzdW1lID0gU0lHVVNSMTsKKwor I2VuZGlmCisKIC8vIEZJWE1FOiBUaGUgZm9sbG93aW5nIGZ1bmN0aW9ucyByZW1haW4gYmVjYXVz ZSB0aGV5IGFyZSB1c2VkIGZyb20gV2ViS2l0IFdpbmRvd3Mgc3VwcG9ydCBsaWJyYXJ5LAogLy8g V2ViS2l0UXVhcnR6Q29yZUFkZGl0aW9ucy5kbGwuIFdoZW4gdXBkYXRpbmcgdGhlIHN1cHBvcnQg bGlicmFyeSwgd2Ugc2hvdWxkIHVzZSBuZXcgQVBJIGluc3RlYWQKIC8vIGFuZCB0aGUgZm9sbG93 aW5nIHdvcmthb3VuZCBzaG91bGQgYmUgcmVtb3ZlZC4gQW5kIG5ldyBjb2RlIHNob3VsZCBub3Qg dXNlIHRoZSBmb2xsb3dpbmcgQVBJcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3Bvc2l4 L1RocmVhZGluZ1BPU0lYLmNwcCBiL1NvdXJjZS9XVEYvd3RmL3Bvc2l4L1RocmVhZGluZ1BPU0lY LmNwcAppbmRleCBlNDhkZDliNTdlZGQ0Y2Y1NWYyNTMzMTY0NTgyM2YzMTA5ZGE0MjIxLi42NGNk MWY3MThkNTVmNmVhNWJhOWQ2YzM0NmQwNzM4ODViMzJmNTY3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V1RGL3d0Zi9wb3NpeC9UaHJlYWRpbmdQT1NJWC5jcHAKKysrIGIvU291cmNlL1dURi93dGYvcG9z aXgvVGhyZWFkaW5nUE9TSVguY3BwCkBAIC0xMDUsOCArMTA1LDYgQEAgcHJpdmF0ZToKIH07CiBz dGF0aWMgTGF6eU5ldmVyRGVzdHJveWVkPFNlbWFwaG9yZT4gZ2xvYmFsU2VtYXBob3JlRm9yU3Vz cGVuZFJlc3VtZTsKIAotLy8gV2UgdXNlIFNJR1VTUjEgdG8gc3VzcGVuZCBhbmQgcmVzdW1lIG1h Y2hpbmUgdGhyZWFkcyBpbiBKYXZhU2NyaXB0Q29yZS4KLXN0YXRpYyBjb25zdGV4cHIgY29uc3Qg aW50IFNpZ1RocmVhZFN1c3BlbmRSZXN1bWUgPSBTSUdVU1IxOwogc3RhdGljIHN0ZDo6YXRvbWlj PFRocmVhZCo+IHRhcmdldFRocmVhZCB7IG51bGxwdHIgfTsKIAogdm9pZCBUaHJlYWQ6OnNpZ25h bEhhbmRsZXJTdXNwZW5kUmVzdW1lKGludCwgc2lnaW5mb190Kiwgdm9pZCogdWNvbnRleHQpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90aHJlYWRzL1NpZ25hbHMuY3BwIGIvU291cmNlL1dU Ri93dGYvdGhyZWFkcy9TaWduYWxzLmNwcAppbmRleCA1ZTdlYjZhY2MzYjg3MGY5N2YwNzg0MTU2 MTA5NDNhODcwODM5NzkxLi5mY2QwZjFkNjhmYWVjZTgzNDBjNzliNGU2YzVkYjA3MWIwYTExMjM0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90aHJlYWRzL1NpZ25hbHMuY3BwCisrKyBiL1Nv dXJjZS9XVEYvd3RmL3RocmVhZHMvU2lnbmFscy5jcHAKQEAgLTI1OCw2ICsyNTgsOSBAQCB2b2lk IGluc3RhbGxTaWduYWxIYW5kbGVyKFNpZ25hbCBzaWduYWwsIFNpZ25hbEhhbmRsZXImJiBoYW5k bGVyKQogICAgICAgICAgICAgYWN0aW9uLnNhX3NpZ2FjdGlvbiA9IGpzY1NpZ25hbEhhbmRsZXI7 CiAgICAgICAgICAgICBhdXRvIHJlc3VsdCA9IHNpZ2ZpbGxzZXQoJmFjdGlvbi5zYV9tYXNrKTsK ICAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJUKCFyZXN1bHQpOworICAgICAgICAgICAgLy8gRG8g bm90IGJsb2NrIHRoaXMgc2lnbmFsIHNpbmNlIGl0IGlzIHVzZWQgb24gbm9uLURhcndpbiBzeXN0 ZW1zIHRvIHN1c3BlbmQgYW5kIHJlc3VtZSB0aHJlYWRzLgorICAgICAgICAgICAgcmVzdWx0ID0g c2lnZGVsc2V0KCZhY3Rpb24uc2FfbWFzaywgU2lnVGhyZWFkU3VzcGVuZFJlc3VtZSk7CisgICAg ICAgICAgICBSRUxFQVNFX0FTU0VSVCghcmVzdWx0KTsKICAgICAgICAgICAgIGFjdGlvbi5zYV9m bGFncyA9IFNBX1NJR0lORk87CiAgICAgICAgICAgICBhdXRvIHN5c3RlbVNpZ25hbHMgPSB0b1N5 c3RlbVNpZ25hbChzaWduYWwpOwogICAgICAgICAgICAgcmVzdWx0ID0gc2lnYWN0aW9uKHN0ZDo6 Z2V0PDA+KHN5c3RlbVNpZ25hbHMpLCAmYWN0aW9uLCAmb2xkQWN0aW9uc1tvZmZzZXRGb3JTeXN0 ZW1TaWduYWwoc3RkOjpnZXQ8MD4oc3lzdGVtU2lnbmFscykpXSk7Cg== 360566 2019-01-30 03:39:01 -0800 2019-01-30 03:51:31 -0800 Patch bug-194014-20190130123900.patch text/plain 3363 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNzA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDNiNWIxMDE3N2RlNTFkNjA4NDk3YWNh MGYzZmEwOGIzMTg5NzZkNjYuLmE5NzNlN2RlNjBmM2NmMzMwNTM0OWVkMWQ5NTljZWIwZjk3NGIw OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDEtMzAgIERvbWluaWsgSW5mdWVociAgPGRp bmZ1ZWhyQGlnYWxpYS5jb20+CisKKyAgICAgICAgRml4IGRlYWRsb2NrIG9uIExpbnV4L3g2NCBi ZXR3ZWVuIFNhbXBsaW5nUHJvZmlsZXIgYW5kIFZNVHJhcHMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDAxNAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvIG5vdCBibG9jayBTSUdVU1IxIHdoZW4gaW5z dGFsbGluZyBzaWduYWwgaGFuZGxlcnMsIHNpbmNlIHRoaXMgc2lnbmFsCisgICAgICAgIGlzIHVz ZWQgdG8gc3VzcGVuZC9yZXN1bWUgbWFjaGluZSB0aHJlYWRzIG9uIExpbnV4LgorCisgICAgICAg ICogd3RmL1RocmVhZGluZy5oOgorICAgICAgICAqIHd0Zi9wb3NpeC9UaHJlYWRpbmdQT1NJWC5j cHA6CisgICAgICAgICogd3RmL3RocmVhZHMvU2lnbmFscy5jcHA6CisgICAgICAgIChXVEY6Omlu c3RhbGxTaWduYWxIYW5kbGVyKToKKwogMjAxOS0wMS0yOSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpA YXBwbGUuY29tPgogCiAgICAgICAgIE1ha2Ugc3VyZSBXVEY6OmdlbmVyYXRlT2JqZWN0SWRlbnRp ZmllcigpIGludGVybmFsIGNvdW50ZXIgZG9lcyBub3QgZ2V0IGR1cGxpY2F0ZWQKZGlmZiAtLWdp dCBhL1NvdXJjZS9XVEYvd3RmL1RocmVhZGluZy5oIGIvU291cmNlL1dURi93dGYvVGhyZWFkaW5n LmgKaW5kZXggM2E4YTRhNTVkMzM5YTBmZTQ5ZmNjYTZjZmU5MzliZWNjY2QxMWY4NC4uNDhhOTA5 NWVmZGMyZGFiNmJhZjI0ZTQ4NDNlMjljNTIwODllOWMwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dU Ri93dGYvVGhyZWFkaW5nLmgKKysrIGIvU291cmNlL1dURi93dGYvVGhyZWFkaW5nLmgKQEAgLTY0 LDYgKzY0LDEzIEBAIGNsYXNzIFByaW50U3RyZWFtOwogLy8gVGhpcyBmdW5jdGlvbiBjYW4gYmUg Y2FsbGVkIGZyb20gYW55IHRocmVhZHMuCiBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBpbml0aWFs aXplVGhyZWFkaW5nKCk7CiAKKyNpZiBVU0UoUFRIUkVBRFMpICYmICFPUyhEQVJXSU4pCisKKy8v IFdlIHVzZSBTSUdVU1IxIHRvIHN1c3BlbmQgYW5kIHJlc3VtZSBtYWNoaW5lIHRocmVhZHMgaW4g SmF2YVNjcmlwdENvcmUuCitjb25zdGV4cHIgY29uc3QgaW50IFNpZ1RocmVhZFN1c3BlbmRSZXN1 bWUgPSBTSUdVU1IxOworCisjZW5kaWYKKwogLy8gRklYTUU6IFRoZSBmb2xsb3dpbmcgZnVuY3Rp b25zIHJlbWFpbiBiZWNhdXNlIHRoZXkgYXJlIHVzZWQgZnJvbSBXZWJLaXQgV2luZG93cyBzdXBw b3J0IGxpYnJhcnksCiAvLyBXZWJLaXRRdWFydHpDb3JlQWRkaXRpb25zLmRsbC4gV2hlbiB1cGRh dGluZyB0aGUgc3VwcG9ydCBsaWJyYXJ5LCB3ZSBzaG91bGQgdXNlIG5ldyBBUEkgaW5zdGVhZAog Ly8gYW5kIHRoZSBmb2xsb3dpbmcgd29ya2FvdW5kIHNob3VsZCBiZSByZW1vdmVkLiBBbmQgbmV3 IGNvZGUgc2hvdWxkIG5vdCB1c2UgdGhlIGZvbGxvd2luZyBBUElzLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dURi93dGYvcG9zaXgvVGhyZWFkaW5nUE9TSVguY3BwIGIvU291cmNlL1dURi93dGYvcG9z aXgvVGhyZWFkaW5nUE9TSVguY3BwCmluZGV4IGU0OGRkOWI1N2VkZDRjZjU1ZjI1MzMxNjQ1ODIz ZjMxMDlkYTQyMjEuLjY0Y2QxZjcxOGQ1NWY2ZWE1YmE5ZDZjMzQ2ZDA3Mzg4NWIzMmY1NjcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3Bvc2l4L1RocmVhZGluZ1BPU0lYLmNwcAorKysgYi9T b3VyY2UvV1RGL3d0Zi9wb3NpeC9UaHJlYWRpbmdQT1NJWC5jcHAKQEAgLTEwNSw4ICsxMDUsNiBA QCBwcml2YXRlOgogfTsKIHN0YXRpYyBMYXp5TmV2ZXJEZXN0cm95ZWQ8U2VtYXBob3JlPiBnbG9i YWxTZW1hcGhvcmVGb3JTdXNwZW5kUmVzdW1lOwogCi0vLyBXZSB1c2UgU0lHVVNSMSB0byBzdXNw ZW5kIGFuZCByZXN1bWUgbWFjaGluZSB0aHJlYWRzIGluIEphdmFTY3JpcHRDb3JlLgotc3RhdGlj IGNvbnN0ZXhwciBjb25zdCBpbnQgU2lnVGhyZWFkU3VzcGVuZFJlc3VtZSA9IFNJR1VTUjE7CiBz dGF0aWMgc3RkOjphdG9taWM8VGhyZWFkKj4gdGFyZ2V0VGhyZWFkIHsgbnVsbHB0ciB9OwogCiB2 b2lkIFRocmVhZDo6c2lnbmFsSGFuZGxlclN1c3BlbmRSZXN1bWUoaW50LCBzaWdpbmZvX3QqLCB2 b2lkKiB1Y29udGV4dCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RocmVhZHMvU2lnbmFs cy5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi90aHJlYWRzL1NpZ25hbHMuY3BwCmluZGV4IDVlN2ViNmFj YzNiODcwZjk3ZjA3ODQxNTYxMDk0M2E4NzA4Mzk3OTEuLmZjZDBmMWQ2OGZhZWNlODM0MGM3OWI0 ZTZjNWRiMDcxYjBhMTEyMzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RocmVhZHMvU2ln bmFscy5jcHAKKysrIGIvU291cmNlL1dURi93dGYvdGhyZWFkcy9TaWduYWxzLmNwcApAQCAtMjU4 LDYgKzI1OCw5IEBAIHZvaWQgaW5zdGFsbFNpZ25hbEhhbmRsZXIoU2lnbmFsIHNpZ25hbCwgU2ln bmFsSGFuZGxlciYmIGhhbmRsZXIpCiAgICAgICAgICAgICBhY3Rpb24uc2Ffc2lnYWN0aW9uID0g anNjU2lnbmFsSGFuZGxlcjsKICAgICAgICAgICAgIGF1dG8gcmVzdWx0ID0gc2lnZmlsbHNldCgm YWN0aW9uLnNhX21hc2spOwogICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlQoIXJlc3VsdCk7Cisg ICAgICAgICAgICAvLyBEbyBub3QgYmxvY2sgdGhpcyBzaWduYWwgc2luY2UgaXQgaXMgdXNlZCBv biBub24tRGFyd2luIHN5c3RlbXMgdG8gc3VzcGVuZCBhbmQgcmVzdW1lIHRocmVhZHMuCisgICAg ICAgICAgICByZXN1bHQgPSBzaWdkZWxzZXQoJmFjdGlvbi5zYV9tYXNrLCBTaWdUaHJlYWRTdXNw ZW5kUmVzdW1lKTsKKyAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJUKCFyZXN1bHQpOwogICAgICAg ICAgICAgYWN0aW9uLnNhX2ZsYWdzID0gU0FfU0lHSU5GTzsKICAgICAgICAgICAgIGF1dG8gc3lz dGVtU2lnbmFscyA9IHRvU3lzdGVtU2lnbmFsKHNpZ25hbCk7CiAgICAgICAgICAgICByZXN1bHQg PSBzaWdhY3Rpb24oc3RkOjpnZXQ8MD4oc3lzdGVtU2lnbmFscyksICZhY3Rpb24sICZvbGRBY3Rp b25zW29mZnNldEZvclN5c3RlbVNpZ25hbChzdGQ6OmdldDwwPihzeXN0ZW1TaWduYWxzKSldKTsK 360568 2019-01-30 03:51:36 -0800 2019-02-14 02:45:53 -0800 Patch bug-194014-20190130125135.patch text/plain 3348 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNzA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDNiNWIxMDE3N2RlNTFkNjA4NDk3YWNh MGYzZmEwOGIzMTg5NzZkNjYuLmE5NzNlN2RlNjBmM2NmMzMwNTM0OWVkMWQ5NTljZWIwZjk3NGIw OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDEtMzAgIERvbWluaWsgSW5mdWVociAgPGRp bmZ1ZWhyQGlnYWxpYS5jb20+CisKKyAgICAgICAgRml4IGRlYWRsb2NrIG9uIExpbnV4L3g2NCBi ZXR3ZWVuIFNhbXBsaW5nUHJvZmlsZXIgYW5kIFZNVHJhcHMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDAxNAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvIG5vdCBibG9jayBTSUdVU1IxIHdoZW4gaW5z dGFsbGluZyBzaWduYWwgaGFuZGxlcnMsIHNpbmNlIHRoaXMgc2lnbmFsCisgICAgICAgIGlzIHVz ZWQgdG8gc3VzcGVuZC9yZXN1bWUgbWFjaGluZSB0aHJlYWRzIG9uIExpbnV4LgorCisgICAgICAg ICogd3RmL1RocmVhZGluZy5oOgorICAgICAgICAqIHd0Zi9wb3NpeC9UaHJlYWRpbmdQT1NJWC5j cHA6CisgICAgICAgICogd3RmL3RocmVhZHMvU2lnbmFscy5jcHA6CisgICAgICAgIChXVEY6Omlu c3RhbGxTaWduYWxIYW5kbGVyKToKKwogMjAxOS0wMS0yOSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpA YXBwbGUuY29tPgogCiAgICAgICAgIE1ha2Ugc3VyZSBXVEY6OmdlbmVyYXRlT2JqZWN0SWRlbnRp ZmllcigpIGludGVybmFsIGNvdW50ZXIgZG9lcyBub3QgZ2V0IGR1cGxpY2F0ZWQKZGlmZiAtLWdp dCBhL1NvdXJjZS9XVEYvd3RmL1RocmVhZGluZy5oIGIvU291cmNlL1dURi93dGYvVGhyZWFkaW5n LmgKaW5kZXggM2E4YTRhNTVkMzM5YTBmZTQ5ZmNjYTZjZmU5MzliZWNjY2QxMWY4NC4uMmQ5MjQy Y2NhYjRiYmQ1ZmQwOThmOTAwNTc0YjdlNTIyMGY3MmIwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dU Ri93dGYvVGhyZWFkaW5nLmgKKysrIGIvU291cmNlL1dURi93dGYvVGhyZWFkaW5nLmgKQEAgLTY0 LDYgKzY0LDEzIEBAIGNsYXNzIFByaW50U3RyZWFtOwogLy8gVGhpcyBmdW5jdGlvbiBjYW4gYmUg Y2FsbGVkIGZyb20gYW55IHRocmVhZHMuCiBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBpbml0aWFs aXplVGhyZWFkaW5nKCk7CiAKKyNpZiBVU0UoUFRIUkVBRFMpCisKKy8vIFdlIHVzZSBTSUdVU1Ix IHRvIHN1c3BlbmQgYW5kIHJlc3VtZSBtYWNoaW5lIHRocmVhZHMgaW4gSmF2YVNjcmlwdENvcmUu Citjb25zdGV4cHIgY29uc3QgaW50IFNpZ1RocmVhZFN1c3BlbmRSZXN1bWUgPSBTSUdVU1IxOwor CisjZW5kaWYKKwogLy8gRklYTUU6IFRoZSBmb2xsb3dpbmcgZnVuY3Rpb25zIHJlbWFpbiBiZWNh dXNlIHRoZXkgYXJlIHVzZWQgZnJvbSBXZWJLaXQgV2luZG93cyBzdXBwb3J0IGxpYnJhcnksCiAv LyBXZWJLaXRRdWFydHpDb3JlQWRkaXRpb25zLmRsbC4gV2hlbiB1cGRhdGluZyB0aGUgc3VwcG9y dCBsaWJyYXJ5LCB3ZSBzaG91bGQgdXNlIG5ldyBBUEkgaW5zdGVhZAogLy8gYW5kIHRoZSBmb2xs b3dpbmcgd29ya2FvdW5kIHNob3VsZCBiZSByZW1vdmVkLiBBbmQgbmV3IGNvZGUgc2hvdWxkIG5v dCB1c2UgdGhlIGZvbGxvd2luZyBBUElzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvcG9z aXgvVGhyZWFkaW5nUE9TSVguY3BwIGIvU291cmNlL1dURi93dGYvcG9zaXgvVGhyZWFkaW5nUE9T SVguY3BwCmluZGV4IGU0OGRkOWI1N2VkZDRjZjU1ZjI1MzMxNjQ1ODIzZjMxMDlkYTQyMjEuLjY0 Y2QxZjcxOGQ1NWY2ZWE1YmE5ZDZjMzQ2ZDA3Mzg4NWIzMmY1NjcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XVEYvd3RmL3Bvc2l4L1RocmVhZGluZ1BPU0lYLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9w b3NpeC9UaHJlYWRpbmdQT1NJWC5jcHAKQEAgLTEwNSw4ICsxMDUsNiBAQCBwcml2YXRlOgogfTsK IHN0YXRpYyBMYXp5TmV2ZXJEZXN0cm95ZWQ8U2VtYXBob3JlPiBnbG9iYWxTZW1hcGhvcmVGb3JT dXNwZW5kUmVzdW1lOwogCi0vLyBXZSB1c2UgU0lHVVNSMSB0byBzdXNwZW5kIGFuZCByZXN1bWUg bWFjaGluZSB0aHJlYWRzIGluIEphdmFTY3JpcHRDb3JlLgotc3RhdGljIGNvbnN0ZXhwciBjb25z dCBpbnQgU2lnVGhyZWFkU3VzcGVuZFJlc3VtZSA9IFNJR1VTUjE7CiBzdGF0aWMgc3RkOjphdG9t aWM8VGhyZWFkKj4gdGFyZ2V0VGhyZWFkIHsgbnVsbHB0ciB9OwogCiB2b2lkIFRocmVhZDo6c2ln bmFsSGFuZGxlclN1c3BlbmRSZXN1bWUoaW50LCBzaWdpbmZvX3QqLCB2b2lkKiB1Y29udGV4dCkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RocmVhZHMvU2lnbmFscy5jcHAgYi9Tb3VyY2Uv V1RGL3d0Zi90aHJlYWRzL1NpZ25hbHMuY3BwCmluZGV4IDVlN2ViNmFjYzNiODcwZjk3ZjA3ODQx NTYxMDk0M2E4NzA4Mzk3OTEuLmZjZDBmMWQ2OGZhZWNlODM0MGM3OWI0ZTZjNWRiMDcxYjBhMTEy MzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RocmVhZHMvU2lnbmFscy5jcHAKKysrIGIv U291cmNlL1dURi93dGYvdGhyZWFkcy9TaWduYWxzLmNwcApAQCAtMjU4LDYgKzI1OCw5IEBAIHZv aWQgaW5zdGFsbFNpZ25hbEhhbmRsZXIoU2lnbmFsIHNpZ25hbCwgU2lnbmFsSGFuZGxlciYmIGhh bmRsZXIpCiAgICAgICAgICAgICBhY3Rpb24uc2Ffc2lnYWN0aW9uID0ganNjU2lnbmFsSGFuZGxl cjsKICAgICAgICAgICAgIGF1dG8gcmVzdWx0ID0gc2lnZmlsbHNldCgmYWN0aW9uLnNhX21hc2sp OwogICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlQoIXJlc3VsdCk7CisgICAgICAgICAgICAvLyBE byBub3QgYmxvY2sgdGhpcyBzaWduYWwgc2luY2UgaXQgaXMgdXNlZCBvbiBub24tRGFyd2luIHN5 c3RlbXMgdG8gc3VzcGVuZCBhbmQgcmVzdW1lIHRocmVhZHMuCisgICAgICAgICAgICByZXN1bHQg PSBzaWdkZWxzZXQoJmFjdGlvbi5zYV9tYXNrLCBTaWdUaHJlYWRTdXNwZW5kUmVzdW1lKTsKKyAg ICAgICAgICAgIFJFTEVBU0VfQVNTRVJUKCFyZXN1bHQpOwogICAgICAgICAgICAgYWN0aW9uLnNh X2ZsYWdzID0gU0FfU0lHSU5GTzsKICAgICAgICAgICAgIGF1dG8gc3lzdGVtU2lnbmFscyA9IHRv U3lzdGVtU2lnbmFsKHNpZ25hbCk7CiAgICAgICAgICAgICByZXN1bHQgPSBzaWdhY3Rpb24oc3Rk OjpnZXQ8MD4oc3lzdGVtU2lnbmFscyksICZhY3Rpb24sICZvbGRBY3Rpb25zW29mZnNldEZvclN5 c3RlbVNpZ25hbChzdGQ6OmdldDwwPihzeXN0ZW1TaWduYWxzKSldKTsK 362007 2019-02-14 02:45:58 -0800 2019-02-15 05:41:51 -0800 Patch bug-194014-20190214114557.patch text/plain 4355 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGZhYWExYThmYWMyZTJiZTM1Nzg3MmMz OTZiYzk5YjM1MmY3Nzk1YTQuLjBjY2I1Mjk2OTM3NTZlNzI4NDdjMzljZmU2MjdiNjNjYmQ3MDBl YTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMzggQEAKKzIwMTktMDItMTQgIERvbWluaWsgSW5mdWVociAgPGRp bmZ1ZWhyQGlnYWxpYS5jb20+CisKKyAgICAgICAgRml4IGRlYWRsb2NrIG9uIExpbnV4L3g2NCBi ZXR3ZWVuIFNhbXBsaW5nUHJvZmlsZXIgYW5kIFZNVHJhcHMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDAxNAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvIG5vdCBibG9jayBTSUdVU1IxIHdoZW4gaW5z dGFsbGluZyBzaWduYWwgaGFuZGxlcnMsIHNpbmNlIHRoaXMgc2lnbmFsCisgICAgICAgIGlzIHVz ZWQgdG8gc3VzcGVuZC9yZXN1bWUgbWFjaGluZSB0aHJlYWRzIG9uIExpbnV4LgorCisgICAgICAg IGZ0bC1haS1maWx0ZXItcGhhbnRvbXMtc2hvdWxkLWNsZWFyLWNsZWFyLXZhbHVlLmpzIGRlYWRs b2NrZWQgd2l0aAorICAgICAgICBlbmFibGVkIHdhdGNoZG9nIGFuZCBzYW1wbGluZy4KKworICAg ICAgICBEZWFkbG9jayBoYXBwZW5lZCBpbiB0aGUgZm9sbG93aW5nIHNpdHVhdGlvbjoKKworICAg ICAgICBUaHJlYWQgMSAoU2FtcGxpbmcpOiBTYW1wbGluZ1Byb2ZpbGVyLmNwcDp0YWtlU2FtcGxl IHRha2VzIGFsbCBuZWVkZWQgbG9ja3MKKyAgICAgICAgYW5kIHRoZW4gdHJpZXMgdG8gc3VzcGVu ZCB0aGUgbWFpbiB0aHJlYWQuCisKKyAgICAgICAgVGhyZWFkIDIgKFdhdGNoZG9nL1ZNVHJhcHMp OiBCZWZvcmUgdGhlIFNhbXBsaW5nLVRocmVhZCBzdXNwZW5kcyB0aGUgbWFpbiB0aHJlYWQKKyAg ICAgICAgYSBzaWduYWwgaXMgY2F1Z2h0IGFuZCB0aGUgc2lnbmFsIGhhbmRsZXIgaXMgaW52b2tl ZCAoVk1UcmFwcy5jcHA6U2lnbmFsU2VuZGVyKS4KKyAgICAgICAgU2lnbmFsU2VuZGVyIHRyaWVz IHRvIGxvY2sgY29kZUJsb2NrU2V0LCBidXQgdGhpcyBpcyBhbHJlYWR5IGxvY2tlZCBieSB0aGUK KyAgICAgICAgU2FtcGxpbmdQcm9maWxlci4KKworICAgICAgICBUaGUgU2FtcGxpbmdQcm9maWxl ciBjYW4gb25seSBnaXZlIHVwIHRoZSBsb2NrIHdoZW4gaXQgc3VzcGVuZHMKKyAgICAgICAgdGhl IHRocmVhZC4gSG93ZXZlciBzaW5jZSB0aGUgVk1UcmFwcyBzaWduYWwgaGFuZGxlciBpcyBhY3Rp dmUsIGFsbCBvdGhlciBzaWduYWxzIGJsb2NrZWQsCisgICAgICAgIHRoZXJlZm9yZSB0aGUgU2Ft cGxpbmdQcm9maWxlciBhbHNvIHdhaXRzIHVudGlsIGl0cyBzaWduYWwgaGFuZGxlciBpcyBpbnZv a2VkLgorCisgICAgICAgIFRoaXMgcGF0Y2ggZml4ZXMgdGhpcyBieSBub3QgYmxvY2tpbmcgU0lH VVNSMSBpbiBpbnN0YWxsU2lnbmFsSGFuZGxlciwgc2luY2UKKyAgICAgICAgaXQgaXMgdXNlZCB0 byBzdXNwZW5kL3Jlc3VtZSB0aHJlYWRzIG9uIExpbnV4LgorCisgICAgICAgICogd3RmL1RocmVh ZGluZy5oOgorICAgICAgICAqIHd0Zi9wb3NpeC9UaHJlYWRpbmdQT1NJWC5jcHA6CisgICAgICAg ICogd3RmL3RocmVhZHMvU2lnbmFscy5jcHA6CisgICAgICAgIChXVEY6Omluc3RhbGxTaWduYWxI YW5kbGVyKToKKwogMjAxOS0wMi0xMyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgogCiAgICAgICAgIFdlIHNob3VsZCBvbmx5IG1ha2Ugcm9wZSBzdHJpbmdzIHdoZW4gY29uY2F0 ZW5hdGluZyBzdHJpbmdzIGxvbmcgZW5vdWdoLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYv VGhyZWFkaW5nLmggYi9Tb3VyY2UvV1RGL3d0Zi9UaHJlYWRpbmcuaAppbmRleCAzYThhNGE1NWQz MzlhMGZlNDlmY2NhNmNmZTkzOWJlY2NjZDExZjg0Li4yZDkyNDJjY2FiNGJiZDVmZDA5OGY5MDA1 NzRiN2U1MjIwZjcyYjA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9UaHJlYWRpbmcuaAor KysgYi9Tb3VyY2UvV1RGL3d0Zi9UaHJlYWRpbmcuaApAQCAtNjQsNiArNjQsMTMgQEAgY2xhc3Mg UHJpbnRTdHJlYW07CiAvLyBUaGlzIGZ1bmN0aW9uIGNhbiBiZSBjYWxsZWQgZnJvbSBhbnkgdGhy ZWFkcy4KIFdURl9FWFBPUlRfUFJJVkFURSB2b2lkIGluaXRpYWxpemVUaHJlYWRpbmcoKTsKIAor I2lmIFVTRShQVEhSRUFEUykKKworLy8gV2UgdXNlIFNJR1VTUjEgdG8gc3VzcGVuZCBhbmQgcmVz dW1lIG1hY2hpbmUgdGhyZWFkcyBpbiBKYXZhU2NyaXB0Q29yZS4KK2NvbnN0ZXhwciBjb25zdCBp bnQgU2lnVGhyZWFkU3VzcGVuZFJlc3VtZSA9IFNJR1VTUjE7CisKKyNlbmRpZgorCiAvLyBGSVhN RTogVGhlIGZvbGxvd2luZyBmdW5jdGlvbnMgcmVtYWluIGJlY2F1c2UgdGhleSBhcmUgdXNlZCBm cm9tIFdlYktpdCBXaW5kb3dzIHN1cHBvcnQgbGlicmFyeSwKIC8vIFdlYktpdFF1YXJ0ekNvcmVB ZGRpdGlvbnMuZGxsLiBXaGVuIHVwZGF0aW5nIHRoZSBzdXBwb3J0IGxpYnJhcnksIHdlIHNob3Vs ZCB1c2UgbmV3IEFQSSBpbnN0ZWFkCiAvLyBhbmQgdGhlIGZvbGxvd2luZyB3b3JrYW91bmQgc2hv dWxkIGJlIHJlbW92ZWQuIEFuZCBuZXcgY29kZSBzaG91bGQgbm90IHVzZSB0aGUgZm9sbG93aW5n IEFQSXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9wb3NpeC9UaHJlYWRpbmdQT1NJWC5j cHAgYi9Tb3VyY2UvV1RGL3d0Zi9wb3NpeC9UaHJlYWRpbmdQT1NJWC5jcHAKaW5kZXggZTQ4ZGQ5 YjU3ZWRkNGNmNTVmMjUzMzE2NDU4MjNmMzEwOWRhNDIyMS4uNjRjZDFmNzE4ZDU1ZjZlYTViYTlk NmMzNDZkMDczODg1YjMyZjU2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvcG9zaXgvVGhy ZWFkaW5nUE9TSVguY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL3Bvc2l4L1RocmVhZGluZ1BPU0lY LmNwcApAQCAtMTA1LDggKzEwNSw2IEBAIHByaXZhdGU6CiB9Owogc3RhdGljIExhenlOZXZlckRl c3Ryb3llZDxTZW1hcGhvcmU+IGdsb2JhbFNlbWFwaG9yZUZvclN1c3BlbmRSZXN1bWU7CiAKLS8v IFdlIHVzZSBTSUdVU1IxIHRvIHN1c3BlbmQgYW5kIHJlc3VtZSBtYWNoaW5lIHRocmVhZHMgaW4g SmF2YVNjcmlwdENvcmUuCi1zdGF0aWMgY29uc3RleHByIGNvbnN0IGludCBTaWdUaHJlYWRTdXNw ZW5kUmVzdW1lID0gU0lHVVNSMTsKIHN0YXRpYyBzdGQ6OmF0b21pYzxUaHJlYWQqPiB0YXJnZXRU aHJlYWQgeyBudWxscHRyIH07CiAKIHZvaWQgVGhyZWFkOjpzaWduYWxIYW5kbGVyU3VzcGVuZFJl c3VtZShpbnQsIHNpZ2luZm9fdCosIHZvaWQqIHVjb250ZXh0KQpkaWZmIC0tZ2l0IGEvU291cmNl L1dURi93dGYvdGhyZWFkcy9TaWduYWxzLmNwcCBiL1NvdXJjZS9XVEYvd3RmL3RocmVhZHMvU2ln bmFscy5jcHAKaW5kZXggNWU3ZWI2YWNjM2I4NzBmOTdmMDc4NDE1NjEwOTQzYTg3MDgzOTc5MS4u ZmNkMGYxZDY4ZmFlY2U4MzQwYzc5YjRlNmM1ZGIwNzFiMGExMTIzNCAxMDA2NDQKLS0tIGEvU291 cmNlL1dURi93dGYvdGhyZWFkcy9TaWduYWxzLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90aHJl YWRzL1NpZ25hbHMuY3BwCkBAIC0yNTgsNiArMjU4LDkgQEAgdm9pZCBpbnN0YWxsU2lnbmFsSGFu ZGxlcihTaWduYWwgc2lnbmFsLCBTaWduYWxIYW5kbGVyJiYgaGFuZGxlcikKICAgICAgICAgICAg IGFjdGlvbi5zYV9zaWdhY3Rpb24gPSBqc2NTaWduYWxIYW5kbGVyOwogICAgICAgICAgICAgYXV0 byByZXN1bHQgPSBzaWdmaWxsc2V0KCZhY3Rpb24uc2FfbWFzayk7CiAgICAgICAgICAgICBSRUxF QVNFX0FTU0VSVCghcmVzdWx0KTsKKyAgICAgICAgICAgIC8vIERvIG5vdCBibG9jayB0aGlzIHNp Z25hbCBzaW5jZSBpdCBpcyB1c2VkIG9uIG5vbi1EYXJ3aW4gc3lzdGVtcyB0byBzdXNwZW5kIGFu ZCByZXN1bWUgdGhyZWFkcy4KKyAgICAgICAgICAgIHJlc3VsdCA9IHNpZ2RlbHNldCgmYWN0aW9u LnNhX21hc2ssIFNpZ1RocmVhZFN1c3BlbmRSZXN1bWUpOworICAgICAgICAgICAgUkVMRUFTRV9B U1NFUlQoIXJlc3VsdCk7CiAgICAgICAgICAgICBhY3Rpb24uc2FfZmxhZ3MgPSBTQV9TSUdJTkZP OwogICAgICAgICAgICAgYXV0byBzeXN0ZW1TaWduYWxzID0gdG9TeXN0ZW1TaWduYWwoc2lnbmFs KTsKICAgICAgICAgICAgIHJlc3VsdCA9IHNpZ2FjdGlvbihzdGQ6OmdldDwwPihzeXN0ZW1TaWdu YWxzKSwgJmFjdGlvbiwgJm9sZEFjdGlvbnNbb2Zmc2V0Rm9yU3lzdGVtU2lnbmFsKHN0ZDo6Z2V0 PDA+KHN5c3RlbVNpZ25hbHMpKV0pOwo=