194012 2019-01-30 01:20:25 -0800 Fix WebKitTestRunner's testPath with Windows full paths 2019-01-31 02:28:28 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii achristensen bfulgham don.olmstead lforschler pvollan ross.kirsling webkit-bug-importer oldest_to_newest 1499942 0 fujii 2019-01-30 01:20:25 -0800 [Win][WebKitTestRunner] Can't get test header options in webkit-test-runner magic comments Some test cases are failing due to failing to get test options. For example, legacy-animation-engine/animations/generic-from-to.html It has the following magic comment: > <!DOCTYPE html> 1499943 1 360564 fujii 2019-01-30 01:29:13 -0800 Created attachment 360564 Patch 1500034 2 don.olmstead 2019-01-30 09:24:06 -0800 From https://blogs.msdn.microsoft.com/ie/2006/12/06/file-uris-in-windows/ > For the local Windows file path > C:\Documents and Settings\davris\FileSchemeURIs.doc > > The corresponding valid file URI in Windows is: > file:///C:/Documents%20and%20Settings/davris/FileSchemeURIs.doc So three forward slashes seem fine its just we're not handling it correctly. Isn't there anything that converts a File URI into a path rather than having special parsing here? 1500039 3 360564 achristensen 2019-01-30 09:33:06 -0800 Comment on attachment 360564 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360564&action=review > Tools/WebKitTestRunner/TestController.cpp:1095 > + // Remove the first '/' if it starts with like "/C:/". starts with something like 1500041 4 360564 achristensen 2019-01-30 09:34:26 -0800 Comment on attachment 360564 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360564&action=review > Tools/ChangeLog:3 > + [Win][WebKitTestRunner] Can't get test header options in webkit-test-runner magic comments I think this needs a better title. Something like "Fix WebKitTestRunner's testPath with Windows full paths" 1500067 5 achristensen 2019-01-30 10:41:38 -0800 (In reply to Don Olmstead from comment #2) > From https://blogs.msdn.microsoft.com/ie/2006/12/06/file-uris-in-windows/ > > > For the local Windows file path > > C:\Documents and Settings\davris\FileSchemeURIs.doc > > > > The corresponding valid file URI in Windows is: > > file:///C:/Documents%20and%20Settings/davris/FileSchemeURIs.doc > > So three forward slashes seem fine its just we're not handling it correctly. > > Isn't there anything that converts a File URI into a path rather than having > special parsing here? Certainly not in the URL class. This is how URLs behave: <script> alert(new URL("file:///C:/Documents%20and%20Settings/davris/FileSchemeURIs.doc").pathname); </script> It's strange, but all browsers agree and it's in the specification. 1500308 6 fujii 2019-01-30 17:12:55 -0800 (In reply to Don Olmstead from comment #2) > From https://blogs.msdn.microsoft.com/ie/2006/12/06/file-uris-in-windows/ Interesting. Should I use PathCreateFromUrl and UrlCreateFromPath API? 1500523 7 360712 fujii 2019-01-31 02:24:44 -0800 Created attachment 360712 Patch 1500524 8 fujii 2019-01-31 02:27:45 -0800 Committed r240775: <https://trac.webkit.org/changeset/240775> 1500525 9 webkit-bug-importer 2019-01-31 02:28:28 -0800 <rdar://problem/47697394> 360564 2019-01-30 01:29:13 -0800 2019-01-31 02:24:26 -0800 Patch bug-194012-20190130182912.patch text/plain 1930 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNjQyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGNmMGM5YzQ4ZmMwNmJmMWY0ODEwYjM0MTk0YmU1Mjk0 NDY5MGY3Ny4uYzdiMmUyNzlmN2QzYjk3ZDI4YTdhOTFjNmVkYjI5NzU5YWMxZGQyOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE5LTAxLTMwICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5dW1dlYktpdFRlc3RSdW5uZXJdIENhbid0IGdldCB0ZXN0IGhlYWRl ciBvcHRpb25zIGluIHdlYmtpdC10ZXN0LXJ1bm5lciBtYWdpYyBjb21tZW50cworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MDEyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU29tZSB0ZXN0IGNhc2VzIHdl cmUgZmFpbGluZyBkdWUgdG8gZmFpbGluZyB0byBnZXQgdGVzdCBvcHRpb25zLgorICAgICAgICB1 cGRhdGVUZXN0T3B0aW9uc0Zyb21UZXN0SGVhZGVyIGZhaWxlZCB0byBvcGVuIHRlc3QgZmlsZXMg YmVjYXVzZQorICAgICAgICB0ZXN0UGF0aCByZXR1cm5lZCB3cm9uZyBmaWxlIHBhdGhzLiBJdCBy ZXR1cm5lZCAiL0M6Ly4uLiIgaWYKKyAgICAgICAgImZpbGU6Ly8vQzovLi4uIiB3YXMgZ2l2ZW4u CisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcDoKKyAgICAg ICAgKFdUUjo6dGVzdFBhdGgpOiBSZW1vdmVkIHRoZSBmaXJzdCAnLycgaWYgdGhlIHBhdGggc3Rh cnRzIHdpdGggbGlrZSAiL0M6LyIuCisKIDIwMTktMDEtMjggIFJvc3MgS2lyc2xpbmcgIDxyb3Nz LmtpcnNsaW5nQHNvbnkuY29tPgogCiAgICAgICAgIFJlbW92ZSB1bm5lY2Vzc2FyeSBgdXNpbmcg bmFtZXNwYWNlIFdURmBzIChvciBhdCBsZWFzdCByZXN0cmljdCB0aGVpciBzY29wZSkuCmRpZmYg LS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcCBiL1Rvb2xz L1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCmluZGV4IDBjZmY3MTk1NmRiOWM0 MjhiYjUxN2I0ZDZjZDNhY2NiOTQxYmU0ZDguLjlkMWMyNjBhYjIzMGU4NTNlNzNjYjQ5Zjg5ODRh MjkwMjljMmNhZTggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRy b2xsZXIuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3Bw CkBAIC0xMDkxLDYgKzEwOTEsMTEgQEAgc3RhdGljIHN0ZDo6c3RyaW5nIHRlc3RQYXRoKFdLVVJM UmVmIHVybCkKICAgICAgICAgYXV0byBwYXRoID0gYWRvcHRXSyhXS1VSTENvcHlQYXRoKHVybCkp OwogICAgICAgICBhdXRvIGJ1ZmZlciA9IHN0ZDo6dmVjdG9yPGNoYXI+KFdLU3RyaW5nR2V0TWF4 aW11bVVURjhDU3RyaW5nU2l6ZShwYXRoLmdldCgpKSk7CiAgICAgICAgIGF1dG8gbGVuZ3RoID0g V0tTdHJpbmdHZXRVVEY4Q1N0cmluZyhwYXRoLmdldCgpLCBidWZmZXIuZGF0YSgpLCBidWZmZXIu c2l6ZSgpKTsKKyNpZiBPUyhXSU5ET1dTKQorICAgICAgICAvLyBSZW1vdmUgdGhlIGZpcnN0ICcv JyBpZiBpdCBzdGFydHMgd2l0aCBsaWtlICIvQzovIi4KKyAgICAgICAgaWYgKGxlbmd0aCA+PSA0 ICYmIGJ1ZmZlclswXSA9PSAnLycgJiYgYnVmZmVyWzJdID09ICc6JyAmJiBidWZmZXJbM10gPT0g Jy8nKQorICAgICAgICAgICAgcmV0dXJuIHN0ZDo6c3RyaW5nKGJ1ZmZlci5kYXRhKCkgKyAxLCBs ZW5ndGggLSAxKTsKKyNlbmRpZgogICAgICAgICByZXR1cm4gc3RkOjpzdHJpbmcoYnVmZmVyLmRh dGEoKSwgbGVuZ3RoKTsKICAgICB9CiAgICAgcmV0dXJuIHN0ZDo6c3RyaW5nKCk7Cg== 360712 2019-01-31 02:24:44 -0800 2019-01-31 02:24:44 -0800 Patch bug-194012-20190131192443.patch text/plain 1841 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNzc0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTEwODk5ZjgwNTAyMGNhNTcwZWMyODM2ZGMxZTJlZmQ3 MWJkYjE4Ny4uMmI0Y2M4ZGRjY2FjM2JiN2U5ZWY1NTdkOGI1ODk1MDlkZmU1OTdhZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE5LTAxLTMxICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIEZpeCBXZWJLaXRUZXN0UnVubmVyJ3MgdGVzdFBhdGggd2l0aCBXaW5kb3dz IGZ1bGwgcGF0aHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5NDAxMgorCisgICAgICAgIFJldmlld2VkIGJ5IEFsZXggQ2hyaXN0ZW5zZW4uCisKKyAg ICAgICAgdXBkYXRlVGVzdE9wdGlvbnNGcm9tVGVzdEhlYWRlciBmYWlsZWQgdG8gb3BlbiB0ZXN0 IGZpbGVzIGJlY2F1c2UKKyAgICAgICAgdGVzdFBhdGggcmV0dXJuZWQgd3JvbmcgZmlsZSBwYXRo cy4gSXQgcmV0dXJuZWQgYSBwYXRoICIvQzovLi4uIgorICAgICAgICBpZiBhIFVSTCAiZmlsZTov Ly9DOi8uLi4iIHdhcyBnaXZlbi4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvVGVzdENv bnRyb2xsZXIuY3BwOgorICAgICAgICAoV1RSOjp0ZXN0UGF0aCk6IFJlbW92ZWQgdGhlIGZpcnN0 ICcvJyBpZiB0aGUgcGF0aCBzdGFydHMgd2l0aCBzb21ldGhpbmcgbGlrZSAiL0M6LyIuCisKIDIw MTktMDEtMzEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtXUEVdIEJ1bXAgZm9udCByZWxhdGVkIGRlcGVuZGVuY2llcyB0byBtYXRjaCB0aGUg R1RLKyBwb3J0CmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9s bGVyLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCmluZGV4 IDkyZTE2MGE2MTU4OTBkMzM2OTI0YzU2MGY0MzNhYjBlZDI1NWE5NDQuLjZjN2U5N2FkYzNkN2Rm MWY0OGE3MTMwNGM4MzA5MmRjODllZGNkNTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVz dENvbnRyb2xsZXIuY3BwCkBAIC0xMDkzLDYgKzEwOTMsMTEgQEAgc3RhdGljIHN0ZDo6c3RyaW5n IHRlc3RQYXRoKFdLVVJMUmVmIHVybCkKICAgICAgICAgYXV0byBwYXRoID0gYWRvcHRXSyhXS1VS TENvcHlQYXRoKHVybCkpOwogICAgICAgICBhdXRvIGJ1ZmZlciA9IHN0ZDo6dmVjdG9yPGNoYXI+ KFdLU3RyaW5nR2V0TWF4aW11bVVURjhDU3RyaW5nU2l6ZShwYXRoLmdldCgpKSk7CiAgICAgICAg IGF1dG8gbGVuZ3RoID0gV0tTdHJpbmdHZXRVVEY4Q1N0cmluZyhwYXRoLmdldCgpLCBidWZmZXIu ZGF0YSgpLCBidWZmZXIuc2l6ZSgpKTsKKyNpZiBPUyhXSU5ET1dTKQorICAgICAgICAvLyBSZW1v dmUgdGhlIGZpcnN0ICcvJyBpZiBpdCBzdGFydHMgd2l0aCBzb21ldGhpbmcgbGlrZSAiL0M6LyIu CisgICAgICAgIGlmIChsZW5ndGggPj0gNCAmJiBidWZmZXJbMF0gPT0gJy8nICYmIGJ1ZmZlclsy XSA9PSAnOicgJiYgYnVmZmVyWzNdID09ICcvJykKKyAgICAgICAgICAgIHJldHVybiBzdGQ6OnN0 cmluZyhidWZmZXIuZGF0YSgpICsgMSwgbGVuZ3RoIC0gMSk7CisjZW5kaWYKICAgICAgICAgcmV0 dXJuIHN0ZDo6c3RyaW5nKGJ1ZmZlci5kYXRhKCksIGxlbmd0aCk7CiAgICAgfQogICAgIHJldHVy biBzdGQ6OnN0cmluZygpOwo=