194000 2019-01-29 20:12:17 -0800 Remove default constructor from LLIntPrototypeLoadAdaptiveStructureWatchpoint 2019-01-29 21:03:10 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller commit-queue ews-watchlist mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1499865 0 keith_miller 2019-01-29 20:12:17 -0800 Fix default constructor with reference member 1499866 1 360541 keith_miller 2019-01-29 20:12:49 -0800 Created attachment 360541 Patch 1499867 2 keith_miller 2019-01-29 20:12:51 -0800 <rdar://problem/47642894> 1499870 3 360541 keith_miller 2019-01-29 20:18:42 -0800 Comment on attachment 360541 Patch Turns out no one uses the default constructor anyway. Will change the patch. 1499871 4 360542 keith_miller 2019-01-29 20:20:13 -0800 Created attachment 360542 Patch 1499872 5 360543 keith_miller 2019-01-29 20:25:52 -0800 Created attachment 360543 Patch for landing 1499895 6 360543 commit-queue 2019-01-29 21:03:08 -0800 Comment on attachment 360543 Patch for landing Clearing flags on attachment: 360543 Committed r240703: <https://trac.webkit.org/changeset/240703> 1499896 7 commit-queue 2019-01-29 21:03:10 -0800 All reviewed patches have been landed. Closing bug. 360541 2019-01-29 20:12:49 -0800 2019-01-29 20:20:12 -0800 Patch bug-194000-20190129201246.patch text/plain 2859 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz MGMyMWVmNzRhMWZjYjllNzdlNWQxY2U3YzQ5MDZiYmE0ODc0Nzc2Li5iNDE1YTljZWNkMDZhNjIw ZDFlYjE1NDYzZDQ1Y2NhOWNhNzNjN2I4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wMS0yOSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBGaXggZGVmYXVsdCBjb25zdHJ1Y3RvciB3aXRoIHJlZmVyZW5jZSBt ZW1iZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 NDAwMAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDc2NDI4OTQ+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBieXRlY29kZS9MTEludFByb3RvdHlw ZUxvYWRBZGFwdGl2ZVN0cnVjdHVyZVdhdGNocG9pbnQuY3BwOgorICAgICAgICAoSlNDOjpMTElu dFByb3RvdHlwZUxvYWRBZGFwdGl2ZVN0cnVjdHVyZVdhdGNocG9pbnQ6OkxMSW50UHJvdG90eXBl TG9hZEFkYXB0aXZlU3RydWN0dXJlV2F0Y2hwb2ludCk6CisgICAgICAgIChKU0M6OkxMSW50UHJv dG90eXBlTG9hZEFkYXB0aXZlU3RydWN0dXJlV2F0Y2hwb2ludDo6ZmlyZUludGVybmFsKToKKyAg ICAgICAgKiBieXRlY29kZS9MTEludFByb3RvdHlwZUxvYWRBZGFwdGl2ZVN0cnVjdHVyZVdhdGNo cG9pbnQuaDoKKwogMjAxOS0wMS0yOSAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u eS5jb20+CiAKICAgICAgICAgUmVtb3ZlIEZJWE1FIGZvciBBbm5leCBCLjMuNSdzICJmb3Itb2Yg dmFyIiBzdWJjYXNlLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2Rl L0xMSW50UHJvdG90eXBlTG9hZEFkYXB0aXZlU3RydWN0dXJlV2F0Y2hwb2ludC5jcHAgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvTExJbnRQcm90b3R5cGVMb2FkQWRhcHRpdmVTdHJ1 Y3R1cmVXYXRjaHBvaW50LmNwcAppbmRleCA2YmVkZGY5Y2NkNjJlNjcxNmFiNDA4NmVmMDE4MTM1 ZjIzY2UyZjUwLi5hYTE5OTdkMjcxOGY4NWU0NjdhYTViNzQ0ZTMzMDFmNmY3MjY4ZGI4IDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvTExJbnRQcm90b3R5cGVMb2Fk QWRhcHRpdmVTdHJ1Y3R1cmVXYXRjaHBvaW50LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvYnl0ZWNvZGUvTExJbnRQcm90b3R5cGVMb2FkQWRhcHRpdmVTdHJ1Y3R1cmVXYXRjaHBvaW50 LmNwcApAQCAtMzQsNyArMzQsNyBAQCBuYW1lc3BhY2UgSlNDIHsKIAogTExJbnRQcm90b3R5cGVM b2FkQWRhcHRpdmVTdHJ1Y3R1cmVXYXRjaHBvaW50OjpMTEludFByb3RvdHlwZUxvYWRBZGFwdGl2 ZVN0cnVjdHVyZVdhdGNocG9pbnQoY29uc3QgT2JqZWN0UHJvcGVydHlDb25kaXRpb24mIGtleSwg T3BHZXRCeUlkOjpNZXRhZGF0YSYgZ2V0QnlJZE1ldGFkYXRhKQogICAgIDogbV9rZXkoa2V5KQot ICAgICwgbV9nZXRCeUlkTWV0YWRhdGEoZ2V0QnlJZE1ldGFkYXRhKQorICAgICwgbV9nZXRCeUlk TWV0YWRhdGEoJmdldEJ5SWRNZXRhZGF0YSkKIHsKICAgICBSRUxFQVNFX0FTU0VSVChrZXkud2F0 Y2hpbmdSZXF1aXJlc1N0cnVjdHVyZVRyYW5zaXRpb25XYXRjaHBvaW50KCkpOwogICAgIFJFTEVB U0VfQVNTRVJUKCFrZXkud2F0Y2hpbmdSZXF1aXJlc1JlcGxhY2VtZW50V2F0Y2hwb2ludCgpKTsK QEAgLTU0LDcgKzU0LDcgQEAgdm9pZCBMTEludFByb3RvdHlwZUxvYWRBZGFwdGl2ZVN0cnVjdHVy ZVdhdGNocG9pbnQ6OmZpcmVJbnRlcm5hbChWTSYgdm0sIGNvbnN0IEYKICAgICAgICAgcmV0dXJu OwogICAgIH0KIAotICAgIGNsZWFyTExJbnRHZXRCeUlkQ2FjaGUobV9nZXRCeUlkTWV0YWRhdGEp OworICAgIGNsZWFyTExJbnRHZXRCeUlkQ2FjaGUoKm1fZ2V0QnlJZE1ldGFkYXRhKTsKIH0KIAog dm9pZCBMTEludFByb3RvdHlwZUxvYWRBZGFwdGl2ZVN0cnVjdHVyZVdhdGNocG9pbnQ6OmNsZWFy TExJbnRHZXRCeUlkQ2FjaGUoT3BHZXRCeUlkOjpNZXRhZGF0YSYgbWV0YWRhdGEpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvTExJbnRQcm90b3R5cGVMb2FkQWRh cHRpdmVTdHJ1Y3R1cmVXYXRjaHBvaW50LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNv ZGUvTExJbnRQcm90b3R5cGVMb2FkQWRhcHRpdmVTdHJ1Y3R1cmVXYXRjaHBvaW50LmgKaW5kZXgg MjdhOGUzMTdmNDYzYTY3ZDVkM2UyNjg2YWE4ZDQ0MzNkOGFhYjQ0Ny4uZTZhODAwOTAyZWE1MzNh YzY0OGE1ODAyMGUyNjdlMzkwMzgzM2NmMCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2J5dGVjb2RlL0xMSW50UHJvdG90eXBlTG9hZEFkYXB0aXZlU3RydWN0dXJlV2F0Y2hwb2lu dC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9MTEludFByb3RvdHlwZUxv YWRBZGFwdGl2ZVN0cnVjdHVyZVdhdGNocG9pbnQuaApAQCAtNDcsNyArNDcsNyBAQCBwcm90ZWN0 ZWQ6CiAKIHByaXZhdGU6CiAgICAgT2JqZWN0UHJvcGVydHlDb25kaXRpb24gbV9rZXk7Ci0gICAg T3BHZXRCeUlkOjpNZXRhZGF0YSYgbV9nZXRCeUlkTWV0YWRhdGE7CisgICAgT3BHZXRCeUlkOjpN ZXRhZGF0YSogbV9nZXRCeUlkTWV0YWRhdGEgeyBudWxscHRyIH07CiB9OwogCiB9IC8vIG5hbWVz cGFjZSBKU0MK 360542 2019-01-29 20:20:13 -0800 2019-01-29 20:25:51 -0800 Patch bug-194000-20190129202011.patch text/plain 1512 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz MGMyMWVmNzRhMWZjYjllNzdlNWQxY2U3YzQ5MDZiYmE0ODc0Nzc2Li5lMmUxMzU3ZWQ0MzU3OTQx MDdmYWY5Mjk2ZWZjYTU5NTVjMWU1YzY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOS0wMS0yOSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBSZW1vdmUgZGVmYXVsdCBjb25zdHJ1Y3RvciBmcm9tIExMSW50UHJv dG90eXBlTG9hZEFkYXB0aXZlU3RydWN0dXJlV2F0Y2hwb2ludAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MDAwCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS80NzY0Mjg5ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGJ5dGVjb2RlL0xMSW50UHJvdG90eXBlTG9hZEFkYXB0aXZlU3RydWN0dXJlV2F0 Y2hwb2ludC5oOgorCiAyMDE5LTAxLTI5ICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bz b255LmNvbT4KIAogICAgICAgICBSZW1vdmUgRklYTUUgZm9yIEFubmV4IEIuMy41J3MgImZvci1v ZiB2YXIiIHN1YmNhc2UuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNv ZGUvTExJbnRQcm90b3R5cGVMb2FkQWRhcHRpdmVTdHJ1Y3R1cmVXYXRjaHBvaW50LmggYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvTExJbnRQcm90b3R5cGVMb2FkQWRhcHRpdmVTdHJ1 Y3R1cmVXYXRjaHBvaW50LmgKaW5kZXggMjdhOGUzMTdmNDYzYTY3ZDVkM2UyNjg2YWE4ZDQ0MzNk OGFhYjQ0Ny4uMGExNzMwYWY3YWI5MTYwNGRlYzUxODAwZTAyNWM3NGJmZjg3NmU2MCAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0xMSW50UHJvdG90eXBlTG9hZEFk YXB0aXZlU3RydWN0dXJlV2F0Y2hwb2ludC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9i eXRlY29kZS9MTEludFByb3RvdHlwZUxvYWRBZGFwdGl2ZVN0cnVjdHVyZVdhdGNocG9pbnQuaApA QCAtMzMsNyArMzMsNiBAQCBuYW1lc3BhY2UgSlNDIHsKIAogY2xhc3MgTExJbnRQcm90b3R5cGVM b2FkQWRhcHRpdmVTdHJ1Y3R1cmVXYXRjaHBvaW50IDogcHVibGljIFdhdGNocG9pbnQgewogcHVi bGljOgotICAgIExMSW50UHJvdG90eXBlTG9hZEFkYXB0aXZlU3RydWN0dXJlV2F0Y2hwb2ludCgp ID0gZGVmYXVsdDsKICAgICBMTEludFByb3RvdHlwZUxvYWRBZGFwdGl2ZVN0cnVjdHVyZVdhdGNo cG9pbnQoY29uc3QgT2JqZWN0UHJvcGVydHlDb25kaXRpb24mLCBPcEdldEJ5SWQ6Ok1ldGFkYXRh Jik7CiAKICAgICB2b2lkIGluc3RhbGwoVk0mKTsK 360543 2019-01-29 20:25:52 -0800 2019-01-29 21:03:08 -0800 Patch for landing bug-194000-20190129202550.patch text/plain 1665 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz MGMyMWVmNzRhMWZjYjllNzdlNWQxY2U3YzQ5MDZiYmE0ODc0Nzc2Li4xYmJhZDU5NzI0NjA4MjEy YTdlYzFmYWJlZDhjNmE4ZjI0ZTNmNWY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOS0wMS0yOSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBSZW1vdmUgZGVmYXVsdCBjb25zdHJ1Y3RvciBmcm9tIExMSW50UHJv dG90eXBlTG9hZEFkYXB0aXZlU3RydWN0dXJlV2F0Y2hwb2ludAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MDAwCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS80NzY0Mjg5ND4KKworICAgICAgICBSZXZpZXdlZCBieSBNYXJrIExhbS4KKworICAgICAg ICBkZWZhdWx0IGNvbnN0cnVjdG9yIGlzIHVudXNlZCBhbmQKKyAgICAgICAgTExJbnRQcm90b3R5 cGVMb2FkQWRhcHRpdmVTdHJ1Y3R1cmVXYXRjaHBvaW50IGhhcyBhIHJlZmVyZW5jZQorICAgICAg ICBkYXRhIG1lbWJlciB3aGljaCBjYXVzZXMgc2FkbmVzcy4KKworICAgICAgICAqIGJ5dGVjb2Rl L0xMSW50UHJvdG90eXBlTG9hZEFkYXB0aXZlU3RydWN0dXJlV2F0Y2hwb2ludC5oOgorCiAyMDE5 LTAxLTI5ICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAg ICBSZW1vdmUgRklYTUUgZm9yIEFubmV4IEIuMy41J3MgImZvci1vZiB2YXIiIHN1YmNhc2UuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvTExJbnRQcm90b3R5cGVM b2FkQWRhcHRpdmVTdHJ1Y3R1cmVXYXRjaHBvaW50LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv Ynl0ZWNvZGUvTExJbnRQcm90b3R5cGVMb2FkQWRhcHRpdmVTdHJ1Y3R1cmVXYXRjaHBvaW50LmgK aW5kZXggMjdhOGUzMTdmNDYzYTY3ZDVkM2UyNjg2YWE4ZDQ0MzNkOGFhYjQ0Ny4uMGExNzMwYWY3 YWI5MTYwNGRlYzUxODAwZTAyNWM3NGJmZjg3NmU2MCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2J5dGVjb2RlL0xMSW50UHJvdG90eXBlTG9hZEFkYXB0aXZlU3RydWN0dXJlV2F0 Y2hwb2ludC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9MTEludFByb3Rv dHlwZUxvYWRBZGFwdGl2ZVN0cnVjdHVyZVdhdGNocG9pbnQuaApAQCAtMzMsNyArMzMsNiBAQCBu YW1lc3BhY2UgSlNDIHsKIAogY2xhc3MgTExJbnRQcm90b3R5cGVMb2FkQWRhcHRpdmVTdHJ1Y3R1 cmVXYXRjaHBvaW50IDogcHVibGljIFdhdGNocG9pbnQgewogcHVibGljOgotICAgIExMSW50UHJv dG90eXBlTG9hZEFkYXB0aXZlU3RydWN0dXJlV2F0Y2hwb2ludCgpID0gZGVmYXVsdDsKICAgICBM TEludFByb3RvdHlwZUxvYWRBZGFwdGl2ZVN0cnVjdHVyZVdhdGNocG9pbnQoY29uc3QgT2JqZWN0 UHJvcGVydHlDb25kaXRpb24mLCBPcEdldEJ5SWQ6Ok1ldGFkYXRhJik7CiAKICAgICB2b2lkIGlu c3RhbGwoVk0mKTsK