193995 2019-01-29 16:18:25 -0800 [MSE] add more source buffer logging 2019-01-29 18:03:46 -0800 1 1 1 Unclassified WebKit Media WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue jer.noble jonlee webkit-bug-importer oldest_to_newest 1499792 0 eric.carlson 2019-01-29 16:18:25 -0800 Add more source buffer logging 1499793 1 eric.carlson 2019-01-29 16:20:29 -0800 <rdar://problem/47650399> 1499794 2 360519 eric.carlson 2019-01-29 16:23:20 -0800 Created attachment 360519 Patch 1499845 3 360519 commit-queue 2019-01-29 18:03:44 -0800 Comment on attachment 360519 Patch Clearing flags on attachment: 360519 Committed r240701: <https://trac.webkit.org/changeset/240701> 1499846 4 commit-queue 2019-01-29 18:03:46 -0800 All reviewed patches have been landed. Closing bug. 360519 2019-01-29 16:23:20 -0800 2019-01-29 18:03:44 -0800 Patch bug-193995-20190129182319.patch text/plain 6249 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNjc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjRjZDRkZjEzNDQwNjFk YzhkOTQ4NTc2MjBjMGFmZDNlYmU2OTUyNS4uOWE5MDdhYWFlNTQxYWI3M2M1NGU4MzM1OGFmYzJh YWY5NGYwZmJmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTAxLTI5ICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNU0VdIGFkZCBt b3JlIHNvdXJjZSBidWZmZXIgbG9nZ2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTkzOTk1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzY1MDM5 OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBu ZXcgdGVzdHMsIG5vIGZ1bmN0aW9uYWwgY2hhbmdlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvYXZmb3VuZGF0aW9uL29iamMvU291cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakMubW06Cisg ICAgICAgIChXZWJDb3JlOjpTb3VyY2VCdWZmZXJQcml2YXRlQVZGT2JqQzo6cmVzZXRQYXJzZXJT dGF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpTb3VyY2VCdWZmZXJQcml2YXRlQVZGT2JqQzo6c2V0 UmVhZHlTdGF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpTb3VyY2VCdWZmZXJQcml2YXRlQVZGT2Jq Qzo6dHJhY2tEaWRDaGFuZ2VFbmFibGVkKToKKyAgICAgICAgKFdlYkNvcmU6OlNvdXJjZUJ1ZmZl clByaXZhdGVBVkZPYmpDOjplbnF1ZXVlU2FtcGxlKToKKyAgICAgICAgKFdlYkNvcmU6OlNvdXJj ZUJ1ZmZlclByaXZhdGVBVkZPYmpDOjp3aWxsU2Vlayk6CisgICAgICAgIChXZWJDb3JlOjpTb3Vy Y2VCdWZmZXJQcml2YXRlQVZGT2JqQzo6c2V0RGVjb21wcmVzc2lvblNlc3Npb24pOgorCiAyMDE5 LTAxLTI5ICBKdXN0aW4gRmFuICA8anVzdGluX2ZhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dl YkdQVV0gRml4IGFuZCBhZGQgdmFsaWRhdGlvbiB0byBXZWJHUFVSZW5kZXJQaXBlbGluZSBhbmQg TVRMVmVydGV4RGVzY3JpcHRvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvU291cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakMubW0g Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9Tb3Vy Y2VCdWZmZXJQcml2YXRlQVZGT2JqQy5tbQppbmRleCAzODMxYzdlY2FmYzlmOGVhY2ZlOWQzZDI5 NDBkNGNiZWVhNTk4YmJkLi5lNDAwZjUwNzFiMDExY2M5Zjk1MzEzZTUwODFkMzk1NjI1MDZjYTc4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRp b24vb2JqYy9Tb3VyY2VCdWZmZXJQcml2YXRlQVZGT2JqQy5tbQorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9Tb3VyY2VCdWZmZXJQcml2YXRl QVZGT2JqQy5tbQpAQCAtNzU2LDYgKzc1Niw3IEBAIHZvaWQgU291cmNlQnVmZmVyUHJpdmF0ZUFW Rk9iakM6OmFib3J0KCkKIAogdm9pZCBTb3VyY2VCdWZmZXJQcml2YXRlQVZGT2JqQzo6cmVzZXRQ YXJzZXJTdGF0ZSgpCiB7CisgICAgTE9HKE1lZGlhU291cmNlLCAiU291cmNlQnVmZmVyUHJpdmF0 ZUFWRk9iakM6OnJlc2V0UGFyc2VyU3RhdGUoJXApIiwgdGhpcyk7CiAgICAgbV9wYXJzZXJTdGF0 ZVdhc1Jlc2V0ID0gdHJ1ZTsKICAgICBtX2Rpc2NhcmRTYW1wbGVzVW50aWxOZXh0SW5pdGlhbGl6 YXRpb25TZWdtZW50ID0gdHJ1ZTsKIH0KQEAgLTgxNiw2ICs4MTcsOCBAQCBNZWRpYVBsYXllcjo6 UmVhZHlTdGF0ZSBTb3VyY2VCdWZmZXJQcml2YXRlQVZGT2JqQzo6cmVhZHlTdGF0ZSgpIGNvbnN0 CiAKIHZvaWQgU291cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakM6OnNldFJlYWR5U3RhdGUoTWVkaWFQ bGF5ZXI6OlJlYWR5U3RhdGUgcmVhZHlTdGF0ZSkKIHsKKyAgICBMT0coTWVkaWFTb3VyY2UsICJT b3VyY2VCdWZmZXJQcml2YXRlQVZGT2JqQzo6c2V0UmVhZHlTdGF0ZSglcCkgLSByZWFkeVN0YXRl ID0gJWkiLCB0aGlzLCAoaW50KXJlYWR5U3RhdGUpOworCiAgICAgaWYgKG1fbWVkaWFTb3VyY2Up CiAgICAgICAgIG1fbWVkaWFTb3VyY2UtPnBsYXllcigpLT5zZXRSZWFkeVN0YXRlKHJlYWR5U3Rh dGUpOwogfQpAQCAtODM4LDYgKzg0MSw5IEBAIGJvb2wgU291cmNlQnVmZmVyUHJpdmF0ZUFWRk9i akM6Omhhc0F1ZGlvKCkgY29uc3QKIHZvaWQgU291cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakM6OnRy YWNrRGlkQ2hhbmdlRW5hYmxlZChWaWRlb1RyYWNrUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQyog dHJhY2spCiB7CiAgICAgaW50IHRyYWNrSUQgPSB0cmFjay0+dHJhY2tJRCgpOworCisgICAgTE9H KE1lZGlhU291cmNlLCAiU291cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakM6OnRyYWNrRGlkQ2hhbmdl RW5hYmxlZCglcCkgLSB2aWRlbyB0cmFja0lEID0gJWksIHNlbGVjdGVkID0gJXMiLCB0aGlzLCB0 cmFja0lELCB0cmFjay0+c2VsZWN0ZWQoKSA/ICJ0cnVlIiA6ICJmYWxzZSIpOworCiAgICAgaWYg KCF0cmFjay0+c2VsZWN0ZWQoKSAmJiBtX2VuYWJsZWRWaWRlb1RyYWNrSUQgPT0gdHJhY2tJRCkg ewogICAgICAgICBtX2VuYWJsZWRWaWRlb1RyYWNrSUQgPSAtMTsKICAgICAgICAgW21fcGFyc2Vy IHNldFNob3VsZFByb3ZpZGVNZWRpYURhdGE6Tk8gZm9yVHJhY2tJRDp0cmFja0lEXTsKQEAgLTg2 Miw2ICs4NjgsOCBAQCB2b2lkIFNvdXJjZUJ1ZmZlclByaXZhdGVBVkZPYmpDOjp0cmFja0RpZENo YW5nZUVuYWJsZWQoQXVkaW9UcmFja1ByaXZhdGVNZWRpYVNvdQogewogICAgIGludCB0cmFja0lE ID0gdHJhY2stPnRyYWNrSUQoKTsKIAorICAgIExPRyhNZWRpYVNvdXJjZSwgIlNvdXJjZUJ1ZmZl clByaXZhdGVBVkZPYmpDOjp0cmFja0RpZENoYW5nZUVuYWJsZWQoJXApIC0gYXVkaW8gdHJhY2tJ RCA9ICVpLCBlbmFibGVkID0gJXMiLCB0aGlzLCB0cmFja0lELCB0cmFjay0+ZW5hYmxlZCgpID8g InRydWUiIDogImZhbHNlIik7CisKICAgICBpZiAoIXRyYWNrLT5lbmFibGVkKCkpIHsKICAgICAg ICAgQUxMT1dfTkVXX0FQSV9XSVRIT1VUX0dVQVJEU19CRUdJTgogICAgICAgICBSZXRhaW5QdHI8 QVZTYW1wbGVCdWZmZXJBdWRpb1JlbmRlcmVyPiByZW5kZXJlciA9IG1fYXVkaW9SZW5kZXJlcnMu Z2V0KHRyYWNrSUQpOwpAQCAtMTEwNCwxNiArMTExMiwyMyBAQCB2b2lkIFNvdXJjZUJ1ZmZlclBy aXZhdGVBVkZPYmpDOjplbnF1ZXVlU2FtcGxlKFJlZjxNZWRpYVNhbXBsZT4mJiBzYW1wbGUsIGNv bnN0CiAgICAgICAgIGlmIChtX2RlY29tcHJlc3Npb25TZXNzaW9uKQogICAgICAgICAgICAgbV9k ZWNvbXByZXNzaW9uU2Vzc2lvbi0+ZW5xdWV1ZVNhbXBsZShwbGF0Zm9ybVNhbXBsZS5zYW1wbGUu Y21TYW1wbGVCdWZmZXIpOwogCi0gICAgICAgIGlmIChtX2Rpc3BsYXlMYXllcikgewotICAgICAg ICAgICAgaWYgKG1fbWVkaWFTb3VyY2UgJiYgIW1fbWVkaWFTb3VyY2UtPnBsYXllcigpLT5oYXNB dmFpbGFibGVWaWRlb0ZyYW1lKCkgJiYgIXNhbXBsZS0+aXNOb25EaXNwbGF5aW5nKCkpIHsKLSAg ICAgICAgICAgICAgICBDTVNhbXBsZUJ1ZmZlclJlZiByYXdTYW1wbGVDb3B5OwotICAgICAgICAg ICAgICAgIENNU2FtcGxlQnVmZmVyQ3JlYXRlQ29weShrQ0ZBbGxvY2F0b3JEZWZhdWx0LCBwbGF0 Zm9ybVNhbXBsZS5zYW1wbGUuY21TYW1wbGVCdWZmZXIsICZyYXdTYW1wbGVDb3B5KTsKLSAgICAg ICAgICAgICAgICBhdXRvIHNhbXBsZUNvcHkgPSBhZG9wdENGKHJhd1NhbXBsZUNvcHkpOwotICAg ICAgICAgICAgICAgIENNU2V0QXR0YWNobWVudChzYW1wbGVDb3B5LmdldCgpLCBrQ01TYW1wbGVC dWZmZXJBdHRhY2htZW50S2V5X1Bvc3ROb3RpZmljYXRpb25XaGVuQ29uc3VtZWQsIChfX2JyaWRn ZSBDRkRpY3Rpb25hcnlSZWYpQHsgKF9fYnJpZGdlIE5TU3RyaW5nICopa0NNU2FtcGxlQnVmZmVy QXR0YWNobWVudEtleV9Qb3N0Tm90aWZpY2F0aW9uV2hlbkNvbnN1bWVkIDogQChZRVMpIH0sIGtD TUF0dGFjaG1lbnRNb2RlX1Nob3VsZE5vdFByb3BhZ2F0ZSk7Ci0gICAgICAgICAgICAgICAgW21f ZGlzcGxheUxheWVyIGVucXVldWVTYW1wbGVCdWZmZXI6c2FtcGxlQ29weS5nZXQoKV07Ci0gICAg ICAgICAgICB9IGVsc2UKLSAgICAgICAgICAgICAgICBbbV9kaXNwbGF5TGF5ZXIgZW5xdWV1ZVNh bXBsZUJ1ZmZlcjpwbGF0Zm9ybVNhbXBsZS5zYW1wbGUuY21TYW1wbGVCdWZmZXJdOwotICAgICAg ICB9CisgICAgICAgIGlmICghbV9kaXNwbGF5TGF5ZXIpCisgICAgICAgICAgICByZXR1cm47CisK KyAgICAgICAgaWYgKG1fbWVkaWFTb3VyY2UgJiYgIW1fbWVkaWFTb3VyY2UtPnBsYXllcigpLT5o YXNBdmFpbGFibGVWaWRlb0ZyYW1lKCkgJiYgIXNhbXBsZS0+aXNOb25EaXNwbGF5aW5nKCkpIHsK KyAgICAgICAgICAgIExPRyhNZWRpYVNvdXJjZSwgIlNvdXJjZUJ1ZmZlclByaXZhdGVBVkZPYmpD OjpkaWRQYXJzZVN0cmVhbURhdGFBc0Fzc2V0KCVwKSAtIGFkZGluZyBidWZmZXIgYXR0YWNobWVu dCIsIHRoaXMpOworCisgICAgICAgICAgICBDTVNhbXBsZUJ1ZmZlclJlZiByYXdTYW1wbGVDb3B5 OworICAgICAgICAgICAgQ01TYW1wbGVCdWZmZXJDcmVhdGVDb3B5KGtDRkFsbG9jYXRvckRlZmF1 bHQsIHBsYXRmb3JtU2FtcGxlLnNhbXBsZS5jbVNhbXBsZUJ1ZmZlciwgJnJhd1NhbXBsZUNvcHkp OworICAgICAgICAgICAgYXV0byBzYW1wbGVDb3B5ID0gYWRvcHRDRihyYXdTYW1wbGVDb3B5KTsK KyAgICAgICAgICAgIENNU2V0QXR0YWNobWVudChzYW1wbGVDb3B5LmdldCgpLCBrQ01TYW1wbGVC dWZmZXJBdHRhY2htZW50S2V5X1Bvc3ROb3RpZmljYXRpb25XaGVuQ29uc3VtZWQsIChfX2JyaWRn ZSBDRkRpY3Rpb25hcnlSZWYpQHsgKF9fYnJpZGdlIE5TU3RyaW5nICopa0NNU2FtcGxlQnVmZmVy QXR0YWNobWVudEtleV9Qb3N0Tm90aWZpY2F0aW9uV2hlbkNvbnN1bWVkIDogQChZRVMpIH0sIGtD TUF0dGFjaG1lbnRNb2RlX1Nob3VsZE5vdFByb3BhZ2F0ZSk7CisgICAgICAgICAgICBbbV9kaXNw bGF5TGF5ZXIgZW5xdWV1ZVNhbXBsZUJ1ZmZlcjpzYW1wbGVDb3B5LmdldCgpXTsKKyNpZiBQTEFU Rk9STShJT1NfRkFNSUxZKQorICAgICAgICAgICAgbV9tZWRpYVNvdXJjZS0+cGxheWVyKCktPnNl dEhhc0F2YWlsYWJsZVZpZGVvRnJhbWUodHJ1ZSk7CisjZW5kaWYKKyAgICAgICAgfSBlbHNlCisg ICAgICAgICAgICBbbV9kaXNwbGF5TGF5ZXIgZW5xdWV1ZVNhbXBsZUJ1ZmZlcjpwbGF0Zm9ybVNh bXBsZS5zYW1wbGUuY21TYW1wbGVCdWZmZXJdOworCiAgICAgfSBlbHNlIHsKICAgICAgICAgYXV0 byByZW5kZXJlciA9IG1fYXVkaW9SZW5kZXJlcnMuZ2V0KHRyYWNrSUQpOwogICAgICAgICBbcmVu ZGVyZXIgZW5xdWV1ZVNhbXBsZUJ1ZmZlcjpwbGF0Zm9ybVNhbXBsZS5zYW1wbGUuY21TYW1wbGVC dWZmZXJdOwpAQCAtMTE2MSw2ICsxMTc2LDcgQEAgTWVkaWFUaW1lIFNvdXJjZUJ1ZmZlclByaXZh dGVBVkZPYmpDOjpmYXN0U2Vla1RpbWVGb3JNZWRpYVRpbWUoY29uc3QgTWVkaWFUaW1lJgogCiB2 b2lkIFNvdXJjZUJ1ZmZlclByaXZhdGVBVkZPYmpDOjp3aWxsU2VlaygpCiB7CisgICAgTE9HKE1l ZGlhU291cmNlLCAiU291cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakM6OndpbGxTZWVrKCVwKSIsIHRo aXMpOwogICAgIGZsdXNoKCk7CiB9CiAKQEAgLTEyNTAsNiArMTI2Niw4IEBAIHZvaWQgU291cmNl QnVmZmVyUHJpdmF0ZUFWRk9iakM6OnNldERlY29tcHJlc3Npb25TZXNzaW9uKFdlYkNvcmVEZWNv bXByZXNzaW9uU2VzCiAgICAgaWYgKG1fZGVjb21wcmVzc2lvblNlc3Npb24gPT0gZGVjb21wcmVz c2lvblNlc3Npb24pCiAgICAgICAgIHJldHVybjsKIAorICAgIExPRyhNZWRpYVNvdXJjZSwgIlNv dXJjZUJ1ZmZlclByaXZhdGVBVkZPYmpDOjpzZXREZWNvbXByZXNzaW9uU2Vzc2lvbiglcCkiLCB0 aGlzKTsKKwogICAgIGlmIChtX2RlY29tcHJlc3Npb25TZXNzaW9uKSB7CiAgICAgICAgIG1fZGVj b21wcmVzc2lvblNlc3Npb24tPnN0b3BSZXF1ZXN0aW5nTWVkaWFEYXRhKCk7CiAgICAgICAgIG1f ZGVjb21wcmVzc2lvblNlc3Npb24tPmludmFsaWRhdGUoKTsK